Nicotina GJ Breakout strategy: an auto-trader by SteveHopwood | Page 11 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

SSS EA v1.0 - Auto Trader Bot 623 replies

Candle Stick Pattern Auto Trader 12 replies

Auto trader for Currenex? 2 replies

SteveHopwood EAs 4 replies

Auto Trade Tradestation Strategy to GFT Forex Account 3 replies

Attachments: Nicotina GJ Breakout strategy: an auto-trader by SteveHopwood
Exit Attachments

Nicotina GJ Breakout strategy: an auto-trader by SteveHopwood

  • #201
  • May 24, 2011 8:22pm May 24, 2011 8:22pm
...The EA which has been running for over 24 hours now redrew the box at the appropriate time and in the correct place but has failed to place the pending orders.

Sorry Paul but the cork is being placed back on the champers bottle

Dave
  • #202
  • May 24, 2011 8:43pm May 24, 2011 8:43pm
Quoting Dixpat
...The EA which has been running for over 24 hours now redrew the box at the appropriate time and in the correct place but has failed to place the pending orders.

Sorry Paul but the cork is being placed back on the champers bottle

Dave
Y, I show the same, take the EA off the chart and reapply and the pending trades will be sent.
The issue is to do with some of the protection I've put in.

It looks like I used iTime, instead of Time. This has been fixed in the attached, Shelley EA, please try this.

Thanks

Paul
Attached File(s)
File Type: mq4 Shelley.mq4   60 KB | 351 downloads
  • #203
  • May 24, 2011 8:57pm May 24, 2011 8:57pm
Quoting batemap
Y, I show the same, take the EA off the chart and reapply and the pending trades will be sent.
The issue is to do with some of the protection I've put in.

It looks like I used iTime, instead of Time. This has been fixed in the attached, Shelley EA, please try this.

Thanks

Paul
Loaded Shelley

No go

Just says "looking for trades"

Dave
  • #204
  • May 24, 2011 10:01pm May 24, 2011 10:01pm
Quoting Dixpat
Loaded Shelley

No go

Just says "looking for trades"

Dave
Hi Dave, can you post a portion of the log?

Thanks

Paul
  • #205
  • May 24, 2011 10:18pm May 24, 2011 10:18pm
Quoting batemap
Hi Dave, can you post a portion of the log?

Thanks

Paul

Hope this helps
Attached File(s)
File Type: pdf Shelley.pdf   818 KB | 398 downloads
  • #206
  • May 24, 2011 11:05pm May 24, 2011 11:05pm
Quoting Dixpat
Hope this helps
Dave

Looks like your times are wrong because you are not getting past this code: -

if (h >= CloseHour || h < RangeCalculationHour) return(false);

This means that either: -

1. Your local hour is greater than your CloseHour (i.e. 1800 British), or
2. Your local hour is before the RangeCalculationHour (i.e. 0200 British)

Can you check the above variables and post the values?

Thanks

Paul
  • #207
  • May 24, 2011 11:11pm May 24, 2011 11:11pm
Quoting batemap
Dave

Looks like your times are wrong because you are not getting past this code: -

if (h >= CloseHour || h < RangeCalculationHour) return(false);

This means that either: -

1. Your local hour is greater than your CloseHour (i.e. 1800 British), or
2. Your local hour is before the RangeCalculationHour (i.e. 0200 British)

Can you check the above variables and post the values?

Thanks

Paul
My variables re times are:

CloseHour 5
RangeCalculationHour 13

My local time is GMT+12

Dave
  • #208
  • May 24, 2011 11:21pm May 24, 2011 11:21pm
Quoting Dixpat
My variables re times are:

CloseHour 5
RangeCalculationHour 13

My local time is GMT+12

Dave
My understanding was that the variables were to be in Local time not GMT

If that is the case then both the equations will give false.

Dave
  • #209
  • May 24, 2011 11:31pm May 24, 2011 11:31pm
Quoting Dixpat
My variables re times are:

CloseHour 5
RangeCalculationHour 13

My local time is GMT+12

Dave
OK, here's my theory and I think this is Shelley's issues as well!

Your current local time is 16:28, so your hour is 16, h = 16. CloseHour = 5, is h greater than or equal to CloseHour , with numbers, is 16 >= 5, yes it is, so we return false, which means trading is not allowed because you are outside of the time window!

We need to tell the EA that your CloseHour is in the future, tomorrow, not in the past, today. I'll need to think about this for a while before fixing, but I've just made a cup of tea, so

Thanks

Paul
  • #210
  • Edited 12:23am May 25, 2011 12:20am | Edited 12:23am
Quoting Dixpat
My understanding was that the variables were to be in Local time not GMT

If that is the case then both the equations will give false.

Dave
Dave

Local time the correct settings, but I have a fix for those down under, in theory it should send trades the moment you load it up, but who knows I coded it

For everybody else this version should not change how your Nico operates, but it would be good to check that out.

Thanks

Paul

P.S. Sorry Dave I should have made a mention of NZ in the EA name.
Attached File(s)
File Type: mq4 Aussie.mq4   60 KB | 303 downloads
  • #211
  • May 25, 2011 1:34am May 25, 2011 1:34am
Quoting jimmynoodles
This trade was stopped for -50. The EA then entered long @ 132.25 which, as far as my understanding of the strategy goes, is correct behavoir.
This new long from yesterday closed at 18:00 hours @ 132.73 (+48). When I woke this morning the EA had correctly drawn the new box and a short trade had already triggered @ 132.33.

Jimmy
The best trade I ever made was my SIN for Jesus' RIGHTEOUSNESS.
  • #212
  • May 25, 2011 3:07am May 25, 2011 3:07am
Quoting batemap
OK, here's my theory and I think this is Shelley's issues as well!

Your current local time is 16:28, so your hour is 16, h = 16. CloseHour = 5, is h greater than or equal to CloseHour , with numbers, is 16 >= 5, yes it is, so we return false, which means trading is not allowed because you are outside of the time window!

We need to tell the EA that your CloseHour is in the future, tomorrow, not in the past, today. I'll need to think about this for a while before fixing, but I've just made a cup of tea, so

Thanks

Paul
Hi Paul,

Nico has problem to open pendings. This has been highlighted by a fews members before.

Default settings

RangeCalculationHour 2
LookBackCandles 8

CloseHour 18

The problem occurs when RangeCalculationHour > CloseHour.

My local's time setting is

RangeCalculationHour 9
LookBackCandles 8

CloseHour 1

GMT +8

Hope you can do something for this.
  • #213
  • May 25, 2011 3:10am May 25, 2011 3:10am
Quoting fxozgirl
Hi Paul,

No champagne on this end just yet...
running your updated de-bug ea from yesterday, box drawn correctly, still no trades.
Checked the logs and it's a bit weird as there's nothing in there, but on checking the experts tab on the platform it is constantly scrolling through with comments.

I have taken a screen shot to try and give you an idea of what it's doing.
Hopefully it will provide some help??

Shelley
My problem is similar as Shelley
  • #214
  • May 25, 2011 3:20am May 25, 2011 3:20am
Hi cobber Paul

Loaded Aussie.EA

20:12:17 Nicotana - AussieNZ GBPJPY,H1: loaded successfully
20:12:33 Nicotana - AussieNZ GBPJPY,H1 inputs: gen="----General inputs----"; Lot=0.01; TakeProfit=100; StopLoss=50; MagicNumber=755; TradeComment="Nicotina"; CriminalIsECN=false; RangeLineColour=(255,255,0); StopTrading=false; TradeLong=true; TradeShort=true; tt="----Trading hour inputs----"; rch="Range calculation hour"; RangeCalculationHour=13; LookBackCandles=8; tcc="Trade closure hour"; CloseHour=5; ptd="PendingTradeExpiryHour"; PendingExpiryTime=5; mf="----Mondy/Friday choices----"; TradeMonday=false; TradeFriday=true; rsiin="----Rsi inputs----"; UseRsi=false; RsiTf=1440; RsiPeriod=20; rsap="Applied price: 0=Close; 1=Open; 2=High"; rsap1="3=Low; 4=Median; 5=Typical; 6=Weighted"; RsiAppliedPrice=0; tr="----Retrace trading----"; TradeTheRetrace=false; RetraceTakeProfit=30; RetraceStopLoss=20; tmm="----Trade management module----"; BE="Break even settings"; BreakEven=false; BreakEvenPips=25; BreakEvenProfit=2; HideBreakEvenStop=false; PipsAwayFromVisualBE=5; JSL="Jumping stop loss settings"; JumpingStop=true; JumpingStopPips=50; AddBEP=false;
20:12:33 Nicotana - AussieNZ GBPJPY,H1: Modified h is 20
20:12:33 Nicotana - AussieNZ GBPJPY,H1: initialized
20:12:56 Nicotana - AussieNZ GBPJPY,H1: Looking for Trades
20:12:56 Nicotana - AussieNZ GBPJPY,H1: Looking for Trades
20:12:56 Nicotana - AussieNZ GBPJPY,H1: Looking for Trades
20:12:57 Nicotana - AussieNZ GBPJPY,H1: Looking for Trades

She is still broken!

Dave
  • #215
  • Edited 8:17am May 25, 2011 7:19am | Edited 8:17am
Quoting Dixpat
Hi cobber Paul

Loaded Aussie.EA

20:12:17 Nicotana - AussieNZ GBPJPY,H1: loaded successfully
20:12:33 Nicotana - AussieNZ GBPJPY,H1 inputs: gen="----General inputs----"; Lot=0.01; TakeProfit=100; StopLoss=50; MagicNumber=755; TradeComment="Nicotina"; CriminalIsECN=false; RangeLineColour=(255,255,0); StopTrading=false; TradeLong=true; TradeShort=true; tt="----Trading hour inputs----"; rch="Range calculation hour"; RangeCalculationHour=13; LookBackCandles=8; tcc="Trade closure hour"; CloseHour=5; ptd="PendingTradeExpiryHour"; PendingExpiryTime=5;...
Hi Dave and all

Can you post the logs please? I really need these to make any sense of what is going on

But, after checking the code I think all is still good, but you will not get any trades until the box is redrawn tomorrow at 2 a.m British time, yes I got it wrong in my previous post

Thanks

Paul
  • #216
  • May 25, 2011 2:13pm May 25, 2011 2:13pm
Quoting batemap
Hi Dave and all

Can you post the logs please? I really need these to make any sense of what is going on

But, after checking the code I think all is still good, but you will not get any trades until the box is redrawn tomorrow at 2 a.m British time, yes I got it wrong in my previous post

Thanks

Paul
I will reload it closer to start time and see what happens then

Noted re logs

Dave
  • #217
  • May 25, 2011 9:50pm May 25, 2011 9:50pm
Steve

I'm having trouble with the following code, the intention is check sever time, check current bar time and if they are not the same then sleep until they are, but it doesn't seem to work

while (TimeHour(TimeCurrent()) != TimeHour(Time[0])) {

The problem is that the value of TimeHour(Time[0]), doesn't seem to increment and, therefore, the loop is never exited. Can you see any problem with this code?

I've changed it slightly in the next post, but I don't hold out much hope that this will fix the problem

Thanks

Paul
  • #218
  • May 25, 2011 9:53pm May 25, 2011 9:53pm
All

There is another problem! It looks like Steve coded the EA based on the orders being opened and closed the same day and that makes sense in the UK, but down under they will, potentially, be opened and closed on different days. This is the issue with no orders being sent.

The other problem is, when the EA is working out whether we've hit the TP or SL zero, once or twice then if the trades are over the midnight boundary then the count will be wrong.

Attached is an EA that I hope fixes this. It uses global variables, because I don't now any other way to keep track of the trades, and deletes ALL global variables at 1800 British time. If you are using some of the MPTM features this may cause you a problem.

Give it a try

Paul
Attached File(s)
File Type: mq4 Aussiev2.mq4   61 KB | 321 downloads
  • #219
  • May 25, 2011 10:37pm May 25, 2011 10:37pm
Quoting batemap

while (TimeHour(TimeCurrent()) != TimeHour(Time[0])) {
I don't have access to MT4 right now to check, but I think you need to use iTime[0] for the bar time?
  • #220
  • May 25, 2011 11:27pm May 25, 2011 11:27pm
Quoting skoda2008
I don't have access to MT4 right now to check, but I think you need to use iTime[0] for the bar time?
Thanks Skoda, I've tried iTime[0] and it seemed to give my the same, wrong, result. But, if you can check that would be great.

Cheers

Paul
0 traders viewing now