Attachments: The Small Hours Simplified - Coding only

The Small Hours Simplified - Coding only

#41
Feb 16, 2011 9:30am Feb 16, 2011 9:30am

todd960960
| Joined Nov 2008 | Status: Trader | 470 Posts

Have you seen the new updated version Colostarr has posted?

Initial Stop Loss (tweaked)
1. Highest High of the last 3 candles, minus the lowest low of the last 3 candles x .764 (Key Fibonacci level)
a. Example: HH3=1.3545; LL3=1.3465 = 80 pips x .764 = 61 pips
b. Stop loss = entry price minus 61 pips
c. (HH3-LL3 x .764 = your initial stop loss)

Trail the stops:
1. If not stopped out or any TP’s are hit move the stop of your open orders to the Lowest Low of the last 3 bars (LL3) minus 3 pips minus spread as new candles form (new higher lows)
2. When TP1 is hit move the stop of existing order to break even (BE).

Target Profits (tweaked)
1. TP1: calculate TP1 entry price plus ATR x .75 (as of the most recently closed candle)
2. TP2: calculate TP2 entry price plus ATR x .95 (as of the most recently closed candle)

Hopefully you can also tweak the existing indicator you created to match the new SL TP rules.

thx,
todd

#42
Edited 1:59pm Feb 16, 2011 1:13pm | Edited 1:59pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

OK, updated indicator. In this version the Alert function is working properly. Also Entry/TP/SL levels are fixed .
I also added an extra indicator option.
"Use old Entry, SL and TP calculations" default is set to false, which means it is using the new calculations for the Small Hours system.
For those who prefer old calculations, just set this option to true.

Also a new email alert option is now added.

Let me know if there's a mistake, so i can look into it

Attached File(s)

Small Hours v2c.mq4 11 KB | 308 downloads

#43
Feb 16, 2011 2:14pm Feb 16, 2011 2:14pm

todd960960
| Joined Nov 2008 | Status: Trader | 470 Posts

Looks good so far. Thanks for the good job on this indicator.

todd

#44
Feb 16, 2011 2:24pm Feb 16, 2011 2:24pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Quoting todd960960

Disliked

Looks good so far. Thanks for the good job on this indicator.

todd

Ignored

you're welcome

#45
Feb 16, 2011 6:09pm Feb 16, 2011 6:09pm

pp22
| Joined Feb 2011 | Status: Trader | 235 Posts

Just curious why arent you applying rule 2? Have you back tested and it makes no difference? Did colostar say it didnt matter?

Thanks ido370 really appreciate all the hard work you and other have put into this.

#46
Edited 7:10pm Feb 16, 2011 6:17pm | Edited 7:10pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Just to make it back according to original rules, and i had some time left this evening, i placed rule 2 back in code.
So now with rule 2 back, and the new calculations from Colostarr, this should your thing to use

Attached File(s)

Small Hours v3.mq4 12 KB | 415 downloads

Attached Image

no further new additions then v2c in post above. Have fun.

#47
Feb 16, 2011 6:21pm Feb 16, 2011 6:21pm

the-game
| Joined Sep 2010 | Status: Trader | 721 Posts

Thanks Ido

#48
Feb 16, 2011 7:05pm Feb 16, 2011 7:05pm

the-game
| Joined Sep 2010 | Status: Trader | 721 Posts

Ido,

Found a small bug for the new calculations in Small Hours v3:

ll3=Low[iLowest(NULL,0,MODE_LOW,5,1)];

should be 3

#49
Feb 16, 2011 7:11pm Feb 16, 2011 7:11pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Quoting the-game

Disliked

Ido,

Found a small bug for the new calculations in Small Hours v3:

ll3=Low[iLowest(NULL,0,MODE_LOW,5,1)];

should be 3

Ignored

*fixed* thanks for finding it

Also changed level 2 code, i made mistake in it, now fixed too. i reuploaded it again in the same post.

#50
Feb 16, 2011 8:55pm Feb 16, 2011 8:55pm

james629
| Joined May 2010 | Status: Trader | 27 Posts

hi ido can you add buy or sell sign or ea for this newbie ?thanks

#51
Feb 16, 2011 8:55pm Feb 16, 2011 8:55pm

the-game
| Joined Sep 2010 | Status: Trader | 721 Posts

Ido,

I think I found another one with the tweaked SL:

Inserted Code

ObjectSetText("sl", "SL: "+DoubleToStr(hh5-(hh3-ll3)-3*0.764*pips2dbl,Digits)+" / "+DoubleToStr(ll5+(hh3-ll3)-3*0.764*pips2dbl,Digits), 9, "Arial Bold", Red);

Should be:

Inserted Code

ObjectSetText("sl", "SL: "+DoubleToStr((hh5+3-((hh3-ll3)*0.764))*pips2dbl,Digits)+" / "+DoubleToStr((ll5-3+((hh3-ll3)*0.764)*pips2dbl,Digits), 9, "Arial Bold", Red);

In other words...
Buy Initial Stop Loss = Entry-((HH3-LL3)*0.764)
Sell Initial Stop Loss = Entry+((HH3-LL3)*0.764)

#52
Feb 16, 2011 9:03pm Feb 16, 2011 9:03pm

the-game
| Joined Sep 2010 | Status: Trader | 721 Posts

Same thing on the TP1 and TP2 calcs... they're missing the 3 pips that is part of the Entry price calculation

#53
Edited 11:22pm Feb 16, 2011 9:44pm | Edited 11:22pm

the-game
| Joined Sep 2010 | Status: Trader | 721 Posts

Here's my revision on the SHOW LEVELS section of your code... up to you if you want to use it.

I've basically put most of the repetitive code into reusable variables.

I've also added the spread calculation. You can turn this on/off with the usespread variable.

Inserted Code

extern string smessage = "Add spread as buffer for Entry and SL";
extern bool usespread = true;
double spread;
double buffer, buyEntry, sellEntry;
double buySL, sellSL, tweakedSL;
double buyTP1, sellTP1, buyTP2, sellTP2;
double buyTweakedTP2, sellTweakedTP2;

Inserted Code

//SHOW LEVELS
   if (showlevels==true)
   {
    spread = MathCeil(MarketInfo(Symbol(),MODE_SPREAD)*Point/pips2dbl)*(pips2points*Point);
    buffer = 3*pips2dbl;
    buyEntry = hh5+buffer;
    sellEntry = ll5-buffer;
    buySL = sellEntry;
    sellSL = buyEntry;
    tweakedSL = (hh3-ll3)*0.764;
    buyTP1 = buyEntry+(tp1*pips2dbl);
    buyTP2 = buyEntry+(atrcalc*pips2dbl);
    sellTP1 = sellEntry-(tp1*pips2dbl);
    sellTP2 = sellEntry-(atrcalc*pips2dbl);
    buyTweakedTP2 = buyEntry+(atrvalue*0.95*pips2dbl);
    sellTweakedTP2 = sellEntry-(atrvalue*0.95*pips2dbl);
    
    ObjectSetText("label", "BUY / SELL", 13, "Arial Bold", lcolor);
    ObjectSetText("stats1", "ATRx1.5 / HH5-LL5 Range: "+DoubleToStr(atrcalc,1)+" / "+DoubleToStr(hhll5,1), 9, "Arial Bold", lcolor);
    ObjectSetText("stats2", "Highest / Lowest: "+DoubleToStr(hh5,Digits)+" / "+DoubleToStr(ll5,Digits), 9, "Arial Bold", lcolor);
    if (usespread) {
      ObjectSetText("entry", "Entry (spread="+DoubleToStr(spread,Digits) + "): "+DoubleToStr(buyEntry+spread,Digits)+" / "+DoubleToStr(sellEntry-spread,Digits), 9, "Arial Bold", lcolor);
    } else {
      ObjectSetText("entry", "Entry: "+DoubleToStr(buyEntry,Digits)+" / "+DoubleToStr(sellEntry,Digits), 9, "Arial Bold", lcolor);
    }
    ObjectSetText("tp1", "TP1: "+DoubleToStr(buyTP1,Digits)+" / "+DoubleToStr(sellTP1,Digits), 9, "Arial Bold", Green);
    
    if (oldcalculations==true) {
      ObjectSetText("tp2", "TP2: "+DoubleToStr(buyTP2,Digits)+" / "+DoubleToStr(sellTP2,Digits), 9, "Arial Bold", Lime);
    } else {
      ObjectSetText("tp2", "TP2: "+DoubleToStr(buyTweakedTP2,Digits)+" / "+DoubleToStr(sellTweakedTP2,Digits), 9, "Arial Bold", Lime);
    }

    if (oldcalculations==true) {
      if (usespread) {
        ObjectSetText("sl", "SL: "+DoubleToStr(buySL-spread,Digits)+" / "+DoubleToStr(sellSL+spread,Digits), 9, "Arial Bold", Red);
      } else {
        ObjectSetText("sl", "SL: "+DoubleToStr(buySL,Digits)+" / "+DoubleToStr(sellSL,Digits), 9, "Arial Bold", Red);
      }
    } else {
      if (usespread) {
        ObjectSetText("sl", "SL: "+DoubleToStr(buyEntry-spread-tweakedSL,Digits)+" / "+DoubleToStr(sellEntry+spread+tweakedSL,Digits), 9, "Arial Bold", Red);
      } else {
        ObjectSetText("sl", "SL: "+DoubleToStr(buyEntry-tweakedSL,Digits)+" / "+DoubleToStr(sellEntry+tweakedSL,Digits), 9, "Arial Bold", Red);
      }
    }
   }

#54
Feb 16, 2011 9:54pm Feb 16, 2011 9:54pm

the-game
| Joined Sep 2010 | Status: Trader | 721 Posts

Here's the fix for your Arrows code:

BEFORE:

Inserted Code

20/pips2dbl

AFTER:

Inserted Code

20*pips2dbl

#55
Feb 17, 2011 2:27am Feb 17, 2011 2:27am

Lopuch
| Joined Aug 2006 | Status: Trader | 164 Posts

It is err with calculation for USD/JPY ? TP is far far way? (Small Hours v.2 latest)

Attached Image (click to enlarge)

Click to Enlarge

Name: usd jpy err.gif
Size: 22 KB

#56
Feb 17, 2011 3:25am Feb 17, 2011 3:25am

pp22
| Joined Feb 2011 | Status: Trader | 235 Posts

Hey ido

Just want to say great work on this, very much appreciated

Just wondering if it would be possible to move the blue square that covers the 5 bars back to previous bars. And have it recalculate all the values. I guess that would be back testing.

Thanks

#57
Feb 17, 2011 7:10am Feb 17, 2011 7:10am

todd960960
| Joined Nov 2008 | Status: Trader | 470 Posts

It's because your using the incorrect version. v.2latest isn't the latest. I think it's v.2b

todd

Quoting Lopuch

Disliked

It is err with calculation for USD/JPY ? TP is far far way? (Small Hours v.2 latest)

Ignored

#58
Feb 17, 2011 10:00am Feb 17, 2011 10:00am

boulavard
| Joined Mar 2010 | Status: Trader | 13 Posts

Quoting ido370

Disliked

Just to make it back according to original rules, and i had some time left this evening, i placed rule 2 back in code.
So now with rule 2 back, and the new calculations from Colostarr, this should your thing to use
Attachment
Attachment

no further new additions then v2c in post above. Have fun.

Ignored

Can somebody tell me how to load this indicator on MT4?

#59
Feb 17, 2011 10:45am Feb 17, 2011 10:45am

Lopuch
| Joined Aug 2006 | Status: Trader | 164 Posts

Quoting todd960960

Disliked

It's because your using the incorrect version. v.2latest isn't the latest. I think it's v.2b

todd

Ignored

Thank you, go tested.

#60
Feb 17, 2011 3:14pm Feb 17, 2011 3:14pm

ido370
| Joined Mar 2010 | Status: Trader | 464 Posts

Quoting Lopuch

Disliked

Thank you, go tested.

Ignored

Hi Lopuch, latest version is on top of page 4, and is version 3.

Commercial Content
/
The Small Hours Simplified - Coding only
Reply to Thread
- 1 2 Page 3 4 5 6 11
- 1 2 Page 3 4 11

0 traders viewing now

Options

Similar Threads

The Small Hours Simplified - Coding only