Need Help writing a simple indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

help in writing MT5 indicator 2 replies

Need help writing an MQL4 indicator - avg trend/existing trend 2 replies

Who helps me out writing ridiculous simple EA 5 replies

Would someone please help me with writing a strategy? 4 replies

Attachments: Need Help writing a simple indicator
Exit Attachments

Need Help writing a simple indicator

  • #1
  • First Post: Nov 15, 2010 12:03pm Nov 15, 2010 12:03pm
Hello

I attempt to write a simple indicator (I'm starting with mql language).
My indicator plots a line at London open and 4 lines up and 4 lines down total 9 lines, Iwrote
#property indicator_buffers 9
#property indicator_color1..... and so on to #9, but this one (#9) is not written in blue as the others
the same occurs with
#property indicator_width1...to #9 and with indicator_style
that means that Metatrader doesn't allow that last line?
If not, there's a way to draw that last line?

Thanks in advance
FxCba
  • #2
  • Nov 15, 2010 12:24pm Nov 15, 2010 12:24pm
MT4 has a limit of 8 buffers.
  • #3
  • Nov 15, 2010 12:40pm Nov 15, 2010 12:40pm
Oh
Thank you very much Aja
  • #4
  • Nov 15, 2010 5:35pm Nov 15, 2010 5:35pm
New question

is this the statement for open value?:

datetime TimeArray[];
double OpenArray[];
ArrayCopySeries(OpenArray,MODE_OPEN,Symbol(),TimeFrame);

I get the open value, but for 0:00hs GMT, I want the open value for London sesion, how should it be?
  • #5
  • Edited 9:46pm Nov 15, 2010 6:02pm | Edited 9:46pm
Quoting FxCba
New question

is this the statement for open value?:

datetime TimeArray[];
double OpenArray[];
ArrayCopySeries(OpenArray,MODE_OPEN,Symbol(),TimeFrame);

I get the open value, but for 0:00hs GMT, I want the open value for London sesion, how should it be?
MODE_OPEN refers to the candle selected. It is the open price of the candle. You should probably be using MODE_TIME if it is time data you require.

MT4 does not know when London opens. You will have to give an opening time/date and search for the bar.

Something like this should give you the latest London open:

PHP Code
int LondonOpenTime=9;
double LondonOpenPrice;

for (int i=0;i<Bars;i++)
  if (TimeHour(TimeArray[i])==LondonOpen  && TimeMinute(TimeArray[i])==0)  LondonOpenPrice=OpenArray[i];
If the time-frame is lower than 1 hour, you'll have to check the minutes too. I've amended the example above.
  • #6
  • Nov 15, 2010 6:32pm Nov 15, 2010 6:32pm
Xaphod

Thank you for your answer, I'll try your solution and I'll make more questions surely
  • #7
  • Nov 16, 2010 5:52pm Nov 16, 2010 5:52pm
Hello, It's me again
I've managed to create the indicator based on other indicator found in other forum, I have a little problem, the indicator has 8 lines I want them labeled but only get one of them with label, can somebody figure out what the problem is?
this is the labels code:

ObjectCreate("1", OBJ_TEXT, 0, 0,0);
ObjectSetText("1", " 1",fontsize,"Arial",Red);
ObjectCreate("0,75", OBJ_TEXT, 0, 0, 0);
ObjectSetText("0,75", " 0,75",fontsize,"Arial",Red);
ObjectCreate("0,55", OBJ_TEXT, 0, 0, 0);
ObjectSetText("0,55", " 0,55",fontsize,"Arial",Red);
ObjectCreate("0,35", OBJ_TEXT, 0, 0, 0);
ObjectSetText("0,35", " 0,35",fontsize,"Arial",Red);
ObjectCreate("-0,35", OBJ_TEXT, 0, 0, 0);
ObjectSetText("-0,35", " -0,35",fontsize,"Arial",Red);
ObjectCreate("-0,55", OBJ_TEXT, 0, 0, 0);
ObjectSetText("-0,55", " -0,55",fontsize,"Arial",Red);
ObjectCreate("-0,75", OBJ_TEXT, 0, 0, 0);
ObjectSetText("-0,75", " -0,75",fontsize,"Arial",Red);
ObjectCreate("-1", OBJ_TEXT, 0, 0, 0);
ObjectSetText("-1", " -1",fontsize,"Arial",Red);

if (PBuffer1[i]!=PBuffer1[i+1]) ObjectMove("1", 0, Time[i],P);
if (PBuffer2[i]!=PBuffer2[i+1]) ObjectMove("0.75", 0, Time[i],Q);
if (PBuffer3[i]!=PBuffer3[i+1]) ObjectMove("0.55", 0, Time[i],R);
if (PBuffer4[i]!=PBuffer4[i+1]) ObjectMove("0.35", 0, Time[i],S);
if (PBuffer5[i]!=PBuffer5[i+1]) ObjectMove("-0.35", 0, Time[i],T);
if (PBuffer6[i]!=PBuffer6[i+1]) ObjectMove("-0.55", 0, Time[i],U);
if (PBuffer7[i]!=PBuffer7[i+1]) ObjectMove("-0.75", 0, Time[i],V);
if (PBuffer8[i]!=PBuffer8[i+1]) ObjectMove("-1", 0, Time[i],W);

P,Q,R,S,T,U,V,W are declared with the indicator calculation

Any suggestion for correct this or replace it with something that works is wellcome
  • #8
  • Nov 16, 2010 8:21pm Nov 16, 2010 8:21pm
Quoting FxCba
Hello, It's me again
I've managed to create the indicator based on other indicator found in other forum, I have a little problem, the indicator has 8 lines I want them labeled but only get one of them with label, can somebody figure out what the problem is?
this is the labels code:
Open up the object list (Ctrl-B or right click_>Object list) and see if your objects are created and if they are, check what properties and parameters they have. They are probably being plotted, but not on the visible part of the chart. Are the time and price parameters what you expect them to be?
  • #9
  • Nov 17, 2010 4:51am Nov 17, 2010 4:51am
Quoting Xaphod
Open up the object list (Ctrl-B or right click_>Object list) and see if your objects are created and if they are, check what properties and parameters they have. They are probably being plotted, but not on the visible part of the chart. Are the time and price parameters what you expect them to be?
Yes Xaphod you're right, but my issue is I can't solve it. First image is one of missing labels, the other is the correct one
Attached Images
  • #10
  • Edited 8:53am Nov 17, 2010 5:06am | Edited 8:53am
Quoting FxCba
Yes Xaphod you're right, but my issue is I can't solve it. First image is one of missing labels, the other is the correct one
Maybe the condition you set is not true and therefore the Move function is not executed. This works for me. Prints '1' next to the current candle:
PHP Code
//+------------------------------------------------------------------+
//| script program start function                                    |
//+------------------------------------------------------------------+
int start() {
  ObjectCreate("1", OBJ_TEXT, 0, 0,0);
  ObjectSetText("1", " 1",12,"Arial",Red); 
  if (ObjectFind("1")>=0) ObjectMove("1", 0, Time[0],Bid);
}
Do this to see if the line is executed and to see what values you are getting:
PHP Code
if (PBuffer1[i]!=PBuffer1[i+1]) 
  Comment("Time=", Time[i], " Buf1=", PBuffer1[i], " Buf2=", PBuffer1[i+1]);
  • #11
  • Nov 17, 2010 5:49am Nov 17, 2010 5:49am
Yes I've got the label but at the current candle level, not where it's supossed to be .
  • #12
  • Nov 20, 2010 2:03pm Nov 20, 2010 2:03pm
Well, I made it, works perfect!!!
Thank you very much Xaphod
  • #13
  • Nov 20, 2010 11:36pm Nov 20, 2010 11:36pm
Awesome! Glad I could be of assistance.
Quoting FxCba
Well, I made it, works perfect!!!
Thank you very much Xaphod
  • #14
  • Nov 21, 2010 8:24am Nov 21, 2010 8:24am
I want to modify the Williams %R formula, I don't need to see the subwindow only need the value of Williams%R in the upper right corner of the chart (see pic), but it's ok is subwindows stays, please some hint how to get it
Attached Image (click to enlarge)
Click to Enlarge Name: ScreenHunter_01 Nov. 21 11.04.gif Size: 19 KB
  • #15
  • Nov 22, 2010 1:26am Nov 22, 2010 1:26am
Quoting FxCba
I want to modify the Williams %R formula, I don't need to see the subwindow only need the value of Williams%R in the upper right corner of the chart (see pic), but it's ok is subwindows stays, please some hint how to get it
Use the function iWPR( string symbol, int timeframe, int period, int shift)
ex:
double dValue=iWPR(NULL,0,14,0);

Also you can use iCustom() to call external indicators.
  • #16
  • Nov 23, 2010 6:15am Nov 23, 2010 6:15am
Thank you my friend, hope I can made it.
Regards
  • #17
  • Last Post: Aug 13, 2013 3:37am Aug 13, 2013 3:37am
hello
can anyone write a simple indicator like atr for me ?
it shows the lenght of tail of a candle for n period :

for every candle :
if the candle is bullish : open-low
if the candle is bearish :high-open
and it shows the average of tale lenght for a "user specified"period
its fully the same as atr
atr(n) shows high-low for n period
the indicator i want shows the lengh of tale for n period
0 traders viewing now