unique magic number by pair

Post #1
Quote
First Post: Edited Nov 3, 2010 2:08am Nov 2, 2010 2:50pm | Edited Nov 3, 2010 2:08am

getting
| Joined Jun 2009 | Status: Member | 265 Posts

here we go, add this to your ea.

extern int Magic=666;//|-------------------------- Number used by EA to identify orders placed by itself and manage them.
extern bool AutoMagic=true;

int init()
if(AutoMagic){
if(Symbol()=="AUDCADm" || Symbol()=="AUDCAD")Magic=66601;
if(Symbol()=="AUDCHFm" || Symbol()=="AUDCHF")Magic=66602;
if(Symbol()=="AUDJPYm" || Symbol()=="AUDJPY")Magic=66603;
if(Symbol()=="AUDNZDm" || Symbol()=="AUDNZD")Magic=66604;
if(Symbol()=="AUDUSDm" || Symbol()=="AUDUSD")Magic=66605;
if(Symbol()=="CADCHFm" || Symbol()=="CADCHF")Magic=66606;
if(Symbol()=="CADJPYm" || Symbol()=="CADJPY")Magic=66607;
if(Symbol()=="CHFJPYm" || Symbol()=="CHFJPY")Magic=66608;
if(Symbol()=="EURAUDm" || Symbol()=="EURAUD")Magic=66609;
if(Symbol()=="EURCADm" || Symbol()=="EURCAD")Magic=66610;
if(Symbol()=="EURCHFm" || Symbol()=="EURCHF")Magic=66611;
if(Symbol()=="EURGBPm" || Symbol()=="EURGBP")Magic=66612;
if(Symbol()=="EURJPYm" || Symbol()=="EURJPY")Magic=66613;
if(Symbol()=="EURNZDm" || Symbol()=="EURNZD")Magic=66614;
if(Symbol()=="EURUSDm" || Symbol()=="EURUSD")Magic=66615;
if(Symbol()=="GBPAUDm" || Symbol()=="GBPAUD")Magic=66616;
if(Symbol()=="GBPCADm" || Symbol()=="GBPCAD")Magic=66617;
if(Symbol()=="GBPCHFm" || Symbol()=="GBPCHF")Magic=66618;
if(Symbol()=="GBPJPYm" || Symbol()=="GBPJPY")Magic=66619;
if(Symbol()=="GBPNZDm" || Symbol()=="GBPNZD")Magic=66620;
if(Symbol()=="GBPUSDm" || Symbol()=="GBPUSD")Magic=66621;
if(Symbol()=="NZDCADm" || Symbol()=="NZDCAD")Magic=66622;
if(Symbol()=="NZDCHFm" || Symbol()=="NZDCHF")Magic=66623;
if(Symbol()=="NZDJPYm" || Symbol()=="NZDJPY")Magic=66624;
if(Symbol()=="NZDUSDm" || Symbol()=="NZDUSD")Magic=66625;
if(Symbol()=="USDCADm" || Symbol()=="USDCAD")Magic=66626;
if(Symbol()=="USDCHFm" || Symbol()=="USDCHF")Magic=66627;
if(Symbol()=="USDJPYm" || Symbol()=="USDJPY")Magic=66628;
if(Symbol()=="USDSGDm" || Symbol()=="USDSGD")Magic=66629;
if(Symbol()=="SGDJPYm" || Symbol()=="SGDJPY")Magic=66630;
if(Magic==0)Magic=666;
}

Post #2
Quote
Nov 3, 2010 12:37pm Nov 3, 2010 12:37pm

7bit
Joined Mar 2009 | Status: Member | 1,231 Posts

ugly code.

Better use a hash function like makeMagicNumber() from the common_functions.mqh library.

Post #3
Quote
Nov 3, 2010 1:14pm Nov 3, 2010 1:14pm

hayseed
Joined Nov 2006 | Status: Member | 4,095 Posts

good grief, whole lot of 6's in that code...... what's wrong with 7...... you might want to add some sort condition for differing timeframes on same pair.......

//----

have yet to see a better method of autogenerating magicnumbers than patrick's method...... he is perhaps the first to fully automate with respect to pairs and timeframes....

it's writtin out in long form here but can be reduced considerably.....

if you could trace the code of most ea's back to the original source, much would end up at patrick's keyboard...... bits and pieces of his code have been copied a gozzillion times.....

it's surprising to see how many commercial ea's have copied his functions cut/paste style.....

you wouldn't know if ya didn't know it, he is the coder behind the ibfx ea's ,indicators, scripts and such....... and has been for many many years.......h

//----

Inserted Code

 
//+------------------------------------------------------------------+
//| Make Magic Number |
//+------------------------------------------------------------------+
int MakeMagicNumber( int ExpertID, bool TimeSpecific )
{
int SymbolCode = 0;
int PeriodCode = 0;
int MagicNumber = 0; 
 
//---- Symbol Code
if( Symbol() == "AUDCAD" || Symbol() == "AUDCADm" ) { SymbolCode = 1000; }
else if( Symbol() == "AUDJPY" || Symbol() == "AUDJPYm" ) { SymbolCode = 2000; }
else if( Symbol() == "AUDNZD" || Symbol() == "AUDNZDm" ) { SymbolCode = 3000; }
else if( Symbol() == "AUDUSD" || Symbol() == "AUDUSDm" ) { SymbolCode = 4000; }
else if( Symbol() == "CHFJPY" || Symbol() == "CHFJPYm" ) { SymbolCode = 5000; }
else if( Symbol() == "EURAUD" || Symbol() == "EURAUDm" ) { SymbolCode = 6000; }
else if( Symbol() == "EURCAD" || Symbol() == "EURCADm" ) { SymbolCode = 7000; }
else if( Symbol() == "EURCHF" || Symbol() == "EURCHFm" ) { SymbolCode = 8000; }
else if( Symbol() == "EURGBP" || Symbol() == "EURGBPm" ) { SymbolCode = 9000; }
else if( Symbol() == "EURJPY" || Symbol() == "EURJPYm" ) { SymbolCode = 1000; }
else if( Symbol() == "EURUSD" || Symbol() == "EURUSDm" ) { SymbolCode = 1100; }
else if( Symbol() == "GBPCHF" || Symbol() == "GBPCHFm" ) { SymbolCode = 1200; }
else if( Symbol() == "GBPJPY" || Symbol() == "GBPJPYm" ) { SymbolCode = 1300; }
else if( Symbol() == "GBPUSD" || Symbol() == "GBPUSDm" ) { SymbolCode = 1400; }
else if( Symbol() == "NZDJPY" || Symbol() == "NZDJPYm" ) { SymbolCode = 1500; }
else if( Symbol() == "NZDUSD" || Symbol() == "NZDUSDm" ) { SymbolCode = 1600; }
else if( Symbol() == "USDCAD" || Symbol() == "USDCADm" ) { SymbolCode = 1700; }
else if( Symbol() == "USDCHF" || Symbol() == "USDCHFm" ) { SymbolCode = 1800; }
else if( Symbol() == "USDJPY" || Symbol() == "USDJPYm" ) { SymbolCode = 1900; }
 
 
//---- Period Code
if( TimeSpecific )
{
if( Period() == 1 ) { PeriodCode = 10; }
else if( Period() == 5 ) { PeriodCode = 20; }
else if( Period() == 15 ) { PeriodCode = 30; }
else if( Period() == 30 ) { PeriodCode = 40; }
else if( Period() == 60 ) { PeriodCode = 50; }
else if( Period() == 240 ) { PeriodCode = 60; }
else if( Period() == 1440 ) { PeriodCode = 70; }
else if( Period() == 10080 ){ PeriodCode = 80; }
}
else
{
PeriodCode = 0;
}
//---- Calculate MagicNumber
MagicNumber = ExpertID+SymbolCode+PeriodCode;
return(MagicNumber);
}

to trade and code, keep both simple... no call to impress....h

Post #4
Quote
Nov 3, 2010 1:30pm Nov 3, 2010 1:30pm

sangmane
Joined Apr 2009 | Status: MT4 Programmer | 758 Posts

Quoting hayseed

Disliked

good grief, whole lot of 6's in that code...... what's wrong with 7......

Ignored

http://en.wikipedia.org/wiki/Number_of_the_Beast

Post #5
Quote
Nov 3, 2010 4:20pm Nov 3, 2010 4:20pm

7bit
Joined Mar 2009 | Status: Member | 1,231 Posts

Quoting hayseed

Disliked

have yet to see a better method of autogenerating magicnumbers than patrick's method

Ignored

Inserted Code

[color=#7f0055][b]int[/b][/color] [color=#000000]start[/color][color=#000000](){[/color]
   magic [color=#000000]=[/color] [color=#000000]makeMagicNumber[/color][color=#000000]([/color][color=#000000]WindowExpertName[/color][color=#000000]() +[/color] [color=#000000]Symbol[/color][color=#000000]() +[/color] [color=#000000]Period[/color][color=#000000]());[/color]
[color=#000000]}[/color]


[color=#717ab3]/**[/color]
[color=#717ab3]* create a positive integer for the use as a magic number.[/color]
[color=#717ab3]*[/color]
[color=#717ab3]* The function takes a string as argument and calculates[/color]
[color=#717ab3]* an 31 bit hash value from it. The hash does certainly not[/color]
[color=#717ab3]* have the strength of a real cryptographic hash function[/color]
[color=#717ab3]* but it should be more than sufficient for generating a[/color]
[color=#717ab3]* unique ID from a string and collissions should not occur.[/color]
[color=#717ab3]*[/color]
[color=#717ab3]* use it in your init() function like this:[/color]
[color=#717ab3]*    magic = makeMagicNumber(WindowExpertName() + Symbol() + Period());[/color]
[color=#717ab3]*[/color]
[color=#717ab3]* where name would be the name of your EA. Your EA will then[/color]
[color=#717ab3]* get a unique magic number for each instrument and timeframe[/color]
[color=#717ab3]* and this number will always be the same, whenever you put[/color]
[color=#717ab3]* the same EA onto the same chart.[/color]
[color=#717ab3]*[/color]
[color=#717ab3]* Numbers generated during testing mode will differ from those[/color]
[color=#717ab3]* numbers generated on a live chart.[/color]
[color=#717ab3]*/[/color]
[color=#7f0055][b]int[/b][/color] [color=#000000]makeMagicNumber[/color][color=#000000]([/color]string key[color=#000000]) {[/color]
   [color=#7f0055][b]int[/b][/color] i[color=#000000],[/color] k[color=#000000];[/color]
   [color=#7f0055][b]int[/b][/color] h [color=#000000]=[/color] [color=#000000]0[/color][color=#000000];[/color]

   [color=#7f0055][b]if[/b][/color] [color=#000000]([/color][color=#000000]IsTesting[/color][color=#000000]()) {[/color]
      key [color=#000000]=[/color] [color=#0000ff]"_"[/color] [color=#000000]+[/color] key[color=#000000];[/color]
   [color=#000000]}[/color]

   [color=#7f0055][b]for[/b][/color] [color=#000000]([/color]i [color=#000000]=[/color] [color=#000000]0[/color][color=#000000];[/color] i [color=#000000]<[/color] [color=#000000]StringLen[/color][color=#000000]([/color]key[color=#000000]);[/color] i[color=#000000]++) {[/color]
      k [color=#000000]=[/color] [color=#000000]StringGetChar[/color][color=#000000]([/color]key[color=#000000],[/color] i[color=#000000]);[/color]
      h [color=#000000]=[/color] h [color=#000000]+[/color] k[color=#000000];[/color]
      h [color=#000000]=[/color] [color=#000000]bitRotate[/color][color=#000000]([/color]h[color=#000000],[/color] [color=#000000]5[/color][color=#000000]);[/color] [color=#2f9956]// rotate 5 bits[/color]
   [color=#000000]}[/color]

   [color=#7f0055][b]for[/b][/color] [color=#000000]([/color]i [color=#000000]=[/color] [color=#000000]0[/color][color=#000000];[/color] i [color=#000000]<[/color] [color=#000000]StringLen[/color][color=#000000]([/color]key[color=#000000]);[/color] i[color=#000000]++) {[/color]
      k [color=#000000]=[/color] [color=#000000]StringGetChar[/color][color=#000000]([/color]key[color=#000000],[/color] i[color=#000000]);[/color]
      h [color=#000000]=[/color] h [color=#000000]+[/color] k[color=#000000];[/color]
      [color=#2f9956]// rotate depending on character value[/color]
      h [color=#000000]=[/color] [color=#000000]bitRotate[/color][color=#000000]([/color]h[color=#000000],[/color] k [color=#000000]&[/color] [color=#000000]0x0000000F[/color][color=#000000]);[/color]
   [color=#000000]}[/color]

   [color=#2f9956]// now we go backwards in our string[/color]
   [color=#7f0055][b]for[/b][/color] [color=#000000]([/color]i [color=#000000]=[/color] [color=#000000]StringLen[/color][color=#000000]([/color]key[color=#000000]);[/color] i [color=#000000]>[/color] [color=#000000]0[/color][color=#000000];[/color] i[color=#000000]--) {[/color]
      k [color=#000000]=[/color] [color=#000000]StringGetChar[/color][color=#000000]([/color]key[color=#000000],[/color] i [color=#000000]-[/color] [color=#000000]1[/color][color=#000000]);[/color]
      h [color=#000000]=[/color] h [color=#000000]+[/color] k[color=#000000];[/color]
      [color=#2f9956]// rotate depending on the last 4 bits of h[/color]
      h [color=#000000]=[/color] [color=#000000]bitRotate[/color][color=#000000]([/color]h[color=#000000],[/color] h [color=#000000]&[/color] [color=#000000]0x0000000F[/color][color=#000000]);[/color]
   [color=#000000]}[/color]

   [color=#7f0055][b]return[/b][/color][color=#000000]([/color]h [color=#000000]&[/color] [color=#000000]0x7fffffff[/color][color=#000000]);[/color]
[color=#000000]}[/color]

[color=#717ab3]/**[/color]
[color=#717ab3]* Rotate a 32 bit integer value bit-wise[/color]
[color=#717ab3]* the specified number of bits to the right.[/color]
[color=#717ab3]* This function is needed for calculations[/color]
[color=#717ab3]* in the hash function makeMacicNumber()[/color]
[color=#717ab3]*/[/color]
[color=#7f0055][b]int[/b][/color] [color=#000000]bitRotate[/color][color=#000000]([/color][color=#7f0055][b]int[/b][/color] value[color=#000000],[/color] [color=#7f0055][b]int[/b][/color] count[color=#000000]) {[/color]
   [color=#7f0055][b]int[/b][/color] i[color=#000000],[/color] tmp[color=#000000],[/color] mask[color=#000000];[/color]
   mask [color=#000000]= ([/color][color=#000000]0x00000001[/color] [color=#000000]<<[/color] count[color=#000000]) -[/color] [color=#000000]1[/color][color=#000000];[/color]
   tmp [color=#000000]=[/color] value [color=#000000]&[/color] mask[color=#000000];[/color]
   value [color=#000000]=[/color] value [color=#000000]>>[/color] count[color=#000000];[/color]
   value [color=#000000]=[/color] value [color=#000000]| ([/color]tmp [color=#000000]<< ([/color][color=#000000]32[/color] [color=#000000]-[/color] count[color=#000000]));[/color]
   [color=#7f0055][b]return[/b][/color][color=#000000]([/color]value[color=#000000]);[/color]
[color=#000000]}[/color]

Now you have seen it. It has been in the common_functions.mqh for a long time now already.

Post #6
Quote
Nov 3, 2010 4:45pm Nov 3, 2010 4:45pm

hayseed
Joined Nov 2006 | Status: Member | 4,095 Posts

hey 7bit..... different methods exist....... different excellent methods exist.......

but there is a tremendous difference in any code i've ever seen and patricks.......

someone managing hundreds or thousands of orders on many pairs and timeframes at the same time would see it......

using patricks method, in my mind i can calculate any magicnumber uniquely for any pair on any timeframe.....h

to trade and code, keep both simple... no call to impress....h

Post #7
Quote
Nov 3, 2010 5:00pm Nov 3, 2010 5:00pm

7bit
Joined Mar 2009 | Status: Member | 1,231 Posts

Quoting hayseed

Disliked

using patricks method, in my mind i can calculate any magicnumber uniquely for any pair on any timeframe.....h

Ignored

Now you know another method that fulfills the same purpose (unique number for each EA, pair, timeframe). Its even more elegant since it works for any new symbol whose name was not preveviously known when the function was written.

Post #8
Quote
Edited 2:27am Nov 4, 2010 2:25am | Edited 2:27am

beckhamis619
| Joined Dec 2009 | Status: Member | 10 Posts

here's one I wrote for an ea in another forum a while ago,

http://en.wikipedia.org/wiki/Jenkins_hash_function

Inserted Code

int jenkinsHash(string symbol,int period) {         
        int magic = 0;
        string msg = symbol + "__" + period;
        for (int i=0;i<StringLen(msg);i++) {
                magic += StringGetChar(msg,i);
                magic += (magic << 10);
                magic ^= (magic >> 6);
        }
        magic += (magic << 3);
        magic ^= (magic >> 11);
        magic += (magic << 15);
        magic = MathAbs(magic);
        return(magic);
}

to use it, set magicnumber = jenkinsHash(Symbol(),Period())

Post #9
Quote
Last Post: Nov 5, 2010 9:28am Nov 5, 2010 9:28am

hayseed
Joined Nov 2006 | Status: Member | 4,095 Posts

Quoting 7bit

Disliked

Now you know another method that fulfills the same purpose (unique number for each EA, pair, timeframe). Its even more elegant since it works for any new symbol whose name was not preveviously known when the function was written.

Ignored

hey 7bit..... yes i had seen that before..... i scan thru most code you post..... your function works with previously unknow symbols.....

but suppose you want to attach the same ea to the 5 separate charts of the usdjpy daily but with different settings.....

or suppose one ea places the trades but they might be managed by another or multiple other ea's.....

when you start trying to manage hundreds or thousands of orders at a time, other issues will become obvious.....

//-----
//-----

for reason's you have so vividly pointed out in the past, your method/preference/style of coding will of course be vastly different than mine...... and better......

don't think for one second i do not look at your code......h

to trade and code, keep both simple... no call to impress....h

Platform Tech
/
unique magic number by pair
Reply to Thread

0 traders viewing now

Options

Similar Threads

unique magic number by pair