Help with logic for only hitting one order per bar | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

3 Bar Fractal with mid-bar and bar on each side 11 replies

One trade per daily bar, or per X bars on current timeframe 0 replies

help coding this "one way logic" indicator please 17 replies

Pin bar, pin bar, pin bar 0 replies

Making sure only one position open per currency pair: Coding help 0 replies

Help with logic for only hitting one order per bar

  • #1
  • First Post: Oct 6, 2010 6:58pm Oct 6, 2010 6:58pm
Hi all,

I have to throw out a big thanks to those who have helped me thus far! I am slowly learning to program this MQL! Now I have to learn MQL5! haha..

Anyways, I have an EA that takes an order upon the opening of a bar being above a line. I want to make sure that if I close out this order on the same bar that it doesn't fire off another trade that met the same requirement etc..

I know I can do this spaghetti code style, but curious if you have a nice routine for such already pre-built?
We are our own best indicator.
  • #2
  • Edited 9:07am Oct 7, 2010 3:35am | Edited 9:07am
Inserted Code
int start()
{
   if(New_Bar())Make_Trade()
......do other stuff
}
//------------------------------------------------------+
bool New_Bar()
{
   static datetime New_Time=0;
   if(New_Time!=Time[0]){
      New_Time=Time[0];
      return(true);
   }
   return(false);
}
  • #3
  • Oct 7, 2010 12:22pm Oct 7, 2010 12:22pm
Quoting kennyhubbard
Inserted Code
int start()
{
   if(New_Bar())Make_Trade()
......do other stuff
}
//------------------------------------------------------+
bool New_Bar()
{
   static datetime New_Time=0;
   if(New_Time!=Time[0]){
      New_Time=Time[0];
      return(true);
   }
   return(false);
}
Wow... Thank you!!! So simple and elegant!
We are our own best indicator.
  • #4
  • May 10, 2021 12:18pm May 10, 2021 12:18pm
Quoting kennyhubbard
int start() { if(New_Bar())Make_Trade() ......do other stuff } //------------------------------------------------------+ bool New_Bar() { static datetime New_Time=0; if(New_Time!=Time[0]){ New_Time=Time[0]; return(true); } return(false); }
Hi, what will happen if the New_Time variable is not static? what difference adding static would make, especially that we are assigning New_Time with the new value of Time[0] in "New_Time=Time[0];" so it will be updated

I am just trying to understand the point of static, that's all

Thanks
  • #5
  • May 10, 2021 5:12pm May 10, 2021 5:12pm
static keyword allows the function to 'remember' the value when the function is called again.

Without static, the value of New_Time will always be 0 when the function is called and the function will always return true. With the static keyword, when the function is called again, it remembers what the value was from last time ie Time[0] and can compare to see if it is still the same.

One logic bug that can be introduced with this routine is that it will only return true once per function call, not per tick. Most functions you can call as many times as you like but not this one. If you call it twice in your OnTick function, for example, the second time you call it, it will return false.
  • #6
  • May 10, 2021 6:02pm May 10, 2021 6:02pm
Quoting bluemele
Anyways, I have an EA that takes an order upon the opening of a bar being above a line. I want to make sure that if I close out this order on the same bar that it doesn't fire off another trade that met the same requirement etc..
//-----

hey blue..... keep in mind the unit reason codes..... reason 3 will reset the static variables and a new order might still be sent if conditions exist.....

inadvertently changing time frames caused a problem for me in the past...... so much so, that on some ea's once the orders close it's coded to remove itself from the chart entirely.....

allowing the ea to remove itself can be the best solution.....h
to trade and code, keep both simple... no call to impress....h
  • #7
  • Last Post: May 10, 2021 9:02pm May 10, 2021 9:02pm
Quoting kennyhubbard
static keyword allows the function to 'remember' the value when the function is called again. Without static, the value of New_Time will always be 0 when the function is called and the function will always return true. With the static keyword, when the function is called again, it remembers what the value was from last time ie Time[0] and can compare to see if it is still the same. One logic bug that can be introduced with this routine is that it will only return true once per function call, not per tick. Most functions you can call as many times...
Got it thanks
0 traders viewing now