Nanningbob V5: Steve Hopwood's auto-trading robot | Page 59 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Nanningbob 4h trading system ver. 5.0 4,432 replies

Nanningbob 60x90 EA 3,920 replies

Help regarding NanningBob EA 27 replies

Nanningbob 4H trading system 2,017 replies

Help to improve profitable EA - 1H NanningBob 40MA 200 BB 10 replies

Attachments: Nanningbob V5: Steve Hopwood's auto-trading robot
Exit Attachments

Nanningbob V5: Steve Hopwood's auto-trading robot

  • #1,161
  • Oct 6, 2010 4:11am Oct 6, 2010 4:11am
there is a little bug, please change the red line

double SetTarget4H(string tradedirection4H)
{
............

if (tradedirection4H == buy) // BUY
{
.................
if (UseAtrTp) // use Atr
{ //EntryPrice = Ask;
AtrVal = iATR(Symbol(), AtrTpTimeFrame, AtrTpPeriod, 0) * AtrTpMultiplier;
if (AtrVal<MinDist) AtrVal=MinDist;
target4H = NormalizeDouble(EntryPrice + AtrVal,Digits);
 }//if (UseAtrTp)
}//if (tradedirection4H == buy)
return (NormalizeDouble(target4H,Digits));
}//End double SetTarget4H(string tradedirection4H)
  • #1,162
  • Oct 6, 2010 8:19am Oct 6, 2010 8:19am
MAX,
can u add magic # to v81 so we can use it in the same account as other EA's? Thanks a million bro, great stuff!

Odysseus

Quoting maxou888
there is a little bug, please change the red line

double SetTarget4H(string tradedirection4H)
{...
forexfusiondotcom
  • #1,163
  • Oct 6, 2010 8:22am Oct 6, 2010 8:22am
there is magic already
  • #1,164
  • Oct 6, 2010 8:29am Oct 6, 2010 8:29am
there is?
is it hardcoded?, because i dont see a user input for it in the EA properties anywhere...

Odysseus
forexfusiondotcom
  • #1,165
  • Oct 6, 2010 9:13am Oct 6, 2010 9:13am
Quoting maxou888
there is a little bug, please change the red line

double SetTarget4H(string tradedirection4H)
{...
Max,

Thanks for the fix, but the variable 'target4H' doesn't exist?
We are our own best indicator.
  • #1,166
  • Oct 6, 2010 9:14am Oct 6, 2010 9:14am
Quoting odysseus11
there is?
is it hardcoded?, because i dont see a user input for it in the EA properties anywhere...

Odysseus
yes harcoded
  • #1,167
  • Oct 6, 2010 9:26am Oct 6, 2010 9:26am
Quoting odysseus11
there is?
is it hardcoded?, because i dont see a user input for it in the EA properties anywhere...

Odysseus
int magic4H =222555;
int magicR =333000;
int magicTX =453100;

I believe you can just change those to not be equal, but he mentions something about 'using them with metals', and I have traded GOLD etc.. so I don't know why a magic number has to be of certain characteristics for metals as I have never had to have a special MN unless I just didn't realize it?
We are our own best indicator.
  • #1,168
  • Oct 6, 2010 9:37am Oct 6, 2010 9:37am
is MPTM already hardcoded on Max's version?
  • #1,169
  • Oct 6, 2010 10:18am Oct 6, 2010 10:18am
Hi Max,
1. In 81 you have added a new sequence in CountOpenTrades4H function. The compare (colored red) should be adjusted with correct digits otherwise it is producing repeated error 1 (no error). the correct compare should be:
if (NormalizeDouble(OrderTakeProfit(),Digits) != NormalizeDouble(take,Digits))
I think that the same correction should be also in CountOpenTrades function.

here is the existing code:

if (RecoveryInProgress4H)
{ if (ObjectFind(breakevenlinename4H) > -1)
{ double take = ObjectGet(breakevenlinename4H, OBJPROP_PRICE1);
if (OrderTakeProfit() != take) OrderModify(TicketNo4H, OrderOpenPrice(), OrderStopLoss(), take, OrderExpiration(), CLR_NONE);

2. Please explain why you need the above ordermodify in the count routine when the trade is in recovery? when you do that the following happens on the same tick:
- Count function sets TP value which is not adjusted for actual DD
- Then you call CheckRecoveryTakeProfit4H which makes the adjstment for the actual DD and then you go trouh ModifyTakeProfit4H which makes the correct modify for the order!

3. In ModifyTakeProfit4H function you don't check for error 1 if modify goes wrong before setting TpMoved4H = false. This cause endless cal to this routine with the same TP value.
The check should be as follow:
bool result = OrderModify(OrderTicket(), OrderOpenPrice(), OrderStopLoss(), NewTake, OrderExpiration(), CLR_NONE);
int err=GetLastError();
if (!result && err>1) TpMoved4H = false;
  • #1,170
  • Oct 6, 2010 10:28am Oct 6, 2010 10:28am
Quoting arbinka
Hi Max,
1. In 81 you have added a new sequence in CountOpenTrades4H function. The compare (colored red) should be adjusted with correct digits otherwise it is producing repeated error 1 (no error). the correct compare should be:
if (NormalizeDouble(OrderTakeProfit(),Digits) != NormalizeDouble(take,Digits))
I think that the same correction should be also in CountOpenTrades function.

here is the existing code:

if (RecoveryInProgress4H)
{ if (ObjectFind(breakevenlinename4H) > -1)
{ double take = ObjectGet(breakevenlinename4H,...
Thanks Arbinka for your suggestions.
I have no time right now to mod and test the bot
I hope you can test these mods and look if it's correct
Thanks
Max
  • #1,171
  • Oct 6, 2010 10:29am Oct 6, 2010 10:29am
Quoting Viv108
is MPTM already hardcoded on Max's version?
yes it is
  • #1,172
  • Oct 6, 2010 10:39am Oct 6, 2010 10:39am
Quoting maxou888
Thanks Arbinka for your suggestions.
I have no time right now to mod and test the bot
I hope you can test these mods and look if it's correct
Thanks
Max
Ok! I will do that. But please clarify point number 2 in my previous post.
  • #1,173
  • Oct 6, 2010 10:41am Oct 6, 2010 10:41am
Hello,
I have in journal couple of errors 130
"2010.10.06 17:34:01 NBv5-mtf-mx081_ GBPJPY,H1: Alert: GBPJPY OP_SELLSTOP H4 failed P=131.62 SL=141.61 TP=132.15(130): invalid stops"
May I modify some settings to avoid this?
Thank you.
Pavel
  • #1,174
  • Oct 6, 2010 10:55am Oct 6, 2010 10:55am
Quoting arbinka
Ok! I will do that. But please clarify point number 2 in my previous post.
Really, I don't know. it's the original code from Steve, I copied more or less the same logic for 4H. May be there is some redundant things, i didn't investigate, but you did, so you could try following your logic and see if the TP is still corrected set.
I appreciate very much your efforts.
Max
  • #1,175
  • Oct 6, 2010 10:57am Oct 6, 2010 10:57am
Quoting maya007
Hello,
I have in journal couple of errors 130
"2010.10.06 17:34:01 NBv5-mtf-mx081_ GBPJPY,H1: Alert: GBPJPY OP_SELLSTOP H4 failed P=131.62 SL=141.61 TP=132.15(130): invalid stops"
May I modify some settings to avoid this?
Thank you.
I think it's related to the error I pointed in post #1161
  • #1,176
  • Oct 6, 2010 11:00am Oct 6, 2010 11:00am
Running since October 4 at market start.

Attached Image



Attached Image (click to enlarge)
Click to Enlarge Name: char2.gif Size: 33 KB
  • #1,177
  • Oct 6, 2010 11:01am Oct 6, 2010 11:01am
I have just noticed that Steve's EA is only taking 2 recovery trades. I have 3 open trades and a re-entry line, but the bot will not take the final recovery trade. Is anyone seeing this?

I'm afraid I've drawn a blank as to why it may be. Any ideas anyone?

Cheers, Beastie.
  • #1,178
  • Oct 6, 2010 11:03am Oct 6, 2010 11:03am
thanks Blu,
btw to find that line in the code to fix just do a edit-->find in the editor and look for double SetTarget4H(string tradedirection4H) and it will come up...i found it

Quoting bluemele
int magic4H =222555;
int magicR =333000;
int magicTX =453100;

I believe you can just change those to not be equal, but he mentions something about 'using them with metals', and I have traded GOLD etc.. so I don't know why a magic number has to be of certain characteristics for metals as I have never had to have a special MN unless I just didn't realize it?
forexfusiondotcom
  • #1,179
  • Oct 6, 2010 11:39am Oct 6, 2010 11:39am
Quoting odysseus11
thanks Blu,
btw to find that line in the code to fix just do a edit-->find in the editor and look for double SetTarget4H(string tradedirection4H) and it will come up...i found it
Ok, now that is really strange. I must have been editing the wrong version....

I have 71c right next to it, so I think that was the problemo!

Thanks.
We are our own best indicator.
  • #1,180
  • Oct 6, 2010 11:41am Oct 6, 2010 11:41am
Quoting arbinka
[font="Arial"]After fixing quite few major bugs in this version I have managed to backtest...
Arbinka,

Are you running this on all pairs or just the pairs that tested well?

Curious as I ran this on a 3 month backtest and thus far about 70% of the pairs fare well, the rest not tooo goood and basically blow ups.

Are you not getting pairs that just get left in never never land with huge drawdown? Curious.. I think AUDJPY was the worst, but I can't recall now..
We are our own best indicator.
0 traders viewing now