Sixths trading - an EA by macman, Bob and Steve
- #1
- First Post: Edited Oct 31, 2010 6:35pm Oct 4, 2010 6:14pm | Edited Oct 31, 2010 6:35pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
- #7
- Oct 4, 2010 8:43pm Oct 4, 2010 8:43pm
- | Joined Aug 2006 | Status: Trader | 1,242 Posts
Looks like you may have come up with something special here. I'll start testing it. It's hard to keep up with you guys.The wheels are always turning aren't they.
- #8
- Oct 5, 2010 1:30am Oct 5, 2010 1:30am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
STEVE,
Please note I have selected secondary trades "False" but it is taking secondary pending orders! I notice in the mptm you have as default "manage this pair only , true" and "manage NB trades, true", therefore I presume that each pair needs its own mptm and we can not have "manage all trades, true".
Kind Regards
The Beast needed a couple of extra lines of code to shut down secondary trading if not required. macman and I did not notice this because we have never shut it down. The fix is in post 1 for anyone who feels they might need to stop secondary trading - if the account looks in danger of becoming over-traded, for instance.
I uploaded the mptm from my live account, where it is set to manage GU only. All you do is cancel this and re-set it to manage all trades as per usual. I have uploaded a version with this as the default, but users familiar with mptm do not need to re-download; simply change the inputs.
- #10
- Oct 5, 2010 1:55am Oct 5, 2010 1:55am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
The idea sounds brilliant! I will start demo testing this today on 20 pairs (Alpari UK Demo)
Can I make one tiny observation? This may be a daft suggestion at this stage or may not be possible but from the other thread it was not easy knowing which version was in post 1 because of all the changes. So is it possible to number the bots, e.g. V001, 002, ... 010, and for the version number to also show on the chart?
- #11
- Edited 2:57am Oct 5, 2010 1:59am | Edited 2:57am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
jono has posted about a bug in the newbies thread.
TB leaves orphan recovery breakeven lines behind when the trades close at be. The fix for this is in post 1. I had not noticed because I have no eye for detail and am demoing the bot on umpteen charts and am too lazy to check all the details.
Coders, merely add
to the if (OpenTrades == 0) conditional block at the beginning of start()
TB leaves orphan recovery breakeven lines behind when the trades close at be. The fix for this is in post 1. I had not noticed because I have no eye for detail and am demoing the bot on umpteen charts and am too lazy to check all the details.
Coders, merely add
Inserted Code
if (ObjectFind(breakevenlinename) > -1) ObjectDelete(breakevenlinename);
- #14
- Oct 5, 2010 5:43am Oct 5, 2010 5:43am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Steve
I have set it up on about 20 pairs on H1. I can see how it works clearly.
One thing I noticed is that it is not closing Pending trades and taking new ones on top.
The attached two charts are for EURUSD and USDCHF which have both seen very large moves this morning. There are 4 pending trades open for each.
I switched off the EA while I remove the pending trades manualy hence the 'x' next to the EA name in the chart screen shot.
I will have a look through the configuration and the code but if you have an idea what is causing...
When 20 or so instances of the robot are all deleting their pending trades at the same time, the platform can become overwhelmed. TB just needed an extra line of code to tell it to keep on trying if the initial order deletion failed.
Fix in post 1.
- #16
- Oct 5, 2010 6:03am Oct 5, 2010 6:03am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I have no trades at all. Looks like I should have had a sell!!
- #17
- Oct 5, 2010 6:13am Oct 5, 2010 6:13am
- Joined Oct 2007 | Status: Trader | 1,099 Posts
Depending on when you loaded TB, you might easily have missed the primary sell at the gold line, but should have had the secondary sell at the green line.
- #19
- Oct 5, 2010 7:00am Oct 5, 2010 7:00am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
DxTrade makes a good point. TB does not send alerts when a trade fails - at certain times these would drive you to the wrist-slashing stage. I shall do something about this eventually, but it is not something that disturbs me right now.
TB does print errors to the Expert's tab, so you can see what is going on.
TB does print errors to the Expert's tab, so you can see what is going on.
Looks like you may have come up with something special here. I'll start testing it. It's hard to keep up with you guys.The wheels are always turning aren't they.
Tell me about it. My comp is full of fu&$ing demo mt4. Nice work guys. Looking forward to it I swear, I don't know when yall sleep