Nanningbob V5: Steve Hopwood's auto-trading robot

Quoting Romano

Disliked

Hi Max,
Looks like we have an undefined variable here, as mine doesn't compile.
Compilation error:
'mode9buy' - variable not defined NBv5-19082010-mx066.mq4 (1648, 23)
and
'mode9sell' - variable not defined
Cheers,
Romano

Ignored

void Mode3Sell()
{
   //Equates to #1 Sell 1 MA 25 BB
   //if (DoesTradeExist()) return;

   double  Var1, Var2;
   //---- indicators
   
   // MOVING AVERAGE
   Var1 = iMA(NULL, PERIOD_H4, 1, 0, MODE_LWMA, PRICE_MEDIAN, 0);
   Var2 = iMA(NULL, PERIOD_H4, 4, 0, MODE_LWMA, PRICE_LOW, 0);

   BbLower = iBands(NULL, PERIOD_H4,  25, 2, 0, PRICE_CLOSE, MODE_LOWER, 0); 
    
   RefreshRates();
   //if (Var2 > BbUpper && Var1 < BbUpper)
  if(Bid > Var2 && Var1 < BbUpper) { Sell(no3_SelBulge); }//if(Bid  > Var3 && Var1 < BbUpper)

}//void Mode3Sell()

Quoting Beastie Boy

Disliked

I just noticed that the same error exists in Mode3Sell as was present in Mode3Buy. Edited code below.

[code]void Mode3Sell()
{...

Ignored

Quoting Beastie Boy

Disliked

In the present code, I think the 1.1.3.3 recovery system is actually implemented as 1.3.3. recovery. I have made some modifications to what I think the system should be. Please take a look and see if it is OK

[code]
//If 1 trade open, then recovery is at the 1st stage
if (OpenTrades == 1)
{
//SendMagicNumber = MagicNumber + 30;
SendLots = Lot * 1;
if (Use2.4.2Recovery) SendLots = Lot * 2;
}//if (OpenTrades == 1)

//If 2 trades open, then recovery is at the 2nd stage
if (OpenTrades == 2)
{
//SendMagicNumber = MagicNumber + 60;
if (Use1.1.3.3Recovery)...

Ignored

Quoting Beastie Boy

Disliked

I just noticed that the same error exists in Mode3Sell as was present in Mode3Buy. Edited code below.

[code]void Mode3Sell()
{...

Ignored

Quoting maxou888

Disliked

use this one

Ignored

Quoting Romano

Disliked

for Max_888
please see........
invalid price on Alpari demo
thanks
Romano

Ignored

Quoting SteveHopwood

Disliked

No, this code is correct. The comments are incorrect and misleading, but the actual code is doing what is intended.

Thanks anyway.

Ignored

Quoting Beastie Boy

Disliked

Perhaps I don't properly understand the 1.1.3.3 recovery system. If it is a 4 stage recovery, that will mean we can have up to 5 open trades. The current code stops trading if there are 4 already open. I shall go and have another look through the NB thread to find the part where 1.1.3.3 recovery is discussed so that I can properly grasp it.

Cheers, Beastie.

Ignored

Quoting maxou888

Disliked

use this one

Ignored

Quoting SteveHopwood

Disliked

No, only 4 trades. It is a little confusing because Bob initially talks about 2.4.2 recovery when he means 1.2.4.2. We have 1.2.4.2, 1.1.3.3 posited by Bob and 1.1.2.4 posited by a contributor here; in each case, the initial 1 is the L1 trade.

Ignored

if (TradeDirection == down)
      {
      //#3
         /*
         double screentop = WindowPriceMax(0);   
         if (BbUpper >= screentop) 
         {
            TradingStatus = mode3sell;
            GlobalVariableSet(GvName, 33);
         }//if (BbUpper >= screentop)) 
         */
         
         // alternatively, if this misses valid bulge buys and sell because of screen refresh, could use this code          

         double BulgeTop = NormalizeDouble(screentop-sixth/2, Digits);

         //Extra bulge code contributed by Beastie. Many thanks, Beastie.
         //if (BbUpper >= BulgeTop)
    if (Allow3)
    {
         if (BbUpper >= BulgeTop && Bulge(TradeDirection,BbUpper,BbLower))
         {
            TradingStatus = mode3sell;
            GlobalVariableSet(GvName, 33);        
         }//if (BbUpper >= BulgeTop)
    }//if (Allow3)

         //#1
    if (Allow1)
    {
         if (Ask < BbUpper)
         {
            TradingStatus = mode1sell;
            GlobalVariableSet(GvName, 11);
         }//if (Ask >= BbUpper)
    }//if (Allow1)
         
         //#2
    if (Allow2)
    {
         if (Ask >= BbUpper)
         {
            TradingStatus = mode2sell;
            GlobalVariableSet(GvName, 22);
         }//if (Ask >= BbUpper)
    }//if (Allow2)     
        
        
         //#4
    if (Allow4)
    {
         if (Ask >= BbUpper - (Mode4DistanceToBB * Point) && Ask <= BbUpper)
         {
            TradingStatus = mode4sell;
            GlobalVariableSet(GvName, 44);
         }//if (Ask >= BbUpper - (Mode4DistanceToBB * Point) )
    }//if (Allow4)

if (TradeDirection == up)
      {
     //#3
         /*
         if (BbLower <= screenbottom) 
         {
            TradingStatus = mode3buy;
            GlobalVariableSet(GvName, 3);
         }//if (BbLower <= screenbottom) 
         */

         //Extra bulge code contributed by Beastie. Many thanks, Beastie.
         double BulgeBottom = NormalizeDouble(screenbottom+sixth/2, Digits);
         //if (BbLower <= BulgeBottom) 

    if (Allow3)
    {
         if (BbLower <= BulgeBottom && Bulge(TradeDirection,BbUpper,BbLower)) 
         {
            TradingStatus = mode3buy;
            GlobalVariableSet(GvName, 3);
         }//if (BbLower <= BulgeBottom) 
    }//if (Allow3)

         //#1
    if (Allow1)
    {
         if (Bid > BbLower)
         {
            TradingStatus = mode1buy;
            GlobalVariableSet(GvName, 1);
         }//if (Ask >= BbUpper)
    }//if (Allow1)
         
         //#2
    if (Allow2)
    {
         if (Bid <= BbLower)
         {
            TradingStatus = mode2buy;
            GlobalVariableSet(GvName, 2);
         }//if (Bid <= BbLower)
    }//if (Allow2)
                
         //#4
    if (Allow4)
    {
         if (Bid <= BbLower + (Mode4DistanceToBB * Point) && Bid >= BbLower)
         {
            TradingStatus = mode4buy;
            GlobalVariableSet(GvName, 4);
         }//if (Bid <= BbLower + (Mode4DistanceToBB * Point) )
    }//if (Allow4)

Quoting Beastie Boy

Disliked

Steve, Max
I think there may be a problem with the trade number testing section of the code. It is possible for the #2 and #3 trade conditions to be satisfied at the same time, ie Ask > = BbUpper and the upper BB satisfying the bulge requirements . When the conditions are tested, TradingStatus will be set to mode3sell. This causes a problem if Allow3 is set to false. No trade will be taken.
To solve this problem, Allow2 and Allow3 etc should be tested before TradingStatus is set.

Also, since bulge detection is a little flakey, #3 trades should...

Ignored

Quoting SteveHopwood

Disliked

What is needed to implement the Allowxxxx inputs to work fully is to place each of the direction-finding code blocks with an if (Allowx) and I will do this sometime soon.

Ignored

Quoting SteveHopwood

Disliked

Thinking about this briefly, it would be possible to combine, say, a #1 sell with a #3 bulge sell by setting the gv to 1133 and re-coding the trigger-checking function calls. It gets a bit complicated, but I am sure it could be done.

Ignored