Nanningbob V5: Steve Hopwood's auto-trading robot | Page 6 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Nanningbob 4h trading system ver. 5.0 4,432 replies

Nanningbob 60x90 EA 3,920 replies

Help regarding NanningBob EA 27 replies

Nanningbob 4H trading system 2,017 replies

Help to improve profitable EA - 1H NanningBob 40MA 200 BB 10 replies

Attachments: Nanningbob V5: Steve Hopwood's auto-trading robot
Exit Attachments

Nanningbob V5: Steve Hopwood's auto-trading robot

  • #101
  • Aug 16, 2010 5:53am Aug 16, 2010 5:53am
Fantastic Simon. Thanks. I have put this into post 1 so everybody gets the latest.

Do me a favour will you, when you have time? Cast your eyes over the attached and see if you can work out why it does not perform as I want.

What is supposed to happen is this:

 

  1. NB finds a negative trade and calls RecoveryModule()
  2. if RecoveryModule() finds the trade is not deeply enough into dd to warrant recovery, it aborts the process
  3. if the trade is deep enough into dd to warrant recovery, NB adds 20 or 40 to the magic number, to allow re-entries.
  4. when a re-entry is made, calls CheckRecoveryTakeProfit(). This uses code pinched from iExposure to calculate the breakeven tp and modify the trades' tp's.

1, 2 and 4 work fine - I know 4 works because I had some code in the wrong order and NB was altering the tp as soon as the trade entered Recovery territory.

I had to do some alteration to the magic number thigy. We do not need different mn's for each trading method, so I have stripped all that out and replaced it with a single mn that can be incremented to allow NB to send recovery trades.

Step 3 does not appear to happen; re-entries are not happening. I was going to try to sort this out this morning, but Bob is cooking something and wanted an ea to allow him to experiment and I have been coding that.
RecoveryInProgress is set when a trade goes into recovery territory. Once a further trade us sent, TpMoved is set to true once all the tp's have been successfully modified, so the robot does not have to keep on looking.

I have to go out to teach soon, and will be out for the rest of today.
Can you see why step 3 is not happening?

Attached File(s)
File Type: mq4 Nanningbob V5 auto-trader with Recovery by Steve and Simon.mq4   70 KB | 798 downloads
  • #102
  • Edited 1:12pm Aug 16, 2010 11:28am | Edited 1:12pm
It days like this, i live for:-

#1 EA works..... #2, #3, and #4 running

this is the Nanningbob V5 auto-trader by Steve and Simon.mq4 running, it was just easier save the file as the original, and autoupdate the charts..
Attached Image (click to enlarge)
Click to Enlarge Name: 2010-08-16_1224.png Size: 27 KB
  • #103
  • Aug 16, 2010 12:16pm Aug 16, 2010 12:16pm
Hey Steve,

I wish I had something I could mention right now that would make everybody step back and say "OMG!!!" But the reality is that I am just subscribing to the thread.

As always thanks for your hard work. Ill take a look at things to see if I can lend a hand.
  • #104
  • Aug 16, 2010 12:54pm Aug 16, 2010 12:54pm
Quoting rfking2
Hey Steve,

I wish I had something I could mention right now that would make everybody step back and say "OMG!!!" But the reality is that I am just subscribing to the thread.

As always thanks for your hard work. Ill take a look at things to see if I can lend a hand.
Great to see you here.

  • #105
  • Aug 16, 2010 7:11pm Aug 16, 2010 7:11pm
Quoting SteveHopwood
Fantastic Simon. Thanks. I have put this into post 1 so everybody gets the latest.

Do me a favour will you, when you have time? Cast your eyes over the attached and see if you can work out why it does not perform as I want.
.....

I have to go out to teach soon, and will be out for the rest of today.
Can you see why step 3 is not happening?

Hi Steve, I shall have a look. I assume in step three a new trade is entered in the original direction with the magic number incremented by 20 or 40 depending on the recovery level.

cheers
Simon
  • #106
  • Aug 16, 2010 7:25pm Aug 16, 2010 7:25pm
Quoting f451
Hi Steve, I shall have a look. I assume in step three a new trade is entered in the original direction with the magic number incremented by 20 or 40 depending on the recovery level.

cheers
Simon
Yes. Sorry I didn't make this clear.

I am just waiting for a backtest to finish before responding to this post at http://www.forexfactory.com/showpost...14&postcount=3 This contributor appears to have spotted something.

  • #107
  • Aug 16, 2010 7:35pm Aug 16, 2010 7:35pm
Ok, the backtest has finished. I am not sure this tvvliet4x has completely solved the problem, but he/she has come closer to doing so than I have in 2 days. The backtest concluded in profit and Recovery trades appear to be opening and closing.

Fantastic contribution tvvliet4. Thank. Many, many thanks. I have recorded my appreciation.

  • #108
  • Aug 16, 2010 7:41pm Aug 16, 2010 7:41pm
Here is the updated version wih tvvliet4's fix.

'Tis a simple fix, but I couldn't spot it.

In the absence of objections, I will put this in post one tomorrow.

Attached File(s)
File Type: mq4 Nanningbob V5 auto-trader with Recovery by Steve and Simon.mq4   70 KB | 528 downloads
  • #109
  • Edited 9:09pm Aug 16, 2010 8:53pm | Edited 9:09pm
Quoting f451
Hi Steve, I shall have a look. I assume in step three a new trade is entered in the original direction with the magic number incremented by 20 or 40 depending on the recovery level.

cheers
Simon
Steve from a quick glance at the code, I think you've got everything in there working OK except you've err, missed the bit where a new order is sent.
Basically there's no code in the recovery module to open the recovery trade.

I've made some mods to RecoveryModule() and converted Buy() and Sell() to return bool result based on a successful order entry so we can correctly set RecoveryInProgress.

EDIT: I just noticed That a fix has already been uploaded, and it's obviously different to what I have coded/proposed. Go with that - this fix will just open and order when you get recovery pips in into drawdown - the other fix may be waiting for an appropriate re-entry point, therefore better.

cheers
Simon
Attached File(s)
File Type: mq4 Nanningbob V5 auto-trader with Recovery by Steve and Simon.mq4   71 KB | 420 downloads
  • #110
  • Aug 16, 2010 9:01pm Aug 16, 2010 9:01pm
Steve,

Given tvvliet4 fix appears to have worked... your master plan for recovery trades was more subtle than I realised!

There is a bug in the SetTargets code in this version tho. I'll post a fix in a second.

cheers
Simon
  • #111
  • Aug 16, 2010 9:07pm Aug 16, 2010 9:07pm
here tis
Attached File(s)
File Type: mq4 Nanningbob V5 auto-trader with Recovery by Steve and Simon.mq4   70 KB | 523 downloads
  • #112
  • Aug 16, 2010 9:11pm Aug 16, 2010 9:11pm
Neatly done F451!!
  • #113
  • Aug 16, 2010 10:59pm Aug 16, 2010 10:59pm
Guys

I have been having some very good results today. I have been spending some time playing around with the settings, this seems to be most stable, and keeps the DD very small.

I am using ADX as the trend on the 60min time frame all other settings are the same (for me Criminal ECN = True).

See Attached.

I am also currently testing using Divergence on H1 as possible trigger also...but that is some days away.
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 2010-08-16_2352.png Size: 55 KB
Click to Enlarge Name: 2010-08-16_2353.png Size: 54 KB
  • #114
  • Aug 16, 2010 11:36pm Aug 16, 2010 11:36pm
Quoting Tread
Guys

I have been having some very good results today. I have been spending some time playing around with the settings, this seems to be most stable, and keeps the DD very small.

I am using ADX as the trend on the 60min time frame all other settings are the same (for me Criminal ECN = True).

See Attached.

I am also currently testing using Divergence on H1 as possible trigger also...but that is some days away.
Tread

I have been thinking about including ADX as a filter for the with trend and then reversal version I'm developing of the Nanningbob v5 EA. From my manual trading I'm seeing a number of situations where NB's system suggests a reversal but in fact it's a trend, and so the trade is initially entered in the wrong direction, creating the drawdowns that need to be managed with the 2 4 2 recovery system. I'm trying to convert these "runners" to positive pips rather than draw down (then theoretically it will be possible to trade with larger lot sizes). Manually I'm using higher timeframe price action (such as pinbars, outside bars, double bar low higher close or double bar high, lower close) to confirm if a potential NB setup is a valid reversal entry, or if instead I should buy with the current "trend".

I was going to use ADX on 4HR/1D timeframe - but how is it going as filter on 1HR? Also, have you considered trading with ADX where you are currently using it as a filter?

The other option I'm exploring is entering the reversal when the white stochastic (7,3,3) crosses back above the oversold or back below the overbought level. This seems to filter out early reversals pretty well.

I'm probably still a week away from presenting the trend and reverse EA. But it is coming.

Macman,

I'm hoping you might employ your extensive forward and backtesting skills to give us a solid comparision between this and the NanningBob v5 EA.

regards
f451 (Simon)
  • #115
  • Edited 12:13am Aug 17, 2010 12:01am | Edited 12:13am
Hi Simon

I think I took the opposite route to you, I gave up the possible pips that could be made with going with the trend and just sat back and waited for ADX on H1 to Flip in my direction for the reversal to kick in. My thinking was at least for time period (after it flips) I could be fairly sure of entering into the money in a reasonable time.

Being even more of a tight wad i tend to drill to m5 to time even further, on the manual trades I sometimes add to the position, so the DD can get high if not managed properly.

Manually when trading this system, I use the H4 for Signal, but lower TF's for filtering of the trades, I did try the stochastic on the lower TF (h1), but i was more comfortable in reading the ADX.

There is a lot of room to play with here, is the waiting for the reversal on the H4 a countertrend? If so then we should probably go into the direction of the initial buy.

I am looking forward to your mod. based on what you said it would buy/sell in one direction (confirmed on higher TF) and then Sell/buy (use the Lower TF) to trigger the lower entry
  • #116
  • Aug 17, 2010 12:35am Aug 17, 2010 12:35am
Hi Simon,

Really appreciate the updates and bug fixes that you've been providing. Quick question though regarding the TP function via BB that you added. I'm using the BB as TP with minimumpips = 50 like the default. In the attached picture, shouldn't this trade have closed then since the trade has moved 50 pips and the price has crossed? Or am I not understanding how it should work. I have attached my settings too.

http://i148.photobucket.com/albums/s...g?t=1282023098
Attached File(s)
File Type: txt nanning.txt   2 KB | 326 downloads
  • #117
  • Edited 1:59am Aug 17, 2010 1:31am | Edited 1:59am
Quoting obnoxious2
Hi Simon,

Really appreciate the updates and bug fixes that you've been providing. Quick question though regarding the TP function via BB that you added. I'm using the BB as TP with minimumpips = 50 like the default. In the attached picture, shouldn't this trade have closed then since the trade has moved 50 pips and the price has crossed? Or am I not understanding how it should work. I have attached my settings too.

http://i148.photobucket.com/albums/s...g?t=1282023098
You are right. It should have closed - but the order was entered without a take profit figure (see the T/P column is blank? that shows your take profit on the order). This means there's a bug in the target setting code.

Did you download the very latest version I uploaded (with Recovery)? Because I have fixed a bug recently that would have caused exactly what you are seeing here.

cheers
f451
  • #118
  • Aug 17, 2010 3:46am Aug 17, 2010 3:46am
See Pic of the ADX Comparison
Attached Image (click to enlarge)
Click to Enlarge Name: 2010-08-17_0431.png Size: 63 KB
  • #119
  • Aug 17, 2010 3:54am Aug 17, 2010 3:54am
Currently running a backtest using the latest version with recovery. Once the backtest suffers a loss the 242 system kicks in however, unless I have misunderstood it (which could be likely) it does seem to then return to original lot size. I have attached a graph to illustrate.

Paul
Attached Image (click to enlarge)
Click to Enlarge Name: TesterGraphEU.gif Size: 6 KB
  • #120
  • Aug 17, 2010 4:09am Aug 17, 2010 4:09am
Quoting paulbt38
Currently running a backtest using the latest version with recovery. Once the backtest suffers a loss the 242 system kicks in however, unless I have misunderstood it (which could be likely) it does seem to then return to original lot size. I have attached a graph to illustrate.

Paul
Thanks Paul. There is a line of code that resets the lot size when the position has closed at BE. I knew it needed adding - I just forgot, so thanks for bringing this up.

The latest version incorporating this bugfix and the one a few posts ago from Simon, is in post 1. I have updated the user guide.

I have also made the automated 2.4.2 recovery an option that users can turn off.

0 traders viewing now