Code my system please: EUR-USD 2010 61 wins 2 losses 97% | Page 9 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Please help code a simple pending grid system 5 replies

Please code this proven system (alien's system v2) 10 replies

38 consecutive wins, 0 losses = win? 30 replies

Code my system into an EA please! 0 replies

most common reasons for wins or losses 17 replies

Attachments: Code my system please: EUR-USD 2010 61 wins 2 losses 97%
Exit Attachments

Code my system please: EUR-USD 2010 61 wins 2 losses 97%

  • #161
  • Aug 6, 2010 7:23am Aug 6, 2010 7:23am
So far so good, 5 wins all different pairs. Hope it does the same for at least 1 month. Thanks rhinocomp13
Today I BUY, tomorrow I SELL!
  • #162
  • Aug 6, 2010 7:48am Aug 6, 2010 7:48am
I'm backtesting it, and I think I can come up with a solution on how we can limit the losses. 90% of them were because the trade was open for a few days. We can set up a time limit for each order. Let's say 24 hours. If is not closed and it's in lose, we shut it down. I will look further into this. Any opinions?
Today I BUY, tomorrow I SELL!
  • #163
  • Aug 6, 2010 7:54am Aug 6, 2010 7:54am
Quoting ecntrader
I'm backtesting it, and I think I can come up with a solution on how we can limit the losses. 90% of them were because the trade was open for a few days. We can set up a time limit for each order. Let's say 24 hours. If is not closed and it's in lose, we shut it down. I will look further into this. Any opinions?
I've always liked time stops. A statistical study of trade length versus winning and losing trades could be very enlightening.

Theoretically you'd almost never hit the PSAR stop.
You are in a maze of twisty little passages, all alike.
  • #164
  • Aug 6, 2010 12:04pm Aug 6, 2010 12:04pm
Quoting ecntrader
I'm backtesting it, and I think I can come up with a solution on how we can limit the losses. 90% of them were because the trade was open for a few days. We can set up a time limit for each order. Let's say 24 hours. If is not closed and it's in lose, we shut it down. I will look further into this. Any opinions?
If someone can code this I could backtest it. I have 99% modelling quality on EURUSD from 2007-2010.
  • #165
  • Aug 6, 2010 12:10pm Aug 6, 2010 12:10pm
The answer is here: http://www.forexfactory.com/showthread.php?t=50669 . But I don't know MQL so I can't help..
Today I BUY, tomorrow I SELL!
  • #166
  • Aug 6, 2010 12:12pm Aug 6, 2010 12:12pm
If asasa doesn't beat me to it, I'll try to incorporate this over the weekend. It looks straightforward.
You are in a maze of twisty little passages, all alike.
  • #167
  • Aug 6, 2010 1:44pm Aug 6, 2010 1:44pm
Quoting stevegee58
If asasa doesn't beat me to it, I'll try to incorporate this over the weekend. It looks straightforward.

Sounds good, much appreciate your work!

Cheers
  • #168
  • Aug 7, 2010 11:01am Aug 7, 2010 11:01am
I did it in a few minutes. I modified the code from that thread. It only work with hours. It's promising by the way. Tested it a little bit and with good results !
Attached File(s)
File Type: mq4 Fisher-PSAR EA_ecntrader.mq4   9 KB | 280 downloads
Today I BUY, tomorrow I SELL!
  • #169
  • Aug 7, 2010 11:53am Aug 7, 2010 11:53am
Quoting ecntrader
I did it in a few minutes. I modified the code from that thread. It only work with hours. It's promising by the way. Tested it a little bit and with good results !
Hah, that's what I get for trying to fix my chainsaw instead of coding!
You are in a maze of twisty little passages, all alike.
  • #170
  • Edited 11:19pm Aug 7, 2010 11:00pm | Edited 11:19pm
Okay, it turns out Metatrader has a stupid filesize limit bug so I had to split up the tests by year (tick data = huge).

Here are the results using ecntrader's EA from post #168. It was backtested from 2007-2010 with 99% backtesting quality and 0 mismatched bar errors.
Attached File(s)
File Type: zip StrateyTester.zip   56 KB | 385 downloads
  • #171
  • Aug 8, 2010 9:45pm Aug 8, 2010 9:45pm
Quoting ecntrader
I did it in a few minutes. I modified the code from that thread. It only work with hours. It's promising by the way. Tested it a little bit and with good results !

I'm not going to change the settings an place on H4 and see if this one does anything.
  • #172
  • Aug 9, 2010 1:13am Aug 9, 2010 1:13am
Plenty of wins with minimal loss, but loses are way too big. Single loss wiped all the gains.
  • #173
  • Aug 9, 2010 11:08am Aug 9, 2010 11:08am
Quoting tommbstone
I'm not going to change the settings an place on H4 and see if this one does anything.
If it did nothing with the previous version, this one won't do anything too, because I just added a small code that will close the order after a specified number of hours.

That option should be set in accordance with the take profit. The longer the take profit is, the longer the order is opened.

Anyone found how to eliminate the losses much better, without increasing the lots after loss?
Today I BUY, tomorrow I SELL!
  • #174
  • Aug 9, 2010 11:12pm Aug 9, 2010 11:12pm
I think it's been me thats done it wrong.


I put on EURGBP by mistake... The spread was to big for the fisher-psar ea_ecntrader to do anything.

so I moved it to gbpusd 4h and did not change any of the settings to see if its working or not. and so far no trades still.

Any ideas?


Quoting ecntrader
If it did nothing with the previous version, this one won't do anything too, because I just added a small code that will close the order after a specified number of hours.

That option should be set in accordance with the take profit. The longer the take profit is, the longer the order is opened.

Anyone found how to eliminate the losses much better, without increasing the lots after loss?
  • #175
  • Aug 10, 2010 3:11am Aug 10, 2010 3:11am
Quoting ecntrader
I'm backtesting it, and I think I can come up with a solution on how we can limit the losses. 90% of them were because the trade was open for a few days. We can set up a time limit for each order. Let's say 24 hours. If is not closed and it's in lose, we shut it down. I will look further into this. Any opinions?
I too implemented this "timeout" option in my EA (I can post it if you want, but I think the EA of stevegee58 already does it).
My feeling is that there is no way to easily get this system to be profitable on the long run.
As long as you cut your losses with this timeout option, you dramatically decrease the win percentage, leading to a negative expectancy as before.
  • #176
  • Aug 10, 2010 3:28am Aug 10, 2010 3:28am
Quoting asasa
I too implemented this "timeout" option in my EA (I can post it if you want, but I think the EA of stevegee58 already does it).
My feeling is that there is no way to easily get this system to be profitable on the long run.
As long as you cut your losses with this timeout option, you dramatically decrease the win percentage, leading to a negative expectancy as before.
That was my exact observation in backtesting. When you set a time limit on trades, you do cut off many of the losers but you also cut off some winners. The affects the win rate enough to overwhelm the reward:risk change.

Always calculate expectancy since this takes both win rate and reward:risk into account for overall profitability.
You are in a maze of twisty little passages, all alike.
  • #177
  • Aug 11, 2010 12:55am Aug 11, 2010 12:55am
Quoting stevegee58
That was my exact observation in backtesting. When you set a time limit on trades, you do cut off many of the losers but you also cut off some winners. The affects the win rate enough to overwhelm the reward:risk change.
Always calculate expectancy since this takes both win rate and reward:risk into account for overall profitability.
Here is a backtest with 99% quality for the period 10/2008-06/2010
Attached Image (click to enlarge)
Click to Enlarge Name: Fisherpsar.gif Size: 10 KB
  • #178
  • Aug 11, 2010 2:08am Aug 11, 2010 2:08am
I've got a trade context is busy error. I'll try to fix it in a few hours. The answer is here - http://articles.mql4.com/141
Today I BUY, tomorrow I SELL!
  • #179
  • Aug 11, 2010 6:06am Aug 11, 2010 6:06am
I have attached the version that will fix that issue posted on my earlier post. Hope it's done right.
Attached File(s)
File Type: mq4 Fisher-PSAR EA_ecntrader.mq4   12 KB | 252 downloads
Today I BUY, tomorrow I SELL!
  • #180
  • Aug 11, 2010 10:05am Aug 11, 2010 10:05am
I still get trade context is busy...any help on the code?
Today I BUY, tomorrow I SELL!
0 traders viewing now