Simple pinbar EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

The Stock/ETF/Commodity Pinbar Thread 122 replies

Pinbar indicator 6 replies

Pinbar and S/R scanner 6 replies

got to do with a hanging man and a pinbar 1 reply

J16 pinbar discussion 7 replies

Attachments: Simple pinbar EA
Exit Attachments

Simple pinbar EA

  • #1
  • First Post: Edited 11:31am Jul 20, 2010 11:20am | Edited 11:31am
I am trying to create a simple EA that recognizes pinbars. I would like the EA to check every currency pair while only attached to one chart but it doesn't check the specified currency. If I write null instead of "EURUSD" and attaches it to a EURUSD chart it works. What have I done wrong?

Here is the code.
Quote
if (iClose("EURUSD",PERIOD_MN1,1) - iOpen("EURUSD",PERIOD_MN1,1) > 0.0001 && iClose("EURUSD",PERIOD_MN1,1) - iOpen("EURUSD",PERIOD_MN1,1) < (iOpen("EURUSD",PERIOD_MN1,1) - iLow("EURUSD",PERIOD_MN1,1))/2)
{
Alert("Pin bar");
}
If slaughterhouses had glass walls, everyone would be a vegetarian!
  • #2
  • Jul 20, 2010 12:04pm Jul 20, 2010 12:04pm
Do you have a Broker that calls their Paris EURUSDm or EURUSDcx or something like that?
  • #3
  • Jul 20, 2010 12:14pm Jul 20, 2010 12:14pm
Quoting TJPLD
Do you have a Broker that calls their Paris EURUSDm or EURUSDcx or something like that?
I don't know. I use liteforex. In the market watch window nothing is written after the name of the currency pair.

Edit: I have previously made an EA that checks many different currency pairs and it worked in lite forex. I just don't remember how I did it.
If slaughterhouses had glass walls, everyone would be a vegetarian!
  • #4
  • Jul 20, 2010 12:30pm Jul 20, 2010 12:30pm
Quoting Gambler180
I would like the EA to check every currency pair while only attached to one chart Here is the code.

hey gambler.... little more to it than that, as you have discovered....

the best way is to create a symbol list and then cycle thru it checking each pair.... for(int i=0;i<14;i++)

you must use the market info string..... look here for example.....

//---
in your case , better still would be to encapsulate the entire code in a single function and save the results in a multidemsional array.....

somewhere buried in my attachments should be the entire ea along with dashboard indicator for pinbars and other such formations...... wrote it long ago for someone one the james thread.....h
to trade and code, keep both simple... no call to impress....h
  • #5
  • Jul 20, 2010 2:17pm Jul 20, 2010 2:17pm
Quoting hayseed
hey gambler.... little more to it than that, as you have discovered....

the best way is to create a symbol list and then cycle thru it checking each pair.... for(int i=0;i<14;i++)

you must use the market info string..... look here for example.....

//---
in your case , better still would be to encapsulate the entire code in a single function and save the results in a multidemsional array.....

somewhere buried in my attachments...
I don't know how to create an array but I have found a solution by looking at another indicator i made last year. The attached indicator checks 32 charts for pinbars. 8 currencies on 4 timeframes. As you can see there is a lot of repititive code. I would like to make it shorter but I'm not good at creating functions.
Attached File(s)
File Type: mq4 pin bars.mq4   10 KB | 1,365 downloads
If slaughterhouses had glass walls, everyone would be a vegetarian!
  • #6
  • Jul 20, 2010 2:51pm Jul 20, 2010 2:51pm
How would the code look like if I make it shorter instead of writing 4 if commands for each currency pair(one if command for each time frame)?
If slaughterhouses had glass walls, everyone would be a vegetarian!
  • #7
  • Jul 20, 2010 10:38pm Jul 20, 2010 10:38pm
I found a smart way to do it.
Attached File(s)
File Type: mq4 1pinbar.mq4   2 KB | 1,933 downloads
If slaughterhouses had glass walls, everyone would be a vegetarian!
  • #8
  • Last Post: Apr 18, 2018 10:30am Apr 18, 2018 10:30am
this pinbar is not working it seems,im looking for multitimeframe pinbar,lets say 4 hour pinbar appeared on 1 hour chart,please if someone has got it,please share,thanks!
0 traders viewing now