Indicators development for T101's not very simple method | Page 114 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

SIMPLE EA for a simple method needed!! 2 replies

Simple System By T101 - My Thought 18 replies

Continuation of T101 method discussions 24 replies

My first attempt at T101's basket method... 2 replies

Attachments: Indicators development for T101's not very simple method
Exit Attachments

Indicators development for T101's not very simple method

  • #2,261
  • Jun 8, 2010 9:38pm Jun 8, 2010 9:38pm
Hello Mr. Pip.

Like everyone else, I appreciate you helping out. Could I ask you to make one slight change. Can you add a user input option to use either the trendmagic indicator or the supertrend indicator in this post http://www.forexfactory.com/showpost.php?p=3747621
The reason I ask is the trendmagic indicator repaints and the supertrend indicator does not.

Regards,
Jeff

Quoting MrPip
Good bug catch on order closing loop.
It should be i >= 0 in two spots, when calculating number of open orders and when closing orders. That is why there were 2 trades left open.

Test this version.

I also modified to close trades from 0 to OrdersTotal by always closing trade 0. Hope that fixes the issue of closing first order through last order as required by new rules.

Don,

I prefer not to use global variables for keeping track of open orders because of possible bugs when updating the global.

Robert
  • #2,262
  • Jun 8, 2010 10:43pm Jun 8, 2010 10:43pm
azjeff,

Have you seen it repaint on M15, H1, or H4? If not, then TrendMagic can be used for this EA.

Robert, if you do intend on adding it, I made indicators before I made the EA, and on the last version of the indicator (pre-EA):
http://www.forexfactory.com/showpost.php?p=3758804

... you can pick up the code to make these changes easier in the EA. I just took the user input out and decided to use only TrendMagic since Kos uses it, and unless on like M1 timeframe, I didn't see different values on TM and ST. I guess it should be there for those that want to use ST and not TM, but I sincerely didn't see TM repaint on the charts Kos stated he used that I can remember, and they always gave the exact same values from what I saw. It should be easy to find the relevant code by doing a search for the boolean UseTrendMagic and UseSuperTrend throughout the indicator.

Regards,

Don


Quoting azjeff
Hello Mr. Pip.

Like everyone else, I appreciate you helping out. Could I ask you to make one slight change. Can you add a user input option to use either the trendmagic indicator or the supertrend indicator in this post http://www.forexfactory.com/showpost.php?p=3747621
The reason I ask is the trendmagic indicator repaints and the supertrend indicator does not.

Regards,
Jeff
  • #2,263
  • Jun 8, 2010 10:58pm Jun 8, 2010 10:58pm
Quoting MrPip
Good bug catch on order closing loop.
It should be i >= 0 in two spots, when calculating number of open orders and when closing orders. That is why there were 2 trades left open.
Thank you.

Quote
I also modified to close trades from 0 to OrdersTotal by always closing trade 0. Hope that fixes the issue of closing first order through last order as required by new rules.

Robert, I guess I'm confused. Would the first order be 0? or the most recent order always be 0? Didn't you say you were using i-- instead of i++ since trade 0 would be closed and then trade 1 would become 0, would be skipped, and then trade 1 (old trade 2) would get closed?


Quote
Don,

I prefer not to use global variables for keeping track of open orders because of possible bugs when updating the global.

Robert

Robert,

I think I understand. This is one area where separate variables would be needed. If that's the case, then TotalOrders should be used one place and OpenOrders another, and they both need to refer to magicnumber (so you wouldn't have a global variable TotalOrders AND a local variable TotalOrders, which to me seems like it would cause trouble). I haven't had a chance to look at the latest revision, but will do that tomorrow and test it then.

Regards,

Don
  • #2,264
  • Jun 8, 2010 11:36pm Jun 8, 2010 11:36pm
Anyone use MrPip's EA that open any trades so far?

Robert, your b and c version both have been quiet, it gives alert for "buyall" or "sellall", but not open positions.

Edited: I guess that without other EAs, your EA will open positions without a problem

i check your code here:
__________________________________

void T101_BuyAll() {

int myTotalOrders;
myTotalOrders = OrdersTotal();

if(myTotalOrders > 0) {
Buys=0;
Sells=0;
for(int cnt=0;cnt<myTotalOrders;cnt++) {
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderMagicNumber() == Magicnumber) {
if(OrderType()==OP_BUY) Buys=Buys+1;
else if(OrderType()==OP_SELL) Sells=Sells+1;
}
}
if(Sells > Buys) T101_CloseAll();
} else if(myTotalOrders == 0)
{
// orders are then opened here.............but the logic cannot reach here.....
}

__________________________________

i am wondering if this is problematic:
because of the 3rd row ------ myTotalOrders = OrdersTotal();
if i have some other EA's position opened, then myTotalOrders will be > 0.
therefore, in the following "if-else" decision, those OrderSend() commands CANNOT be reached, can they? as a result, no positions to be opened....

i'm sort of confused right now, if i'm murmuring something dumb, please forgive me.
  • #2,265
  • Edited 12:45am Jun 9, 2010 12:16am | Edited 12:45am
My version c seems to be trading just fine, and the basket no longer having the issue of not closing all the trades.
Now I just need to get it profitable lol

Edit:
spoke too soon, sorry this new version is not resetting the profitlock variable now. Which is causing it to instantly reopen all trades, close them all (cause it thinks it's made the profitlock again, and instantly close them all again. So still some more bug squashing required.
  • #2,266
  • Jun 9, 2010 12:32am Jun 9, 2010 12:32am
Quoting azjeff
Hello Mr. Pip.

Like everyone else, I appreciate you helping out. Could I ask you to make one slight change. Can you add a user input option to use either the trendmagic indicator or the supertrend indicator in this post http://www.forexfactory.com/showpost.php?p=3747621
The reason I ask is the trendmagic indicator repaints and the supertrend indicator does not.

Regards,
Jeff
Hi Azjeff!

the way we use TrendMagic here has nothing to do with repainting, look at my postings very well I never mentioned anything about colour. I can as well change the RED to BLUE so that we have it all BLUE, and it would still be as effective as it has been.

I have seen threads where mere mention of "repainting" mare all the effort people are putting forward and derailed the good idea some is putting forward.

The focus right now is to get the EA on a sure footing, and thank God the coders are taking it up

kos
John 3:16 - From THIS love no power on earth can me sever.
  • #2,267
  • Jun 9, 2010 3:44am Jun 9, 2010 3:44am
Goodmorning all.

let me give you my results of using version B. didnt saw version C because was sleeping.

as mentioned before version B on this thread, it does not close the 2 opposites.

however did someone already test if version B or C does do another sell or buy when 1 trade is finnished.

since i did not see a test result of that yet here. i will keep version B on. just to see when all conditions are met it will open up another buy or sell.

also i think a good idea is. that whatever we test now we give in what kind of settings we have used and on which timeframe.

on version B i have used timeframe 1 hour and i used the standard settings.
  • #2,268
  • Jun 9, 2010 4:59am Jun 9, 2010 4:59am
Quoting tazmaan
My version c seems to be trading just fine, and the basket no longer having the issue of not closing all the trades.
Now I just need to get it profitable lol

Edit:
spoke too soon, sorry this new version is not resetting the profitlock variable now. Which is causing it to instantly reopen all trades, close them all (cause it thinks it's made the profitlock again, and instantly close them all again. So still some more bug squashing required.

I think I found the bug for resetting profit lock.
Added reset function call at end of code for close all.

Also added SuperTrend option and fixed the looping problem mentioned when other EAs have open trades.

Combined GetOrdersTotal with CheckTradeType function.

For some reason I cannot test because the BI_T101_OTR_V1_5.ex4 does not work on my build for some reason.

If someone would contact the author and have him send me the source code privately I would appreciate it. This would allow me to test my changes to the EA before releasing as well as make some money with it when it proves to work correctly.

I promise not to share the source code anywhere.

Robert
Attached File(s)
File Type: mq4 T101_EA_byDon_JustKos_06-09-10.mq4   36 KB | 558 downloads
  • #2,269
  • Jun 9, 2010 5:49am Jun 9, 2010 5:49am
Hello guys!
Can you please explain why I have 0 values in Condition 1 and Condition 3 sections?
Are any other indicators attached needed?
Attached Image (click to enlarge)
Click to Enlarge Name: 11.jpg Size: 142 KB
  • #2,270
  • Edited 6:28am Jun 9, 2010 6:27am | Edited 6:28am
Hi Robert,
Thanks for the great new code.
I'm testing now on H1 and it seems to be running fine.
Trades are open - just not in profit yet.
What build of metatrader are you using? I'm using v4 build 226 and BI_T101_OTR_V1_5 runs fine. Also are you using "UseIBFXPairs == False"? If so this could be a problem since I don't think BI_T101_OTR_V1_5 supports either CADJPY or USDCAD. Also I don't think it supports symbol suffixes in case you have these.

Hi Mathers,
It looks like you're having trouble with both the "Trend Magic" and "BI_T101_OTR_V1_5" indicators. Did these load successfully when put the EA on the chart. Check the "Journal" tab for error messages.

Regards, Aristarchus
  • #2,271
  • Jun 9, 2010 6:34am Jun 9, 2010 6:34am
it also opened up for me and it is hoovering between the +40 pips and the +60pips at the moment.

also i have it on the 1 hour graphic.
  • #2,272
  • Jun 9, 2010 6:51am Jun 9, 2010 6:51am
Quoting Aristarchus
Hi Mathers,
It looks like you're having trouble with both the "Trend Magic" and "BI_T101_OTR_V1_5" indicators. Did these load successfully when put the EA on the chart. Check the "Journal" tab for error messages.

Regards, Aristarchus
Thank you. BI_T101_OTR_V1_5 is now Ok. But if I place Kos_TrendMagic_EAPrep_indi_Don_v1.3.mq4 to Indicator folder, build, rename to "Trend Magic.ex4", I got MT crash with critical error on EA start. (I also use build 226)
  • #2,273
  • Jun 9, 2010 7:34am Jun 9, 2010 7:34am
Hi, Robert:

I just sent PM and email to OnTheRoad, but he/she hasn't shown up on FF recently, not sure when/what the reply will be.

Also, there is another solution:

Don has provided us an indicator that is (at least approximating) BI_t101_otr v15. Don's indicator appears to me are identical on chart to BI(i'm not sure since i can't read BI's code too.)

Try this, it is very easy to call, showing my calling below:
BuyAll_instant = iCustom(LeadingPair+pair_suffix, buyallTF, "T101_BuyAllPairs",normalpairs,pair_suffix,0,10000,20,BuyAllfMA,1,BuyAllsMA,1,0,0);
BuyAll_fast = iCustom(LeadingPair+pair_suffix, buyallTF, "T101_BuyAllPairs",normalpairs,pair_suffix,0,10000,20,BuyAllfMA,1,BuyAllsMA,1,1,0);
BuyAll_slow = iCustom(LeadingPair+pair_suffix, buyallTF, "T101_BuyAllPairs",normalpairs,pair_suffix,0,10000,20,BuyAllfMA,1,BuyAllsMA,1,2,0);

you only need BuyAll_fast and BuyAll_slow, hope this can be a temporal solution if you want to run it on your pc.

note that i feel that Don's indic is more resource-consuming(maybe you can look into why). However, calling it from an EA has not really crashed my PC so far.

Quoting MrPip

For some reason I cannot test because the BI_T101_OTR_V1_5.ex4 does not work on my build for some reason.

If someone would contact the author and have him send me the source code privately I would appreciate it.

I promise not to share the source code anywhere.
Attached File(s)
File Type: mq4 T101_BuyAllPairs.mq4   6 KB | 539 downloads
  • #2,274
  • Jun 9, 2010 7:34am Jun 9, 2010 7:34am
ok using the latest version of MR pips.

i changed 1 setting from true to false. that is using the DonsMM to false. the reason is my CGI demo account does not allow 0.87 etc. it only allows 0.10 and 020 etc.

the result is that it started a trade with buys all open and closed the tradingbasket at +50 pips.

it resetted the tradingbasket as it would hopefully do.

then 3 minutes later it started a new trade with buys all open. it closed that again with +50 pips.

it reset the tradingbasket again.

2 minutes later it started again all buys.

is this alright? that it checks if signal still open and opens up again all buys?
  • #2,275
  • Jun 9, 2010 8:07am Jun 9, 2010 8:07am
Hi Friends,

Phew . lots of updates and I just downloaded and started using the latest version of MR pips.

Changed DonsMM to false as I can trade only in 0.10 lots or more.

It opened orders automatically unlike other versions.

Currently pips locked at +50 and total pips @ +110

Now locked 50 pips and closed in my demo acct

It again opened Buy trade and now @ -70 pips.

Cheers
The One Who Makes The Thunder Roar Also Hears A Butterfly Sigh - Ruzbeh
  • #2,276
  • Jun 9, 2010 8:34am Jun 9, 2010 8:34am
I've locked $50 this morning and still rising, so that's over $600 locked with various versions of this EA so far this week.

Also, OnTheRoad is the author of the BI indicator. I sent MrPip a PM so hopefully the two of them can work something out. Thanks to MrPip for reviewing the code, thanks to disbellj for authoring it, and of course thanks to Kos for the rule set!
  • #2,277
  • Jun 9, 2010 8:37am Jun 9, 2010 8:37am
Here men,

version by mrpips that ends with "c"

it seems we are making headway with this EA. I have tested the opening and closing of trades on 15min TF, and for me it worked well.

the trade I show now is on 1HR TF and the EA ending with c, by mrpips. It took this trade beautifully, and as each condition is fulfilled it takes note of them and as soon as the last one lined up, it fired a buy very fast. Its on now +700 pips.

its DAILY samir on 1HR TF all settings default

I will keep monitoring it and update us back

kos
Attached Image(s) (click to enlarge)
Click to Enlarge Name: 700.gif Size: 36 KB
Click to Enlarge Name: don seee.gif Size: 20 KB
John 3:16 - From THIS love no power on earth can me sever.
  • #2,278
  • Jun 9, 2010 8:45am Jun 9, 2010 8:45am
Mathers,

If you don't know what you're doing, please ask first I guess, rather than do what you did.

Kos_TrendMagic_EAPrep_indi_Don_v1.3.mq4 is an indicator I made, and as it says in it's name, is (was) a Prep for the EA. It is not Trend Magic.ex4 indicator.

You changed the name and the extension. Why would you do that? Now you and anyone that gets a hold of it will think it's Trend Magic.ex4, when it's not Trend Magic and not and .ex4. Please throw it in your trash and empty your trash.

If you look on google, you'll find Trend Magic. No need to just pick up any old indicator and name it thinking that it'll "magically" change the source code to be another indicator's source code.

Regards,

Don


Quoting Mathers
Thank you. BI_T101_OTR_V1_5 is now Ok. But if I place Kos_TrendMagic_EAPrep_indi_Don_v1.3.mq4 to Indicator folder, build, rename to "Trend Magic.ex4", I got MT crash with critical error on EA start. (I also use build 226)
  • #2,279
  • Jun 9, 2010 8:49am Jun 9, 2010 8:49am
Hi forum,

Charvo asked me for mq4 source of BI indi,

after searching some HDDs and backups , finally I found it,

it is attached here,

Regards

OTR
Attached File(s)
File Type: mq4 BI_T101_OTR_V1_5.mq4   10 KB | 831 downloads
  • #2,280
  • Jun 9, 2010 8:50am Jun 9, 2010 8:50am
Kos,

Just take note of Samir's indicator and how I talked about the wrong bar being used problem. My indicator and EA are correct (especially EA I made sure). Just like real IA trades were put on at beginning of week, or beginning of day, the right bar must be used or the values are not right. That's why comments in the indicators were there, to make sure of the correctness. But my new added code should take care of it "on the fly", and only subtract one bar if MT4 given bar shows open time before day/week open time. If it does, one bar is subtracted and that one is used as startbar. So having said all this, I hope mine and Samir's match up mostly, but I've done enough research to trust my numbers more.

Regards,

Don


Quoting Kosomolate
Here men,

version by mrpips that ends with "c"

it seems we are making headway with this EA. I have tested the opening and closing of trades on 15min TF, and for me it worked well.

the trade I show now is on 1HR TF and the EA ending with c, by mrpips. It took this trade beautifully, and as each condition is fulfilled it takes note of them and as soon as the last one lined up, it fired a buy very fast. Its on now +700 pips.

its DAILY samir on 1HR TF all settings default

I will keep monitoring it and update us back

kos
2 traders viewing now