How do I open only 1 buy/sell trade per bar? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

3 Bar Fractal with mid-bar and bar on each side 11 replies

EA to open buy/sell on every bar 0 replies

Looking for code that will open buy/sell according to bar up or down 1 reply

Pin bar, pin bar, pin bar 0 replies

I am looking for EA to put Buy Stops, Buy limits, Sell limits, and Sell Stops. I will 0 replies

How do I open only 1 buy/sell trade per bar?

  • #1
  • First Post: May 29, 2010 4:20am May 29, 2010 4:20am
I would like to allow only one buy or one sell trade PER BAR.

Once a buy trade has been opened and closed on the same bar, no other buy trades should be allowed on that bar. Only sell trades can be allowed.

Once a sell trade has been opened and closed on the same bar, no other sell trades should be allowed on that bar. Only buy trades can be allowed.

What is the simplest paragraph(s) of code required, and where exactly do I place it/them?
  • #2
  • May 29, 2010 3:20pm May 29, 2010 3:20pm
I assume you already have buy and sell flag logic in your code. Just add the following code to the Start() function. What it does is resets the flags to false at the start of every bar. Once a trade is opened, set the appropriate flag to true and test the flag whenever a valid setup is found.

The only complication I see, is what to do if the trade from the previous bar is still open, but that is another topic.

This is the declaration for the logic below.
bool buyFlag = false, sellFlag = false;
datetime barStart = 0;

Put this in your Start() function before your trading logic.
if (barStart < Time[0]) //start of new bar
{
barStart = Time[0];
buyFlag = false;
sellFlag = false;
}
  • #3
  • May 29, 2010 3:37pm May 29, 2010 3:37pm
I added the codes to my code, but apparently they don't seem to work.

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 3.0;
extern int Slippage = 30;
extern bool UseStopLoss = False;
extern int StopLoss = 30;
extern bool UseTakeProfit = False;
extern int TakeProfit = 60;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
int BarCount;
int Current;
bool TickCheck = False;
bool buyFlag = false, sellFlag = false;
datetime barStart = 0;


int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;
if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;
if (barStart < Time[0]) //start of new bar
{
barStart = Time[0];
buyFlag = false;
sellFlag = false;
}
  • #4
  • May 29, 2010 3:42pm May 29, 2010 3:42pm
What do you mean? Was there a compile error? Where is the rest of the code for checking the setup conditions and sending orders?
  • #5
  • May 29, 2010 3:44pm May 29, 2010 3:44pm
The program still opened more than 1 buy/sell trade per bar.

I added the codes as you stated.

What additional codes are there to be added to my order send condition checking codes?
  • #6
  • May 29, 2010 3:51pm May 29, 2010 3:51pm
There isn't any trade opening logic in the code you posted. How can it open trades?
  • #7
  • May 29, 2010 3:55pm May 29, 2010 3:55pm
I am only posting the part of my code where those codes are added.

The rest of my code contains everything else.
  • #8
  • May 29, 2010 4:01pm May 29, 2010 4:01pm
hey mind.... we have to guess so much when only a small part is shown..... that looks like sufix cores code..... not sure....

you'll need to add the flags to the signal section and also reverse them there or at the ordersend section...... roughly, similar to below.....h

Inserted Code
 
//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+
 
if (buyFlag == false  && Buy1_1 < Buy1_2 && Buy2_1 > Buy2_2) Order = SIGNAL_BUY;
 
if (sellFlag == false  && Sell1_1 > Sell1_2 && Sell2_1 < Sell2_2) Order = SIGNAL_SELL;
to trade and code, keep both simple... no call to impress....h
  • #9
  • May 29, 2010 4:09pm May 29, 2010 4:09pm
Thanks. I just added the "buyFlag == false" and "sellFlag == false" codes to my Signal logic, but it still opens more than one buy/sell trade per bar.

And how do I reverse them there or the ordersend section like you mentioned?
  • #10
  • May 29, 2010 4:22pm May 29, 2010 4:22pm
and this would only be a guess without knowing the full code.....h


Inserted Code
 
//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+
 
if (buyFlag == false  && Buy1_1 < Buy1_2 && Buy2_1 > Buy2_2) {Order = SIGNAL_BUY; buyFlag = true;}  
 
if (sellFlag == false  && Sell1_1 > Sell1_2 && Sell2_1 < Sell2_2) {Order = SIGNAL_SELL; sellFlag = true;}
to trade and code, keep both simple... no call to impress....h
  • #11
  • Last Post: May 29, 2010 5:18pm May 29, 2010 5:18pm
Quoting hayseed
and this would only be a guess without knowing the full code.....h


Inserted Code
 
//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+
 
if (buyFlag == false  && Buy1_1 < Buy1_2 && Buy2_1 > Buy2_2) {Order = SIGNAL_BUY; buyFlag = true;}  
 
if (sellFlag == false  && Sell1_1 > Sell1_2 && Sell2_1 < Sell2_2) {Order = SIGNAL_SELL; sellFlag = true;}

Thank you. Adding this seems to work fine.
0 traders viewing now