Modify Script to become an EA | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Could someone please modify this script? 5 replies

Script to modify lot size of pending order 2 replies

Can someone modify this script for me please? 0 replies

Can Someone Please Modify This Script? 7 replies

Is there a Script or EA to modify stops? 3 replies

Modify Script to become an EA

  • #1
  • First Post: Edited 12:45pm May 18, 2010 12:30pm | Edited 12:45pm
Hello Folks.

I'm just experimenting with programming.

I have a script which works if I run it manually. It's placing a pending order on the close of the previous candle.

To get this thing automated I need some modification, but I'm really stuck at this point.

These are the important points (which I can think of so far):

 

  1. How do I tell the EA that it should plece only one (1) pending order of each type before the next candle will open (In case a pending order becomes active and SL/TP is hit)?
  2. If the price is not right (too close to open a pending order), how do I tell the EA to continue trying to open a position until the price is right or the next candle opens (so the values have changed anyways).
  3. How do I calculate the time for the expiration of a pending order? So in case I'm on the M5 I want all pending orders closed just before the new candle opens.
  4. How Do I tell the EA to close all open orders before (or just when) the next candle opens).


And just upfront in case anybody is asking: This it not a strategy. I'm just experimenting with code and would like to see my own EA in the Backtest mode. Results are not important for me at this time, but working with the code is.

Thanks.
MikeFT

Inserted Code
#include <stdlib.mqh>
#include <WinUser32.mqh>


#property show_inputs
#property show_confirm

extern double Lots = 0.10;
extern double takeprofit = 300;
extern double stoploss = 200;
extern datetime expiration =D'31.12.2010';

double PrevClose;



int start()

   {
   PrevClose = iClose(NULL,PERIOD_M5,1);
   


OrderSend(Symbol(),OP_SELLSTOP,Lots,PrevClose,3,PrevClose+stoploss*Point,PrevClose-takeprofit*Point,"Comment",0,expiration,CLR_NONE);
OrderSend(Symbol(),OP_BUYSTOP,Lots,PrevClose,3,PrevClose+stoploss*Point,PrevClose-takeprofit*Point,"Comment",0,expiration,CLR_NONE);
}
  • #2
  • May 18, 2010 12:40pm May 18, 2010 12:40pm
You need to become aquainted with Time[] and date arithmetic. Here are a few code snippets that will help. The first will execute once on the opening of a new bar. The second will do basic date arithmetic to figure out the time of some future bar of interest. I don't think I answered all your questions because I didn't understand some of them. This is a good start and maybe you can figure out the rest.

if (barStart < Time[0]) //start of new bar
{
// put your bar opening logic here
barStart = Time[0];
} // end if barstart


datetime expiryTime = Time[0] + nBars*Period()*60;
  • #3
  • May 18, 2010 2:03pm May 18, 2010 2:03pm
Thanks, CodeMeister.

I have the expiration working. Will continue with the second snipplet you gave me right now.

Also: I edited my first post. I hope my questions are a bit more clear by now.
  • #4
  • Edited 4:27pm May 18, 2010 3:27pm | Edited 4:27pm
Those questions are definitely tougher. I think you need to start thinking differently. You cannot do anything "before the next candle will open". You have to wait until the new candle opens. If you think about it, you will realize why.

From the MQL4 website, this is how to handle pending orders too close to the Bid/Ask. Caveat - not all brokers populate the MarketInfo stuff properly, especially the ones with variable spreads. With them, you have to experiment and use your imagination. At placing of a pending order, the open price cannot be too close to the market. The minimal distance of the pending price from the current market one in points can be obtained using the MarketInfo() function with the MODE_STOPLEVEL parameter. In case of false open price of a pending order, the error 130 (ERR_INVALID_STOPS) will be generated.


Close all orders - caveat - I grabbed this code from 2 places so it might not compile but it gives you the idea. The error checking is basic, you might want to be more comprehensive. The important part is to do a countdown of the orders when closing. In MT4, orders are sequenced from 0 to allOrders-1. If you delete the first one, the second one is no longer numbered 1, rather it is now 0. The other important thing when handling orders is to always normalize prices. This save you lots of grief in the unlikely event that the number isn't.

PHP Code
   int allOrders=OrdersTotal();
   int nOpen = 0;
   for(int pos=allOrders-1;pos>=0;pos--)
   {        
    if ((OrderSymbol() == Symbol() && OrderMagicNumber()==MAGICMT) && (OrderType() == OP_BUY || OrderType() == OP_SELL))
    {

   if(OrderSelect(pos,SELECT_BY_POS,MODE_TRADES)) 
   {
      int ticket = OrderTicket();
 
      if (lotsize == 0) double lots = OrderLots();
      else lots = lotsize;
 
      if (OrderType() == OP_BUY)
      { 
         OrderClose(ticket, lots, NormalizeDouble(Bid,Digits), Slippage, Violet); 
         if (GetLastError() == 0)
         { 
            Print(Symbol(), " Order Closed : ",ticket, " ", OrderClosePrice());
            return (true);
         }   
         else Print(Symbol(), " Order Not Closed : ",ticket, " ", GetLastError());
     }
      if (OrderType() == OP_SELL)
      {
         OrderClose(ticket, lots, NormalizeDouble(Ask,Digits), Slippage, Violet); 
         if (GetLastError() == 0)
         { 
            Print(Symbol(), " Order Closed : ",ticket, " ", OrderClosePrice());
            return (true);
         }   
         else Print(Symbol(), " Order Not Closed : ",ticket, " ", GetLastError());
      }
   }
    }
  • #5
  • May 18, 2010 5:27pm May 18, 2010 5:27pm
Quoting CodeMeister
Inserted Code
      if (barStart < Time[0]) //start of new bar 
      {
// put your bar opening logic here
          barStart = Time[0];
      } // end if barstart
Have this snippet running too. Great info! Am just debugging on the 1M.

I will work trough all the information from your previous post in the next step.

Another issue:
If I place a pending order with a too close expiration time, MT tells me invalid parameters.
Does anybody know what the minimum expiration time is (I guess 10 min) and if there is a function to find that out.
Does it differ from broker to broker?

Thanks.
MikeFT
  • #6
  • May 18, 2010 5:56pm May 18, 2010 5:56pm
I have never tried expiration orders as my broker doesn't allow them. But I try MarketInfo with MODE_EXPIRATION. Again some brokers may not set this field even if they allow expiration orders.

Maybe someone else can jump in and give both of us the benefit of their experience.
  • #7
  • May 19, 2010 2:17pm May 19, 2010 2:17pm
Inserted Code
if (barStart < Time[0]) //start of new bar 
      {
// put your bar opening logic here
          barStart = Time[0];
      } // end if barstart
This code is nice and works, BUT I just relized that it depends on the current timeframe on my chart. So whenever I switch the timeframe, the EA will do things which I don't want it do do?

How can I modify this code that it's always looking for just a specified bar timeframe (e.g. H1).
So no matter if I'm in M1, or maybe W1 - the EA is only paying attention to a new H1 bar.

Any suggestions?
MikeFT
  • #8
  • May 19, 2010 2:43pm May 19, 2010 2:43pm
I think I understand the question. It is easily done with iTime(). It is almost the same thing except using iTime() instead of Time[0]. This allows you to specify another TF and / or another currency pair.
  • #9
  • Last Post: May 20, 2010 5:12am May 20, 2010 5:12am
Quote
iTime()

Perfekt. Sure that works. Thanks.
0 traders viewing now