Can Someone Please Modify This Script? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Could someone please modify this script? 5 replies

can someone please modify this indicator for 5 decimals 0 replies

can someone please modify this indicator for 5 decimals 0 replies

Can someone please modify this indicator? 5 replies

Can someone modify this script for me please? 0 replies

Attachments: Can Someone Please Modify This Script?
Exit Attachments

Can Someone Please Modify This Script?

  • #1
  • First Post: Apr 21, 2009 12:52am Apr 21, 2009 12:52am
Hello,

I have attached a script which offers several useful options. Yet, I find that, in my opinion, it could use two more which are:

  1. Close all when "x" dollars (total) reached (+/-)
  2. Close all when "x" percentage of account reached (+/-)

Could someone please take a look at this and add the necessary code?

Thank you very much,

GF

Attached File(s)
File Type: mq4 CloseAll.mq4   5 KB | 549 downloads
  • #2
  • Apr 21, 2009 6:58am Apr 21, 2009 6:58am
You can sum OrderProfit() for all orders if the same symbol to see if they reached the "x" dollars profit limit.

The same is for percentage. (SumOfAllOrders / AccountBalance()) * 100 = gain/loss in percents
"You are too special to go with the rest." - Rimantas Petrauskas
  • #3
  • Apr 21, 2009 9:22am Apr 21, 2009 9:22am
Quoting wrm
You can sum OrderProfit() for all orders if the same symbol to see if they reached the "x" dollars profit limit.

The same is for percentage. (SumOfAllOrders / AccountBalance()) * 100 = gain/loss in percents

Hi WRM,

Thanks for your input. I know that you have the best of intentions in trying to help. However, when it comes to code, its a bit like Hieroglyphics to me and I don't think they have printed the "MT4 For Dummies" book yet. So, what I really need is for someone to take the code and add the options I referenced and post the finished product for me and all to use.

What is needed is the inclusion of external parameters to allow one to input the values for the script to close ALL open orders (not just by a specific pair, but all of them) when the total reaches "X" dollars (+ or -) or "X" percentage of the account.

If you can do this, it would be greatly appreciated.

Regards,

GF
  • #4
  • Apr 21, 2009 9:31am Apr 21, 2009 9:31am
Quoting goingforward
Hello,

I have attached a script which offers several useful options. Yet, I find that, in my opinion, it could use two more which are:

  1. Close all when "x" dollars (total) reached (+/-)
  2. Close all when "x" percentage of account reached (+/-)

Could someone please take a look at this and add the necessary code?

Thank you very much,

GF

You must run an EA for this because the price must be checked with each tick and a script only runs once.

Use these EAs for your application. Use the EA that is appropriate for what you are trying to do. Place it on any chart, I use GBPJPY, because there are more ticks and it will close all trades when the criteria of the EA is met.
Attached File(s)
File Type: mq4 CloseTrades_After_Account_Loss_Percent.mq4   3 KB | 436 downloads
File Type: mq4 CloseTrades_After_Account_Loss_TooMuch.mq4   3 KB | 410 downloads
File Type: mq4 CloseTrades_After_Account_Profit_Reached.mq4   3 KB | 481 downloads
File Type: mq4 CloseTrades_After_Account_Win_Percent.mq4   4 KB | 417 downloads
  • #5
  • Apr 21, 2009 10:20am Apr 21, 2009 10:20am
Quoting smjones
You must run an EA for this because the price must be checked with each tick and a script only runs once.

Use these EAs for your application. Use the EA that is appropriate for what you are trying to do. Place it on any chart, I use GBPJPY, because there are more ticks and it will close all trades when the criteria of the EA is met.

Thank you for posting these scripts. As a matter of fact, I already had used the "Close All After Profit Reached" script and that was what prompted me to want to add that function to the other script I found and posted above.

If one has multiple pairs open and then decides that the then current cummulative win/loss level is such that you want to immediately close them all, it would be difficult to use these scripts as they do not offer external parameter inputs. Instead, you have to pre-determine your win/loss level ($ or %) and change it in the code and then save it before using it. This would defeat the ability to move "on a dime". That is why I thought that by merging these scripts into the one I initially posted, would create the best possible scenario. Does that make sense?

Thanks for your help. It is always appreciated.

GF
  • #6
  • Apr 25, 2009 8:47pm Apr 25, 2009 8:47pm
Quoting goingforward
Hello,

I have attached a script which offers several useful options. Yet, I find that, in my opinion, it could use two more which are:

  1. Close all when "x" dollars (total) reached (+/-)
  2. Close all when "x" percentage of account reached (+/-)

Could someone please take a look at this and add the necessary code?

Thank you very much,

GF

Good day GoingForward,

I've coded what you requested. I hope you like it. I have also made it an Expert Advisor, NOT a script.

Unfortunately, the markets are closed right now(saturday here in CA), so I could not test it! But, I re-read the code 5 times to make sure it was correct. It looks correct to me. So, here you go. See attached below


Oksana17.
|
^
Attached File(s)
File Type: mq4 MoneyManagement.mq4   7 KB | 537 downloads
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #7
  • Apr 25, 2009 9:09pm Apr 25, 2009 9:09pm
Quoting Oksana17
Good day GoingForward,

I've coded what you requested. I hope you like it. I have also made it an Expert Advisor, NOT a script.

Unfortunately, the markets are closed right now(saturday here in CA), so I could not test it! But, I re-read the code 5 times to make sure it was correct. It looks correct to me. So, here you go. See attached below


Oksana17.
|
^
Wow...THANK YOU!

I surely did not expect that quite so soon. I am sure that it is fine and I will gladly take it out for a test drive next week. Its a handy tool to have.

I owe you one...or two...or three.

Regards,

GF
  • #8
  • Last Post: Apr 26, 2009 11:11am Apr 26, 2009 11:11am
Quoting goingforward
Wow...THANK YOU!

I surely did not expect that quite so soon. I am sure that it is fine and I will gladly take it out for a test drive next week. Its a handy tool to have.

I owe you one...or two...or three.

Regards,

GF
You are very welcome.

Oksana17.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
0 traders viewing now