100% Win Math Grid Ea

Quoting freetv_king

Disliked

Hi Viper
I wanted to thank you for all the great work u have put in this EA so far. I am currently testing it on a 5 digit account and everything is working fine except ATR auto increments. It works fine on a 4 digit account. With the same settings and same day on a 4 digit account the increments are like 9 pips and on a 5 digit account its 53 pips.
I would appreciate if u can fix this on your next release. I am using ver 2.6.1
Thanks

Ignored

Quoting tradingviper

Disliked

Welcome back and happy to hear from you ! I haven't been around all that much lately either. Been busy on some private projects and other stuff, but hope to be back in force soon...

Ignored

Quoting tradingviper

Disliked

Good catch king. It is a bug. I must have never tested that portion with a 5-digit account. Thanks for your help in finding these nasty little creatures :-)

The updated version is attached. This version only fixes the bug found by king and described here. There are no new or enhanced features.

Hopefully, there will be a new version here soon... keep your fingers crossed that I find the time and inspiration... Of course, other's inspirations are welcome also.

Thanks.
Viper

Ignored

if(buyGoalProfit < profitTarget)   // - Increment lots Buy

while(buyGoalProfit < profitTarget)   // - Increment lots Buy

buyGoalProfit  = checkPendingProfit(lots,OP_BUY, initialSetKey);

if(sellGoalProfit < profitTarget)   // - increment Lots Sell

while(sellGoalProfit < profitTarget)   // - increment Lots Sell

sellGoalProfit = checkPendingProfit(lots,OP_SELL,initialSetKey);

Quote

Disliked

Andrew, is there anything in the code that would allow for pending orders to be deleted more quickly when a sequence closes?

Quoting wwwild

Disliked

Hi Plasmapants,

Even though it may take a little time to close all of those pending orders, I don't believe there would be any negative impact what-so-ever - because the open price is so far away for all of those pending orders that it could take 10mins to close them all and the price would still be well away. But, I guess...

Ignored

Quoting wwwild

Disliked

Hi Viper,

While investigating some unusual "losses" during backtesting, I found this bug (that caused the wierd losses) with an easy fix.

Basically, this bug will not come up very often, but is definatley there. What happens is the current code will only open 1 new pending order every tick. So if it had to open 60 pending orders, it would take 60 ticks. If the price reversed the opposite direction and hit one of the levels before 60 ticks, it would mean that it would not have enough pending orders to open in order for the maths to work correctly.......

Ignored

Quote

Disliked

With your fix, i have error "OrderSend error 148", Alpari 5 digits backtest day

Quote

Disliked

On some trade servers, the total amount of open and pending orders can be limited. If this limit has been exceeded, no new position will be opened (or no pending order will be placed) and trade server will return error 148 (ERR_TRADE_TOO_MANY_ORDERS).

Quoting Chroniclez

Disliked

This EA is not 100%. My strategy is.

Ignored

Quoting tradingviper

Disliked

Good catch king. It is a bug. I must have never tested that portion with a 5-digit account. Thanks for your help in finding these nasty little creatures :-)

The updated version is attached. This version only fixes the bug found by king and described here. There are no new or enhanced features.

Hopefully, there will be a new version here soon... keep your fingers crossed that I find the time and inspiration... Of course, other's inspirations are welcome also.

Thanks.
Viper

Ignored

Quoting tradingviper

Disliked

Good catch king. It is a bug. I must have never tested that portion with a 5-digit account. Thanks for your help in finding these nasty little creatures :-)

The updated version is attached. This version only fixes the bug found by king and described here. There are no new or enhanced features.

Hopefully, there will be a new version here soon... keep your fingers crossed that I find the time and inspiration... Of course, other's inspirations are welcome also.

Thanks.
Viper

Ignored

            buyPrice = initialPrice+(cpt*increment+incrementAdjustStart)*PointValue;
            
            // EJAZ START LOTS CALC
            int newBuyGoalProfit = buyGoalProfit;
            int multiplier = 0;
            while (newBuyGoalProfit < profitTarget) {
               multiplier = multiplier + 1;
               newBuyGoalProfit+=(buyGoal-(incrementAdjustFinal*PointValue)-buyPrice)/PointValue*(cpt*lots)/lots;
            }
            // EJAZ END
            
            if(Ask <= buyPrice-MarketInfo(Symbol(),MODE_STOPLEVEL)*PointValue)
            {
               if( UseOrdersReliable ) {
               //EJAZ added in the *multiplier
               ticket =
               OrderSendReliable(Symbol(),OP_BUYSTOP,cpt*lots*multiplier,buyPrice,MAX_ENTRY_SLIPPAGE,sellGoal-stopLossStealthAdjust,
                                 buyGoal,initialSetKey,MagicNumber,0);
               }
               else {
               //EJAZ added in the *multiplier
               ticket =
               OrderSend(Symbol(),OP_BUYSTOP,cpt*lots*multiplier,buyPrice,MAX_ENTRY_SLIPPAGE,sellGoal-stopLossStealthAdjust,
                         buyGoal,initialSetKey,MagicNumber,0);
               } 

            sellPrice = initialPrice-(cpt*increment+incrementAdjustStart)*PointValue;

            // EJAZ START LOTS CALC
            int newSellGoalProfit = sellGoalProfit;
            multiplier = 0;
            while (newSellGoalProfit < profitTarget) {
               multiplier = multiplier + 1;
               newSellGoalProfit+=(sellPrice-(sellGoal+spread)+(incrementAdjustFinal*PointValue))/PointValue*(cpt*lots)/lots;
            }
            // EJAZ END STOP
            
            if(Bid >= sellPrice-MarketInfo(Symbol(),MODE_STOPLEVEL)*PointValue)
            {
               if( UseOrdersReliable ) {
               //EJAZ added in the *multiplier
               ticket =
               OrderSendReliable(Symbol(),OP_SELLSTOP,cpt*lots*multiplier,sellPrice,MAX_ENTRY_SLIPPAGE,buyGoal+spread+stopLossStealthAdjust,
                                 sellGoal+spread,initialSetKey,MagicNumber,0);
               }
               else {
               //EJAZ added in the *multiplier
               ticket =
               OrderSend(Symbol(),OP_SELLSTOP,cpt*lots*multiplier,sellPrice,MAX_ENTRY_SLIPPAGE,buyGoal+spread+stopLossStealthAdjust,
                         sellGoal+spread,initialSetKey,MagicNumber,0);
               }