Steve Hopwood's Boris Schlossberg-inspired trading robots | Page 39 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Know Yourself, Know Your Setup, by Boris Schlossberg 9 replies

Mechanical day trading inspired by First Strike Plus 2 replies

Which movie has inspired you the most in your trading? 12 replies

New Webinar with Kathy Lien, Boris Schlossberg and Ken Calhoun 2 replies

Lien-Schlossberg book, Hayden:The RSI - any opinion? 1 reply

Attachments: Steve Hopwood's Boris Schlossberg-inspired trading robots
Exit Attachments

Steve Hopwood's Boris Schlossberg-inspired trading robots

  • #761
  • Apr 12, 2010 8:47am Apr 12, 2010 8:47am
Quoting paulbt38
Rascacio If you press Ctrl and Y and on the chart it should draw lines at 00:00 Paul
Well that was easy !!! thanks for that Paul, I feel like a right gobsh*te now !!
This will save a lot of messing about !!
  • #762
  • Apr 12, 2010 9:02am Apr 12, 2010 9:02am
Hi Steve following on from a previous post, my 10 a day has just made a trade on GU opened at 14.41 closed at 14.52 for 10 pips profit !!

I like the idea of grabbing 10 quick pips, I'm not greedy ( A bird in the hand and all that ) and will be happy to see if it keeps on trading.
  • #763
  • Apr 12, 2010 9:14am Apr 12, 2010 9:14am
Quoting hiredwhip
Hi Steve,
Yes the trades went to half closed but the JS didn't go to + BEP.
thanks for the answer.....have a good weekend...

whip
Hi Steve,
I'm still working on this bot.....The trades are going to half closed and the JS is jumping but it is landing at -1 instead of + BEP......Thankz

whip
  • #764
  • Apr 12, 2010 10:56am Apr 12, 2010 10:56am
Quoting SteveHopwood
Re 2ma mace stops and tp's, would you guys like me to code the ability to use ATR to generate these?

I agree that the 2MA-MACD might be the more successful of the bots, although I have not tested all of them as yet.

Adding ATR as an method for SL and TP might be useful as long as it is an optional feature. I have 2 demos of this bot running. One demo is going without intervention and doing OK so far. The other demo where I intervene and close some trades manually is doing very well so far. Using ATR might accomplish some of what I've been doing manually.

If you do add ATR code to the bot, I'll set up a third demo to run it w/o intervention and see how it does.
  • #765
  • Apr 12, 2010 1:03pm Apr 12, 2010 1:03pm
Quoting sundog
Steve did you get around to looking at the Asian session trading times, in regards to my earlier post about the Asian session is open message?

Tks.
I have added a fix, at least I think it is a fix. Sing out if it does not work.

The same bug existed within 5mm and 2ma macd, but I am not sure it matters here. Still fixed, though.

I have also added the analysis bots to the zip.

  • #766
  • Apr 12, 2010 1:03pm Apr 12, 2010 1:03pm
Quoting hiredwhip
Hi Steve,
I'm still working on this bot.....The trades are going to half closed and the JS is jumping but it is landing at -1 instead of + BEP......Thankz

whip
Fix in post 1. This was a basic coding error so everything should be ok now. Shout out if not.

  • #767
  • Apr 12, 2010 1:04pm Apr 12, 2010 1:04pm
Quoting octomanoak
I agree that the 2MA-MACD might be the more successful of the bots, although I have not tested all of them as yet.

Adding ATR as an method for SL and TP might be useful as long as it is an optional feature....
Ok, will do.

  • #768
  • Apr 12, 2010 3:19pm Apr 12, 2010 3:19pm
Quoting octomanoak
I agree that the 2MA-MACD might be the more successful of the bots, although I have not tested all of them as yet.

Adding ATR as an method for SL and TP might be useful as long as it is an optional feature....
Have done. Update in post 1. Would you do me a favour and make sure the function is working as intended. It should do as it is merely copied from other robots where it is working properly; just shout out if not.

  • #769
  • Apr 12, 2010 5:37pm Apr 12, 2010 5:37pm
Steve, is it possible to fix CloseLosingTradesAfterMins on momo?

Regards
Elovv
  • #770
  • Apr 12, 2010 5:54pm Apr 12, 2010 5:54pm
Quoting Elovv
Steve, is it possible to fix CloseLosingTradesAfterMins on momo?

Regards
Elovv
I had a quick look.

Here is the sequence of events when I have an idea.

 

  1. Produce the input.
  2. Add the status of the input to the on-screen feedback display.
  3. Code the robot to act upon the input.

On this occasion, I forgot to carry out step 3. This means, it only looks as though the robot is coded to close the trade.

I will sort this out soon.

  • #771
  • Apr 12, 2010 6:50pm Apr 12, 2010 6:50pm
Quoting SteveHopwood
Have done. Update in post 1. Would you do me a favour and make sure the function is working as intended. It should do as it is merely copied from other robots where it is working properly; just shout out if not.

Thank you Steve. Just loaded up the latest version with the ATR code on demo. Will let you know if I notice anything not working right.
  • #772
  • Apr 12, 2010 7:20pm Apr 12, 2010 7:20pm
Quoting SteveHopwood
Have done. Update in post 1. Would you do me a favour and make sure the function is working as intended. It should do as it is merely copied from other robots where it is working properly; just shout out if not.

Hi Steve!
Since you are clearly extremely busy coding all these great bots, I figured I could help you at least a tiny bit by pointing out a (small) bug in your latest addition to the 2ma MaCD bot:

The line "double AtrVal = iATR(NULL, 0, AtrPeriod, 0);//Take account of user choosing this option"

should be changed to "double AtrVal = iATR(symbol, 60, AtrPeriod, 0);//Take account of user choosing this option"

since otherwise you would use the ATR-Value of the chart the EA is attached to for ALL the pairs you're trading!!

Please keep up the excellent work, it is people like you that make ALL the difference on here!

J.
  • #773
  • Apr 12, 2010 8:30pm Apr 12, 2010 8:30pm
Quoting octomanoak
Hope you are back to full health very soon Astral. Sounds like an awful, awful flu.
Thanks very much indeed guys for your concern, all the get wells I have had posted here and by pms reinforces my belief that for some reason people in FF are truly wonderful human beings (with exception of one or two plonkers who do not last long). You have humbled me gentlemen (and a lady). You are wonderful, wonderful people and I wish you long and prosperous life.

humbly yours,
astral77

p.s. will soon be resuming my usual insignificant postings.
  • #774
  • Apr 13, 2010 2:00pm Apr 13, 2010 2:00pm
Quoting Jayper
Hi Steve!
Since you are clearly extremely busy coding all these great bots, I figured I could help you at least a tiny bit by pointing out a (small) bug in your latest addition to the 2ma MaCD bot:

The line "double AtrVal = iATR(NULL, 0, AtrPeriod, 0);//Take account of user choosing this option"

should be changed to "double AtrVal = iATR(symbol, 60, AtrPeriod, 0);//Take account of user choosing this option"

since otherwise you would use the ATR-Value of the chart the EA is attached to for ALL the pairs you're trading!!

Please keep up the...
Thanks J. As it happens, this bot is allowed to run on any tf the user wants. 4H has been successful as well as the 1H. I don't think anyone is testing D1.

  • #775
  • Apr 13, 2010 4:08pm Apr 13, 2010 4:08pm
Quoting SteveHopwood
Thanks J. As it happens, this bot is allowed to run on any tf the user wants. 4H has been successful as well as the 1H. I don't think anyone is testing D1.

Totally agree about the tf Steve,

but what about "symbol" instead of "NULL"? Or do you really want to use the ATR from GbpJpy also for EurUsd, EurGbp and so on?
  • #776
  • Apr 13, 2010 4:09pm Apr 13, 2010 4:09pm
Hi Steve,
Just got in and happened to see this. Enclosed is a short USDCAD trade in the second half of the trade with the stop well north of the price. With the trade in this position the stop should be at +BEP I believe. If you get a chance check this one out please.......Thankz

whip
Attached Image (click to enlarge)
Click to Enlarge Name: usdcad.jpg Size: 137 KB
  • #777
  • Apr 13, 2010 4:19pm Apr 13, 2010 4:19pm
Quoting hiredwhip
Hi Steve,
Just got in and happened to see this. Enclosed is a short USDCAD trade in the second half of the trade with the stop well north of the price. With the trade in this position the stop should be at +BEP I believe. If you get a chance check this one out please.......Thankz

whip
Nope. Abandon the CCI bot. Either the system is rubbish or the robot is rubbish or both.

Either or all ways, it is not worth pursuing and I can't be arsed.

  • #778
  • Apr 13, 2010 4:22pm Apr 13, 2010 4:22pm
OK Steve ......will do....Have a good day

whip
  • #779
  • Apr 13, 2010 5:28pm Apr 13, 2010 5:28pm
I have done some pruning of post 1 and the robots in the robot zip, in light of experience here.

If anybody is happily trading something I have removed, then please sing out. The robot can always be reinstated.

  • #780
  • Apr 13, 2010 8:14pm Apr 13, 2010 8:14pm
Quoting Jayper
The line "double AtrVal = iATR(NULL, 0, AtrPeriod, 0);//Take account of user choosing this option"

should be changed to "double AtrVal = iATR(symbol, 60, AtrPeriod, 0);//Take account of user choosing this option"

since otherwise you would use the ATR-Value of the chart the EA is attached to for ALL the pairs you're trading!!
I openly admit I do not understand code, so pardon me for my ignorance.

I can see how this suggestion to change "null" to "symbol" might relate to which currency pair the ATR refers to, but what is the meaning of changing the "0" to "60"? Does the "60" specify a timeframe, such as 60 minutes regardless of the timeframe of the chart the EA is loaded on? And if so, does the 0" refer to the timeframe of the chart the EA is loaded on?
0 traders viewing now