Steve Hopwood's Boris Schlossberg-inspired trading robots | Page 36 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Know Yourself, Know Your Setup, by Boris Schlossberg 9 replies

Mechanical day trading inspired by First Strike Plus 2 replies

Which movie has inspired you the most in your trading? 12 replies

New Webinar with Kathy Lien, Boris Schlossberg and Ken Calhoun 2 replies

Lien-Schlossberg book, Hayden:The RSI - any opinion? 1 reply

Attachments: Steve Hopwood's Boris Schlossberg-inspired trading robots
Exit Attachments

Steve Hopwood's Boris Schlossberg-inspired trading robots

  • #701
  • Apr 8, 2010 12:54pm Apr 8, 2010 12:54pm
Quoting SteveHopwood
I have looked at the code and cannot see anything wrong.

Look at the attached pic of an eurcad trade from 6.55 am on 5th April, highlighted in the trades window.

The turquiose line marks the first macd histogram to be checked for a cross. The pic indicates the robot is checking back 1 bar too many, so I have added a fix for that.

That apart, everything looks ok.

Of course I don't know how to read the code, so I cannot contribute on that level. Clearly on my chart the bot entered a trade that does not fit the strategy. Is it possible that it is because I'm running on H1 charts? Is there some way that the bot is checking when the MACD cross occurs or when price is above/below the MAs that checks on a different timeframe than the H1 chart and therefore enters a trade that might be valid, but for another timeframe?
  • #702
  • Apr 8, 2010 1:47pm Apr 8, 2010 1:47pm
Quoting octomanoak
Of course I don't know how to read the code, so I cannot contribute on that level. Clearly on my chart the bot entered a trade that does not fit the strategy. Is it possible that it is because I'm running on H1 charts? Is there some way that the bot is checking when the MACD cross occurs or when price is above/below the MAs that checks on a different timeframe than the H1 chart and therefore enters a trade that might be valid, but for another timeframe?
Nope. The robot is specific to the chart tf - one of the things I checked in the code.

  • #703
  • Apr 8, 2010 2:01pm Apr 8, 2010 2:01pm
Quoting SteveHopwood
Nope. The robot is specific to the chart tf - one of the things I checked in the code.

My EURGBP took a sell 27 min ago! 1 hour chart. MACD has been negative several days. I guess something must be wrong. But what?

Best wishes
Elovv
  • #704
  • Apr 8, 2010 3:28pm Apr 8, 2010 3:28pm
Quoting Elovv
My EURGBP took a sell 27 min ago! 1 hour chart. MACD has been negative several days. I guess something must be wrong. But what?

Best wishes
Elovv
No idea. Sorry. Can't solve a problem that does not occur at my end. I will continue to review the code, but I have spent quite a long time doing this already and do not expect to spot anything new. The code is simple. This does not mean that I have not done anything wrong; it does make it less and less likely the more I review it.

  • #705
  • Apr 8, 2010 7:25pm Apr 8, 2010 7:25pm
Just put up a new demo of latest version of the bot. It is doing very well so far on M5 chart FXDD demo...up 111 pips in just a few hours.
  • #706
  • Apr 9, 2010 2:22am Apr 9, 2010 2:22am
Perhaps I am just too dense and tired to grasp it at the moment, but can someone explain why the bot entered a long trade on 4/9/10 06:21 at a price of 1.5313, which was above the market?

I have the bot set for pending trades with pendingorderpips 100 (10 pips).

It looks like the GbpUsd pair would have met the entry criteria on the 4/8/10 15:00 bar, but the pending order did not activate until 06:21 on 4/9/10.

GbpUsd-2MA-MACD.jpg
Attached Image (click to enlarge)
Click to Enlarge Name: GbpUsd-2MA-MACD.jpg Size: 68 KB
  • #707
  • Edited 4:25am Apr 9, 2010 3:59am | Edited 4:25am
Quoting SteveHopwood
No idea. Sorry. Can't solve a problem that does not occur at my end. I will continue to review the code, but I have spent quite a long time doing this already and do not expect to spot anything new. The code is simple. This does not mean that I have not done anything wrong; it does make it less and less likely the more I review it.

Hi Steve

Thank You for Your hard exellent work. When i loaded the 2smamacd template it loaded the mt4 original MACD on the chart, I didn´t notice that (MACD true from Swingman whas in the folder). Sorry if I caused You a lot of extra work.
I have changed MACD on my chart to Swingmans.
Maybee the robot couldn´t use the original MACD? I dont know, just see that it took trades without right MACD rules.
Let see what happens know when I have the right MACD on my chart.
Maybee You could load a kneew template?

paulbt38, I can see on your chart You have wrong MACD (and same problems as me) Rascasio, do You have right MACD with Your excellent result? I have positiv result with wrong MACD (Robot trades with the trend)

Regards
Elovv
  • #708
  • Apr 9, 2010 5:13am Apr 9, 2010 5:13am
The 2ma macd trades I am getting all look correct to me.

10 a day leaped into live overnight with an EU and a GU trade - both winners - so the code is ok. I think.

  • #709
  • Apr 9, 2010 5:20am Apr 9, 2010 5:20am
Elovv

Thanks for spotting the wrong MACD - sometimes I can't see something for looking at it. I too echo you gratitude to Steve for producing these EA's as he has clearly put in a lot of work. I am still finding some bizarre trades although over the last couple of days my demo account is still extremely positive. I have attached a screenshot from this morning. A previous GBPUSD trade closed and exactly 30 mins later a new one opened despite MACD (the right one) being positve for a lot longer than 5 bars. Anyway as long as it is making money
Attached Image (click to enlarge)
Click to Enlarge Name: screenshot.JPG Size: 151 KB
  • #710
  • Apr 9, 2010 5:25am Apr 9, 2010 5:25am
Steve

Glad your 10 a day burst into live last night. Just checked my account and no action (this is on Alpari UK Demo). Also no trade on Asian Breakout all week after a promising run last week. I can only see my account on myfxbook when at work so will check the log tonight and see if any errors stopped any trades.

Again, thanks for your hard work
  • #711
  • Apr 9, 2010 7:04am Apr 9, 2010 7:04am
Quoting paulbt38
Elovv

...new one opened despite MACD (the right one) being positve for a lot longer than 5 bars. Anyway as long as it is making money
HI

The BOT is behaving properly. Please note the BOT takes the value of MACD and not how the BAR looks on the chart. Have a look at the MACD bars 5 or 6 hours before and you see it is almost ZERO, it may have been the case that the value gone into -ve and back to +ve within the same hour BAR. I have tested the single pair version quite extensively and have been using it since its creation, it does not have any bugs as far as I know. I can not vouch for the multipair version with the same conviction, but it seems ok to me so far.

Kind Regards
  • #712
  • Apr 9, 2010 8:14am Apr 9, 2010 8:14am
Quoting astral77
HI

The BOT is behaving properly. Please note the BOT takes the value of MACD and not how the BAR looks on the chart. Have a look at the MACD bars 5 or 6 hours before and you see it is almost ZERO, it may have been the case that the value gone into -ve and back to +ve within the same hour BAR. I have tested the single pair version quite extensively and have been using it since its creation, it does not have any bugs as far as I know. I can not vouch for the multipair version with the same conviction, but it seems ok to me so far.

Kind Regards...

Astral77

Thanks for that. I thought that might have been the case and did mention this in one of my posts yesterday. The rules in the book simply refer to using the indicator bars. I assume by using the actual value during the hour we will simply get a faster entry point. I can understand that the value may cross during the current candle and that would set up a trade, however from what you are saying I understand that within the last five bars if it had crossed at all, even only for a short time, that would be enough to trigger the trade as this is what must have happened this morning (see earlier screenshot). The only reason I mention this is because by the time the trade was placed (after a previous close) the momentum seemed to be running out. Now I know that no system is perfect and therefore there can be losses but I am just trying to think out load and minimise these. I will consider increasing the sleep time in my settings as clearly one trade hit a trailing stop which might be a sign that momentum is running out and simply my second trade this morning was entered too quickly. I will see if that takes out these quicky trades for me. As I said before these are small issues as it seems to be very profitable so far.

Paul
  • #713
  • Apr 9, 2010 9:03am Apr 9, 2010 9:03am
Quoting astral77
HI

The BOT is behaving properly. Please note the BOT takes the value of MACD and not how the BAR looks on the chart. Have a look at the MACD bars 5 or 6 hours before and you see it is almost ZERO, it may have been the case that the value gone into -ve and back to +ve within the same hour BAR. I have tested the single pair version quite extensively and have been using it since its creation, it does not have any bugs as far as I know. I can not vouch for the multipair version with the same conviction, but it seems ok to me so far.

Kind Regards...
Thanks

A little observation. MACD value is not exactly same on Chart and MACD chart. For examle on chart GBPJPY:50sma=142.89100sma=142.89 Trade direction long MACD=-0.010
On macd chart MACD=0.0103
I dont know why ore if it matters.

Regards
Elovv
  • #714
  • Apr 9, 2010 9:08am Apr 9, 2010 9:08am
Quoting paulbt38
Astral77

Thanks for that. I thought that might have been the case and did mention this in one of my posts yesterday. The rules in the book simply refer to using the indicator bars. I ... As I said before these are small issues as it seems to be very profitable so far.

Paul
Hi Paul

You are quite right. Sometimes when automating you can not replicate the system 100% and I THINK that this is the case here. I do not know if the same thing happens if you choose the full candle option since I do not use that option. I agree with you that this seems to be a sound system and STEVE has done a fantastic job automating it. Please bear in mind what Schlossberg says (i.e. Trading is an ART). I think this BOT benefits from some manual intervention for example when you feel the entry was not good enough closing the trade or adjusting the SL.

Wishing you the BEST of luck
Kind Regards
  • #715
  • Apr 9, 2010 10:22am Apr 9, 2010 10:22am
Astral,

How is your 2ma Macd on the 4 hr going? you're live with it correct?
  • #716
  • Apr 9, 2010 10:47am Apr 9, 2010 10:47am
Over 24 hours the latest version of this bot has done remarkably well on M5 on forward demo FXDD. 315 pips captured in that time.

Is anyone else testing the latest version of the bot on M5?

Congrats Steve!
  • #717
  • Apr 9, 2010 10:54am Apr 9, 2010 10:54am
Quoting octomanoak
Over 24 hours the latest version of this bot has done remarkably well on M5 on forward demo FXDD. 315 pips captured in that time.

Is anyone else testing the latest version of the bot on M5?

Congrats Steve!
Great results, octomanoak! Which settings do you use? DD is not too big?
Best regards!
  • #718
  • Apr 9, 2010 11:10am Apr 9, 2010 11:10am
Quoting octomanoak
Over 24 hours the latest version of this bot has done remarkably well on M5 on forward demo FXDD. 315 pips captured in that time.

Is anyone else testing the latest version of the bot on M5?

Congrats Steve!
I can test it on IBFX next week. Which pair and settings do You use?

Best wishes
Elovv
  • #719
  • Apr 9, 2010 11:46am Apr 9, 2010 11:46am
Elovv and Meister,

I'm using all default settings including all the pairs in the default, although I adjusted the lots for the account size (which should not affect the pips gained) and I set the friday close hour for a time appropriate for my PC local time.

The DD is not high because the strategy has relatively tight and trailing stops and there is a limit of 6 trades open at any time (maxtradesallowed = 6). Just be sure you use a lot setting appropriate for your account size and that is divisible by 2 on your broker's platform.

Also, check the default pairs to be sure your broker trades those pairs...remove any your broker doesn't handle.

One caution: Do not go live based on my report of 24 hours running the bot on demo!!! Next week might not go so well for the bot.

Good luck!
  • #720
  • Apr 9, 2010 11:57am Apr 9, 2010 11:57am
Octomanoak

I have been testing momo on the 1 hr chart. Wednesday and early Thursday were bad days however since then I have recovered losses for the week and am up. I am trying both half close and full close. At present the half close appears slightly better. I have been using lot size 0.02 and have the following results.

You will notice that my 2ma MACD results do not appear great. These are the results on my VPS which has been running the 2ma MACD since Wednesday night about 7pm (GMT+1). I have also been running it in work since earlier that day and instead of a loss am showing a healthy profit of over $100. I guess for both of these bots Wednesday evening and Thursday morning were not great. Saying that I have a nice healthy open profit at the moment and my first 2ma MACD 4hr pending trades have been taken. Pity the week had to end.
Attached Image (click to enlarge)
Click to Enlarge Name: screenshot.JPG Size: 169 KB
0 traders viewing now