Just a poverty-sticken dimbo thrashing around in the dark hoping to make a few pips here and there to save being thrown out on the street, aren't you?
scooby-doo BOJ JPY pairs trading robot
- #7,962
- Apr 1, 2010 5:35pm Apr 1, 2010 5:35pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I looked at the code again and say a call to start() at the end of init(). I have removed the call and put up the newest version in post 1.
Could it be that a call to start() before the chart receives a tick causes the robot to work on incorrect figures and therefore send trades based on erroneous figures?
Could it be that a call to start() before the chart receives a tick causes the robot to work on incorrect figures and therefore send trades based on erroneous figures?
- #7,963
- Apr 1, 2010 5:43pm Apr 1, 2010 5:43pm
- Joined Jul 2009 | Status: Trader | 2,158 Posts
I looked at the code again and say a call to start() at the end of init(). I have removed the call and put up the newest version in post 1.
Could it be that a call to start() before the chart receives a tick causes the robot to work on incorrect figures and therefore send trades based on erroneous figures?
How could that happen I asked myself....
Well, I had the tick sender program running.
But still strange if the Experts Tab was disabled i.e. RED ????????
Scoobs
- #7,964
- Apr 1, 2010 5:44pm Apr 1, 2010 5:44pm
- Joined Jul 2009 | Status: Trader | 2,158 Posts
Just a poverty-sticken dimbo thrashing around in the dark hoping to make a few pips here and there to save being thrown out on the street, aren't you?
Just hope its not clacton on sea
Scoobs.
- #7,967
- Apr 1, 2010 6:30pm Apr 1, 2010 6:30pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I think I see the flaw in my logic. Take this lot for a buy:
On initial start up, the Ask is above the EMA_020_M15 - AtrVal and so sends a pending trade. If I am lucky, this trade fills and the markets continue in my favour to tp.
Equally likely, there is a retrace going on. Despite this, the trade fills, and then the retrace continues and the trade stops out. From here, a continuation of the trend is more likely, which explains the subsequent success of the robot as it sends pending trades in the direction of the overall trend.
I think I know what to do about this and will post a fix in time for next week. In the meantime, amazing that a flawed logic should result in the kind of profits my accounts have seen. Bet you anything you like the fix stops trading dead in its tracks.
Inserted Code
Get_Trend(TradePair[b]);
double AtrVal = Get_ATR(TradePair[b], RetraceAtrTf, RetraceAtrMultiplier);
if(Trend == up)
{
double ask = MarketInfo(TradePair[b], MODE_ASK);
if (IsTradeAllowed())
{
if(ask <= EMA_020_M15 - AtrVal)//Immediate buy trade
{
SendOrder(TradePair[b],OP_BUY,Lots);
}//if(ask <= EMA_020_M15 - AtrVal)
if(ask > EMA_020_M15 - AtrVal)//Pending buy stop
{
SendOrder(TradePair[b],OP_BUYSTOP, Lots);
}//if(ask <= EMA_020_M15 - AtrVal)
}//if (IsTradeAllowed)
}//if(Trend == up) Equally likely, there is a retrace going on. Despite this, the trade fills, and then the retrace continues and the trade stops out. From here, a continuation of the trend is more likely, which explains the subsequent success of the robot as it sends pending trades in the direction of the overall trend.
I think I know what to do about this and will post a fix in time for next week. In the meantime, amazing that a flawed logic should result in the kind of profits my accounts have seen. Bet you anything you like the fix stops trading dead in its tracks.
- #7,970
- Apr 1, 2010 7:43pm Apr 1, 2010 7:43pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Steve,
I hate to state the obvious but the reason why your account grew nicely was because there is a very strong argument for just going with a currencies current trend. Sometimes we do this commercially, especially if there is no major economic news pending etc.
Yes, you will get DD and the odd blown SL but overall unless there is NFP news etc then you should come out with a profit.
Setting your TP and SL to ATR(DAILY) will help allot.
Obviously the key is not to be entering a trade when a currencies trend is or is coming to exhaustion.
Scoobs....
This robot is supposed to enter a trade when a retrace is ending. Because I got my logic knickers into a twist, it is a matter of luck when this happens.
- #7,971
- Apr 1, 2010 7:44pm Apr 1, 2010 7:44pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
CurrencySharksWithFriggingLaserBeams.mq4
extern bool CriminalIsECN = false;
extern bool CriminalIsEvil = true;
extern bool CriminalIsVeryEvil = true;
extern bool CrminialIsPinkyEvil = true;
double TakeProfit=1000000000000;
- #7,972
- Apr 1, 2010 9:17pm Apr 1, 2010 9:17pm
Don't tempt me. Given the mood I am in tonight, this little lot might just appear as inputs in my update to Monica's More Intelligent Sister.
- #7,974
- Apr 2, 2010 3:23am Apr 2, 2010 3:23am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
In time for trading after the Easter break, the Trend Retracement will be reborn as The Big Lewinsky.
Here is the logic behind TBL:
Here is the logic behind TBL:
- the robot recognises a trend exists.
- it waits for a retrace from the previous hi-lo by the number of pips returned by the ATR calculation, then sends a pending trade in the direction of the trend.
The trading logic is fine. The logic I coded into the robot entirely missed out the spot-the-retrace bit. It has been successful because it is trading in the direction of the trend; when it took a trade at the end of a retrace, that was pure luck when it was first loaded.
I know how to code the spot-the-retrace bit, so it is just a matter of getting it done.
- #7,975
- Apr 2, 2010 5:05am Apr 2, 2010 5:05am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Guys, I have to be the least intelligent individual ever to start making modest profits trading forex.
I have just spent a couple of hours coding market-movement detection and hi-lo functions etc.
The I realised that the original coding was what was needed but the blasted conditionals were the wrong way around. Again. As usual.
So, in an up trend, the price has to retrace back below the EMA_020_M15. This is the correct conditional for a buy
not if(ask > EMA_020_M15 - AtrVal)
Hell's bells and buckets of blood.
So, The Big Lewinsky is born. It is the same robot as Trend Replacement, but with a bit more accurate coding and a better name. It must replace TR immediately.
It probably won't trade at all because the coding is correct.
I cannot be bothered going through the faff of editing the robot zip and post 1 etc just yet. Those of you who have been keeping up with events here know what to do, so use the attached version.
We need to know just how deep to let a retrace go, so I am going to work on displaying the ATR values returned when calculated using the various UsexxxATRrt choices.
Watch this space.
I have just spent a couple of hours coding market-movement detection and hi-lo functions etc.
The I realised that the original coding was what was needed but the blasted conditionals were the wrong way around. Again. As usual.
So, in an up trend, the price has to retrace back below the EMA_020_M15. This is the correct conditional for a buy
Inserted Code
if(ask <= EMA_020_M15 - AtrVal)//Pending buy stop
{
SendOrder(symbol,OP_BUYSTOP, Lots);
}//if(ask <= EMA_020_M15 - AtrVal) not if(ask > EMA_020_M15 - AtrVal)
Hell's bells and buckets of blood.
So, The Big Lewinsky is born. It is the same robot as Trend Replacement, but with a bit more accurate coding and a better name. It must replace TR immediately.
It probably won't trade at all because the coding is correct.
I cannot be bothered going through the faff of editing the robot zip and post 1 etc just yet. Those of you who have been keeping up with events here know what to do, so use the attached version.
We need to know just how deep to let a retrace go, so I am going to work on displaying the ATR values returned when calculated using the various UsexxxATRrt choices.
Watch this space.
- #7,977
- Apr 2, 2010 5:33am Apr 2, 2010 5:33am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
This is really interesting.
The attached update has the ATR values on display. This shows how far the market has to move on the higher ATR time frame settings.
Maybe you guys with a better 'feel' for the markets than me could think about the ranges displayed and which UsexxxATRrt setting to use as a trade trigger. For now, the robot defaults to the H1.
Popping it on an Alpari UK demo 1H chart, there has been a retrace from a down trend. Using the 15M ATR trade trigger, the bot sent the appropriate sell stop and so appears to be working as originally planned in concept.
Nice one for speaking up Elovv - my balls-up would have taken longer to emerge without this.
The attached update has the ATR values on display. This shows how far the market has to move on the higher ATR time frame settings.
Maybe you guys with a better 'feel' for the markets than me could think about the ranges displayed and which UsexxxATRrt setting to use as a trade trigger. For now, the robot defaults to the H1.
Popping it on an Alpari UK demo 1H chart, there has been a retrace from a down trend. Using the 15M ATR trade trigger, the bot sent the appropriate sell stop and so appears to be working as originally planned in concept.
Nice one for speaking up Elovv - my balls-up would have taken longer to emerge without this.
- #7,978
- Apr 2, 2010 5:38am Apr 2, 2010 5:38am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Steve,
As a general rule of thumb, if the price retraces by 25% of its daily ATR then you are good to place a pending order in the overall direction of the original trend.
Scoobs.
I will leave the bot as it is for now, so people can play with it. Unless there are a lot of howls to retain the flexibility of choice, I will make the adjustments in time for Tuesday.
Cheers. That is another great help.
- #7,979
- Apr 2, 2010 5:42am Apr 2, 2010 5:42am
- | Joined May 2009 | Status: Veni, Vidi, Pipsi | 95 Posts
From #7975 to #7977 in 18 minutes. My suggestion for a new version: "Speedy Gonzales". Keep them coming, Steve 
This is really interesting.
The attached update has the ATR values on display. This shows how far the market has to move on the higher ATR time frame settings.
Maybe you guys with a better 'feel' for the markets than me could think about the ranges displayed and which UsexxxATRrt setting to use as a trade trigger. For now, the robot defaults to the H1.
Popping it on an Alpari UK demo 1H chart, there has been a retrace from a down trend. Using the 15M ATR trade trigger, the bot sent the appropriate sell stop and so appears to be working as...