How to know if the last closed order | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

How Does One get the Last Open Price of the Last opened order 1 reply

How to make the EA wait x bars since the last order was closed 0 replies

Order Comment blank after order closed 4 replies

Go only long if last closed order was sell and inverse 3 replies

Help - Taking The Last Closed Trade On The History 1 reply

How to know if the last closed order

  • #1
  • First Post: Mar 26, 2010 12:59pm Mar 26, 2010 12:59pm
...Was hit by SL or TP? I used to select last order with this code to change the boolean sell or buy to false if the order is closed and allow to open another same order...:

if(sell==true)
if(OrderSelect(OrdersHistoryTotal()-1,SELECT_BY_POS,MODE_HISTORY)==true)
if(OrderTicket()==ticket_sell)
sell=false;

Any suggestions?
  • #2
  • Mar 26, 2010 1:12pm Mar 26, 2010 1:12pm
OrderSelect(i, SELECT_BY_POS, MODE_HISTORY);

if(OrderClosePrice() == OrderTakeProfit()) Print("TakeProfit Hit");
if(OrderClosePrice() == OrderStopLoss()) Print("StopLoss Hit");
  • #3
  • Mar 26, 2010 1:16pm Mar 26, 2010 1:16pm
Quoting Ronald Raygun
OrderSelect(i, SELECT_BY_POS, MODE_HISTORY);

if(OrderClosePrice() == OrderTakeProfit()) Print("TakeProfit Hit");
if(OrderClosePrice() == OrderStopLoss()) Print("StopLoss Hit");
Really fast answer, thanks a lot!
  • #4
  • Mar 26, 2010 6:07pm Mar 26, 2010 6:07pm
Forgive my ignorance, how would you implement this code to execute only once at the end of each order?

Many thanks.
Long live dynamic range
  • #5
  • Mar 26, 2010 11:20pm Mar 26, 2010 11:20pm
Hi Ronald,

I am not sure this code would be bulletproof given the potential for slippage at most brokers. Surely it would be quite common for the Close price and the TP to be slightly off?

This may be a bit better :-

if (StringFind( OrderComment(), "[sl]" ) >= 0 ) Print("StopLoss Hit"); ;
if (StringFind( OrderComment(), "[tp]" ) >= 0 ) Print("TakeProfit Hit");
  • #6
  • Edited Mar 27, 2010 1:41am Mar 26, 2010 11:37pm | Edited Mar 27, 2010 1:41am
Quoting Doris
Forgive my ignorance, how would you implement this code to execute only once at the end of each order?

Many thanks.
This should work the way you want.

Inserted Code
 total = OrdersHistoryTotal();
         for(i = total - 1; i >= 0; i--){
         OrderSelect(i, SELECT_BY_POS,MODE_HISTORY);
         if(OrderSymbol() == Symbol()){

if(TimeCurrent() - OrderCloseTime()==1){
if(OrderClosePrice() == OrderTakeProfit()) Print("TakeProfit Hit");
if(OrderClosePrice() == OrderStopLoss()) Print("StopLoss Hit");}}
  • #7
  • Mar 27, 2010 1:33am Mar 27, 2010 1:33am
int
Prev_Orders = -1,
MagicNumber = 460;
//+------------------------------------------------------------------+
//| program start function |
//+------------------------------------------------------------------+
int start()
{
//----
if (Prev_Orders < 0)Prev_Orders = OrdersHistoryTotal(); //we have to start somewhere so set previous orders to history total for first tick
if (OrdersHistoryTotal() > Prev_Orders)Alert(Get_Reason(MagicNumber));//history orders has increased, so an order must have closed>>>>> lets get the reason & do something with it

Prev_Orders = OrdersHistoryTotal(); //record the number of history orders for the next round
//----
return(0);
}
//+------------------------------------------------------------------+
string Get_Reason(int Local_Magic)
{
for(int i=OrdersHistoryTotal()-1;i >= 0;i--){ //loop through orders in reverse order....last one closed should be first up.
if (!OrderSelect(i, SELECT_BY_POS,MODE_TRADES)){ //select the order
Print( "OrderSelect(SELECT_BY_TICKET) - Error #",GetLastError() );//Oops, there is a problem
continue; //move on
}
if (OrderMagicNumber() == Local_Magic){ //is this the order we are interested in?
if (StringFind( OrderComment(), "[sl]" ) >= 0 ) return("StopLoss Hit");//Stoploss comment
if (StringFind( OrderComment(), "[tp]" ) >= 0 ) return("TakeProfit Hit");//TakeProfit comment
if (StringFind( OrderComment(), "[SO]" ) >= 0 ) return("Stopped Out");//Stopped Out Comment
}
}
return("Dunno, not my order or if it was, it was closed some other way"); //Been through the orders and its none of the above 3 reasons
}
  • #8
  • Mar 27, 2010 1:46am Mar 27, 2010 1:46am
Quoting kennyhubbard
Hi Ronald,

I am not sure this code would be bulletproof given the potential for slippage at most brokers. Surely it would be quite common for the Close price and the TP to be slightly off?

This may be a bit better :-

if (StringFind( OrderComment(), "[sl]" ) >= 0 ) Print("StopLoss Hit"); ;
if (StringFind( OrderComment(), "[tp]" ) >= 0 ) Print("TakeProfit Hit");

That's a perfectly viable alternative.

As for how common it is, I guess my broker treats me well. Hasn't happened yet.
  • #9
  • Mar 27, 2010 10:08am Mar 27, 2010 10:08am
Quoting Ronald Raygun
That's a perfectly viable alternative.

As for how common it is, I guess my broker treats me well. Hasn't happened yet.
Actually just noticed that not all brokers append the [sl] or [tp] to the comments, so this is not so reliable either.

Back to you Ronald.......I had a look at some TP trades and there are definite differences between TP and close prices, even if it is 0.1 of a pip, so you gonna have to make provision for that.
  • #10
  • Mar 27, 2010 10:26am Mar 27, 2010 10:26am
Quoting Trad3r
...Was hit by SL or TP? I used to select last order with this code to change the boolean sell or buy to false if the order is closed and allow to open another same order...:

if(sell==true)
if(OrderSelect(OrdersHistoryTotal()-1,SELECT_BY_POS,MODE_HISTORY)==true)
if(OrderTicket()==ticket_sell)
sell=false;

Any suggestions?
if there are only two possibilities: hit by SL or TP, the code should be easier:
PHP Code
if(OrderSelect(OrdersHistoryTotal()-1,SELECT_BY_POS,MODE_HISTORY))
{
  if(OrderType()==OP_BUY)
  {
     if(OrderClosePrice()>OrderStopLoss()) Print("Hit TP");
     else Print("Hit SL");
  }
  else if(OrderType()==OP_SELL)
  {
     if(OrderClosePrice()<OrderStopLoss()) Print("Hit TP");
     else Print("Hit SL");
  }
}
  • #11
  • Mar 27, 2010 10:42am Mar 27, 2010 10:42am
Quoting kennyhubbard
Actually just noticed that not all brokers append the [sl] or [tp] to the comments, so this is not so reliable either.

Back to you Ronald.......I had a look at some TP trades and there are definite differences between TP and close prices, even if it is 0.1 of a pip, so you gonna have to make provision for that.
Orderselect...

if(MathAbs(OrderClosePrice() - OrderTakeProfit()) > MathAbs(OrderClosePrice() - OrderStopLoss())) Print("StopLoss");

if(MathAbs(OrderClosePrice() - OrderTakeProfit()) < MathAbs(OrderClosePrice() - OrderStopLoss())) Print("TakeProfit");


Something like that...
  • #12
  • Mar 27, 2010 11:29am Mar 27, 2010 11:29am
Yup that would do it..........

sangmane's idea would work too although I would check for a OrderClosePrice >= TP as sometimes it is the same and other times it overshoots a bit.

Had a bit of an AHA moment here. looking through several trades, I cannot find a single one where the TP was hit and the price retraced before the fill was complete ie the fill price is ALWAYS equal to or better than the TP. I had never noticed how many extra pips I scored through over-runs(or +'ve slippage) on my TP's. Perhaps some-one else can comment on this and confirm or disprove the theory........

Can't comment on whether the SL fill is the same as I don't have any of those. I also can't comment on whether this is also the same at an instant execution bucketshop as I have stopped using them.
  • #13
  • Mar 27, 2010 11:44am Mar 27, 2010 11:44am
kenny, my idea is that if there are only two possibilities : hit TP or SL, then if price close above SL in a buy order, that we can be sure that it's not SL that closed that order
  • #14
  • Mar 27, 2010 11:55am Mar 27, 2010 11:55am
sangmane, of course you are quite correct......I wasn't paying attention again
  • #15
  • Mar 27, 2010 12:14pm Mar 27, 2010 12:14pm
  • #16
  • Mar 27, 2010 3:51pm Mar 27, 2010 3:51pm
Quoting asgard2
This should work the way you want.

Inserted Code
 total = OrdersHistoryTotal();
         for(i = total - 1; i >= 0; i--){
         OrderSelect(i, SELECT_BY_POS,MODE_HISTORY);
         if(OrderSymbol() == Symbol()){

if(TimeCurrent() - OrderCloseTime()==1){
if(OrderClosePrice() == OrderTakeProfit()) Print("TakeProfit Hit");
if(OrderClosePrice() == OrderStopLoss()) Print("StopLoss Hit");}}
Thanks asgard2, nice solution which works perfectly with this slight alteration...
Inserted Code
if(TimeCurrent() - OrderCloseTime()==0)
Thanks alot!
Long live dynamic range
  • #17
  • Mar 30, 2010 5:25am Mar 30, 2010 5:25am
Quoting Ronald Raygun
OrderSelect(i, SELECT_BY_POS, MODE_HISTORY);

if(OrderClosePrice() == OrderTakeProfit()) Print("TakeProfit Hit");
if(OrderClosePrice() == OrderStopLoss()) Print("StopLoss Hit");
Ronald, I've actually coded this about a half year ago. And I remember I encountered a problem. Sometimes there is slippage and price will not exit exactly at the TP or SL. It could be +/- x pips from the pre-determined exit price.
Request custom Expert Advisor or Indicator: dostapyuk "at" gmail . com
  • #18
  • Mar 30, 2010 7:51am Mar 30, 2010 7:51am
Quoting Oksana17
Ronald, I've actually coded this about a half year ago. And I remember I encountered a problem. Sometimes there is slippage and price will not exit exactly at the TP or SL. It could be +/- x pips from the pre-determined exit price.
We already offered alternatives to the original. Please keep up with the thread!
  • #19
  • Last Post: Jul 23, 2010 2:55pm Jul 23, 2010 2:55pm
can someone tell me where in the Start() function should the last order checking function go ?
0 traders viewing now