scooby-doo BOJ JPY pairs trading robot | Page 390 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading correlation pairs by using the other pairs 843 replies

Export All pairs or selected pairs to .csv with script 3 replies

Pairs of Currency Pairs 4 replies

Trending Pairs / Ranging Pairs 0 replies

Robot trading 120 replies

Attachments: scooby-doo BOJ JPY pairs trading robot
Exit Attachments

scooby-doo BOJ JPY pairs trading robot

  • #7,781
  • Edited 12:48pm Mar 24, 2010 10:00am | Edited 12:48pm
Quoting SteveHopwood
Yes. I have it live an an IBFX account so all the filters are turned on; it is taking trades.

Hello Steve,

first day testing Monica (original not cols). Trades are taken and bot seems to go well.

Looking at code, you've defined iNew3 & iNew4 but then don't see them used in code to take decisions, wonder why.

When Rsi [cc] is calculated ( Use_Rsi_xx), the same named variable is used by each PERIOD, so how these mixed values periods can be checked ? Should not be named as Rsi_M1 [cc] ... Rsi_H1 [cc] ... Rsi_W [cc] ... ? That, if i understand (but my little 2 cells brain is limited), use the higher Rsi [cc] period=true.

Some explanations are welcome.
  • #7,782
  • Mar 24, 2010 10:00am Mar 24, 2010 10:00am
Quoting nubchai
Scooby no I didn't realize that. But I'm running these EAs without closing down for news

Sandy
Not a good idea to be trading on budget days.

You need bigger balls than normal.

Economists/Analysts/Traders are all trying to analyse the budget to see if it is credible or full of holes. This causes allot of market speculation by our friendly hedge funds etc.

Scoobs.
  • #7,783
  • Mar 24, 2010 10:40am Mar 24, 2010 10:40am
Quoting dinofx
Hello Steve,

first day testing Monica . Trades are taken and bot seems to go well.

Looking at code, you've defined iNew3 & iNew4 but then don't see them used in code to take decisions, wonder why.
This is how we dynamically resize an array.

Quote
When Rsi [cc] is calculated ( Use_Rsi_xx), the same named variable is used by each PERIOD, so how these mixed values periods can be checked ? Should not be named as Rsi_M1 [cc] ... Rsi_H1 [cc] ... Rsi_W [cc] ... ? That, if i understand (but my little 2 cells brain is limited), use the higher Rsi [cc] period=true.

Some explanations are welcome.
Rsi[] is an array. I use this specifically to avoid having to individually address different variables when these variables might not be needed because the user has not set the associated boolean to true.

  • #7,784
  • Mar 24, 2010 10:44am Mar 24, 2010 10:44am
I have done some tidying up for Monica - retouched the makeup, given her a hair-do, that sort of thing.

Specifically, I have tidied up the half-close code. There is an additional input - BEP - that adds/subtracts this figure to the break even stop loss at half-close time. If you are testing my latest Boris Schlossberg robots (and if you are not, then you are missing a treat) then you will be familiar with this setting.

  • #7,785
  • Mar 24, 2010 10:45am Mar 24, 2010 10:45am
Quoting SteveHopwood
This is how we dynamically resize an array.


Rsi[] is an array. I use this specifically to avoid having to individually address different variables when these variables might not be needed because the user has not set the associated boolean to true.

You see why coding is not my cup of tea
  • #7,786
  • Mar 24, 2010 10:48am Mar 24, 2010 10:48am
Quoting scooby-doo
Not a good idea to be trading on budget days.

You need bigger balls than normal.

Economists/Analysts/Traders are all trying to analyse the budget to see if it is credible or full of holes. This causes allot of market speculation by our friendly hedge funds etc.

Scoobs.
Well it's demo trading so there's no impact on my wallet. But I understand your point.

Sandy
  • #7,787
  • Mar 24, 2010 11:02am Mar 24, 2010 11:02am
Quoting SteveHopwood
I have done some tidying up for Monica - retouched the makeup, given her a hair-do, that sort of thing.

Specifically, I have tidied up the half-close code. There is an additional input - BEP - that adds/subtracts this figure to the break even stop loss at half-close time. If you are testing my latest Boris Schlossberg robots (and if you are not, then you are missing a treat) then you will be familiar with this setting.

Hey Steve, while your at it

Maybe you can correct;
Inserted Code
": Over sold = ", Rsi_Overbought, ":
add Add;
Inserted Code
if(start_hourm==0 && end_hourm==12 && start_houre==12 && end_houre==24){
   ScreenMessage = StringConcatenate(ScreenMessage, Gap, "EA enabled for 24hr trading ", NL);}
if(start_hourm!=0 || end_hourm!=12 || start_houre!=12 || end_houre!= 24){
   ScreenMessage = StringConcatenate(ScreenMessage, Gap, "AM trade hour start = ", start_hourm, NL);
   ScreenMessage = StringConcatenate(ScreenMessage, Gap, "AM trade hour end = ", end_hourm, NL);
   ScreenMessage = StringConcatenate(ScreenMessage, Gap, "PM trade hour start = ", start_houre, NL);
   ScreenMessage = StringConcatenate(ScreenMessage, Gap, "PM trade hour end = ", end_houre, NL);}
24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not
  • #7,788
  • Mar 24, 2010 11:09am Mar 24, 2010 11:09am
Quoting scooby-doo
Not a good idea to be trading on budget days.

You need bigger balls than normal.

Economists/Analysts/Traders are all trying to analyse the budget to see if it is credible or full of holes. This causes allot of market speculation by our friendly hedge funds etc.

Scoobs.
Scoobs
Will it be safe to run the original tonight or will the dust still be settling
  • #7,789
  • Mar 24, 2010 11:15am Mar 24, 2010 11:15am
Sorry guys. When I loaded Monica onto my live 4 digit crim account, I noticed I had not added the adjustment code for the BEP setting.

If you are one of those to have downloaded in the last few minutes, you need to re-download.

  • #7,790
  • Mar 24, 2010 11:28am Mar 24, 2010 11:28am
Quoting matrixebiz
Hey Steve, while your at it

Maybe you can correct;
Inserted Code
": Over sold = ", Rsi_Overbought, ":
add Add;
[code]
if(start_hourm==0 && end_hourm==12 && start_houre==12 && end_houre==24){...
Done. I would have noticed that display thingy eventually. Possibly.
  • #7,791
  • Mar 24, 2010 11:43am Mar 24, 2010 11:43am
Quoting dryclean
Scoobs
Will it be safe to run the original tonight or will the dust still be settling
It should be ok as London/Europe/USA will be closed.

Scoobs.
  • #7,792
  • Mar 24, 2010 12:11pm Mar 24, 2010 12:11pm
Quoting SteveHopwood
Done. I would have noticed that display thingy eventually. Possibly.
Your zip only has the cols version of Monica not the original version
24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not
  • #7,793
  • Mar 24, 2010 12:46pm Mar 24, 2010 12:46pm
Cheers. I have put that right.

Save you a trip.

Attached File(s)
File Type: mq4 Scooby-doo Monica Rsi Overkill.mq4   41 KB | 275 downloads
  • #7,794
  • Mar 24, 2010 1:47pm Mar 24, 2010 1:47pm
Steve.. what timeframe are you running Monica on? I have been using 1m EURUSD for the past few days but its not been impressive!

Any ideas?
  • #7,795
  • Mar 24, 2010 11:33pm Mar 24, 2010 11:33pm
Hi, Steve, many thanks.

one question, your "MaxSpread" is 120, that's for 5-digit criminal, right? just try to confirm since you take care 4 or 5 digits for those trailing stop, jump stop, etc, but not this MaxSpread.


Quoting SteveHopwood
Cheers. I have put that right.

Save you a trip.

  • #7,796
  • Mar 25, 2010 4:40am Mar 25, 2010 4:40am
Quoting charvo
Hi, Steve, many thanks.

one question, your "MaxSpread" is 120, that's for 5-digit criminal, right? just try to confirm since you take care 4 or 5 digits for those trailing stop, jump stop, etc, but not this MaxSpread.
It does now. That was an oversight. Cheers.

Attached File(s)
File Type: mq4 Scooby-doo Monica Rsi Overkill.mq4   41 KB | 219 downloads
  • #7,797
  • Mar 25, 2010 6:01am Mar 25, 2010 6:01am
The attached defaults to not trading, so bung it on a demo and watch.

I am trying to adapt Max's label printing code so Monica displays the OB/OS/N information in rows and columns.

The UserFeedback and text printing functions are immediately below the general declarations stuff. In the pairs info display loop, I have put in the line of code if (cc == 8) break; This allows the robot to display 9 rows of pair information. This works perfectly.

Remove the break line, recompile and watch the peculiar things that happen. These start to happen as soon as the robot is told to display >9 lines of code.

Could those of you who understand how all this works have a look please, and come up with a fix? This one has me beat.

Attached File(s)
File Type: mq4 Scooby-doo Monica Rsi Overkill cols1.mq4   42 KB | 243 downloads
  • #7,798
  • Mar 25, 2010 8:36am Mar 25, 2010 8:36am
Steve, can you double check the Half Trade close code in the Monica EA to see if it looks ok,

ie; Alert(Symbol(), " MA MACD Combo robot ", OrderType()," part-close failed with error(",err,"): ",Er

Looks like it's called but haven't noticed it triggering.

Thanks
24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not
  • #7,799
  • Mar 25, 2010 9:33am Mar 25, 2010 9:33am
i'm always amazed by those beautiful screen layouts since i am like you feeling it is painful to program. but, hey, why not just copy Max's code for your use?

guess i said something dumb,

Quoting SteveHopwood

I am trying to adapt Max's label printing code so Monica displays the OB/OS/N information in rows and columns.

Could those of you who understand how all this works have a look please, and come up with a fix? This one has me beat.

  • #7,800
  • Mar 25, 2010 9:45am Mar 25, 2010 9:45am
What time frame is best for Monica go on?
3 traders viewing now