scooby-doo BOJ JPY pairs trading robot | Page 381 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading correlation pairs by using the other pairs 843 replies

Export All pairs or selected pairs to .csv with script 3 replies

Pairs of Currency Pairs 4 replies

Trending Pairs / Ranging Pairs 0 replies

Robot trading 120 replies

Attachments: scooby-doo BOJ JPY pairs trading robot
Exit Attachments

scooby-doo BOJ JPY pairs trading robot

  • #7,601
  • Mar 18, 2010 2:01am Mar 18, 2010 2:01am
Quoting tazmaan
Steve,
Can you double check your code on the new 3ema bot? I don't think its getting the 20 period h1 ATR for TP/SL correct.
I just dropped it into action and it immediately took a trade on GU. When I check the h1 ATR20 for GU, it shows 30 pips currently. Which should mean sl is set to 30 pips, tp is set to 60 pips. The trade just opened has a sl of 5.5 pips, and the tp is 11.2. Maybe atr reading on 5 digit criminal is a bit flawed? Not sure.
Thanks for lookin at it
I can see nothing wrong in the code; stops and tp's appear to be correct in the trades on my 5 digit demo.

There is nothing changed in the attached. Added is a display of the AtrPeriod ATR readings the robot is working with, to make checking easier.

Attached File(s)
File Type: mq4 Scooby-doo 3 Ema Rsi auto trading robot.mq4   27 KB | 320 downloads
  • #7,602
  • Edited 2:48am Mar 18, 2010 2:37am | Edited 2:48am
This version fixes a bug that had the robot looking back one bar too few; fix courtesy of peejaywk again.

It also has Asian spelled correctly in the robot's name.

If you get it on in time to re-read the Asian session, press the F3 key and delete the relevant global variables, so the bot can replace them with the correct ones.

Attached File(s)
File Type: mq4 Steve Hopwood's BS Asian session breakout multi-pair.mq4   42 KB | 235 downloads
  • #7,603
  • Mar 18, 2010 3:25am Mar 18, 2010 3:25am
Squished a bug that causes sell trades to trigger Breakout_Pips above the low, rather than below.

Attached File(s)
File Type: mq4 Steve Hopwood's BS Asian session breakout multi-pair.mq4   42 KB | 269 downloads
  • #7,604
  • Mar 18, 2010 3:58am Mar 18, 2010 3:58am
A quick heads-up about the Trend Retracement robot as I have not said much about it.

Its performance on both live and demo accounts plummeted the instant I put it on live, so I took it off the live account.

In the last two weeks, the demo has made steady progress, regained the losses and has added £79 to a £1000 Alpari UK demo at 0.02 lots per trade. So far this week, the profits are £43.

  • #7,605
  • Mar 18, 2010 5:33am Mar 18, 2010 5:33am
Original still keeps pluggin along....

1 sell basket and 1 buys basket for TP last night the buy took 15 min ,so back to normal there. Account almost back to where I was before basket hit SL on 3-9. Best 1 night ever . . . . 48 pips
  • #7,606
  • Mar 18, 2010 5:33am Mar 18, 2010 5:33am
Anyone got a function that tells if last closed order was + or - ?

Cheers

Scoobs.
  • #7,607
  • Mar 18, 2010 6:24am Mar 18, 2010 6:24am
Quoting scooby-doo
Anyone got a function that tells if last closed order was + or - ?

Cheers

Scoobs.
Inserted Code
OrderSelect(OrdersHistoryTotal() - 1, SELECT_BY_POS, MODE_HISTORY);
double price = OrderProfit() ;

if (OrderProfit() > 0) do_something;
if (OrderProfit() < 0) do_something_else;

  • #7,608
  • Mar 18, 2010 7:04am Mar 18, 2010 7:04am
Quoting SteveHopwood
Inserted Code
OrderSelect(OrdersHistoryTotal() - 1, SELECT_BY_POS, MODE_HISTORY);
double price = OrderProfit() ;

if (OrderProfit() > 0) do_something;
if (OrderProfit() < 0) do_something_else;
Thanks Steve

Do I need to put it in a for/loop ?

Scoobs
  • #7,609
  • Mar 18, 2010 7:07am Mar 18, 2010 7:07am
Quoting SteveHopwood
Squished a bug that causes sell trades to trigger Breakout_Pips above the low, rather than below.

I think it is time that Steve added a graphical avatar, so I propose Steve uses this:
Attached Image
  • #7,610
  • Mar 18, 2010 7:11am Mar 18, 2010 7:11am
Quoting scooby-doo
Thanks Steve

Do I need to put it in a for/loop ?

Scoobs
Not if you only want to check the last order in the history tab. Yes, if you need to check earlier trades.

  • #7,611
  • Mar 18, 2010 7:15am Mar 18, 2010 7:15am
Quoting macman
I think it is time that Steve added a graphical avatar, so I propose Steve uses this:
Hehe. I tried. FF will not let me upload animated images for my avatar. Shame; I liked that one.
  • #7,612
  • Mar 18, 2010 9:33am Mar 18, 2010 9:33am
Quoting SteveHopwood
I can see nothing wrong in the code; stops and tp's appear to be correct in the trades on my 5 digit demo.

There is nothing changed in the attached. Added is a display of the AtrPeriod ATR readings the robot is working with, to make checking easier.

Thanks for the onscreen display. However I just dropped the new one on, and it's currently showing the ATR for GU to be .001. No wonder its losing like crazy since last night
  • #7,613
  • Mar 18, 2010 10:26am Mar 18, 2010 10:26am
Quoting SteveHopwood
I can see nothing wrong in the code; stops and tp's appear to be correct in the trades on my 5 digit demo.

There is nothing changed in the attached. Added is a display of the AtrPeriod ATR readings the robot is working with, to make checking easier.

Just had a quick look at the code. I think the problem is occuring because the EA is attached to a lower timeframe than H1. The atr is calculated using chart period:
AtrVal = Get_ATR(symbol, Period(), TpAtrMultiplier);

Therefore if you want to force it to be ATR on H1, then you need to change Period() to PERIOD_H1.
  • #7,614
  • Mar 18, 2010 10:48am Mar 18, 2010 10:48am
Quoting bojia88
Just had a quick look at the code. I think the problem is occuring because the EA is attached to a lower timeframe than H1. The atr is calculated using chart period:
AtrVal = Get_ATR(symbol, Period(), TpAtrMultiplier);

Therefore if you want to force it to be ATR on H1, then you need to change Period() to PERIOD_H1.
'Tis ok. I want users to be able to trade this system on any tf they chose, so the H1 thingy is not enforced in any of the filters, or shouldn't be. If this leads to too small an ATR to be useful, then traders will have to go up a few notches.

Thanks anyway.

  • #7,615
  • Mar 18, 2010 11:12am Mar 18, 2010 11:12am
Quoting SteveHopwood
'Tis ok. I want users to be able to trade this system on any tf they chose, so the H1 thingy is not enforced in any of the filters, or shouldn't be. If this leads to too small an ATR to be useful, then traders will have to go up a few notches.

Thanks anyway.

Agree. Users need put it on H1 chart if he wants SL/TP based on H1 ATR.
  • #7,616
  • Mar 18, 2010 12:07pm Mar 18, 2010 12:07pm
Thanks, I guess I should have taken a peek in the code to see this for myself.
Thought it was hardcoded based on the rules scoobs gave, will know better for next time, thanks for the wake up!
  • #7,617
  • Mar 18, 2010 12:14pm Mar 18, 2010 12:14pm
Quoting SteveHopwood
'Tis ok. I want users to be able to trade this system on any tf they chose, so the H1 thingy is not enforced in any of the filters, or shouldn't be. If this leads to too small an ATR to be useful, then traders will have to go up a few notches.

Thanks anyway.

Steve, the iATR TP and SL calculation is code set for double so why can I not use 0.6? I have to put whole numbers 1, 2, etc. if I put 1.9 it just still uses 1 ??
Thanks
24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not
  • #7,618
  • Mar 18, 2010 12:35pm Mar 18, 2010 12:35pm
Hey Steve, checking the Monica EA you made a little boo-boo and put;

PendingOrderDeleteMins/= 10;

instead of;

PendingOrderPips/= 10;
24 hours in a day – 24 bottles of beer in a case – Coincidence? I think not
  • #7,619
  • Mar 18, 2010 1:22pm Mar 18, 2010 1:22pm
Quoting scooby-doo
Anyone got a ?

Scoobs.
hi Scoob,

i'm still looking about LagRsi and i've found something interesting from Ehlers

see: http://www.forexfactory.com/showthread.php?t=226154
  • #7,620
  • Mar 18, 2010 1:31pm Mar 18, 2010 1:31pm
Quoting SteveHopwood
Inserted Code
OrderSelect(OrdersHistoryTotal() - 1, SELECT_BY_POS, MODE_HISTORY);
double price = OrderProfit() ;

if (OrderProfit() > 0) do_something;
if (OrderProfit() < 0) do_something_else;
That won't work if there are multiple EA's on the account or manual trades, and it won't necessarily get the last order for the currency.

I think you have to do the loop above starting from OrdersHistoryTotal()-1 down, looking for symbol & magic match. And check return value from OrderSelect() for success/failure!
7 traders viewing now