@ ZZBRN
Thanks for your help, mate. Got a bit more code as per your suggestions if you would look at the PM. Cheers!
Thanks for your help, mate. Got a bit more code as per your suggestions if you would look at the PM. Cheers!
scooby-doo BOJ JPY pairs trading robot
- #7,083
- Mar 3, 2010 3:22pm Mar 3, 2010 3:22pm
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
- #7,084
- Mar 3, 2010 3:43pm Mar 3, 2010 3:43pm
- Joined Jul 2009 | Status: Trader | 2,158 Posts
Little bird didn't said on witch side we should be ???
Obviously making allot of dosh along the way.
The problem is that I dont know how big the sell off and buy back will be.
But it should be good fun to watch.
Scoobs.
- #7,085
- Mar 3, 2010 3:50pm Mar 3, 2010 3:50pm
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
- #7,086
- Mar 3, 2010 4:03pm Mar 3, 2010 4:03pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
For any latecomers stuck with any aspect of Original 2.4, octomanoak's latest user guide is in the zip in post one.
Brilliant contribution again, octomanoak. Cheers.
Brilliant contribution again, octomanoak. Cheers.
- #7,090
- Mar 3, 2010 5:11pm Mar 3, 2010 5:11pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Hmmmm. A new one for the Original bot.
Mine just took out a sell basket but also took an extra gj trade (eglobal live cent account), so the basket consists of 2 gj's and one ej. Oh well, it will hit its tp that much more quickly.
Don't you coders all just love mt4?
Mine just took out a sell basket but also took an extra gj trade (eglobal live cent account), so the basket consists of 2 gj's and one ej. Oh well, it will hit its tp that much more quickly.
Don't you coders all just love mt4?
Hmmmm. A new one for the Original bot.
Mine just took out a sell basket but also took an extra gj trade (eglobal live cent account), so the basket consists of 2 gj's and one ej. Oh well, it will hit its tp that much more quickly.
Don't you coders all just love mt4?
I've attached a screenshot of the trades since last week (with comments). I accidentally placed a standard lot trade, which luckily turned out OK. Looking at the statement so far, the trading has been somewhat irregular. The large losing basket pretty much wipes out all the small profits. There are some buy baskets that were missed and a sell basket, where there should've been a buy(I guess this was corrected by steve in his last update, Re: wave 2 trading). I'm keeping a close eye on it, but not sure if I'll let it run unattended yet.
Will keep you guys posted...
- #7,092
- Mar 3, 2010 5:58pm Mar 3, 2010 5:58pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
When I went through to the trading computer a few minutes ago, I found the cause of the rogue extra trade.
The robot had successfully sent the first gj trade, but the ej failed.
A subsequent basket send, timed one minute later, succeeded. I thought that such events would spot that the first trade had been sent, but evidently not. This is a tiny bug that needs looking at.
The robot had successfully sent the first gj trade, but the ej failed.
A subsequent basket send, timed one minute later, succeeded. I thought that such events would spot that the first trade had been sent, but evidently not. This is a tiny bug that needs looking at.
When I went through to the trading computer a few minutes ago, I found the cause of the rogue extra trade.
The robot had successfully sent the first gj trade, but the ej failed.
A subsequent basket send, timed one minute later, succeeded. I thought that such events would spot that the first trade had been sent, but evidently not. This is a tiny bug that needs looking at.
I noticed in the following code you have Sleep interval set to 5000, but your comment says "half a second". I believe 5000 translates to 5 seconds. If you meant half a second, then it should be 500, am I right?
Inserted Code
if (!TradeSent)
{
Sleep(5000);//Half a second to avoid overloading
Tries++;
} Not sure if this was the reason for your error today, but its possible that a sleep time of 5 seconds resulted in the market price to shift more than the allowed slippage.
Worth looking into IMHO.
Thanks,
Jason
EDIT: I take the last statement back.. even if it waits 5 seconds, the price should be the latest since its fetched SendTrade() function.
- #7,094
- Mar 3, 2010 6:28pm Mar 3, 2010 6:28pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Hi Steve,
I noticed in the following code you have Sleep interval set to 5000, but your comment says "half a second". I believe 5000 translates to 5 seconds. If you meant half a second, then it should be 500, am I right?
[code]if (!TradeSent)...
This is not a major bug, so I will not post an update just yet, until I have looked into the cause of the rogue trade.
What probably happened is this: the robot tried 30 times to send the ej trade, then gave up like a good little robot. On a subsequent tick, it found that there was not a complete basket in place but trading conditions were still correct, so it sent the complete basket.
I will sort this out tomorrow and post an update.
- #7,095
- Mar 3, 2010 6:34pm Mar 3, 2010 6:34pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
The first thing I will do is pepper the code with this construct:
to force the robot to wait until the blasted criminal has got out of bed, or the blasted platform has stopped pissing about, or the blasted internet connection has reinstated itself. I have started doing this in my latest bots.
Any other ideas also welcome.
Inserted Code
while (!IsTradeAllowed() )
{
}//while (!IsTradeAllowed() ) Any other ideas also welcome.
