getting last 5 zig zag values | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Zig Zag Expert Advisor Problem 5 replies

Programing the most powerful Zig Zag 3 replies

Zig Zag Help 1 reply

Zig and Zag - anyone tried this indicator? 5 replies

Zig Zag 3 replies

getting last 5 zig zag values

  • #1
  • First Post: Edited 4:02pm Mar 3, 2010 3:22pm | Edited 4:02pm
What I'm trying to do is get the last 5 zig values (both price and time).

I know the basics
Inserted Code
double varZigZag=iCustom(NULL,0,"ZigZag",varExtDepth,varExtDeviation,varExtBackstep,0,varBar);
datetime varDateTime=itime(null,0,varBar);

But I'm trying to figure out how to get the last 5 values. I also need to determine whether they are a high value or low value.

Any ideas?
  • #2
  • Mar 3, 2010 5:07pm Mar 3, 2010 5:07pm
High zigzag values are equal to the price's high.
Low zigzag values are equal to the price's low.

Using a while loop...

Inserted Code
int ZigZagFoundCount = 0;
int ZigZagShift = 0;
double ZigZag1[5];

while(ZigZagFoundCount < 5)
   {
   if(ZigZag(Null, 0, ZigZagShift) == High[ZigZagShift])
      {
      ZigZag[ZigZagFoundCount] = ZigZag(NULL, 0, ZigZagShift);
      ZigZagFoundCount++;
      }
   //do reverse for short
   if(....)
      {
      }
   ZigZagShift++;

   }
  • #3
  • Mar 3, 2010 6:19pm Mar 3, 2010 6:19pm
might have to make a few slight changes, but once made that should work.....

or at least something very similar does for me daily.....h
to trade and code, keep both simple... no call to impress....h
  • #4
  • Last Post: Edited 8:36pm Mar 3, 2010 6:25pm | Edited 8:36pm
et al, Thanks a ton!!!!! Ron, thanks for the code!!! I got it to work. But I can't get it to re-draw the trend lines when the new values from zig zag get formed.

And it doesn't draw right in a backtest. Works fine in 'live' charts.

Any one got any ideas?
Inserted Code
#property indicator_chart_window
#property indicator_buffers 2
extern int varExtDepth=12;
extern int varExtDeviation=5;
extern int varExtBackstep=3;
double ceiling[];
double floor[];
int init()
  {
//---- indicators
   IndicatorBuffers(2);
   IndicatorDigits(Digits);
//---- drawing settings
//---- indicator buffers mapping
   SetIndexBuffer(0,ceiling);
   SetIndexBuffer(1,floor);
   
   SetIndexLabel(0,"Upper band") ;
   SetIndexLabel(1,"Lower band") ;
   
   SetIndexEmptyValue(0,0.0);
   SetIndexEmptyValue(1,0.0);
   ArraySetAsSeries(ceiling,true);
   ArraySetAsSeries(floor,true);
//----
   return(0);
  }
int deinit()
  {
//----
   ObjectDelete("Ceiling"); ObjectDelete("Floor");
//----
   return(0);
  }
int start()
  {
//   int    counted_bars=IndicatorCounted();
//----
   int shift;
   bool varNewBar=funcIsNewBar(Period());
   if (varNewBar)
   {
     ObjectDelete("Ceiling"); ObjectDelete("Floor");
     procDrawTrends();
     for(shift=Bars-1; shift>=0; shift--)
     {
       ceiling[shift]=ObjectGetValueByShift("Ceiling",shift);
       floor[shift]=ObjectGetValueByShift("Floor",shift);
     }      
   }
   return(0);
   }
//+------------------------------------------------------------------+
void procDrawTrends()
   {
   int ZigZagHighCount=0, ZigZagLowCount=0, ZigZagCount=0;
   int ZigZagShift = 0;
   double ZZHigh[2],ZZLow[2];
   datetime ZZHTime[2],ZZLTime[2];
   while(ZigZagHighCount < 3 && ZigZagLowCount < 3)
   {
      double ZigZag=iCustom(NULL,0,"ZigZag",varExtDepth,varExtDeviation,varExtBackstep,0,ZigZagShift);
      if((ZigZag == High[ZigZagShift] || ZigZag == Low[ZigZagShift]) && ZigZagCount==0){ZigZagCount++; ZigZagShift++;}
      else 
      {
         if(ZigZag == High[ZigZagShift])
         {
            ZZHigh[ZigZagHighCount]=ZigZag;
            ZZHTime[ZigZagHighCount]=iTime(NULL,0,ZigZagShift);
            ZigZagHighCount++; ZigZagCount++;
         }
         //do reverse for short
         if(ZigZag == Low[ZigZagShift])
         {
            ZZLow[ZigZagLowCount]=ZigZag;
            ZZLTime[ZigZagHighCount]=iTime(NULL,0,ZigZagShift);
            ZigZagLowCount++; ZigZagCount++;      
         }
      }
      ZigZagShift++;
   } 
   ObjectCreate("Ceiling",OBJ_TREND,0,ZZHTime[1],ZZHigh[1],ZZHTime[0],ZZHigh[0]);
   ObjectCreate("Floor",OBJ_TREND,0,ZZLTime[1],ZZLow[1],ZZLTime[0],ZZLow[0]);
   ObjectSet("Ceiling",OBJPROP_STYLE,STYLE_SOLID);
   ObjectSet("Floor",OBJPROP_STYLE,STYLE_SOLID);
   ObjectSet("Ceiling",OBJPROP_WIDTH,2);
   ObjectSet("Floor",OBJPROP_WIDTH,2);
   ObjectSet("Ceiling",OBJPROP_COLOR,Blue);
   ObjectSet("Floor",OBJPROP_COLOR,Red);
  
//----
   string varMessage,n="n";
   varMessage=StringConcatenate("ZigZagCount: ",ZigZagCount,n,
                                "ZigZagHighCount: ",ZigZagHighCount,n,
                                "ZigZagLowCount: ",ZigZagLowCount,n,
                                "ZZHTime[0]: ",ZZHTime[0],n,
                                "ZZHigh[0]: ",ZZHigh[0],n,
                                "ZZHTime[1]: ",ZZHTime[1],n,
                                "ZZHigh[1]: ",ZZHigh[1],n,
                                "ZZLTime[0]: ",ZZLTime[0],n,
                                "ZZLow[0]: ",ZZLow[0],n,
                                "ZZLTime[1]: ",ZZLTime[1],n,
                                "ZZLow[1]: ",ZZLow[1]);
   Alert(varMessage);                             
   return(0);
  }
  
//+---------------------- support funcion(s) ------------------------+
bool funcIsNewBar(int timeFrame)
   {
   bool res=false;
   
   // the array contains open time of the current (zero) bar
   // for 7 (seven) timeframes
   static datetime _sTime[7];  
   int i=6;
   //Note: i below will be 6 or timeframe will be day.
   switch (timeFrame) 
      {
      case 1  : i=0; break;
      case 5  : i=2; break;
      case 15 : i=3; break;
      case 30 : i=4; break;
      case 60 : i=5; break;
      case 240: break;
      case 1440:break;
      default:  timeFrame = 1440;
      }
//----
   if (_sTime[i]==0 || _sTime[i]!=iTime(Symbol(),timeFrame,0))
      {
      _sTime[i] = iTime(Symbol(),timeFrame,0);
      res=true;
      }
      
//----
   return(res);   
   }
0 traders viewing now