scooby-doo BOJ JPY pairs trading robot
- #6,342
- Feb 18, 2010 2:04pm Feb 18, 2010 2:04pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Please wait for Scoobs to comment before considering releasing 'updates' of his robot. He has strong opinions about how his bot should be used and may well not want different versions in the hands of less experienced people.
Also, the last thing we want is multiple versions of the same robots being released by different people. I have seen this happen in other threads; the result is utter chaos.
What coders do with bots for their own use is different. By the time you get to the stage where you can make these changes, you usually know what you are doing and understand the changed you have made.
Also, the last thing we want is multiple versions of the same robots being released by different people. I have seen this happen in other threads; the result is utter chaos.
What coders do with bots for their own use is different. By the time you get to the stage where you can make these changes, you usually know what you are doing and understand the changed you have made.
- #6,347
- Edited 3:53pm Feb 18, 2010 3:52pm | Edited 3:53pm
Steve,
It should work if you are prepared to continue with the excellent administrative function and post new, developments in a seperate section on page one.
... the last thing we want is multiple versions of the same robots being released by different people. I have seen this happen in other threads; the result is utter chaos.
It should work if you are prepared to continue with the excellent administrative function and post new, developments in a seperate section on page one.
- #6,348
- Edited Feb 19, 2010 4:04am Feb 18, 2010 4:27pm | Edited Feb 19, 2010 4:04am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Please feel free to post your work. No need to wait for my permission.
Scoobs.
In the hope that this will save me answering some questions, here are the new inputs and a brief explanation of their use:
- UseTpAtr=true; use ATR to calculate the take profit and stop loss. If you are not familiar with ATR, please Google it rather than ask basic questions about it in this thread.
- AtrPeriod=14; the default ATR indi period setting
- AtrTpMultiplier=1; multiplies the ATR reading by this figure to arrive at the take profit figure. Some traders like to use ADX to arrive at the multiplier; this is a figure I coded by request.
- AtrTpTf=240; the time frame in minutes to use in the take profit ATR calculation - defaults to H4 on Scoobs' recommendation.
- UseSlAtr=true; use ATR to calculate the take profit
- AtrSlMultiplier=1;
- AtrSlTf=1440; the time frame in minutes to use in the stop loss ATR calculation - defaults to D1 on Scoobs' recommendation..
- EaManagesTrades=true; allows the robot to set a breakeven at open price + ATR (buy) or - ATR (sell) multiplied by half of AtrTpMultiplier.
- Bep=50; the number of pips to add at breakeven - 5 digit criminal. The robot automatically adjusts for 4 digit crims.
In my experience so far, using ATR to calculate the stop has led to fewer large losers. I do not know whether this will continue.
Play with this version and see what you all think.
I have no idea whether this version will have more success than Scoob's original version. We all know that the Scoobs' unmodified wipes out the profits from four winners when it has a loser, but I do not know whether using ATR will make any difference. I have Sccobs' unmodified on my tiny eglobal live test account and have no intention of replacing it just yet.
We shall see.
- #6,352
- Feb 18, 2010 5:28pm Feb 18, 2010 5:28pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Nice, off course I will try!
my idea was some thing more simple
- #6,353
- Feb 18, 2010 5:39pm Feb 18, 2010 5:39pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I am suffering one of my fuzzies.
Coders, please look at the blue highlighted code. It is trying to stop the robot placing stops that are too close to the market to be allowed. I don't want MODE_LOTSTEP; what do I want?
Coders, please look at the blue highlighted code. It is trying to stop the robot placing stops that are too close to the market to be allowed. I don't want MODE_LOTSTEP; what do I want?
Inserted Code
void ManageTrade()
{
OrderSelect(TicketNo, SELECT_BY_TICKET);
if (OrderCloseTime() > 0) return;
double digits = MarketInfo(OrderSymbol(), MODE_DIGITS);
double ask = MarketInfo(OrderSymbol(), MODE_ASK);
double bid = MarketInfo(OrderSymbol(), MODE_BID);
double point = MarketInfo(OrderSymbol(), MODE_POINT);
double AtrValue=iATR(OrderSymbol(),0,AtrPeriod,0);
double BuyTarget = NormalizeDouble(OrderOpenPrice() + AtrValue, digits);
double SellTarget = NormalizeDouble(OrderOpenPrice() - AtrValue, digits);
if (OrderType() == 0 && ask >= BuyTarget && OrderStopLoss() < OrderOpenPrice() )
{
double stop = NormalizeDouble(OrderOpenPrice() + (Bep * point), digits);
[color=RoyalBlue]if (stop - OrderOpenPrice() < MarketInfo(OrderSymbol(), MODE_LOTSTEP) ) stop = OrderOpenPrice();[/color]
bool result = OrderModify(TicketNo, OrderOpenPrice(), stop, OrderTakeProfit(), OrderExpiration(), CLR_NONE);
if (!result)
{
int err=GetLastError();
Alert(OrderSymbol(), " Scoobs 20 EMA Buy SL order modify failed with error(",err,"): ",ErrorDescription(err));
}//if (!result)
}//if (OrderType() == 0)
if (OrderType() == 1 && bid <= BuyTarget && OrderStopLoss() > OrderOpenPrice() )
{
stop = NormalizeDouble(OrderOpenPrice() - (Bep * point), digits);
[color=RoyalBlue] if (OrderOpenPrice() - stop < MarketInfo(OrderSymbol(), MODE_LOTSTEP) ) stop = OrderOpenPrice();[/color]
result = OrderModify(TicketNo, OrderOpenPrice(), stop, OrderTakeProfit(), OrderExpiration(), CLR_NONE);
if (!result)
{
err=GetLastError();
Alert(OrderSymbol(), " Scoobs 20 EMA Sell SL order modify failed with error(",err,"): ",ErrorDescription(err));
}//if (!result)
}//if (OrderType() == 1 && bid <= BuyTarget && OrderStopLoss() > OrderOpenPrice() )
}//void ManageTrade() - #6,356
- Feb 18, 2010 6:28pm Feb 18, 2010 6:28pm
I am suffering one of my fuzzies.
Coders, please look at the blue highlighted code. It is trying to stop the robot placing stops that are too close to the market to be allowed. I don't want MODE_LOTSTEP; what do I want?
[code]void ManageTrade()
{...
Why not take the blue highlighted if condition out completely?
And replace it by something like:
if bid >= OrderOpenPrice + ATRValuexpoint
Ordermodify......
"The only successful substitute for brains is silence."
- #6,357
- Feb 18, 2010 6:29pm Feb 18, 2010 6:29pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
I answered my own question. I wanted MODE_STOPLEVEL.
Updated version in post 6350.
Updated version in post 6350.
- #6,358
- Edited 6:35pm Feb 18, 2010 6:29pm | Edited 6:35pm
- | Joined Nov 2009 | Status: Trader | 1,196 Posts
- #6,360
- Feb 18, 2010 6:32pm Feb 18, 2010 6:32pm
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Steve
You do know that your SL's are huge,
Scoobs
I used ATR * 4 for the stop because I was asked to. No idea if this is good or not. There is an input that allows people to reduce this if they want.