scooby-doo BOJ JPY pairs trading robot

Quoting dinofx

Disliked

i think you have seen my ROI , well today was a stress test for that bot, already done my settings today: m1 then m15 (but most of $$ made on 9gmt / 12 gmt) with LR 10,0,2,12, no sma, no highrsi, no hedge, else as default.

Ignored

Quoting MaMood

Disliked

Hi Jag,

not sure if you are aware of that options in MT4:
Tools/options/Charts: "Max bars in history" and "MAx bars in chart"

From my experience these values are used by MT4 and they are working properly. But of curse you can "overrule" these settings by some code in your EAs or scripts ...

CU,
MaMood

Ignored

Quoting dinofx

Disliked

trades are taken even if comments show "not allowed " for both buy & sell
( highrsi activated)

Ignored

Quoting maxou888

Disliked

In order to fix the init / uninit prob with indic, I tried with another indic from Swingman suggestion (StochasticRSI) and the problem is the same.
So I think the problem don't come from the indic, but rather with our loop from PairToTrade

Ignored

Quoting SteveHopwood

Disliked

That makes sense. Somebody posted code for incorporating the indi code within the robot not far back. It might be worthwhile experimenting with that.

Ignored

Quoting SteveHopwood

Disliked

Once pending trades are sent, the comments will read no trades allowed because no new trades can be sent. Slightly confusing unless you are the coder.

Ignored

Quoting maxou888

Disliked

that seems work, displalyed values of rsi in mode 1 are the same.
Hope the shift is working

Ignored

//+------------------------------------------------------------------+
//| CalculateDailyRange      Average Daily Range                     |
//+------------------------------------------------------------------+
double ADR(string symbol)
{
double    Risk_to_Reward_ratio =  3.0;
double    R1=0,R5=0,R10=0,R20=0,RAvg=0,DynamicRAvg=0;
int       RoomUp=0,RoomDown=0,StopLoss_Long=0,StopLoss_Short=0;
double    SL_Long=0,SL_Short=0;
double    low0=0,high0=0;
    double     digits = MarketInfo(symbol, MODE_DIGITS);
      double     [color=Blue] [b]point[/b][/color] = MarketInfo(symbol, MODE_POINT);

[color=Black]   //if(digits==3 || digits==5) {vpoint=10*point;}
   //else                       {vpoint=point;}[/color]

   int i=0;
   R1 =  (iHigh(symbol,PERIOD_D1,1)-iLow(symbol,PERIOD_D1,1))/[b][color=Blue]vpoint[/color][/b];

Quoting SwingMan

Disliked

To avoid zero divisions, I sugested you can use the "point" variable instead "vpoint" in the ADR function:

[code]
//+------------------------------------------------------------------+
//| CalculateDailyRange...

Ignored

Quoting maxou888

Disliked

Hi swingman,

Are you sure ? I didn't write this function ADr, so I do not want too much modify it. But if you test this modification and be sure it's OK, I will incorporate it. Let me know

Ignored

Quoting dinofx

Disliked

as each pair have a specific dynamic volatility, i'm thinking to customize RsiPeriod but it need to be an external parameter ( default rsi(2) can be well in some circumtances and not so good in others)

Ignored

Quoting scooby-doo

Disliked

You need to base it on the ADR of each pair.

Currencies with a high daily range need a higher RSI(x). Also when a currency is in its most active period then it needs to be set higher.

Scoobs.

Ignored

Quoting dinofx

Disliked

as each pair have a specific dynamic volatility, i'm thinking to customize RsiPeriod but it need to be an external parameter ( default rsi(2) can be well in some circumtances and not so good in others)

Ignored

Quoting SteveHopwood

Disliked

Done and uploaded to post 1. The inputs should be obvious.

Ignored