Stoch EA need help | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help with stoch indicator 0 replies

Stoch Alert color coding help please 0 replies

Help needed with Stoch indi - please? 1 reply

Need Developer Help, Fix Great Stoch Indicator, Compensation? 5 replies

Help with Alerts by Stoch-MACD Indicator 0 replies

Attachments: Stoch EA need help
Exit Attachments

Stoch EA need help

  • #1
  • First Post: Jan 29, 2010 3:52am Jan 29, 2010 3:52am
Hi
I've been testing this simple EA and it works really well, but I have a few ideas to add to it. Im not good at coding, so I would apreciate if someone could add a few things:

- EA to close open trade on a cross of D period stochastic and level... (for Long TP = cross D perid stoch 80 level, Short TP = cross D perid stoch 20 level, for example...but I'd like to be able to choose the #)

-add max number of open trades

-add magic number

Thank you for your help.

This is the link to the original post and the EA:
http://www.forexfactory.com/showthread.php?t=161982
  • #2
  • Jan 29, 2010 11:44am Jan 29, 2010 11:44am
Don't know about the first part, but I added a Max_Trade option and magic number options. The Max_Trade option should work so long as it opens only one order at a time and not a Buy and Sell simultaneously. I added the magic number options as well, but there were already preexisting magic numbers. I don't know what they were about? There didn't appear to be anything associated with them, so I went ahead and made them user-definable. If you leave either one set at 0, it will assign the previous magic numbers.

Maybe this is all you needed to know, was their values?
Attached File(s)
File Type: mq4 Stochastic Cross 833 v0.1_01.mq4   4 KB | 408 downloads
  • #3
  • Jan 30, 2010 5:20pm Jan 30, 2010 5:20pm
Hi
Thank you so much for your help with this EA.
Could anybody add the following logic to this EA:

-if in buy & (dline > 80.0) & (Auto TP = true) ,close buy order [work as a TP ]

-if in buy & (Kline< 20.0) & (Auto SL = true) close buy order [work as a SL] tell EA to wait for the stoch to cross (close candle) above 20.0 to activate this SL
- if in sell & (dline < 20.0) & (Auto TP= true) close sell order [work as a TP]

- if in sell & (Kline< 80.0) & (Auto SL = true) close buy order [work as a SL] tell EA to wait for the stoch to cross (close candle) under 80.0 to activate this SL

levels could be set in the settings like:
Auto TP = true (if true use the following levels)
Buy order TP at level = 80
Sell order TP at elev = 20
Auto SL = true (if true use the following levels)
Buy order SL at level = 20
Sell order SL at level = 80
Regular SL and TP should be use as a backup (max SL and Max TP).
  • #4
  • Jan 30, 2010 7:45pm Jan 30, 2010 7:45pm
Yeah, sorry I couldn't help you out with this part here. I am not familiar enough with it. The other stuff, yeah, I work with it quite a bit. Which is why it was enough to fix. If I get a chance, maybe I'll look into to it later? as I do need to learn to work with it at some point.
  • #5
  • Jan 31, 2010 12:21am Jan 31, 2010 12:21am
Okay, I just added this code here:

PHP Code
   Total=OrdersTotal(); cnt2=0;
   for(cnt2=Total-1; cnt2>=0; cnt2--)
   {
      if(OrderSelect(cnt2,SELECT_BY_POS,MODE_TRADES)==true)
      {
         if(OrderType()==OP_BUY){
         if(dline[?] > 80.0 || kline[?] < 20.0){
         OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,Magenta); } }
         if(OrderType()==OP_SELL){
         if(dline[?] < 20.0 || kline[?] < 80.0){
         OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),3,Magenta); } }
      }
   }
I think it might be close to what you are asking for. It's supposed to "automatically" close the orders once the criteria is met. However, there needs to be a number (integer) specified within the brackets after the variables "dline" and "kline." Should that be a "1?" ... I don't know?

Also, one of your "<" or ">" signs appears to be incorrect. So, you might want to go back and double-check.
Attached File(s)
File Type: mq4 Stochastic Cross 833 v0.1_02.mq4   4 KB | 371 downloads
  • #6
  • Jan 31, 2010 3:00am Jan 31, 2010 3:00am
Would you mind checking this code? I tried to add adjustable levels for automatic TP and SL in the setting so I can quickly optimize the EA, but something is wrong (with my skils) and I can not compile it. What am I missing?
Thank you again.
Attached File(s)
File Type: mq4 Stochastic Cross 833 v0.1_03.mq4   5 KB | 382 downloads
  • #7
  • Edited 7:14pm Jan 31, 2010 4:09am | Edited 7:14pm
Okay, I see what you're trying to do is make the variables adjustable ... well, at least I got it to compile anyway. If you have assigned all the correct values, then it should work.

Also, did you check to make sure your "<" and ">" signs are correct? If this were a simple order, without any references to an indicator, I would say the "<" in the last option (Sell SL) is incorrect. But, then again, I don't know enough about the Stochastic indicator to be certain.


ETA: Please note modification I made to EA two posts below. Should be "<" sign in Buy SL option instead.
Attached File(s)
File Type: mq4 Stochastic Cross 833 v0.1_04.mq4   4 KB | 406 downloads
  • #8
  • Jan 31, 2010 4:53am Jan 31, 2010 4:53am
Hey, I just tried backtesting this and something is definitely wrong. It keeps placing orders one after the other, and kills the account in no time at all.

You might want to see if someone who knows a little bit more about it can help you out?
  • #9
  • Edited 6:27am Jan 31, 2010 5:20am | Edited 6:27am
Okay, apparently the "<" sign in the Buy SL option was incorrect. After changing this, at least it places orders without going nuts. I also tried changing the signs in all four options, in every possible way I could think, and it only works the way it's set up currently. So, my guess is that this is correct. I have also modified the EA to reflect this.

Now, whether the EA works the way it's supposed to, I couldn't say? If it does, then please let me know. I may find a use for it myself.

Thanks.

ETA: No, it doesn't appear to work. It only closes the orders at the predefined Take Profit and Stop Loss values. Sorry.
  • #10
  • Jan 31, 2010 3:09pm Jan 31, 2010 3:09pm
Hi ecTrade
Thanks again!
You are right that the "<" sign in the sell SL option was incorrect. Kline in sell order needs to be > than 80 level (sell_S_level) to make sense.
Market opens in one hour, I will be testing on demo and I hope it will do what we would like it to do. How did you test that it closes open trades only on SL and TP ?

Thanks
  • #11
  • Jan 31, 2010 7:05pm Jan 31, 2010 7:05pm
Quoting paralotnik
Hi ecTrade
Thanks again!
You are right that the "<" sign in the sell SL option was incorrect. Kline in sell order needs to be > than 80 level (sell_S_level) to make sense.
However, like I said (two posts later), it appeared to be the "<" sign in the Buy SL option that was incorrect. Or, at least when I fixed it, it appeared to open up Buy and Sell trades when it was supposed to.

Of course it doesn't explain why it tried to open a bunch of trades all at once. I'm wondering if maybe the Max_Trades function is not working?

Quote
Market opens in one hour, I will be testing on demo and I hope it will do what we would like it to do.
Good luck!

Quote
How did you test that it closes open trades only on SL and TP ?

Thanks
I set the preexisting SL and TP variables up to 1,000, figuring if the "'Auto Close" is supposed to kick in, it would do so long before that. But, nothing happened.

Also, if you are expecting it to close beyond these values, they shouldn't be there or, set quite so low. Because it will always close if it reaches these first. Or, possibly you have the values on the Auto Close feature set too high?
  • #12
  • Jan 31, 2010 7:16pm Jan 31, 2010 7:16pm
Hi
Could someone figure out how to fix these problems, please...
Problem:
1. EA enters into a trade after cross of K-line and D-line and crossing level 80 or 20 (depends on if sell or buy) (this works great) but is not waiting for the crossing candle to close to activate SL (when this candle crosses up and down a couple times through this level, it results in opening and closing trades losing spread or more!
2. EA does not clos trades that cross the TP level (ie. when in buy should close when D-line cross above 80, or in a sell when D-line crosses the 20 level)
2. EA does not trade if there are any open trades on the same pair even with max number of trades set to 5

I feel like we are very close to making this EA prfitable s please if someone knows how to fix it--help, please...
Attached File(s)
File Type: mq4 Stochastic Cross 833 v0.1_04.mq4   4 KB | 433 downloads
  • #13
  • Edited 7:51pm Jan 31, 2010 7:40pm | Edited 7:51pm
Or, maybe it's supposed to attempt to open a bunch of trades all at once which, is only limited by the Max_Trade option? If so, that tells me the Max_Trade is not working, and the other variables and/or "<" or ">" signs (in Auto Close) are incorrect.

If I knew more about how the Stochastic works, I would have a better idea on how to fix it. I guess I will know though, once we get it operational.

Like you, I think it would be great to see how it works when it's fully functional.
  • #14
  • Feb 1, 2010 8:09pm Feb 1, 2010 8:09pm
Hi ecTrade
I found another stoch EA that has some type of auto TP and SL maybe you could see if you can figure out how they coded it and apply it to our EA? I hope we can get this thing to work soon. Thanks
Attached File(s)
File Type: mq4 Double MTF Stochs EA.mq4   10 KB | 467 downloads
  • #15
  • Feb 1, 2010 8:26pm Feb 1, 2010 8:26pm
Yeah, I can take a look at it. I'm not sure when though ... probably sometime tomorrow.
  • #16
  • Feb 4, 2010 6:51am Feb 4, 2010 6:51am
Well, I took a look, and it's really not making much sense. Sorry. Even if I could find these "automatic" settings, they're not using the same variables. This is where the problem lies. I don't understand the Stochastic oscillator well enough in general, to know what to do with them. If I wasn't quite so busy, maybe I could look into it further.

This is what I'm working on currently. You might be interested in taking a look. The most current updated files are in this post here.
  • #17
  • Feb 8, 2010 1:27pm Feb 8, 2010 1:27pm
Hi ecTrade
Could you tell me how to add to this EA no trades hours like (3 adjustable NO trade zone):
No trade 1:
Stop trade GMT: 3:00
Start trade GMT: 4:00
No trade 2:
Stop trade GMT: 5:00
Start trade GMT: 6:00
No trade 3:
Stop trade GMT: 10:00
Start trade GMT: 11:00

Thank you so much for all your help
  • #18
  • Feb 8, 2010 2:38pm Feb 8, 2010 2:38pm
Quoting paralotnik
Hi ecTrade
Could you tell me how to add to this EA no trades hours like (3 adjustable NO trade zone):
No trade 1:
Stop trade GMT: 3:00
Start trade GMT: 4:00
No trade 2:
Stop trade GMT: 5:00
Start trade GMT: 6:00
No trade 3:
Stop trade GMT: 10:00
Start trade GMT: 11:00

Thank you so much for all your help
Sorry, but I haven't worked with dates that much. I doesn't sound like it's terribly complicated though. I'm sure somebody else should be able to help.

Or, if I do take a shot, you can start by telling me the difference between your time zone and GMT time and, which is greater? I think that's probably half the battle right there.
  • #19
  • Feb 8, 2010 4:12pm Feb 8, 2010 4:12pm
Hi ecTrade
I found this post with a code to auto detect GMT offset,
http://www.forexfactory.com/showthread.php?p=3394978
Maybe we could base the time calculations on this code?
I'm in EST (US) but I use brokers with 0GMT nad +2GMT
Thanks
  • #20
  • Last Post: Feb 10, 2010 4:51am Feb 10, 2010 4:51am
Hi
I just added off time option to this EA and it compiled fine, but EA is not opening any trades. Could someone check the code and fix it, please.
Thank you.
Attached File(s)
File Type: mq4 Stochastic Cross 833 v0.1_01_time off.mq4   4 KB | 409 downloads
0 traders viewing now