Need Developer Help, Fix Great Stoch Indicator, Compensation?

Two problems:

1. Email alert is not working

2. Signals at the end of each bar instead of just signal bar

Thanks in advance for any help!
LCT

hi lct,

email alert isn't working because that NewBar() in "if (SendAnEmail && NewBar()) " will always return false.

look at this NewBar() function:

bool NewBar()
{
static datetime lastbar;
datetime curbar=Time[0];
if(lastbar!=curbar)
{
lastbar=curbar;
return(true);
}
else
{
return(false);
}
}

you shouldn't call NewBar() more than once in a single start() function, because once called, curbar will be assigned to lastbar variable (lastbar=curbar), so that at the second call, this condition ( if (lastbar!=curbar) ) will be false.

to solve this problem, you could modify the code as follow:
1. assign bool xNewBar = NewBar() before loop

bool xNewBar=NewBar(); //put here
for(i=0; i<=limit; i++)
....
...

then change
if (AlertOn && NewBar()) to if (AlertOn && xNewBar)
and
if (SendAnEmail && NewBar()) to if (SendAnEmail && xNewBar)

it should do the trick

regards

Thanks for the help! That seems to be working.

Although when I loaded it up the alert window had about 30 signals from the past and I received an email/text for everyone! Anyway to avoid this when opening up the indicator?

Thanks again!

Still seem to be getting a signal after every bar. I attached the updated code, not sure if I entered it correctly.


Thanks,
LCT

hi,

the correction that i suggested is for solve the problem number 1 (email alert is not working.

about alert that show up after every bar, let's see if i can solve it.

be right back..

---------
mods attached

Thanks so much! Seems to be working.

How long have you been coding? What do you trade?