Brilliant Stuff Scoobs and Steve
Original - In and out (TP) in 4 minutes
Many Thanks,
drxyber
scooby-doo BOJ JPY pairs trading robot
- #4,721
- Jan 19, 2010 3:04am Jan 19, 2010 3:04am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
- #4,722
- Jan 19, 2010 3:20am Jan 19, 2010 3:20am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
- camvcvoo's lot size error: I had forgotten to add the line of code that sets a (minimum acceptable lot size * 2) lot size if the calculated one is too small. I had remembered this in the hedging routine; that is why I thought I had coded the function. The double multiplier is so the hedge can be 50% of the original.
- xicecube's invalid price error: this resulted from a faulty conversion of the function from a single to a multi-pair capacity function. Constants such as Point and Digit have to be converted into variables using the MarketInfo call, and I had forgotten to do so.
Essential download with the fixes in post 1.
I am going to spend an hour reading the code to see if there are any other instances of influence-inspired blunders, but traders should not wait to download if they want the bot to take accurate trades.
- #4,723
- Jan 19, 2010 3:34am Jan 19, 2010 3:34am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Scoobs, what should Dog's Bollocks Period setting be? At the mo, it is 5.
- #4,724
- Jan 19, 2010 3:39am Jan 19, 2010 3:39am
- Joined Jul 2009 | Status: Trader | 2,158 Posts
Scoobs, what should Dog's Bollocks Period setting be? At the mo, it is 5.
But this will mean potentially more DD before trades show a profit.
Basically the safer you want it the higher the RSI but with less trades.
- #4,726
- Jan 19, 2010 3:54am Jan 19, 2010 3:54am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Should be 2 which will mean more trades.
But this will mean potentially more DD before trades show a profit.
Basically the safer you want it the higher the RSI but with less trades.
In light of this, I have made the rsi period a user input. Raise the number of trades and potential dd with the RsiPeriod input. It defaults to 5 as this seems to be doing ok. It aint bust so I don't propose fixing it. I recommend people leave it alone unless you know what you are doing.
I have read through the code and added a couple of lines to make sure the hedging function does not look at closed trades. I found nothing else.
With any luck, the latest version is the final one. We shall see.
- #4,729
- Jan 19, 2010 5:30am Jan 19, 2010 5:30am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Sorry guys. The DB required its first hedge and this threw up another bug. The download in post 1 is essential for those of you wanting to use hedging.
I added one more input - ShowPositionOnly. This one is for those like me, whose trading computer sits on its own doing nothing but testing/trading robots, and who monitor the positions from a different machine. Set this to true and it will show the open position only; it will not trade, or act upon the position in any way.
I added one more input - ShowPositionOnly. This one is for those like me, whose trading computer sits on its own doing nothing but testing/trading robots, and who monitor the positions from a different machine. Set this to true and it will show the open position only; it will not trade, or act upon the position in any way.
- #4,730
- Jan 19, 2010 5:31am Jan 19, 2010 5:31am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
HI Steve
I know you are looking at DB codes, just in case you missed this one I am getting the following warning:
"GBPJPYFXFHedge 0 order send failed with error(4107): invalid price parameter for trade function:
The strange thing is that at present there is no open trade for GBPJPY!
Kind Regards
- #4,732
- Jan 19, 2010 5:51am Jan 19, 2010 5:51am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Latest DB update up and running with no problems now on Alpari UK.
Woohoo! You're the man Steve!
Famous last words again, probably.
- #4,734
- Jan 19, 2010 6:36am Jan 19, 2010 6:36am
- | Joined Nov 2009 | Status: Trader | 1,196 Posts
Cheers astral77. I got the same error for the same reason. See my previous - our posts crossed in the ether.
Kind regards
- #4,735
- Jan 19, 2010 7:17am Jan 19, 2010 7:17am
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
- #4,736
- Jan 19, 2010 7:22am Jan 19, 2010 7:22am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Steve, just a quick question about the OP Bot and the basket closure Take Profit settings.
On my demo, I've noticed the basket has been well above the TP target several times (not complaining about that) but the bot hasn't closed the basket and taken the profit.
Should it close at the TP target, or have you cleverly set the bot to stay open and take as much profit as possible over and above the targeted TP?
(see pic attached)
When at or past the tp, the robot will close the trades once the RS reading is heading into opposite territory, to maximise the gains. It remains to be seen how successful this is. We shall see.
- #4,737
- Jan 19, 2010 7:25am Jan 19, 2010 7:25am
- | Commercial User | Joined Apr 2007 | 8,331 Posts
Steve
Thanks for all the hard work you are doing
In the last Scooby zip file there are 2 opposites
opposites and opposites v1.
Also The Don't use LIVE feature is still active in only the 24 bot and the opposites Would you consider removing the NO LIVE feature
we're all big boys here if all are notified should be no problamo
Will do later on, and will post to let you know.
- #4,738
- Jan 19, 2010 7:26am Jan 19, 2010 7:26am
Hehe. Thanks. Took a while, but I think we got there.
Famous last words again, probably.
Cheers,
Ed
- #4,740
- Jan 19, 2010 7:39am Jan 19, 2010 7:39am
- Joined Oct 2008 | Status: Sailing for pips | 2,099 Posts
Explained in a recent post. Not sure where, but not long ago.
Will do later on, and will post to let you know.
I had to look dafter up
daft (dhttp://img.tfd.com/hm/GIF/abreve.gifft)
adj. daft·er, daft·est 1. Mad; crazy.
2. Foolish; stupid.
3. Scots Frolicsome.
[Middle English dafte, foolish, from Old English gedæfte, meek.]
dafthttp://img.tfd.com/hm/GIF/prime.gifly adv.
dafthttp://img.tfd.com/hm/GIF/prime.gifness n.