scooby-doo BOJ JPY pairs trading robot | Page 235 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading correlation pairs by using the other pairs 843 replies

Export All pairs or selected pairs to .csv with script 3 replies

Pairs of Currency Pairs 4 replies

Trending Pairs / Ranging Pairs 0 replies

Robot trading 120 replies

Attachments: scooby-doo BOJ JPY pairs trading robot
Exit Attachments

scooby-doo BOJ JPY pairs trading robot

  • #4,681
  • Jan 18, 2010 1:27pm Jan 18, 2010 1:27pm
I have some good demo trades today. A DB basket closed and an open trade in profit. RS hedging has protected some from turning into stop-hitting losers and closed out at a profit overall. One Simple hitting its tp and an open trade nicely in profit.

Looking good, all this.

  • #4,682
  • Jan 18, 2010 1:28pm Jan 18, 2010 1:28pm
Quoting fxshadow
Steve,

Just wondering if the max trades allowed on the DB bot included hedge trades? Might be better if that wasn't the case.
Looking into this right now. I needed to solve the recurring trades thingy first.

  • #4,683
  • Jan 18, 2010 1:36pm Jan 18, 2010 1:36pm
Quoting fxshadow
Steve,

Just wondering if the max trades allowed on the DB bot included hedge trades? Might be better if that wasn't the case.
It did, but doesn't now. The latest update to post 1 separates Main from Hedge trades in calculating the number of trades open. The MaxTradesAllowed should only respond to open Main trades, not any hedges.

  • #4,684
  • Jan 18, 2010 1:54pm Jan 18, 2010 1:54pm
Hi, long time lurker. Trader for fun, coder (20+ years) to allow meals and shelter.

First, thanks to Scoobs and Steve for tireless effort. Been great fun following this thread.

Some possible bugs in DB...

*NoOfPairs doesn't appear to get reset to 0 in CalculatePairsPassed(). Reloads can result in incorrect pair count.

*A bit confused on the hedging. It appears to be hedging using Symbol()/Bid/Ask rather than OrderSymbol() and MarketInfo Bid/Ask for the currently selected order. That doesn't seem correct, but I may not be fully understanding how the hedge should work. I'll gladly crawl back under my rock.
  • #4,685
  • Jan 18, 2010 2:26pm Jan 18, 2010 2:26pm
After reading about everyone's DB bot launching trades, I'm wondering if I have a problem, as I have been running it over 10 hours now and have seen no trades.

Here's my set:

GVI=-----General trade inputs-----
PairsToTrade=EURAUD,EURCAD,EURCHF,EURGBP,EURJPY,EURNZD,EURUSD,AUDJPY,CADJPY,CHFJPY,GBPJPY,NZDJPY,USDJPY,AUDUSD,EURUSD,GBPUSD,NZDUSD,USDCAD,USDCHF
Lot=0.01000000
RobotCalculatesLotSize=1
LotDivisor=100000
OverBought=70
OverSold=30
StopLoss=500.00000000
HedgeNotStopLoss=1
BreakEvenProfitPercent=0.10000000
TakeProfit=500.00000000
BasketClosurePercentage=1.25000000
MagicNumber=666789
TradeComment=Dog's Bollocks
MaxTradesAllowed=7
CriminalIsECN=0
MinChannelDepth=600
wei=----Week ending inputs----
FridayClose=1
SaturdayClose=0
CloseHour=12
oae=----Odds and ends----
ShowPairsInformation=1
DisplayGapSize=30

And I've included a screen shot of it running. And yes, this is the latest version that Steve posted about 1/2 hour ago. Do you see all those entries with no pair listed in the screen? A bug, perhaps?

Cheers,
Ed
Attached Image (click to enlarge)
Click to Enlarge Name: DBscreen.PNG Size: 195 KB
  • #4,686
  • Jan 18, 2010 2:46pm Jan 18, 2010 2:46pm
OK. I have something. The Experts Log is showing a recurring error while running the DB ea:

"symbol name for MarketInfo function must be a string."

I have not changed timeframes when running this ea. I simply load in an H1 chart, launch the robot, and then watch.

Attached is a screenshot.

Cheers,
Ed
Attached Image (click to enlarge)
Click to Enlarge Name: DBscreen2.PNG Size: 190 KB
  • #4,687
  • Jan 18, 2010 2:48pm Jan 18, 2010 2:48pm
just restart your platform and don't touch it
  • #4,688
  • Jan 18, 2010 2:54pm Jan 18, 2010 2:54pm
Now I am really confused. I closed the chart with the ReconnectEA running, closed the chart with the DB ea running, restarted the terminal, opened up only the GY H1 chart, started the DB ea, and the left everything else alone.

It appears to me there might be some kind of interaction between the ReconnectEA and the DB ea, as the DB ea now appears to be functioning OK.

Go figure...
Attached Image (click to enlarge)
Click to Enlarge Name: DBscreen3.PNG Size: 156 KB
  • #4,689
  • Jan 18, 2010 2:55pm Jan 18, 2010 2:55pm
Quoting awk
just restart your platform and don't touch it
That's what I did when I downloaded the most recent version.

Well, anyway, we're running again. Oh, the mysteries of life! (smile) Now if it will make a trade or two so I can see it working in action.
And, on my second computer I've relaunched both charts mentioned above, one with the DB and one with the ReconnectEA to see if, indeed, there's any interaction. Will report back later.

Thanks,
Ed
  • #4,690
  • Jan 18, 2010 3:11pm Jan 18, 2010 3:11pm
Quoting enewbold
That's what I did when I downloaded the most recent version.

Well, anyway, we're running again. Oh, the mysteries of life! (smile) Now if it will make a trade or two so I can see it working in action.
And, on my second computer I've relaunched both charts mentioned above, one with the DB and one with the ReconnectEA to see if, indeed, there's any interaction. Will report back later.

Thanks,
Ed
Is there any reason you have E/U listed twice as pairs to trade?
  • #4,691
  • Jan 18, 2010 4:02pm Jan 18, 2010 4:02pm
Quoting fxshadow
Is there any reason you have E/U listed twice as pairs to trade?
Those are the defaults listed:

EURAUD,EURCAD,EURCHF,EURGBP,EURJPY,EURNZD,EURUSD,AUDJPY,CADJPY,CHFJPY,GBPJPY,NZDJPY,USDJPY,AUDUSD,EURUSD,GBPUSD,NZDUSD,USDCAD,USDCHF

I'm going into the code and delete the second one, then recompile. Thanks for the tip.

Cheers,
Ed
  • #4,692
  • Jan 18, 2010 4:29pm Jan 18, 2010 4:29pm
Quoting enewbold
That's what I did when I downloaded the most recent version.

Well, anyway, we're running again. Oh, the mysteries of life! (smile) Now if it will make a trade or two so I can see it working in action.
And, on my second computer I've relaunched both charts mentioned above, one with the DB and one with the ReconnectEA to see if, indeed, there's any interaction. Will report back later.

Thanks,
Ed
Hi Ed,

Thanks for guiding me to this great thread.

I've experienced exactly the same as you - no trades and the Marketinfo messages. I'm having a look though the code to see if I can spot anything.

Until then, my instance of the Dogs Diddleys remains castrated.

Cheers,
Nick.
  • #4,693
  • Jan 18, 2010 4:35pm Jan 18, 2010 4:35pm
Alright guys yet another bug report.

USDJPY was correctly triggered,but right after it it was trying to be hedged by EURUSD. The loss of the trade was still too small. Also the hedges was closed and reopened infinitelly. Steve?
  • #4,694
  • Jan 18, 2010 4:52pm Jan 18, 2010 4:52pm
The marketinfo bug and the strange screen display are the result of turning the ShowPairsInformation input on and off.

I had assumed that accessing a running robot's input window would cause the robot to restart completely. This turns out not to be true - the original inputs are not re-accessed.

There is a fix in post 1. For the coders or the brave, instead of downloading the fixed version, go to init() and add the blue coloured line to the code, then recompile (press the F5 key):

//Extract the pairs traded by the user
// Cleanup first
NoOfPairs=0;
 InputString=PairsToTrade;
CleanUpInputString();

Go on, non-coders. Be brave and try it, then feel smug when it works.

_______________________________________________________________________________________________________

On a harsher note, anybody unable to work out how duplicate pairs snuck into the PairsToTrade inputs hasn't been reading my posts and those of scoobs. Frankly, if you can't even be bothered to read these posts, then you deserve every problem you suffer. Ok, so there was only one brief exchange about trading pairs, but they held everything we need to know and I don't expect to have to bludgeon people over the head with info. I spend a LOT of time coding this stuff; the least people here can do is read my posts with a modicum of attention.

Use your brains, guys, or leave forex forever. Only idiots trade robots whose use they do not understand.

Tell you what; there is a warm round of applause awaiting the first individual brave enough to state the reason for these duplicate pairs appearing in the inputs list. No mockery and scorn for failed attempts, I promise.


  • #4,695
  • Jan 18, 2010 4:55pm Jan 18, 2010 4:55pm
Quoting awk
Alright guys yet another bug report.

USDJPY was correctly triggered,but right after it it was trying to be hedged by EURUSD. The loss of the trade was still too small. Also the hedges was closed and reopened infinitelly. Steve?
Looking into it.

  • #4,696
  • Jan 18, 2010 4:59pm Jan 18, 2010 4:59pm
Quoting awk
Alright guys yet another bug report.

USDJPY was correctly triggered,but right after it it was trying to be hedged by EURUSD. The loss of the trade was still too small. Also the hedges was closed and reopened infinitelly. Steve?
I can say one thing immediately. The orphan hedge closing routine is working properly.

The robot is opening an incorrect hedge. Then it spots the 'orphan' and closes it. What a well-behaved little bot.
  • #4,697
  • Jan 18, 2010 5:06pm Jan 18, 2010 5:06pm
Thanks Scooby and Steve for all your valuable info, ea's and help. On DB the 60min rsi is not displaying (show 0 value) on the info screen. Don't know if this will affect the running of the ea. Steve, when you got a minute can you have a look at it. Screen shot attached.

Thanks
Attached Image (click to enlarge)
Click to Enlarge Name: db no usd-cad midtf rsi.gif Size: 23 KB
  • #4,698
  • Jan 18, 2010 5:07pm Jan 18, 2010 5:07pm
Quoting SteveHopwood

Tell you what; there is a warm round of applause awaiting the first individual brave enough to state the reason for these duplicate pairs appearing in the inputs list. No mockery and scorn for failed attempts, I promise.
Let's try this: You list all available EUR pairs first, then all the JPY, then all the USD. That means that EURJPY, EURUSD and USDJPY are listed twice.
  • #4,699
  • Jan 18, 2010 5:08pm Jan 18, 2010 5:08pm
The following error messages are appearing with the DB Bot on Alpari UK. (See Screenshot attached).
Attached Image (click to enlarge)
Click to Enlarge Name: DB Bot Error.jpg Size: 98 KB
  • #4,700
  • Jan 18, 2010 5:19pm Jan 18, 2010 5:19pm
Quoting awk
Let's try this: You list all available EUR pairs first, then all the JPY, then all the USD. That means that EURJPY, EURUSD and USDJPY are listed twice.
I do share this view.
福 子 Victor V
17 traders viewing now