scooby-doo BOJ JPY pairs trading robot | Page 213 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading correlation pairs by using the other pairs 843 replies

Export All pairs or selected pairs to .csv with script 3 replies

Pairs of Currency Pairs 4 replies

Trending Pairs / Ranging Pairs 0 replies

Robot trading 120 replies

Attachments: scooby-doo BOJ JPY pairs trading robot
Exit Attachments

scooby-doo BOJ JPY pairs trading robot

  • #4,241
  • Jan 5, 2010 1:54pm Jan 5, 2010 1:54pm
Steve,

I figured out the problem. The broker(criminal) that I am using wont allow a small 5 pip stop loss. When the system goes to place the stop order...the 5 pip stop loss triggers the error. Sorry for the earlier question.
  • #4,242
  • Jan 5, 2010 4:15pm Jan 5, 2010 4:15pm
Quoting Jezza
Steve will correct me if I'm wrong here (I usually am) but I would have thought that the OP Robot should have closed down those trades automatically as soon as the targeted profit was reached.


Oh and a belated Happy New Year to everyone and thanks to all concerned for your continued dedication, generosity and ingenious ideas!!
Not necessarily. Explained in post 1.

  • #4,243
  • Jan 5, 2010 4:43pm Jan 5, 2010 4:43pm
My Original V2.1 just opened buy trade. I thought only sell trade during Tokyo opens? Using MIG.

Also, Basket V3 suspended trade because of news item. However, check with FF's calender, no news on JPY.

Any idea???

Thanks.
福 子 Victor V
  • #4,244
  • Jan 5, 2010 5:53pm Jan 5, 2010 5:53pm
Quoting SteveHopwood
Not necessarily. Explained in post 1.

Yeah I did read that with the update about the RS paramaters. Thanks for the confirmation.
Its doing well this week. Made 20% since Monday morning Mind you, it has been trending down very nicely since exactly that time!
  • #4,245
  • Jan 6, 2010 4:41am Jan 6, 2010 4:41am
I added some code to AI last night:

 

  1. 2 stage order sending - the input is the usual CriminalIsECN. I am not sure if the code is correct and the error trapping is sketchy.
  2. Only allow one set of trading per day. Sometimes this is both buy and sell stop orders, sometimes just one of them.
  3. Tidied up the robot's ability to spot its own trades without confusing them with non-robot trades.

Attached File(s)
File Type: mq4 AI.mq4   6 KB | 430 downloads
  • #4,246
  • Jan 6, 2010 7:35am Jan 6, 2010 7:35am
Hi Steve,

Some feedback regarding the minor error "symbol name marketinfo function must be a string."

After installing some error traps across the program I can now confirm your suspicions of 24 Nov:-
--------------------------------------
void CheckNewCandleFormation()
--------------------------------------
Can't make any other suggestions yet, still looking.
But hope that helps narrow the "where to fix".

All the best

drxyber
  • #4,247
  • Jan 6, 2010 10:25am Jan 6, 2010 10:25am
Quoting Dr Xyber
Hi Steve,

Some feedback regarding the minor error "symbol name marketinfo function must be a string."

After installing some error traps across the program I can now confirm your suspicions of 24 Nov:-
--------------------------------------
void CheckNewCandleFormation()
--------------------------------------
Can't make any other suggestions yet, still looking.
But hope that helps narrow the "where to fix".

All the best

drxyber
Cheers. This error usually occurs when people change timeframes with the robot running. I don't care about it; there are no MarketInfo calls that do not contain a string.

If you find one, sing out. You won't.
  • #4,248
  • Jan 6, 2010 10:52am Jan 6, 2010 10:52am
Hi Steve,

In examining the init() code, I see some entries that are confusing me somewhat, This snippet indicates "if this account is not a demo account, then disable the EA. I understand that and agree with it.

//This robot is not to be used on live accounts yet
if (!IsDemo() )
{
MessageBox("This robot will not run on a live account.");
Comment(" This robot does not run on a live account");
DisabledMessage = "This robot does not run on a live account";
RobotDisabled = true;
return;
}//if (IsDemo() )

However, the above COMMENT doesn't agree with the beginning IF statement. No problem yet, as I too have made little typos like this in my own code.

However, the next part is somewhat confusing in that the logic appears to be saying, "If this is NOT a demo account, then check the magic number," and then it checks to see if that number is, in fact, 123456. Shouldn't the code read "if this IS a demo account, check the magic number," and "if the magic number is exactly equal to 12345, then you must change it"? (also, the comment at the end of the IF magic number statement is incorrect).

//Check magic number.
if (!IsDemo() )
{
if (MagicNumber == 123456)
{
MessageBox("You cannot run this robot until changed the MagicNumber input from the default of 12345." + NL
+ "Please reload the robot with a new MagicNumber input.");
Comment(" This robot can do nothing. Please reload it");
DisabledMessage = "You need to change the MagicNumber input";
RobotDisabled = true;
return;
}//if (MagicNumber == 12345)
}//if (!IsDemo)

Thanks for your advice; I'm learning more and more with each passing day.

Cheers,
Ed
  • #4,249
  • Jan 6, 2010 10:53am Jan 6, 2010 10:53am
Steve, thank you for the updated AI bot. Will put that on demo and report back.

I have a question abuot the Scooby 24hr bot, though. It has never taken a trade since December 14 when I put it up on demo. I've checked the settings many times. See no error messages. Everything appears right. What might I be missing?

JR
  • #4,250
  • Jan 6, 2010 11:17am Jan 6, 2010 11:17am
Quoting enewbold
Hi Steve,

In examining the init() code, I see some entries that are confusing me somewhat,...
I structure my code by copying the original conditional at the end of the block - I find this helps me read my code later on. When I change the conditional, I do not always remember to change the end-of-block comment. That is what happened here.

Quote
However, the above COMMENT doesn't agree with the beginning IF statement. No problem yet, as I too have made little typos like this in my own code....
In English, if (!IsDemo) means 'if the account is not a demo account'. If the account is not a demo, then it must be a live one as there are no other kinds. There is no if (IsLive) construct, so I have to check for a negative condition. This sort of thing has caused me hours of logic fuzz over the last 3 years.

Quote
Thanks for your advice; I'm learning more and more with each passing day.

Cheers,
Ed
You're welcome. All traders should learn mql4.

  • #4,251
  • Jan 6, 2010 5:39pm Jan 6, 2010 5:39pm
I realised tonight that the law of unintended consequences kicked in when I added Scoobs' correlation code to the Original robot, to cut out the wave 2 trading when the correlation was wrong.

Because of where I placed the code, it also killed the BOJ trading. V2.2 is in post 1.

  • #4,252
  • Jan 6, 2010 6:42pm Jan 6, 2010 6:42pm
Quoting SteveHopwood
I realised tonight that the law of unintended consequences kicked in when I added Scoobs' correlation code to the Original robot, to cut out the wave 2 trading when the correlation was wrong.

Because of where I placed the code, it also killed the BOJ trading. V2.2 is in post 1.

Steve, would the "Law of Unintended Consequences" explain why the 24hr bot has not taken any trades (ever) since December 14 when I set it up?

Also, is it OK to post a URL to a tracking site where the group can see my results on one or more demo accounts where I am running these bots?
  • #4,253
  • Jan 6, 2010 6:58pm Jan 6, 2010 6:58pm
Quoting octomanoak
Steve, would the "Law of Unintended Consequences" explain why the 24hr bot has not taken any trades (ever) since December 14 when I set it up?
Probably. The OP and 24H versions both use correlation and they haven't taken any trades on my demos for ages. I might remove correlation from the OP if it doesn't burst into life soon. We shall see.

Quote
Also, is it OK to post a URL to a tracking site where the group can see my results on one or more demo accounts where I am running these bots?
Please feel free.

  • #4,254
  • Jan 6, 2010 7:11pm Jan 6, 2010 7:11pm
Quoting SteveHopwood
The OP and 24H versions both use correlation and they haven't taken any trades on my demos for ages.
Steve by OP do you mean the Opposite Robot? I loaded up the latest version today on a demo account and already have a trade closed out for a profit.

It's only the 24hr bot that has been an issue for me, except for that "Unintended Consequences" thing on the Original bot v2.1. Previous versions of the Original bot traded on my demo.

JR
  • #4,255
  • Jan 6, 2010 7:18pm Jan 6, 2010 7:18pm
Quoting octomanoak
Steve by OP do you mean the Opposite Robot? I loaded up the latest version today on a demo account and already have a trade closed out for a profit.
Excellent. OP stands for Opposite Position, so we are talking about the same robot.

I haven't checked mine today - all the demos are on a separate machine in the music room and I will look at them before going to bed.

  • #4,256
  • Jan 6, 2010 7:44pm Jan 6, 2010 7:44pm
For those interested in following my demo of Scooby Opposite Robot, see the following URL. I just put it on today and have a couple of closed baskets already!

http://www.myfxbook.com/members/octo...opposite/12413
  • #4,257
  • Jan 6, 2010 9:31pm Jan 6, 2010 9:31pm
Quoting octomanoak
For those interested in following my demo of Scooby Opposite Robot, see the following URL. I just put it on today and have a couple of closed baskets already!

http://www.myfxbook.com/members/octo...opposite/12413
Which broker are you using? Cannot get mine to work other than on IBFX. Mind to post your settings? Thanks!
  • #4,258
  • Jan 6, 2010 9:46pm Jan 6, 2010 9:46pm
Hi Steve,

I have a problem when setting this up. Your 1.8 version was ok and worked great for me. But when I upgraded to 2.0 or even 2.1 the robot stood still for more than 1 week.

As I thought it was wrong with the Next Jap Public holiday parameter, I've changed it to 2010.01.11 22:00 but it was useless.

I don't know why 1.8 can run smoothly while the latest do not! Can you please give me a solution for this?
  • #4,259
  • Jan 6, 2010 10:03pm Jan 6, 2010 10:03pm
I had to skim the last 100 pages. My eyes have been reading this thread for 3 days.

Great job on this EA and trading strategy.
I will try out the original v2.1bot on demo for a few months and see how it performs.
thx guys for all the hard work.
  • #4,260
  • Jan 6, 2010 10:18pm Jan 6, 2010 10:18pm
Quoting SteveHopwood
I added some code to AI last night:

 

  1. 2 stage order sending - the input is the usual CriminalIsECN. I am not sure if the code is correct and the error trapping is sketchy.
  2. Only allow one set of trading per day. Sometimes this is both buy and sell stop orders, sometimes just one of them.
  3. Tidied up the robot's ability to spot its own trades without confusing them with non-robot trades.

Hi Steve,
Are the default settings in the AI EA for 5 digit criminals? Because have taken 2 trades so far but TP is only 10 pips (100 for 5 digit) and SL is 5 pips (50 for 5 digit) - seems a little shy ...?
6 traders viewing now