Custom Indicator "shortname is too long error" | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Broker Challenge "NDD/STP" vs. True "ECN" and "Mkt Mkr" broker talk 46 replies

Dealing with "Invalid Price", "Requote", "Server Busy" in MT4 3 replies

How to catch an error when loading a custom indicator? 0 replies

EA error message (0) no error 6 replies

An EA Trading System with custom indicator "Solar Joy" 32 replies

Attachments: Custom Indicator "shortname is too long error"
Exit Attachments

Custom Indicator "shortname is too long error"

  • #1
  • First Post: Nov 23, 2009 3:39pm Nov 23, 2009 3:39pm
I'm fairly new to programming EA's, especially iCustom indicators.
When I added my iCustom indicator to a functioning EA it compiled ok and
draws the indicator on the chart.

But no trades are taken and the indie is removed with the error message
"shortname too long". There's no reference to a shortname in the EA and shortening the indicator name to a single letter "Z" still gets this error.

Ideas?
Attached Image
  • #2
  • Nov 24, 2009 7:55am Nov 24, 2009 7:55am
You need post the EA and indicator file for us to help you
  • #3
  • Nov 24, 2009 7:58pm Nov 24, 2009 7:58pm
When you are calling this function in your code you are generating the error:

void IndicatorShortName( string name)

I believe the max length of 'name' is 32 characters, but I am not 100% positive.
  • #4
  • Dec 7, 2009 9:17am Dec 7, 2009 9:17am
Thanks very much
Your reply helped me isolate the problem. I don't understand the "void" data type usage, ... when you must use use it and when not to. It's not well documented in MetaEditor. Could anyone point to a source where it's clearly explained?
  • #5
  • Dec 7, 2009 10:01am Dec 7, 2009 10:01am
void is when you're not expecting a returned value.

E.g. when opening an order, I use a void function to open the order, set the sl/tp and manage any error handling. The rest of the EA doesn't need to know what the result was.

In my tick collection EA, I could technically turn the link-handling segment into void function.
  • #6
  • Dec 7, 2009 3:34pm Dec 7, 2009 3:34pm
Quoting Ronald Raygun
void is when you're not expecting a returned value.

E.g. when opening an order, I use a void function to open the order, set the sl/tp and manage any error handling. The rest of the EA doesn't need to know what the result was.

In my tick collection EA, I could technically turn the link-handling segment into void function.
I've been trying to use your old HMA EA. The EA structure is excellant and HMA has always been one of my base indicators. The problem is the EA will trade during the candle. This means that if you are long and the candle turns red or short for a few ticks it will close the long trade and enter a shot position which leaves you short in a long trend. I asked this question several times in several forums but none of the answers work.

I'll attact the specific EA in question. I'm hoping you could help me.
Attached File(s)
File Type: mq4 HMA_Expert_v1.mq4   16 KB | 536 downloads
  • #7
  • Dec 8, 2009 10:15am Dec 8, 2009 10:15am
OK, so I get that the purpose is to declutter our code and thereby save memory and increase speed/efficiency. Is that correct?

I notice that placing the void statement (or removing it) before function calls may generates errors

Is there a way to know when it must or must not be used. vs may or may not be used.

just trying to get a better feel for how its used in everyday programming

Thanks for the help
  • #8
  • Dec 8, 2009 11:18am Dec 8, 2009 11:18am
Quoting Traderduke
I've been trying to use your old HMA EA. The EA structure is excellant and HMA has always been one of my base indicators. The problem is the EA will trade during the candle. This means that if you are long and the candle turns red or short for a few ticks it will close the long trade and enter a shot position which leaves you short in a long trend. I asked this question several times in several forums but none of the answers work.

I'll attact the specific EA in question. I'm hoping you could help me.

That's not what I wrote...

Anyway. if you want the EA to place a signal at the end of the bar, in my EA, you just set EachTickMode to False. What it does is it shifts the indicator values back one bar.
  • #9
  • Dec 8, 2009 9:56pm Dec 8, 2009 9:56pm
Quoting Ronald Raygun
That's not what I wrote...

Anyway. if you want the EA to place a signal at the end of the bar, in my EA, you just set EachTickMode to False. What it does is it shifts the indicator values back one bar.
Thanks for answering my stupid request I attached the wrong EA. The Heiken ashi I should have attached also gave false signals at times until I added a "Volume[0]--1" to the Indicator. I'll try the Ea option as you suggested.

Thanks again
  • #10
  • Dec 10, 2009 6:00am Dec 10, 2009 6:00am
Quoting Ronald Raygun
That's not what I wrote...

Anyway. if you want the EA to place a signal at the end of the bar, in my EA, you just set EachTickMode to False. What it does is it shifts the indicator values back one bar.
RR
Changing the ETM to false does as you say but it doesn't let the EA Enter an opposite postion at that time of the reversal. I'm still testing the "Volume" solution that I mentioned earlier. I'll let you know.

Thanks for the responce
  • #11
  • Last Post: Dec 10, 2009 6:52am Dec 10, 2009 6:52am
Quoting Traderduke
RR
Changing the ETM to false does as you say but it doesn't let the EA Enter an opposite postion at that time of the reversal. I'm still testing the "Volume" solution that I mentioned earlier. I'll let you know.

Thanks for the responce
RR,
I've attached a picture of the problem. The EA is changing the postion during the candle instead of at the open of the next candle which would avoid false signals. I realize that the ETM False would solve that particular aspect of the problem but then then the EA won't take the opposite postion on the reversal. The volume[0]==1 placed in the indicator solved the problem for the HMA EA but for some reason it doen't help the Heiken EA, any thoughts???
Attached Image (click to enlarge)
Click to Enlarge Name: 2009-12-10_074103-HA-EA.png Size: 28 KB
0 traders viewing now