scooby-doo BOJ JPY pairs trading robot | Page 190 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading correlation pairs by using the other pairs 843 replies

Export All pairs or selected pairs to .csv with script 3 replies

Pairs of Currency Pairs 4 replies

Trending Pairs / Ranging Pairs 0 replies

Robot trading 120 replies

Attachments: scooby-doo BOJ JPY pairs trading robot
Exit Attachments

scooby-doo BOJ JPY pairs trading robot

  • #3,781
  • Dec 2, 2009 7:11pm Dec 2, 2009 7:11pm
Hi Steve,

Had the same error on O V1.2 when it tried to take a trade. Both bots were straight out of the box, no adjustments at all. Alpari UK and got same file notes as macman on my print-out. Good Luck......It sure is fun

whip
  • #3,782
  • Dec 2, 2009 7:19pm Dec 2, 2009 7:19pm
Sorry bout that earlier post, though I did amend it once it was pointed out.


Anyways.. Heres my experts folder list from today, I've underlined a bit that looks out of place since the original trade is from the Original, the hedge is from the H24, typing this made me check and my magic numbers are the same, so i've just amended that.
Attached Image
  • #3,783
  • Dec 2, 2009 8:08pm Dec 2, 2009 8:08pm
Quoting scooby-doo
JPY economic data was released early to BOJ traders well ahead of the scheduled time. Their interpretation of it was negative.

This does happen from time to time as there are no rules in forex.
Great Analysis. How did you figure that one out? You must do a tremendous amount of research.

Respectfully'

Fxcellent
GREED IS THE ULTIMATE INDICATOR
  • #3,784
  • Dec 2, 2009 8:12pm Dec 2, 2009 8:12pm
Hello all and today I started a new Alpari-UK demo again with the newest version of the 24hr ea. Since I am not a seasoned trader, I expose myself as being a total noob, but sometimes you need to be a noob to learn.
At any rate what I did was open two 15 min gbp/jpy charts. Using the default settings except the magic number I did the following.
On the first chart with magic number 12345 I manually placed a sell basket. On the second chart with magic number 123456 I manually placed a buy basket.
Since the market will either go up, down, or sideways, at one point you should be making a profit.
What I am not sure if it can be done is to combine all this action into using just the following:
1. Have the ea be able to have two magic numbers so one can be used to monitor the two sell pairs, and one be able to monitor the two buy pairs.
2. As soon as either the buy pairs or sell pairs hit the tp then immediately open another pair.
Not sure what kind of dd this would give? Maybe the basket stoploss level might need to be raised?
Here is a sample of what the account is doing so far.
https://www.myfxbook.com/portfolio/jpy/8703
  • #3,785
  • Dec 2, 2009 8:23pm Dec 2, 2009 8:23pm
I think a call to calculate base lot size is missing in LookForOverboughtOpportunity (and in the mirroring oversold funtion) before calling the trade send function.

It's also a good practice to add more information in the error trapping, reporting the current values for strongest, lots, baselotsize, lotstep, so that you can tell which one is the culprit when such errors arise.



Quoting SteveHopwood
Can anybody else see anything wrong with the code here? The trade sending function is called with the type (buy or sell) and symbol (either GJ or EJ) as passed parameters. 'strongest' is the strongest price in the basket and is calculated before the trade sending function is called.
  • #3,786
  • Edited 9:37pm Dec 2, 2009 9:25pm | Edited 9:37pm
Quoting letizia
Hello all and today I started a new Alpari-UK demo again with the newest version of the 24hr ea. Since I am not a seasoned trader, I expose myself as being a total noob, but sometimes you need to be a noob to learn.
At any rate what I did was open two 15 min gbp/jpy charts. Using the default settings except the magic number I did the following.
On the first chart with magic number 12345 I manually placed a sell basket. On the second chart with magic number 123456 I manually placed a buy basket.
Since the market will either go up, down, or sideways,...
I've always thought it would be nice to have an EA attached to anyone new in forex (myself included) ---The EA would send an inverse order to my live acct... But for now I'll just settle for trading with the monitor upside down...

Almost for got to include my basket trade was good for tonight that's 4 for 4 (using older filled with bugs version)
usdjpy
gbpjpy
eurjpy
chfjpy
audjpy
  • #3,787
  • Dec 2, 2009 9:40pm Dec 2, 2009 9:40pm
just had a basket sell and TP on original v1.2 -

shame about the one that happened this morning where i lost plenty.

still trading on demo.
  • #3,788
  • Dec 2, 2009 9:41pm Dec 2, 2009 9:41pm
and Steve, I dont the error message in the afternoon session, i only get the error msg in the morning session...if that is any help.
  • #3,789
  • Dec 3, 2009 2:12am Dec 3, 2009 2:12am
Quoting fxcellent
Great Analysis. How did you figure that one out? You must do a tremendous amount of research.

Respectfully'

Fxcellent
I logged onto my work's trading floor remotely and it was self evident given the pending orders at CB/Interbank level. Also, I had an email waiting in my inbox from work colleagues in Hong Kong.
  • #3,790
  • Dec 3, 2009 3:39am Dec 3, 2009 3:39am
Quoting challenger78
I think a call to calculate base lot size is missing in LookForOverboughtOpportunity (and in the mirroring oversold funtion) before calling the trade send function.
Thanks. The base lot calculation function is called early in start() and the result displayed on screen, so we know that is not a problem.

Good idea to add some extra info to the error display alert; for now I have just added lot size. The updated versions are in post 1.

  • #3,791
  • Dec 3, 2009 3:46am Dec 3, 2009 3:46am
I reckon define variables outside Buy trade if() function - like;

RefreshRates();

double TradePrice; // scalpz
double Stop; // scalpz
double Take; // scalpz

// Buy trade
if (type == 0)
{
TradePrice=ask; // scalpz
Stop = NormalizeDouble(ask - sl,digits); // scalpz
Take = NormalizeDouble(ask + tp,digits); // scalpz

}//if (type == 0)

// Sell trade
if (type == 1)
{
TradePrice=bid;
Stop = NormalizeDouble(bid + sl,digits);
Take = NormalizeDouble(bid - tp,digits);

}//if (type == 1)


Cause I can't see how the Sell trade if() function has access to the variables before they are defined.
I have changed my Original v1.3 copy & testing for the morning session.

cheers scalpz
Target 2 : Stoploss in the green
  • #3,792
  • Dec 3, 2009 4:11am Dec 3, 2009 4:11am
Quoting scalpz
I reckon define variables outside Buy trade if() function - like;

RefreshRates();

double TradePrice; // scalpz
double Stop; // scalpz
double Take; // scalpz

// Buy trade
if (type == 0)
{
TradePrice=ask; // scalpz
Stop = NormalizeDouble(ask - sl,digits); // scalpz
Take = NormalizeDouble(ask + tp,digits); // scalpz

}//if (type == 0)

// Sell trade
if (type == 1)
{
TradePrice=bid;
Stop = NormalizeDouble(bid + sl,digits);
Take = NormalizeDouble(bid - tp,digits);

}//if (type == 1)


Cause I can't see how the Sell trade if() function has...
That was useful scalpz, because it made me realise the RefreshRates() call had no effect because the variables were calculated outside SendTrade(), so I have re-ordered this.

No idea whether all this will cure the invalid trade volumes error, but good to correct blunders in the code anyway.

  • #3,793
  • Dec 3, 2009 8:07am Dec 3, 2009 8:07am
Hi Steve

I noticed a possible problem with the TP

After hitting the stoploss :-(

The next basket was successful but it only made $12

TP was set at $200 with standard defaults on the BOJ Orig 1.2

And I have seen this happen a few times before in my testing

Hopefully, you can figure it out

Many thanks

hatter
Attached Image (click to enlarge)
Click to Enlarge Name: Strange_TP_2.jpg Size: 200 KB
  • #3,794
  • Dec 3, 2009 9:10am Dec 3, 2009 9:10am
It seems we may have a turning point in this strategy/methodology as the guppy doesnt seem to know where to go in the market.

Volatility and volumes are well down since the no show of intervention lastnight and likewise having a knock on effect on the other XXXJPY pairs.

Will be interesting to see exactly what happens later tonight.
  • #3,795
  • Dec 3, 2009 12:40pm Dec 3, 2009 12:40pm
Latest version...anyone have them working? macman, did ever get them to produce a chart??
Vincit qui se vincit.
  • #3,796
  • Dec 3, 2009 1:01pm Dec 3, 2009 1:01pm
Pippopotamus,

yepp,....works perfectly. Itīs an offline chart and takes a little time for the candles to build some history.

Instructions are inside the tab section.
  • #3,797
  • Edited 1:28pm Dec 3, 2009 1:22pm | Edited 1:28pm
Quoting Pippopotamus
Latest version...anyone have them working? macman, did ever get them to produce a chart??
Yes, the offline chart certainly works, but takes a very long time to populate. Mine has been running for nearly two days non-stop and has so far created 92 bars on M15 TF

Also the difference between the xxxJPY chart and GbpJpy chart is smaller than I had expected.

Still looking at how useful it is, but certainly a very smart piece of programming IMHO.

Edit:

92/4 (m15 bars) = 23 hours - about right
  • #3,798
  • Dec 3, 2009 1:22pm Dec 3, 2009 1:22pm
Information

I and some others have noticed that sometimes your TP is hit but the ea/bot doesnt close the trades.

One reason could be that there is not a tick coming from your broker so basically your ea/bot stop working even though the profit/loss is moving up and down.

A simple solution to this is to have mt4_ticker running in the background.

You can download it from here: http://www.fx1.net/mt4tick.php
  • #3,799
  • Dec 3, 2009 2:31pm Dec 3, 2009 2:31pm
Thanks for the link Scooby looks like a nice tool. Too bad you need to register before downloading it. I am not sure I want to give them my phone number and all the rest of the stuff they want.
Thanks again!
Vince
  • #3,800
  • Dec 3, 2009 2:45pm Dec 3, 2009 2:45pm
Quoting letizia
Thanks for the link Scooby looks like a nice tool. Too bad you need to register before downloading it. I am not sure I want to give them my phone number and all the rest of the stuff they want.
Thanks again!
Vince
Give them a fake phone number - 'tis what I do in these circumstances.

1 trader viewing now