scooby-doo BOJ JPY pairs trading robot | Page 67 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading correlation pairs by using the other pairs 843 replies

Export All pairs or selected pairs to .csv with script 3 replies

Pairs of Currency Pairs 4 replies

Trending Pairs / Ranging Pairs 0 replies

Robot trading 120 replies

Attachments: scooby-doo BOJ JPY pairs trading robot
Exit Attachments

scooby-doo BOJ JPY pairs trading robot

  • #1,321
  • Nov 10, 2009 5:48pm Nov 10, 2009 5:48pm
My v2 took a buy on demo too about 30 mins ago.

Cal
  • #1,322
  • Nov 10, 2009 5:48pm Nov 10, 2009 5:48pm
Quoting Jezza
This is why NOBODY (except Steve if he chooses to as he is the coder) should be trading this EA live yet.
If you are, it's at your own risk and it's your own fault if you get your fingers burnt.
Iv'e got 3 demo accounts going and they have all opened buy baskets.
Very wise of you.
  • #1,323
  • Nov 10, 2009 5:49pm Nov 10, 2009 5:49pm
Quoting macman
OK, so what should it read ?
if ( (hour == BuyHourStarts || hour == BuyHourStarts + 1 || hour == BuyHourStarts + 2)
  • #1,324
  • Nov 10, 2009 5:53pm Nov 10, 2009 5:53pm
My accounts sent a buy tonight as well.

Doesn't matter how hard I look, I can't see how this could happen.

  • #1,325
  • Nov 10, 2009 5:53pm Nov 10, 2009 5:53pm
News are out Actual = 10.5%

Now we wait lol
  • #1,326
  • Nov 10, 2009 5:54pm Nov 10, 2009 5:54pm
Quoting 5msport
Mine opened a SELL order this morning.

Worked great on live account.

Really happy ..... have made $58 every morning so far.

Taking it slow at this stage, but will look at enlarging my contracts as I go.

Thanks Scooby for your system and all your help, much appreciated.
What version are you using?
  • #1,327
  • Nov 10, 2009 5:57pm Nov 10, 2009 5:57pm
Quoting SteveHopwood
My accounts sent a buy tonight as well.

Doesn't matter how hard I look, I can't see how this could happen.

The brackets in BuyHours Steve, zz spotted it well
  • #1,328
  • Nov 10, 2009 5:57pm Nov 10, 2009 5:57pm
Quoting SteveHopwood
This is another case of 'hats off to scoob'.

Briefly, a call to an indi is supposed to contain within the call all of the inputs that are visible to the user of the indi. This is how the robot's call code is coded.

Scoobs posted many pages a much shorter version of the call.

So, at the time of writing this, the 'official' version of the call gives a reading of 99999 minutes until the next news event, so the robot concludes there is no news pending and carries on its merrie way.

What a surprise? Scoob's version gives the correct reading....
Steve,

There a programmers and there are ............

  • #1,329
  • Nov 10, 2009 5:57pm Nov 10, 2009 5:57pm
Quoting challenger78
if ( (hour == BuyHourStarts || hour == BuyHourStarts + 1 || hour == BuyHourStarts + 2)
Yep, that'll fix it. Those compound if statements can get very messy; easy to miss erroneous parens!
  • #1,330
  • Nov 10, 2009 5:59pm Nov 10, 2009 5:59pm
I am using V1.9

I have V2 on another live account as well, but it didnt trade at all.

I have found V1.9 has been working great for me.
  • #1,331
  • Nov 10, 2009 6:01pm Nov 10, 2009 6:01pm
woohooo the sell bakset i took right after the news is now rockin green
  • #1,332
  • Nov 10, 2009 6:01pm Nov 10, 2009 6:01pm
Big drop GBP/JPY now.
  • #1,333
  • Nov 10, 2009 6:03pm Nov 10, 2009 6:03pm
hmm question when you manually open the basket its a bit of a pain closing them all one by one... could there be a script to close all the orders as well?
  • #1,334
  • Nov 10, 2009 6:03pm Nov 10, 2009 6:03pm
Quoting zznbrm
Yep, that'll fix it. Those compound if statements can get very messy; easy to miss erroneous parens!
I can't believe I have been so stupid.

The conditional was once upon a time far more complicated than the present one; the erroneous brackets are left over from that.

Well spotted. Many thanks from all of us.

Sorry the blunder has taken so long to surface everyone. V2.1 coming very soon.

  • #1,335
  • Nov 10, 2009 6:05pm Nov 10, 2009 6:05pm
Hello Steve and all.Not to sound as one of those who just post to see their name in print, using the newest version, mine also opened a buy. Would it be possible for you to look into the code of the last version 1.9 and see if there is a line in version 2.0 that is there that might cause the buy instead of sell. 1.9 was ok here
Hope I don't get added to the list of ignore by asking this question?


Thanks Vince!
Have a great night/day everyone
  • #1,336
  • Nov 10, 2009 6:06pm Nov 10, 2009 6:06pm
Thanks to Steve and Scooby for all your excellent work - this is still a work in progress, with great potential.
  • #1,337
  • Nov 10, 2009 6:07pm Nov 10, 2009 6:07pm
Quoting Ervichov
hmm question when you manually open the basket its a bit of a pain closing them all one by one... could there be a script to close all the orders as well?
there you go... in scripts folder, double click to close all orders of these 5 pairs - regardless if they belong to this EA or not.

Or you can just reload the EA and let it manage them.
Attached File(s)
File Type: mq4 CloseAll_5_JPY.mq4   < 1 KB | 354 downloads
  • #1,338
  • Nov 10, 2009 6:07pm Nov 10, 2009 6:07pm
well just closed the basket with a $79 gain
  • #1,339
  • Nov 10, 2009 6:08pm Nov 10, 2009 6:08pm
Quoting Ervichov
well just closed the basket with a $79 gain
Well done.
  • #1,340
  • Nov 10, 2009 6:08pm Nov 10, 2009 6:08pm
Quoting Ervichov
hmm question when you manually open the basket its a bit of a pain closing them all one by one... could there be a script to close all the orders as well?
I think i already post the script. BTW..i attached here again..
Attached File(s)
File Type: mq4 2CloseAllOrder.mq4   7 KB | 414 downloads
0 traders viewing now