scooby-doo BOJ JPY pairs trading robot | Page 19 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading correlation pairs by using the other pairs 843 replies

Export All pairs or selected pairs to .csv with script 3 replies

Pairs of Currency Pairs 4 replies

Trending Pairs / Ranging Pairs 0 replies

Robot trading 120 replies

Attachments: scooby-doo BOJ JPY pairs trading robot
Exit Attachments

scooby-doo BOJ JPY pairs trading robot

  • #361
  • Nov 5, 2009 4:20am Nov 5, 2009 4:20am
Quoting sahars
Hi Johnithai,

I made a mistake again. For Malaysia should use 0500 and 1300 hours, while for Thailand (Bangkok) it should 0400 and 1200 hours since Bangkok and Tokyo has 2 hours different.

BTW guys (for still confuse for time to use...!!!)

I have attached here again the indicator which tell you the time of those major cities...
Hi, well Tokyo opens at 7am that makes it 5am in BKK, tokyo closes at 4pm makes it 2pm in BKK.
SO shouldn't it be 5 - 14 then for Thailand?
Enter Signature
  • #362
  • Nov 5, 2009 4:23am Nov 5, 2009 4:23am
Quoting johninthai
Hi, well Tokyo opens at 7am that makes it 5am in BKK, tokyo closes at 4pm makes it 2pm in BKK.
SO shouldn't it be 5 - 14 then for Thailand?
You must set 2 hour before Tokyo open and 2 hours before Tokyo close.
  • #363
  • Nov 5, 2009 4:26am Nov 5, 2009 4:26am
Quoting scooby-doo
Steve,

Can you add in M5 and M30 as an acceptable TF combination.

I will update the pdf later today.

Cheers.

PS. I got an email from Alpari, they have corrected my account with GBP 2,279 and apologised for a system error. Like I believe that load of ........
Is this your preferred time frames? If not, what do you prefer?
  • #364
  • Nov 5, 2009 4:28am Nov 5, 2009 4:28am
Quoting smjones
Is this your preferred time frames? If not, what do you prefer?
no,

i prefer M15 and H1
  • #365
  • Nov 5, 2009 4:30am Nov 5, 2009 4:30am
Quoting scooby-doo
no,

i prefer M15 and H1
Thanks, that seems to be the consensus.
  • #366
  • Nov 5, 2009 4:31am Nov 5, 2009 4:31am
Quoting sahars
You must set 2 hour before Tokyo open and 2 hours before Tokyo close.

Ok, that makes it 5am - 2pm then for Thailand.
Enter Signature
  • #367
  • Nov 5, 2009 4:32am Nov 5, 2009 4:32am
Steve

Why are these people getting hung up on what times to enter...

Surely...

TimeHour(TimeLocal()) >= 22 && TimeMinute(TimeLocal()) >= 30

Is the same all around the world or am I missing something ?????
  • #368
  • Nov 5, 2009 4:46am Nov 5, 2009 4:46am
That was a great party we had last night. For some of you, it was daytime so you were able to keep the party going.

My machine did not take any trades during the Tokyo closing session; it downloaded some Windows updates that installed themselves then rebooted the machine. This is my coding computer, so I haven't told it not to do that.

Just to let you all know, the faulty Sell trades you all got this morning resulted from some faulty logic coded into the robot. I have fixed this and emulated a Buy session and a Sell session and everything now seems OK.

I am going to code the extra filter into the basket take profit function and add the differential lot sizing; this will make a huge difference to the potential profit on offer. I will post as soon as this is done then you can all play with it.

  • #369
  • Nov 5, 2009 4:48am Nov 5, 2009 4:48am
Quoting smjones
There is a bug in the RS_GROUP_JPY V1.2 for any broker that does not have CADJPY. From what I can see it is calculating on 7 JPY pairs. If CADJPY is not there as in IBFX, or other pairs like FXDD then the average of the sum of the 7 pairs devided by the total 7 pairs will be weighted and off....
Thanks. I will look into this.

Thanks for the vouch, by the way. You were the first one to do this and I felt honoured. I tried to pm my thanks at the time, but you were not accepting pm's.

Hehe. The first time I noticed I had a vouch, I didn't know what the symbol meant. I headed straight for my profile to see what I could spend my voucher on.
  • #370
  • Nov 5, 2009 4:51am Nov 5, 2009 4:51am
Quoting SteveHopwood
Thanks. I will look into this.

Thanks for the vouch, by the way. You were the first one to do this and I felt honoured. I tried to pm my thanks at the time, but you were not accepting pm's.

Hehe. The first time I noticed I had a vouch, I didn't know what the symbol meant. I headed straight for my profile to see what I could spend my voucher on.
LOL, you can PM now, I added you to my list.
  • #371
  • Nov 5, 2009 4:54am Nov 5, 2009 4:54am
Hey Steve, execellent job as always!
Also many many thanks to the initiator of this whole idea, ScoobyDoo!

Anyway while you are fixing the code, can you also look into the below:

I was puzzled why the basket was not closed by the EA when we are using the broker which needs this CriminalIsECN = true (2 stages ordersend). So I found the code below that needs modifying:
if (CriminalIsECN)
{
ticket = OrderSend(symbol, type, BaseLot, TradePrice, 5, 0, 0, TradeComment, MagicNumber,0, CLR_NONE);
if (EmergencyStopLoss != 0)
{
if (ticket > 0)
bool result = OrderModify(ticket, OrderOpenPrice(), Stop, Take, 0, CLR_NONE);

Can you verify that? Thanks again.

cheers,
  • #372
  • Nov 5, 2009 5:08am Nov 5, 2009 5:08am
Quoting Kling
Hey Steve, execellent job as always!
Also many many thanks to the initiator of this whole idea, ScoobyDoo!

Anyway while you are fixing the code, can you also look into the below:

I was puzzled why the basket was not closed by the EA when we are using the broker which needs this CriminalIsECN = true (2 stages ordersend). So I found the code below that needs modifying:...
Nicely spotted Kling. You prove your value with your eye to detail yet again. I had not spotted this because I had not actually tested the 2 stage thingy. I have made the change, which probably needs making to the individual trading robot as well.

This robot is a bit easier to delve into than the KG Range.



Edit: just had a look, and the function in the individual trading robot also needed the change.
  • #373
  • Nov 5, 2009 5:26am Nov 5, 2009 5:26am
Quoting SteveHopwood
Nicely spotted Kling. You prove your value with your eye to detail yet again. I had not spotted this because I had not actually tested the 2 stage thingy. I have made the change, which probably needs making to the individual trading robot as well.

This robot is a bit easier to delve into than the KG Range.



Edit: just had a look, and the function in the individual trading robot also needed the change.
Hi Steve,

As always you create something outstanding EA. BTW..I realized that the EA does not open any trade (either on basket or individual) if the previous opened trade at the previous session does not closed. It needs to be closed manually all the previous trade in order the new trade to be opened...I'm not sure whether this matter has been fixed yet or not at your revised version...

Just for your info, the KG Range is open buying trade almost the XXXJPY pairs...

Thanks Pal for your excellent coding...

Cheers

Sahars
  • #374
  • Nov 5, 2009 5:50am Nov 5, 2009 5:50am
I don't understand how anyone made money on the trades the EA took at Tokyo's close.
My individual BOJ EA took Longs at 06:30:
EUR/JPY @ 134.34
CAD/JPY @ 85.00
GBP/JPY @ 149.49
... all went to -50-60 down ... have pulled back to about 30 underwater at present - but certainly not making money.

What I have got so wrong?
Do I need to load the BOJ Basket not the BOJ trading robot?
But the BOJ Basket I downloaded from page 1 is a .php file and doesn't show in experts when saved.
Any suggestions?
Sorry to be a novice .... trying my best though.
  • #375
  • Nov 5, 2009 5:52am Nov 5, 2009 5:52am
Updated version in post 1, for those of you who want to experiment by forcing a basket trade.

  • #376
  • Nov 5, 2009 5:52am Nov 5, 2009 5:52am
Quoting SteveHopwood
Thanks. I will look into this.
If you would like me to fix it to dynamically look for any pair and adjust itself, I would be happy to. I have already thought out how to do it and can do it in about 5 minutes, if you have the source code. You can PM me if you want me to do it and take some of the work off of you.
  • #377
  • Nov 5, 2009 5:55am Nov 5, 2009 5:55am
[quote=sahars;3210674]Hi Steve,

As always you create something outstanding EA. BTW..I realized that the EA does not open any trade (either on basket or individual) if the previous opened trade at the previous session does not closed. It needs to be closed manually all the previous trade in order the new trade to be opened...I'm not sure whether this matter has been fixed yet or not at your revised version...

Just for your info, the KG Range is open buying trade almost the XXXJPY pairs...

Thanks Pal for your excellent coding...

Cheers

Sahars[/quote
Hi
I think that is because hedge is not allowed
  • #378
  • Nov 5, 2009 5:56am Nov 5, 2009 5:56am
Quoting sahars
Hi Steve,

As always you create something outstanding EA. BTW..I realized that the EA does not open any trade (either on basket or individual) if the previous opened trade at the previous session does not closed. It needs to be closed manually all the previous trade in order the new trade to be opened...I'm not sure whether this matter has been fixed yet or not at your revised version...
I shall leave it as it is for now. If this becomes a problem, I will sort it out.

This does remind me I need to code a one-basket-a-session function; I had forgotten about that.

  • #379
  • Nov 5, 2009 6:02am Nov 5, 2009 6:02am
Quoting smjones
If you would like me to fix it to dynamically look for any pair and adjust itself, I would be happy to. I have already thought out how to do it and can do it in about 5 minutes, if you have the source code. You can PM me if you want me to do it and take some of the work off of you.
Cheers. I have taken you up on the offer and sent a pm.

  • #380
  • Nov 5, 2009 6:28am Nov 5, 2009 6:28am
Quoting SteveHopwood
Cheers. I have taken you up on the offer and sent a pm.

Finished
3 traders viewing now