troublesome line of code | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Variable Window and Line By Line Learning 4 replies

Help to edit day open line to week open line ! 11 replies

Yesterday closing line and Today Opening Line Indicator 0 replies

rsi crossing the 20 line and the 80 line 0 replies

hwo to get rid of teh Buy line and Sell line 2 replies

troublesome line of code

  • #1
  • First Post: Aug 22, 2009 7:16am Aug 22, 2009 7:16am
Hi People,

I am having trouble with this line of code. I do not get errors but it doesn't work.

I am new at this so, if I am missing something really obvious, sorry.

What the code is supposed to do is to evaluate the current price and if it is lower than the open of the last 15 minute bar X pricepoint, then not order.


extern double pricepoint3 = 30


if(MayOpenDeferOrder) //can open limit or stop orders.
{
if((type == _OP_BUY) && Bid <= (iOpen(NULL,PERIOD_M15,1)-(pricepoint3*0.0001))) MayOpenDeferOrder = false;
}

If someone could point me to the problem, I would really appreciate it.

cheers A
  • #2
  • Aug 22, 2009 12:48pm Aug 22, 2009 12:48pm
Its hard to guess the full context of your codes if you only post snipplet.

but this line (type == _OP_BUY) looks weird.

remove the underscore before OP_BUY to look like below and see how it goes.

(type == OP_BUY)
Programming for a better future.
  • #3
  • Aug 22, 2009 1:05pm Aug 22, 2009 1:05pm
Yeah, the "_OP_BUY" doesn't look right.
  • #4
  • Edited 5:52am Aug 23, 2009 4:03am | Edited 5:52am
Quoting ecTrade
Yeah, the "_OP_BUY" doesn't look right.
Thanks guys.. I have this going and now I have another problem.

I might be getting a bit to far advanced for my 3 days programming experience but I would like to get this going if I can.

I am trying to introduce a time out on the buy stop order and have it deleted after 15 minutes.

I have managed to put together this code but;

1) I am not really sure it will do what I want and

2) it comes up with a warning message that the function is not referenced.

What do you all think?

.............................................................................................

extern double StopResetMinutes =15;
extern int UseDeferOrderTimeout =1;

if (UseDeferOrderTimeout == 1)
{

if ((TimeCurrent() - OrderOpenTime()) >= StopResetMinutes)

{ total=OrdersTotal();

for(int i=0; i<total; i++)

{

if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))

{

cmd=OrderType();
if(cmd!=OP_BUY && cmd!=OP_SELL)

{

OrderPrint();

result=OrderDelete(OrderTicket());

if(result!=TRUE) Print("LastError = ", GetLastError());
break;

}

}
else { Print( "Error when order select ", GetLastError()); break; }

return(0);

}
}

}

Edit, I changed the code here and I think it looks better but still it comes up with a few errors.

Errors:

UseDeferOrderTimeout .... expression not allowed on global scope
{ .... expression not allowed on global scope
i .... variable already defined
cmd .....variable not defined

Among others... I would be good if I could just fix one at a time.. If anyone has any clues why this is so messed up. Please let me know

cheers

A
  • #5
  • Aug 23, 2009 6:49am Aug 23, 2009 6:49am
Dont worry people,

I have it working and thanks

This is what I did at the end.. took some figuring out

if (UseDeferOrderTimeout > 0)
{
total = OrdersTotal();

for(int x = 0; x < total; x++)
{
OrderSelect(i,SELECT_BY_POS,MODE_TRADES);

if(OrderSymbol() != Symbol()) continue;

if((OrderType() == OP_BUY) || (OrderType() == OP_SELL))
{
if((TimeCurrent() - OrderOpenTime()) >= StopResetMinutes * 60)
{
if(PrintComments) Print("Stop Order Deleted");

OrderDelete(OrderTicket());
}
}

}

}
  • #6
  • Aug 23, 2009 7:52am Aug 23, 2009 7:52am
Did you figure this out on your own? Looks pretty good. It's nice and neat.

Of course I don't claim to be an expert on such things ... not just yet.
  • #7
  • Aug 23, 2009 10:15am Aug 23, 2009 10:15am
Quoting ecTrade
Did you figure this out on your own? Looks pretty good. It's nice and neat.

Of course I don't claim to be an expert on such things ... not just yet.
Yes, I figured out how to cheat a bit more.

I have another problem (seems they are never ending). I would like my EA to wait for 15 minutes after take profit until it submits another order.

I am really not sure how to go about it. I thought maybe I could do this

If take profit < x minutes, do not order. I can write most of the code but I am stumped with the take profit bit.

Anyway, I will get back with what I come up with and see if anyone has any suggestions
  • #8
  • Aug 23, 2009 11:43am Aug 23, 2009 11:43am
Am not sure how to set up the delay, but you should be able to use this to get the order to repeat itself. Which will continue to do so until you set up the delay and define "Set_Delay," which is the value specified once "Time_Count" is reached. So long as "Set_Delay" and "Time_Count" are set to 0 (by default), it will continue to place orders without a delay. I don't know, does that make any sense?

The OrderCloseTime() function at the bottom determines when the order closes and resets "Gate1" and "Time_Count," in order to place the next order.

PHP Code
//+------------------------------------------------------------------+
//|                                              Recurring Order.mq4 |
//|                                Copyright © 2009, Dennis Hamilton |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2009, Dennis Hamilton"
#property link      "[email protected]"

extern string Symbol1="EURUSD";
extern double Lots1=0.05;
extern int Slip=3,TakeProfit=10;

int Gate1=0,Ticket5,Set_Delay=0,Time_Count=0;

//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   if(Gate1==0&&Set_Delay==Time_Count)
     {
      Ticket5=OrderSend(Symbol(),OP_BUY,Lots1,Ask,Slip,0,Ask+Point*TakeProfit,"",0,0,Blue);
      Gate1=1;
     }
   if(OrderSelect(Ticket5,SELECT_BY_TICKET,MODE_HISTORY)==true)
     {
      datetime ctm=OrderCloseTime();
      if(ctm>0){ Gate1=0; Time_Count=0; }
     }
//----
   return(0);
  }
//+------------------------------------------------------------------+
  • #9
  • Aug 24, 2009 1:15pm Aug 24, 2009 1:15pm
Try this

if (TimeCurrent()>(OrderCloseTime()+900)) { Gate1=0; Time_Count=0; }

Quoting ecTrade
Am not sure how to set up the delay, but you should be able to use this to get the order to repeat itself. Which will continue to do so until you set up the delay and define "Set_Delay," which is the value specified once "Time_Count" is reached. So long as "Set_Delay" and "Time_Count" are set to...
  • #10
  • Aug 24, 2009 6:49pm Aug 24, 2009 6:49pm
Quoting findmanu
Try this

if (TimeCurrent()>(OrderCloseTime()+900)) { Gate1=0; Time_Count=0; }

You Guys are great.. this is exactly what I needed

cheers

A
  • #11
  • Aug 24, 2009 7:16pm Aug 24, 2009 7:16pm
If you wanted to have the pending order expire why not just set the 'expiration' property when you place the order? Much simpler than what you've done.

Here's the definiton of the OrderSend function...

Inserted Code
int OrderSend( string symbol, int cmd, double volume, double price, int slippage, double stoploss, double takeprofit, string comment=NULL, int magic=0, datetime expiration=0, color arrow_color=CLR_NONE)

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #12
  • Aug 24, 2009 8:10pm Aug 24, 2009 8:10pm
Quoting luxinterior
If you wanted to have the pending order expire why not just set the 'expiration' property when you place the order? Much simpler than what you've done.

Here's the definiton of the OrderSend function...

Inserted Code
int OrderSend( string symbol, int cmd, double volume, double price, int slippage, double stoploss, double takeprofit, string comment=NULL, int magic=0, datetime expiration=0, color arrow_color=CLR_NONE)
Lux
Hi Lux,

I am not wanting a pending order to expire, just to delay orders after the takeprofit event.

The other reason of course is because I am so new at coding (forth day now).. it needs to be really simple for me to be able to do it.

Thanks so much for the info though.
  • #13
  • Aug 25, 2009 6:17am Aug 25, 2009 6:17am
Quoting findmanu
Try this

if (TimeCurrent()>(OrderCloseTime()+900)) { Gate1=0; Time_Count=0; }
By the way, the +900 value for the OrderCloseTime is not showing up correctly. It shows up as +90 0 (with a space) instead of +900. I was going to reply and ask how you were calculating this, but saw that it said +900 in the editor mode. And of course 900 divided by 60 equals 15 or, 15 minutes, and that makes sense.

Thanks!
  • #14
  • Aug 25, 2009 7:56am Aug 25, 2009 7:56am
I was responding to this line in post #4...

Quote
I am trying to introduce a time out on the buy stop order and have it deleted after 15 minutes.

Must have misunderstood. English is only my first language

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #15
  • Aug 25, 2009 11:00am Aug 25, 2009 11:00am
Quoting luxinterior
I was responding to this line in post #4...



Must have misunderstood. English is only my first language

Lux

Oh, sorry, I had that sorted out and I had moved on to the next problem.

I still have quite a few to sort out but I am getting there.
  • #16
  • Aug 27, 2009 1:07am Aug 27, 2009 1:07am
I wonder if anyone can tell me why this code prevents any orders and causes the visual backtest to freeze?

I have been at this for hours now.. can not figure it out.

if(MayOpenDeferOrder && (Delay_Next_Order_Minutes > 0)) //Time Delay for the next Order
{
total = OrdersTotal();

for(i = total - 1; i >= 0; i--)
{
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);

if(OrderSymbol() != Symbol()) continue;

if((OrderType() == OP_BUY) || (OrderType() == OP_SELL))
{
if((TimeCurrent() - OrderOpenTime() /60) > Delay_Next_Order_Minutes) MayOpenDeferOrder = false;
}
}
}

Any suggestions would be appreciated..

thanks

A
  • #17
  • Aug 27, 2009 1:25am Aug 27, 2009 1:25am
Quoting asgard2
I wonder if anyone can tell me why this code prevents any orders and causes the visual backtest to freeze?

I have been at this for hours now.. can not figure it out.

if(MayOpenDeferOrder && (Delay_Next_Order_Minutes > 0)) //Time Delay for the next Order...
Am not sure about this? "if(MayOpenDeferOrder && (Delay_Next_Order_Minutes > 0))" ...

Is "Delay_Next_Order_Minutes" a function or just a variable?

If it's a function, I believe it should read, "if(MayOpenDeferOrder && Delay_Next_Order_Minutes() > 0)" ...

If it's just a variable it should read, "if(MayOpenDeferOrder && Delay_Next_Order_Minutes > 0)" ...
  • #18
  • Aug 27, 2009 2:15am Aug 27, 2009 2:15am
Quoting ecTrade
.

Is "Delay_Next_Order_Minutes" a function or just a variable?
.

Hi EC

No, Delay_Next_Order_Minutes is just a variable. Since this is the first OrderSelect I have done (never want to do another) I thought I must have something wrong there.

I pasted in your code and it still hangs the chart and wont open any orders.

I will keep plugging away.. If you have any more idea's, I would love to hear them.


cheers

A
  • #19
  • Aug 27, 2009 2:31am Aug 27, 2009 2:31am
Basic math...... remember how math problems are supposed to be solved.....

if((TimeCurrent() - OrderOpenTime() /60) > Delay_Next_Order_Minutes) MayOpenDeferOrder = false;


changed to:

if(((TimeCurrent() - OrderOpenTime()) /60) > Delay_Next_Order_Minutes) MayOpenDeferOrder = false;

The way it was caused the code to convert orderopentime to minutes then subtract it from TimeCurrent().
  • #20
  • Aug 27, 2009 2:48am Aug 27, 2009 2:48am
Quoting magnumfreak

changed to:

if(((TimeCurrent() - OrderOpenTime()) /60) > Delay_Next_Order_Minutes) MayOpenDeferOrder = false;

The way it was caused the code to convert orderopentime to minutes then subtract it from TimeCurrent().
I changed it.

I think my head hurts... still no luck! No compile errors.. either.
0 traders viewing now