help w/ indicator | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Peak and Trough indicator - someone help make this indicator 2 replies

Please help turn this price channel indicator to MTF indicator 0 replies

Please help to change this indicator into MTF indicator 3 replies

help, help, help (templates) 5 replies

help w/ indicator

  • #1
  • First Post: Aug 23, 2009 2:21pm Aug 23, 2009 2:21pm
I'm hoping someone here can help. I'm trying to write an indicator that will tell me how much time is remaining in a candle.

But I can't figure out if I'm getting the right data. I get some huge number that I can't translate into minutes.

I'm trying this on a 4hr chart (backtesting. which, for something that should be so simple, should be easy to do).

Inserted Code
#property indicator_chart_window
int init()
  {
   return(0);
  }
int deinit()
  {
   return(0);
  }
int start()
  {
   int    counted_bars=IndicatorCounted(); int limit; 
   if(counted_bars<0) return(-1); 
   datetime varLeft;
   limit=Bars-counted_bars-1;
   for(int shift=0; shift<limit; shift++)
   {   
      varLeft=TimeCurrent()-Time[shift];
      Comment(varLeft," minutes left until end of bar");
   }
   return(0);
  }
  • #2
  • Aug 23, 2009 2:27pm Aug 23, 2009 2:27pm
use this function:

string TimeToStr( datetime value, int mode=TIME_DATE|TIME_MINUTES)
Converts value containing time in seconds that has passed since January 1, 1970, into a string of "yyyy.mm.dd hh:mi" format.
Parameters:
value - Positive amount of seconds that have passed since 00:00, January 1, 1970.
mode - Optional data output mode can be one or combination of:
TIME_DATE gets result as "yyyy.mm.dd",
TIME_MINUTES gets result as "hh:mi",
TIME_SECONDS gets result as "hh:mi:ss".

Sample:
string var1=TimeToStr(TimeCurrent(),TIME_DATE|TIME_SECONDS);
  • #3
  • Aug 23, 2009 4:16pm Aug 23, 2009 4:16pm
Thanks, that gets it in a readable format, but on a 4hour chart, it's counting down until the end of the day (I used TIME_MINUTES).

Any ideas?
  • #4
  • Aug 23, 2009 5:02pm Aug 23, 2009 5:02pm
varLeft = (Time[shift] + 1440) - TimeCurrent();

Take the time of the bar add 4 hours to it (1440 seconds) then subtract the current time.
  • #5
  • Aug 23, 2009 6:38pm Aug 23, 2009 6:38pm
returns invalid time error from the comment. And I get the usual large number otherwise.
  • #6
  • Aug 23, 2009 6:45pm Aug 23, 2009 6:45pm
Quoting nondisclosure00
returns invalid time error from the comment. And I get the usual large number otherwise.
oops, didn't think about it returning a number too low. You will have to do the math to convert the seconds remaining into minutes and seconds. varLeft will contain the number of seconds until the end of the candle.
  • #7
  • Last Post: Aug 23, 2009 7:05pm Aug 23, 2009 7:05pm
well, here's the code that works, kind of. In a back test, timecurrent() pulls last server time and not current tester time. I wish there was a way to fix that. to use tester time, then i could appropriately test my EA.
Inserted Code
//+------------------------------------------------------------------+
//|                                        Candle_Remaining_Time.mq4 |
//|                      Copyright © 2009, MetaQuotes Software Corp. |
//|                                        [url]http://www.metaquotes.net[/url] |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2009, MetaQuotes Software Corp."
#property link      "[url]http://www.metaquotes.net[/url]"
#property indicator_chart_window
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int    counted_bars=IndicatorCounted(); int limit; 
   if(counted_bars<0) return(-1); 
   datetime varLeft; 
   int varBarday, varBarhour, varBarminute, varCurday, varCurhour, varCurminute;
   int varRemday, varRemhour, varRemminute;
   limit=Bars-counted_bars-1;
   for(int shift=0; shift<limit; shift++)
   {   
      varBarday=TimeDay(Time[shift]);
      varBarhour=TimeHour(Time[shift]);
      varBarminute=TimeMinute(Time[shift]);
      varCurday=TimeDay(TimeCurrent());
      varCurhour=TimeHour(TimeCurrent());
      varCurminute=TimeMinute(TimeCurrent());
      varRemday=varCurday-varBarday;
      varRemhour=varCurhour-varBarday;
      varRemminute=varCurminute-varBarminute;
      Comment(varRemday," Days,",varRemhour," Hours,",varRemminute," Minutes until end of candle");
   }
   return(0);
  }
//+------------------------------------------------------------------+
0 traders viewing now