Modifying Order Based on Order Count | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Help - Modifying the SweetSpot Indicator 8 replies

convert indicator that count bars to have it count ticks. is this possible? 0 replies

EA question on modifying an order's comment field. 2 replies

Help needed with modifying an ea 0 replies

Modifying the standard Trendline tool... 1 reply

Modifying Order Based on Order Count

  • #1
  • First Post: Aug 6, 2009 7:47pm Aug 6, 2009 7:47pm
Okay, I expect I could probably figure this out on my own (eventually) but, since I see no point in banging my head against the wall, I figured I'd give it a try. What I'm trying to do is modify a preexisting order based upon the order count.

Here is the code I'm using that determines the total orders, beginning with the earliest order I believe, and counts up incrementally.

PHP Code
//---- Check for Open Orders
   int total=OrdersTotal(),cmd,TBS_cnt=0;
   for(int cnt=0; cnt<=total; cnt++)
     {
      if(OrderSelect(cnt,SELECT_BY_POS)==true)
        {
         cmd=OrderType();
         if(cmd==OP_BUY||cmd==OP_SELL){ TBS_cnt+=1; }
        }
     }
Basically what I've done is create the first "counter" to determine the number of orders or current count (both OP_BUY and OP_SELL) and duplicated it (by adding a "2' at the end of each variable) to create a second counter for determining the second order preceding the current one, which was just placed. This is the order I'm attempting to modify and change the Take Profit value.

PHP Code
//---- Modify Selected Orders
   int totalZ=OrdersTotal(),cmdZ,TBS_cntZ=0;
   for(int cntZ=0; cntZ<=totalZ; cntZ++)
     {
      if(OrderSelect(cntZ,SELECT_BY_POS)==true)
        {
         cmdZ=OrderType();
         if(cmdZ==OP_BUY||cmdZ==OP_SELL){TBS_cntZ+=1; }
         if(TBS_cnt>2&&TBS_cntZ==TBS_cnt-2)
          {
           OrderModify(TBS_cntZ,0,0,OrderTakeProfit()-Point*TP1,0,Blue);
          }
       }
    }
I haven't attempted to do this before (although I know the first counter works), so I'm only guessing this is how it should be done. And, although it complies okay, and the initial orders are processed okay, it won't come back and modify them.

Anybody got any ideas?

Thanks!
  • #2
  • Aug 6, 2009 8:05pm Aug 6, 2009 8:05pm
Is there any reason you cannot sort by ordercomment?
  • #3
  • Aug 6, 2009 8:16pm Aug 6, 2009 8:16pm
The first parm to OrderModify is ticket number, not a count.
  • #4
  • Aug 6, 2009 8:30pm Aug 6, 2009 8:30pm
Quoting Ronald Raygun
Is there any reason you cannot sort by ordercomment?
No, I am not familiar with that. Also, I will most likely not know what order it is, because the orders are part of an array. So, the only thing I really have to go on is the order count.

The reason I am trying to do this is in case the computer crashes or something happens so I have to reopen the EA. Currently it's set up to modify selected orders but, only so long as the computer is up and running and something doesn't happen to the EA. If something happens and there are any preexisting orders, the information is lost and it won't acknowledge them. At which point I have to modify each one manually and it is no longer automatic, which kind of sucks.
  • #5
  • Aug 6, 2009 8:41pm Aug 6, 2009 8:41pm
Quoting Kenz987
The first parm to OrderModify is ticket number, not a count.
Parm, what is that? ... and, if I don't have the ticket number, does that mean I can't modify it?

Of course this little gem here (from the other thread), seems perfectly capable of modifying the order without a ticket number (or, so it seems). Maybe I can figure out what I need to do by studying this further?

PHP Code
//+------------------------------------------------------------------+
//|                              StopLoss and TakeProfit Manager.mq4 |
//|                              Copyright © 2009, TradingSytemForex |
//|                                http://www.tradingsystemforex.com |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2009, TradingSytemForex"
#property link "http://www.tradingsystemforex.com"

extern int StopLoss=21;
extern int TakeProfit=10;

//+------------------------------------------------------------------+

void start() 
{
   double SL,TP;
   int i,Total;
   int Dig=MarketInfo(Symbol(),MODE_DIGITS);     

//+------------------------------------------------------------------+

  Total=OrdersTotal();
  if(Total>0)
  {
     for(i=Total-1; i>=0; i--) 
     {
        if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES)==true) 
        {
           if(OrderSymbol()==Symbol() && OrderType()==OP_SELL && OrderStopLoss()==0 && OrderTakeProfit()==0) 
           {
              if(StopLoss>0)SL=OrderOpenPrice()+StopLoss*Point;else SL=0;
              if(TakeProfit>0)TP=OrderOpenPrice()-TakeProfit*Point;else TP=0;
              OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(SL,Dig),NormalizeDouble(TP,Dig),OrderExpiration(),CLR_NONE);
           }
           if(OrderSymbol()==Symbol() && OrderType()==OP_BUY && OrderStopLoss()==0 && OrderTakeProfit()==0) 
           {
              if(StopLoss>0)SL=OrderOpenPrice()-StopLoss*Point;else SL=0;
              if(TakeProfit>0)TP=OrderOpenPrice()+TakeProfit*Point;else TP=0;
              OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(SL,Dig),NormalizeDouble(TP,Dig),OrderExpiration(),CLR_NONE);
           }
        }
     }
  }
}

//+------------------------------------------------------------------+
  • #6
  • Aug 6, 2009 9:04pm Aug 6, 2009 9:04pm
By the way, the ticket number is just an integer value I believe. So, what I need to do is come up with this value in order to get it to work. Or, maybe not, I don't know? I don't know if can do this just by the order count alone?
  • #7
  • Aug 6, 2009 9:10pm Aug 6, 2009 9:10pm
Actually it is using the ticket number. If you look at the piece of code you posted you'll see in the OrderModify function the very first parameter ('param' as a previous poster abbreviated it too ) is OrderTicket which is the order ticket for the order index you're currently looking at. Make sense? You're passing the count variable when in fact you need to pass the ticket number of the order who's index you have counted (-1 as it's zero based index).

Good luck

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #8
  • Aug 6, 2009 9:37pm Aug 6, 2009 9:37pm
Hey, I got it to modify the orders when substituting 'TBS_cntZ' with 'OrderTicket().' Does that make sense?

So, instead it of:

PHP Code
OrderModify(TBS_cntZ,0,0,OrderTakeProfit()-Point*TP1,0,Blue);
It should read:

PHP Code
OrderModify(OrderTicket(),0,0,OrderTakeProfit()-Point*TP1,0,Blue);
Of course I don't know exactly which orders were modified or, if it still works if the computer goes down but, I'll find out soon enough.
  • #9
  • Aug 6, 2009 9:43pm Aug 6, 2009 9:43pm
Did you read my response above? The ticket is the for the order that you've currently selected with OrderSelect. So if you're looping through the orders then your first index will be 0, next one is 1 etc. It depends where you are in your loop as to which order is selectd and therefore which order is modified.

Lux
MT4 EA, Indicator and Alert Coder Since 2006
  • #10
  • Aug 6, 2009 9:59pm Aug 6, 2009 9:59pm
Yes, I did read it, but not until after I posted my response. And yes, I understand that the ticket numbers are unique and, that they're not the same as the count but, I have to find a way to associate the two in order to get it to work, I believe.

Okay, so what if there were only 3 open orders, are these referred to as tickets 0,1 and 2, in spite of the fact that there may have been previous orders listed the same? Is it only the open orders that are listed? If so, then it should be pretty easy to do what I want to do.
  • #11
  • Aug 6, 2009 10:02pm Aug 6, 2009 10:02pm
hey ec.... the journal should show the ticket number and any action taken.... such as modifying , closing and such....

it might be possible for the ticket numbers not to be in chronological order....

using maigicnumbers can help maintain control.....

if you for some reason need the earliest/oldest order placed, sort by OrderOpenTime().....h
to trade and code, keep both simple... no call to impress....h
  • #12
  • Aug 6, 2009 10:10pm Aug 6, 2009 10:10pm
Quoting luxinterior
The ticket is the for the order that you've currently selected with OrderSelect.

Lux
The thing is, I don't know which order I've selected, except that it has to be based upon the count (in the order of succession) in order for it to work.
  • #13
  • Aug 6, 2009 10:28pm Aug 6, 2009 10:28pm
Quoting hayseed
hey ec.... the journal should show the ticket number and any action taken.... such as modifying , closing and such....

it might be possible for the ticket numbers not to be in chronological order....

using maigicnumbers can help maintain control.....

if you for some reason need the earliest/oldest order placed, sort by OrderOpenTime().....h
Yes, I need to place the ticket numbers in chronological order after the machine has been shut down, or the program has closed, and it looks like the OrderOpenTime() might be what I need to use. Will see. Thanks.
  • #14
  • Last Post: Aug 9, 2009 1:15pm Aug 9, 2009 1:15pm
Well, I almost got it to work.

Here is the code that I came up with:

PHP Code
int Prev_Open=0;
for(int ii=(OrdersTotal()-1); ii>=0; ii--)
  {
   OrderSelect(ii, SELECT_BY_POS, MODE_TRADES);
   int Cur_Open=OrderOpenTime();
   if(Cur_Open>Prev_Open)
     {
      Prev_Open+=1;
      if(Prev_Open==1){ TBuy1=OrderTicket(); }
      if(Prev_Open==2){ TBuy2=OrderTicket(); }
     }
  }
OrderModify(TBuy2,OrderOpenPrice(),0,OrderOpenPrice()-Point*TP1,0,Red);
Currently I'm focusing on the TBuy2 Ticket, which is supposed to grab the second order back, which is what it does. And that's great! However, when inputting the OrderOpenPrice() in the Take Profit field, depending on where the OrderModify() function is called up in the program, I either get a bunch of goose eggs or, the wrong the value. That's not right is it? And no, it doesn't matter whether the "-Point*TP1" is there or not.

I also tried substituting the OrderTakeProfit() function instead, but that doesn't make any difference either.

Can anyone help?
0 traders viewing now