Can someone try to fix this indicator (fixed) | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Can someone fix this currency strength indicator? 37 replies

Could someone fix this indicator, please? 0 replies

Can someone please fix this alert indicator? 0 replies

Can someone please fix this MA cross indicator? 1 reply

Need someone to fix bugs in my indicator 3 replies

Attachments: Can someone try to fix this indicator (fixed)
Exit Attachments

Can someone try to fix this indicator (fixed)

  • #1
  • First Post: Edited 12:22pm Jun 29, 2009 7:38am | Edited 12:22pm
Hi everyone,

i have made an indicator based on a strategy i'm looking at but can't find what's wrong with it.

The purpose is for it to place previous week high/low/middle and a short and long indicator line.

The long indicator line seems to be ok (but i'm not sure the calculation is right) but the short has the same value as the long despite the calculation being reversed.

The code is pretty self explainatory. Thanks a lot in advance.
Attached File(s)
File Type: mq4 High Low.mq4   5 KB | 623 downloads
  • #2
  • Jun 29, 2009 10:09am Jun 29, 2009 10:09am
Inserted Code
               PrevWeekHi = LastWeekHi;
               PrevWeekLo = LastWeekLo;
               LastWeekHi = Open[i];
               LastWeekLo = Open[i];
               PrevWeekMid= (PrevWeekHi + PrevWeekLo)/2;
               PrevWeekClose = Close[i+1];
               PipValue = (LastWeekHi - LastWeekLo)/3;
               PrevWeekShort = PrevWeekClose - (LastWeekHi - LastWeekLo)/3;
               PrevWeekLong = PrevWeekClose + (LastWeekHi - LastWeekLo)/3;

You're setting both LastWeekHi and LastWeekLo equal to Open[i].
Hence (LastWeekHi - LastWeekLo)/3 will always equal zero.
Hence PrevWeekShort and PrevWeekLong will both equal PrevWeekClose - 0, i.e. the same value.


Not sure exactly what you're trying to achieve, but if you change the last two lines to.......

Inserted Code
               PrevWeekShort = PrevWeekClose - ([u]Prev[/u]WeekHi - [u]Prev[/u]WeekLo)/3;
               PrevWeekLong = PrevWeekClose + ([u]Prev[/u]WeekHi - [u]Prev[/u]WeekLo)/3;

.......does this give the desired result?
  • #3
  • Last Post: Jun 29, 2009 12:04pm Jun 29, 2009 12:04pm
Quoting hanover
[code]...
Doh i'm so stupid ! When you look the code too long you miss the obvious

Thanks Hanover. The result is as expected
0 traders viewing now