Help with code. | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

indicator code to inside EA code 15 replies

Help - any tools that can easily convert MQL4 code to Easy Language code? 7 replies

Translating some code into Pseudo code for a laymen? 3 replies

Hidden Code in Code 12 replies

help, help, help (templates) 5 replies

Attachments: Help with code.
Exit Attachments

Help with code.

  • #1
  • First Post: Jun 13, 2009 5:58am Jun 13, 2009 5:58am
I am trying to compare the current candle volume to the average volume data for x amount of bars.

I have looked at a ton of different things and tried all of them but none seem to be working.

Does any one know the code to do this?

I have the math correct (once I have the average) I just can't seem to get the average code correct.

This is my last attempt:
Inserted Code
 
 
double a = iVolume(NULL,0,lookback)/Point; //Look back is number of bars to average out over
 
double c = Volume[Current]; //Current Candle Volume

Any help is appreciated.
The trend always ends.
  • #2
  • Jun 13, 2009 8:18am Jun 13, 2009 8:18am
Top of the code;

extern int NumberOfBars = 500;
extern int MA_Length = 100;

//---- buffers
double v4[];
double Vol[];


Put this after int Start();
AVGVolume();

Put this at the bottom of the code;
int AVGVolume()
{
double tempv;
int limit;
int counted_bars=IndicatorCounted();
//---- last counted bar will be recounted
if(counted_bars>0) counted_bars--;
if ( NumberOfBars == 0 )
NumberOfBars = Bars-counted_bars;
limit=NumberOfBars; //Bars-counted_bars;


for(int i=0; i<limit; i++)
{
tempv=0;


for( int n=i;n<i+MA_Length;n++ )
{
tempv= Volume[n] + tempv;
}
v4[i] = NormalizeDouble(tempv/MA_Length,0); // AVERAGE VOLUME
Vol[i]= iVolume(NULL, 0, i); // CURRENT VOLUME


}
//----
return(0);
}


Regards
forexflash
  • #3
  • Jun 13, 2009 8:31am Jun 13, 2009 8:31am
Shamous...is it working??

you also need to put this after init;

SetIndexBuffer(5,v4);
SetIndexStyle(5,DRAW_NONE);
SetIndexBuffer(6,Vol);
SetIndexStyle(6,DRAW_NONE);

The bold numbers represents a number of buffer...this ones are 5 and 6th.
This will work only if you have less bufers than 5 curently...and you also need to add 2 buffers at the top of the code.....#property indicator_buffers 7

Regards
forexflash
  • #4
  • Jun 13, 2009 9:01am Jun 13, 2009 9:01am
No since I'm not a coder Thanks for you help though.
The trend always ends.
  • #5
  • Jun 13, 2009 9:13am Jun 13, 2009 9:13am
Here..........
Attached File(s)
File Type: mq4 shamous average volume.mq4   2 KB | 250 downloads
forexflash
  • #6
  • Jun 13, 2009 9:20am Jun 13, 2009 9:20am
Thank you sir. It's not that I couldn't get the code in. It has a number of things it needs to do, and I can't make your code work with mine.

I'll try modifiy your code as a base. Maybe I can get it working that way.
The trend always ends.
  • #7
  • Jun 13, 2009 9:31am Jun 13, 2009 9:31am
If you want I can help you even more.....just tell exactly what do you need! Or you can post code here for me to check it out.

Regards
forexflash
  • #8
  • Jun 13, 2009 11:03am Jun 13, 2009 11:03am
I need to use the averaged number v4 in calculations with Vol in another part of the script.

Inserted Code
 
double average = v4;
double current = Vol;
 
if ( current < average )
{ 
DisplayOrderMessage("Current Bar Volume: Low");
}

is not working.

I have tried a bunch of things but so far no luck. How can I use the buffers for v4 and Vol in the script?
The trend always ends.
  • #9
  • Jun 13, 2009 11:25am Jun 13, 2009 11:25am
Quoting ShamusFamous
I need to use the averaged number v4 in calculations with Vol in another part of the script.

Inserted Code
 
double average = v4;
double current = Vol;
 
if ( current < average )
{ 
DisplayOrderMessage("Current Bar Volume: Low");
}

is not working.

I have tried a bunch of things but so far no luck. How can I use the buffers for v4 and Vol in the script?

Try this...it should work!
If (Vol[0]<v4[0])
{
Message("Current Bar Volume: Low");
}

Regards
forexflash
  • #10
  • Jun 13, 2009 11:27am Jun 13, 2009 11:27am
Quoting FOREXflash
Try this...it should work!
If (Vol[0]<v4[0])
{
Message("Current Bar Volume: Low");
}

Regards

I'm pretty sure that was one of the variations I tried but I'll try it again.
The trend always ends.
  • #11
  • Jun 13, 2009 11:34am Jun 13, 2009 11:34am
Look this...I added your text massage to previous code!
Look at the code after the int Start()
Attached File(s)
File Type: mq4 shamous average volume.mq4   2 KB | 279 downloads
forexflash
  • #12
  • Jun 13, 2009 11:52am Jun 13, 2009 11:52am
Quoting FOREXflash
Look this...I added your text massage to previous code!
Look at the code after the int Start()

Based on certain calculations it is placing an arrow above or below the candle. It is placing the same arrow (same color) on every candle.
The trend always ends.
  • #13
  • Jun 13, 2009 12:01pm Jun 13, 2009 12:01pm
You need to have 2 buffers for 2 colors!
This code is exactly what you are looking for.
Attached File(s)
File Type: mq4 shamous signals.mq4   2 KB | 326 downloads
forexflash
  • #14
  • Jun 13, 2009 12:17pm Jun 13, 2009 12:17pm
Quoting FOREXflash
You need to have 2 buffers for 2 colors!
This code is exactly what you are looking for.

I am using 5 colors One for each calculation and a total of 7 buffers (5) for arrows/colors and 2 for your averaging code. Depending on the result of the math a bar is flaged with an icon and a color and a message is printed to the chart.



Currently every bar is being made the same arrow and the same color.

I'll figure it out. Thanks again for your help.
The trend always ends.
  • #15
  • Jun 13, 2009 12:28pm Jun 13, 2009 12:28pm
I finally got it. I missed an int in place of current bar 0

Thank you again for your help.

Now the next question. Can you make a message print to chart using bold attribute?

I have font, face, and size.

Cheers
The trend always ends.
  • #16
  • Jun 13, 2009 12:42pm Jun 13, 2009 12:42pm
Just add this;

if (ObjectFind("Shamous") == -1 )
{
ObjectCreate("Shamous", OBJ_LABEL, 0, 0, 0);
ObjectSet("Shamous", OBJPROP_COLOR, Red);
ObjectSet("Shamous", OBJPROP_CORNER, Corner);
ObjectSet("Shamous", OBJPROP_XDISTANCE, 5);
ObjectSet("Shamous", OBJPROP_YDISTANCE, 15);}
ObjectSetText("Shamous","VOLUME: PENDING...", 10,"Tahoma Bold",White);

bold text; YOUR TEXT, SIZE, FONT, COLOR

BE ADVISED THAT THE TEXT SHAMOUS IN ALL THE LINES OF CODE NEEDS TO BE CHANGED FOR EVERY NEXT TEXT YOU WILL USE!!!
LIKE;

if (ObjectFind("Shamous1") == -1 )
{
ObjectCreate("Shamous1", OBJ_LABEL, 0, 0, 0);
ObjectSet("Shamous1", OBJPROP_COLOR, Red);
ObjectSet("Shamous1", OBJPROP_CORNER, Corner);
ObjectSet("Shamous1", OBJPROP_XDISTANCE, 5);
ObjectSet("Shamous1", OBJPROP_YDISTANCE, 15);}
ObjectSetText("Shamous1","SPREAD: PENDING...", 10,"Tahoma Bold",Red);

ETC............
forexflash
  • #17
  • Jun 13, 2009 3:25pm Jun 13, 2009 3:25pm
Thank you sir.
The trend always ends.
  • #18
  • Last Post: Jun 14, 2009 3:39am Jun 14, 2009 3:39am
Thanks again for your help FF. I was able to get it all done and it works awesome.
The trend always ends.
0 traders viewing now