Popup Alert When MA cross... need help

Hi guys.

Im trying to make my first EA. Its simple and all it does is make a popup alert and sound when 2 MA's cross. It however does not work eventhough there was a smiley at the top right of the chart, indicating the EA is working fine.

Attached is my code. Can someone correct my mistakes ?

Thanks in advance guys !!! :-)



//+------------------------------------------------------------------+
//| First MA Indicator.mq4 |
//| Copyright 2009, MetaQuotes Software Corp. |
//| http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "Copyright 2009, MetaQuotes Software Corp."
#property link "http://www.metaquotes.net"
#include <WinUser32.mqh>

bool Question=false;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start()
{
//----
double sma5, ema20, ema10;
sma5=iMA(NULL,0,5,0,0,0,0);
ema20=iMA(NULL,0,20,0,1,0,0);
ema10=iMA(NULL,0,10,0,1,0,0);

bool loop=true;

while (loop==true)
{
if (sma5==ema20 || sma5==ema10)
{
PlaySound("news.wav");
Question=true;
int ret=MessageBox("Time of important MA CROSSINGS. ARE YOU WATCHING?",
"Question", MB_YESNO|MB_ICONQUESTION|MB_TOPMOST);
}
}
//----
return(0);
}
//+------------------------------------------------------------------+

one thing i never do is try get prices or Ma's to equal each other perfectly by using == as this is seldom if ever true.

the ticks dont arrive in perfect order like 1 per second...they arrive sometimes randomly and so can skip the point where the 2 MA's are == ...

so i use >= or <=

I have written a small tutorial on coding this sort of thing so activate your PM and PM me if you want to have it.

cheers

My PM is still awaiting activation. Could you provide a link or attachment here? Thanks. :-)

To post the link here would be against the rules, its better if you send me a PM when its active...but it should be active immediately, as far as I know.

cheers