Simple Indicator Question | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

SIMPLE EA for a simple method needed!! 2 replies

Trading is this Simple? Finally Explained simple and clearly! 46 replies

Simple EA + indicator question: use of iCustom() 1 reply

Help? Simple Question Regarding Arrows Indicator Coding 0 replies

Simple Question, maybe a dumb question 2 replies

Attachments: Simple Indicator Question
Exit Attachments

Simple Indicator Question

  • #1
  • First Post: Edited Apr 12, 2009 2:26am Apr 11, 2009 9:37pm | Edited Apr 12, 2009 2:26am
I am writing an indicator that reads a .csv file and then simply plots the values in the file in a histogram fashion. The format of the file is:

Date Value
mm/dd/yyyy x1
mm/dd1/yyyy x2

etc etc

I need it to plot the values in the second column i.e. "Value" at the corresponding dates.

So far I've just written the code to open the file but I'm unsure as to how to do the graphical component of the indicator.

Also:

double array;

FileReadArray(handle, array, 0 , 2);
FileClose(handle);

is that the correct code to read the .csv file?

Thanks.

EDIT: I'm also having difficulty with dates. Is there another way other than using seconds?

string strDate = "2007.6.15";
datetime dDate = StrToTime(strDate);

Saw that code somewhere... not sure what it means though... I've never used datetime before or string.
  • #2
  • Apr 12, 2009 7:00am Apr 12, 2009 7:00am
It seems I'm stuck on reading the file:

PHP Code
#property indicator_separate_window
#property  indicator_buffers 1
#property  indicator_color1  Blue

   double test[3];

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
//---- drawing settings
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,test);
   IndicatorShortName("test");
   SetIndexLabel(0,"test");
}

//+------------------------------------------------------------------+
//| Start Function                                                   |
//+------------------------------------------------------------------+

int start()
{
   int handle;

   handle = FileOpen("Test.csv", FILE_CSV|FILE_READ,',');
   if(handle < 1)
   {
     Print("Test.csv not found, the last error is ", GetLastError());
     return(false);
   }
   else
   {
      FileReadArray(handle, test, 0 , 2);    
      FileClose(handle);
      Print("array is", test);
   }
   return(0);
}
I wrote a simple indicator code to test simply reading a 1 dimensional array... and this is what I see in the readout.

The file "Test.csv" contains the following info:

1
2
3
Attached Image
  • #3
  • Last Post: Apr 12, 2009 11:01pm Apr 12, 2009 11:01pm
Hi guys... still not working... I've edited the program a bit but its still not doing anything that resembles life. I'm getting an error "handle 1 does not exist in FileIsEnding", which would mean that the file never ends? (Which doesn't make sense) yet despite this, the array is still empty. As for the actual plotting of the values, all I see is a blank screen in the indicator window. The only thing that currently works is the name of the indicator... just says "test" in the upper corner as it should. I'm pretty much stumped... any help would be much appreciated.

PHP Code
#property  indicator_separate_window
#property  indicator_buffers 1
#property  indicator_color1  Blue

   int test[3,2];
   string Str_DtTm;
   datetime Dat_DtTm;

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
{
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,test);
   IndicatorShortName("test");
   SetIndexLabel(0,"test");
   SetIndexDrawBegin(0, 0);
}

//+------------------------------------------------------------------+
//| Start Function                                                   |
//+------------------------------------------------------------------+

int start()
{
   int handle;
   int counter = 0;

   handle = FileOpen("Test.csv", FILE_CSV|FILE_READ,',');
   if(handle < 1)
   {
     Print("Test.csv not found, the last error is ", GetLastError());
     return(false);
   }
   else
   {
      while(FileIsEnding(handle)==false)
      {
         Str_DtTm = FileReadString(handle);
         test[counter, 1] = FileReadInteger(handle);
         if(FileIsEnding(handle)==true)
         {
            break;
         }
         Dat_DtTm = StrToTime(Str_DtTm);
         Print("array is", test);
         FileClose(handle);
         /*WindowRedraw();*/
         counter++;
      }
   }
   
//   string       strDate  = "2007filereadarrayfilereadarrayfilereadarrayfilereadarray.6.15";
//   datetime     dDate    = StrToTime(strDate);

   return(0);
}
0 traders viewing now