How to get custom indicator values?

I am trying to use the EMA Crossover Signal indicator in an EA and am have trouble getting the values from it. I am use iCustom() and no matter what mode I select (0 or 1) the indicator only returns 2147483647. Any thoughts on what I am doing wrong?

Here is an example of what I am trying to do:

double EMA = iCustom(NULL,0,"EMA Crossover Signal",5,13,false,0,0);

Print(EMA);

Here is the indy code:

//+------------------------------------------------------------------+
//| EMA-Crossover_Signal.mq4 |
//| Copyright 2005, Jason Robinson (jnrtrading) |
//| http://www.jnrtading.co.uk |
//+------------------------------------------------------------------+

/*
+------------------------------------------------------------------+
| Allows you to enter two ema periods and it will then show you at |
| Which point they crossed over. It is more usful on the shorter |
| periods that get obscured by the bars / candlesticks and when |
| the zoom level is out. Also allows you then to remove the emas |
| from the chart. (emas are initially set at 5 and 6) |
+------------------------------------------------------------------+
*/
#property copyright "Copyright 2005, Jason Robinson (jnrtrading)"
#property link "http://www.jnrtrading.co.uk"

#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 SeaGreen
#property indicator_color2 Red

double CrossUp[];
double CrossDown[];
extern int FasterEMA = 5;
extern int SlowerEMA = 13;
extern bool SoundON=false;
double alertTag;
double control=2147483647;

//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0, DRAW_ARROW, EMPTY,3);
SetIndexArrow(0, 233);
SetIndexBuffer(0, CrossUp);
SetIndexStyle(1, DRAW_ARROW, EMPTY,3);
SetIndexArrow(1, 234);
SetIndexBuffer(1, CrossDown);
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start() {
int limit, i, counter;
double fasterEMAnow, slowerEMAnow, fasterEMAprevious, slowerEMAprevious, fasterEMAafter, slowerEMAafter;
double Range, AvgRange;
int counted_bars=IndicatorCounted();
//---- check for possible errors
if(counted_bars<0) return(-1);
//---- last counted bar will be recounted
if(counted_bars>0) counted_bars--;

limit=Bars-counted_bars;

for(i = 0; i <= limit; i++) {

counter=i;
Range=0;
AvgRange=0;
for (counter=i ;counter<=i+9;counter++)
{
AvgRange=AvgRange+MathAbs(High[counter]-Low[counter]);
}
Range=AvgRange/10;

fasterEMAnow = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i);
fasterEMAprevious = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i+1);
fasterEMAafter = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i-1);

slowerEMAnow = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_CLOSE, i);
slowerEMAprevious = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_CLOSE, i+1);
slowerEMAafter = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_CLOSE, i-1);

if ((fasterEMAnow > slowerEMAnow) && (fasterEMAprevious < slowerEMAprevious) && (fasterEMAafter > slowerEMAafter)) {
CrossUp[i] = Low[i] - Range*0.5;
}
else if ((fasterEMAnow < slowerEMAnow) && (fasterEMAprevious > slowerEMAprevious) && (fasterEMAafter < slowerEMAafter)) {
CrossDown[i] = High[i] + Range*0.5;
}
if (SoundON==true && i==1 && CrossUp[i] > CrossDown[i] && alertTag!=Time[0]){
Alert("EMA Cross Trend going Down on ",Symbol()," ",Period());
alertTag = Time[0];
}
if (SoundON==true && i==1 && CrossUp[i] < CrossDown[i] && alertTag!=Time[0]){
Alert("EMA Cross Trend going Up on ",Symbol()," ",Period());
alertTag = Time[0];
}

}
return(0);
}

check the file name of the icustom. Make sure you have all the dashes and underscores in place. Also make sure the capital letters are in the right spot. It must be exactly as the file is spelled.

No luck... the file name is "EMA Crossover Signal" and that is exactly how I have it entered.

Rename the indicator file to somthing simple like "EMACS" or something. I have had some issues with filenames and spaces.

Nope, that didn't work either.

I'm considering just incorporating the indy code directly into the EA or just writing own MA cross code... but I was hoping to not reinvent the wheel and the use the EMA Signals to see the arrows when it see a cross.

Have you looked at what values the indicator returns in the data window? It usually would not have any values.

Your iCustom should look something like this.

iCustom(NULL, 0, "EMA Crossover Signal ", FasterEMA, SlowerEMA, 0, 0);

I would edit the indicator to set every non-arrow to 0, like so. I find it easier when setting trade logic.

If you build your EA to trade based on this indicator solely, please note that, that indicator is repainting big time. The arrow will appear and vanish and reappear again. Read the indicator code carefully, and change those lines to make it a non repainting arrow.

I'm curious, if a field for values in an indicator are blank, what do I put in the trade logic? EMPTY_VALUE doesn't work.

I don't know. I can't really program, only edit. I just know when there is no value returned it generally creates a problem for me. I don't even know if it is the problem here but I thought I would bring it to the smarter member's attention as a possible problem.

yes...

if (EMA == EMPTY_VALUE){
........
........

equivalent to zero or null or that number 2147483647

Maybe this will help..Add this 2 lines in red

//---- indicators
SetIndexStyle(0, DRAW_ARROW, EMPTY,3);
SetIndexArrow(0, 233);
SetIndexBuffer(0, CrossUp);
SetIndexEmptyValue(0,0.0);

SetIndexStyle(1, DRAW_ARROW, EMPTY,3);
SetIndexArrow(1, 234);
SetIndexBuffer(1, CrossDown);
SetIndexEmptyValue(1,0.0);

Then in your EA..

double EMA_green = iCustom(..... 0,0);
double EMA_red = iCustom(..... 1,0);
if (EMA_green != 0) {
OrderSend (....... your are buying
if (EMA_red != 0) {
OrderSend (.......your are selling


I hope this helps..

[email protected] (please reply to)

Is there a most recent version of this indicator?

Can't find Mr. Jason Robinson, the UK author, not the athlete, to ask why the popup alert works but the email alert does not?

The thread seems to have stopped over a year ago and maybe all is resolved? Running on M30, EUR/USD.

Thanks to any who can help,
boristabby5