Slingshot 30M & 1H - The 2nd Coming...... | Page 36 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Slingshot-30 Min. PA System 394 replies

ECN && STP && Scalping && Hedging - Broker Review - Oct 2009 24 replies

question about "slingshot" indicators 1 reply

Advice/Criticism on Indicator Settings for 30M and 2H 0 replies

SlingShot Method A 12 replies

Attachments: Slingshot 30M & 1H - The 2nd Coming......
Exit Attachments

Slingshot 30M & 1H - The 2nd Coming......

  • #701
  • Edited 10:03pm Feb 19, 2009 7:36pm | Edited 10:03pm
Hey BlackWolf -

Great idea about RR - hopefully he will see this and will respond. He is a much more advanced programmer than I am and probably has dealt with this issue on many levels. Love the "e-pip-hany" - got to remember to put it away for future use, high five for that one!

Gary

Quoting BlackWolf
All in good humor and fun, Gary. You know you have the highest admiration and respect from me and from us all. I was just yankin' your chain, Bud.

Might I make a suggestion to your earlier e-pip-hany post? I like the whole idea a lot, very well thought out - which doesn't surprise me considering the source. Maybe run it past our good friend Ronald Raygun (Kid Wonder), just to be sure. Two sets of eyes are always better than one and two amazing sets of eyes like you and him would be kill-ahhh!

Looking forward to v2.8
  • #702
  • Feb 19, 2009 7:50pm Feb 19, 2009 7:50pm
Bob - excellent feedback.

I tried the IsTradeContextBusy() several days ago following up on a different idea than the one I expressed earlier. Couldn't really get it to do much. After having researched this semaphore idea a bit, there are lots of issues on where such a function (IsTradeContextBusy) is placed and how an ea responds to the placement. I think that was probably what was wrong earlier - I was using it in a very simplistic manner and probably had it misplaced it in the code to begin with. Its been an interesting topic to study whether is applies here or not....= learning is always time well spent.

I find the reversal strategy interesting and am curious in what you (and RR?) eventually find out but that's probably best left to another thread. It is a different trading system deserving of its own discussion.

Thanks again - Gary

Quoting bbayles
Gary,

I know exactly what you mean...sometimes we just get too close to the problem to see the answer (although I prefer my long walks along a nearby trout stream with fishing rod in hand).



You may well be on to something here, although I've never run across it yet myself. Perhaps you can do something with the IsTradeContextBusy() function, maybe in a while loop.

Part of my problem, and the reason I've not been more active in the thread is that like Ronald Raygun I think of this as more of a reversal stratagy than a trend following one....
  • #703
  • Feb 19, 2009 8:03pm Feb 19, 2009 8:03pm
Wow lots of words to read there Gary. I guess you deserve a trip to Hawaii hee hee

Anyway, I too could not determine why it would not close trades. 2.7 ended the day closing properly, but who knows what tomorrow brings. I wish we could debug the code live, like vb does.
  • #704
  • Feb 19, 2009 8:13pm Feb 19, 2009 8:13pm
Thanks Cfi! That did it!

Quoting Cfi
Set the SSMultiFilter input "ShowMacdVlines" from False to True.
  • #705
  • Feb 19, 2009 8:45pm Feb 19, 2009 8:45pm
Thanks hazelj80 -

I'll check out the lead.

Gary

Quoting hazelj80
i know that hayseed on here would add soemthing called "order reliable" management to his EA's to stop the confusion. You would have to add it to the libraries part of mt4. is this close to what you did? it sounds like it but i'm not a programmer at all!
  • #706
  • Feb 19, 2009 9:08pm Feb 19, 2009 9:08pm
Hi All -

One more time! Attached is version 2.8 of the ea. Several changes:

1. Per my very long post earlier, I've added two more functions to get all the ea's to be good little boys and girls, stand in an orderly line and wait their turn to trade. These functions are TradeIsBusy() and TradeIsNotBusy() - and for the curious (you sick puppies!) these two functions are at the very end of the program.

Thanks to some really wonderful contributions, two other great changes have been made.

2. From sayembara we have added UseRecommendedSettings, a parameter with a default setting of true. This will recognize the trading pair and set the SL to the value per post #1. llambert3 are you 'ing?! If you wish to set the SL manually just change the setting to false. The default setting of the parameter Stoploss is 0 - this doesn't not have to changed if your using UseRecommendedSettings = true. The comment in the upper left corner of the screen will show you the current SL value (e.g, 35) - wouldn't want you worrying. Just remembered I changed the name of the parameter to UseRecommendedSLSettings just to be clear about which settings are changed.

3. Thanks to bbayles - his code has solved the issue of brokers using 5 digits. The ea will now make the correction automatically whether your broker uses 3,4 or 5 digits.

Many thanks to both of you for your efforts - greatly appreciated!

Gary
Attached File(s)
File Type: mq4 Slingshot_2.8.mq4   44 KB | 319 downloads
  • #707
  • Feb 19, 2009 9:46pm Feb 19, 2009 9:46pm
Hey Damon -

Since we are trying to duplicate in the ea your successful system that you trade manually, a quick question. The slippage for both opening and closing orders in the ea is now 3 (hard coded). Do you use a different value, different values for different pairs, ........? Just trying to follow the fearless leader!

Gary
  • #708
  • Feb 19, 2009 9:46pm Feb 19, 2009 9:46pm
Gary, your efforts on this EA is amazing... thank you!!
It'll feel better when it stops hurting.
  • #709
  • Feb 19, 2009 11:05pm Feb 19, 2009 11:05pm
Many many thanks Gary for all the endless hours you are putting in on this. Its over the top and beyond the call of duty. You deserve a metal. Thanks again
Richard
  • #710
  • Feb 20, 2009 1:58am Feb 20, 2009 1:58am
Quoting Pavatar
Hi All -

Many thanks to both of you for your efforts - greatly appreciated!

Gary
Gary,

...and I thought the EA was the robot... then the amount of time put into this made me think - maybe you are a robot! Do you actually sleep and do other things?

hey, buddy, you are fantastic, thank you so much for the hard work!!! it's very very much appreciated!

hsa
  • #711
  • Edited 2:52am Feb 20, 2009 2:10am | Edited 2:52am
sorry to be a pain, but does anyone have any idea what this means:

2009.02.20 08:04:59 Slingshot_2.8 EURJPY,M30: TradeIsBusy()-GlobalVariableSetOnCondition("TradeIsBusy",1.0,0.0 )-Error #4105
(using v2.8)

EDIT:
Half an hour later, and the EA can't seem to trade properly. There are one or two occasional traders but mainly the error message above...
I have the latest build of Metatrader (220), FYI.
  • #712
  • Feb 20, 2009 2:43am Feb 20, 2009 2:43am
Hello everyone,

I wanted to post this yesterday, but I'm new to this forum and had to wait for my username/password to be 'verified' by the administrators.

I've been reading this thread for a few days now having done an unsuccessful 'quick and dirty' attempt at a SlingShot EA when Martin Alexander released it a while back. I have to say that I'm very impressed with the professional nature of the way that you guys are progressing this thread and this is one of the reasons why I've become interested in it.

I may be able to offer some help to Gary on the programming side - I've been programming in general for about 25 years and with MetaTrader for the last 12 months or so. I'm not much of a trader, but believe that I can help out on the programming and testing side.

Gary has done a great job with the code - its very well laid out and looks very effective too. I don't want to step on anyone's toes with my comments, so I'll tread lightly!

Here's a couple of thoughts around the EA regarding the missing trades, although I appreciate that Gary has now put in the semaphore logic:

1. The OrderSend() function needs to have an error handling process around it. At the moment, the way that the EA is coded means that following the completion of the OrderSend() function, it will print an error into the Journal if it fails to complete the opening of the order correctly, which you can check to determine if there has been any failed opening of trades. It doesn't attempt to retry the opening of the trade. What it should do is to have several (e.g. 5) attempts to open the trade, each separated by a second or two delay. A good but possibly over-engineering version of code to do this can be found if you Google 'OrderReliable.mqh' (sorry, not sure if i can post links to other Forums etc, so being on the safe side). There is the argument that you don't need to do this, as the function may(!) be executed on the next tick, however, this is perhaps the purist view (which I'm not, hence the comment about being over engineered!).

2. Similarly, the OrderClose() function in the code doesn't have any type of error handling or notification at all. Adopting the same approach as mentioned above may the be answer to the problems of trades not being closed at the correct time.

Check the journal (and the logs in the '<installed directorylogs' folder) to see if you have any errors such as TradeContextBusy - this indicates that the broker was unable to fulfill the action (e.g. Open or Close a trade).

I note that the EA has a check in it to ensure that the server is ready, but its worth a check in the journal or logs anyway and possibly the addition of the error handling routines.

I've not amended the EA for the reason that we need to have only one person changing the EA, otherwise we'll get out of sync with updates etc. I'll leave that to Gary, who has done a fantastic job so far, but will offer my help to him in case he wants to discuss any aspect of the EA from a coding point of view.

It should be possible for several EA's (or the same EA's in the same trading window) to operate concurrently as each operates on its own 'thread' within the MetaTrader platform. Personally, I believe that the error handing routines will help overcome the issue of trades being closed incorrectly.

Also, on the testing side, I'm going to change over my testing platform to Alpari (UK) from ODL today (hopefully) so can offer some feedback on the 5 digit brokers.

NOTE: This post is in no way a criticism of what has been developed, I just want to try and help the development of this excellent EA.

Cheers,
Nick.
  • #713
  • Feb 20, 2009 3:00am Feb 20, 2009 3:00am
I propose to go ahead and make the adjustments. Rename the file by adding "mod" so that users can know this is not the official one.

Then, inform Gary on where to make the changes so that he can verified it and update.

This will certainly reduce the amount or time taken for Gary to figure out why, what and where to adjust. Faster to receive ver 2.9
  • #714
  • Feb 20, 2009 3:03am Feb 20, 2009 3:03am
Gary,

I think this line (in red) is the artifact of my 'setup pip' calculation. Can safely be deleted.

double lotSize = MarketInfo(Symbol(), MODE_LOTSIZE);

if(UseRecommendedSLSettings == true)
{
if(Symbol()=="EURUSD") Stoploss = 35;
if(Symbol()=="EURJPY") Stoploss = 45;
if(Symbol()=="GBPJPY") Stoploss = 55;
if(Symbol()=="GBPUSD") Stoploss = 45;
if(Symbol()=="USDJPY") Stoploss = 25;
}
  • #715
  • Feb 20, 2009 6:00am Feb 20, 2009 6:00am
Hello swnke2,

Thanks for your help with this. I wish I knew something about programming as I would love to be able to help Gary as well. A post above is right. If you know how to add this to the code easily, please do so and just add mod behind it and let Gary know and he will add it to his next version.

Once again, thanks for your help....Damon

Quoting swnke2
Hello everyone,

I wanted to post this yesterday, but I'm new to this forum and had to wait for my username/password to be 'verified' by the administrators.

I've been reading this thread for a few days now having done an unsuccessful 'quick and dirty' attempt at a SlingShot EA when Martin Alexander released it a while back. I have to say that I'm very impressed with the professional nature of the way that you guys are progressing this thread and this is one of the reasons why I've become interested in it.

I may be able to offer some help...
"Keep your eyes on the helpers" - Mr. Rogers
  • #716
  • Feb 20, 2009 6:15am Feb 20, 2009 6:15am
Quoting Pavatar
Hi All -

One more time! Attached is version 2.8 of the ea. Several changes:

1. Per my very long post earlier, I've added two more functions to get all the ea's to be good little boys and girls, stand in an orderly line and wait their turn to trade. These functions are TradeIsBusy() and TradeIsNotBusy() - and for the curious (you sick puppies!) these two functions are at the very end of the program.

Thanks to some really wonderful contributions, two other great changes have been made.

2. From sayembara we have added UseRecommendedSettings,...
well I would be happy if i didn't fall asleep at 10pm last night!!!! .. i'll put it on now.
  • #717
  • Feb 20, 2009 6:23am Feb 20, 2009 6:23am
Quoting hsa013
sorry to be a pain, but does anyone have any idea what this means:

2009.02.20 08:04:59 Slingshot_2.8 EURJPY,M30: TradeIsBusy()-GlobalVariableSetOnCondition("TradeIsBusy",1.0,0.0 )-Error #4105
(using v2.8)

EDIT:
Half an hour later, and the EA can't seem to trade properly. There are one or two occasional traders but mainly the error message above...
I have the latest build of Metatrader (220), FYI.
you are right... it isn't trading.... it opened up one, but the others it is not and the error is there.
  • #718
  • Feb 20, 2009 7:16am Feb 20, 2009 7:16am
Hey Nick!

Many many thanks! Welcome to the fun There is never any negative sensitivity to folks trying to help - any and all are welcomed at any time to help me stumble my way through the maze of trying to get these little robots to work properly.

I think (know!) your right about getting the opening and closing to work properly by multiple requests and after watching the performance of the semaphore so far I think it may be the way to go. I know of what you speak and have used this approach before ...........had a bad experience doing it this way (on a live account no less) and have 'ed out ever since. It wasn't the approach, it was a very dumb, simple mistake on my part, but its much easier to blame the functions.

I'll checkout OrderReliable.mqh. Is there any particular code you would like to see in the ea - if so, just post it and let's give it a whirl. All help greatly appreciated at any time.

Thanks for the clarification/correction on the 'thread' - I was under the impression that there was only one thread for the account, not for each ea. That being the case, my 'semaphore' approach is absolutely not necessary - I don't think its working anyway.

Gary

Quoting swnke2
Hello everyone,

I wanted to post this yesterday, but I'm new to this forum and had to wait for my username/password to be 'verified' by the administrators.

I've been reading this thread for a few days now having done an unsuccessful 'quick and dirty' attempt at a SlingShot EA when Martin Alexander released it a while back. I have to say that I'm very impressed with the professional nature of the way that you guys are progressing this thread and this is one of the reasons why I've become interested in it.

I may be able to offer some help...
  • #719
  • Feb 20, 2009 7:18am Feb 20, 2009 7:18am
Good morning sayembara -

I was going to ask you about that but being the trusting fellow I am, I put it in. Thanks for the clarification.
Quoting sayembara
Gary,

I think this line (in red) is the artifact of my 'setup pip' calculation. Can safely be deleted.

double lotSize = MarketInfo(Symbol(), MODE_LOTSIZE);

if(UseRecommendedSLSettings == true)
{
if(Symbol()=="EURUSD") Stoploss = 35;
if(Symbol()=="EURJPY") Stoploss = 45;
if(Symbol()=="GBPJPY") Stoploss = 55;
if(Symbol()=="GBPUSD") Stoploss = 45;
if(Symbol()=="USDJPY") Stoploss = 25;
}...
  • #720
  • Feb 20, 2009 7:22am Feb 20, 2009 7:22am
Ok - another idea down the tubes! I think we are on the right track that causing the problem with closing orders, I just implemented a wrong solution. It will take a just a minute to comment out the semaphore and leave the 'good stuff' that is working. I'll post version 2.9 in a minute so we can test it the other new features. Nick made an excellent suggestion and will work on that this morning.

Gary

Quoting llambert3
you are right... it isn't trading.... it opened up one, but the others it is not and the error is there.
0 traders viewing now