Help needed with custom indicator(how to call it from the ea) | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Custom MT4 Stochastics Indicator needed 6 replies

[MT4] Weird problems with Custom Indicator and iCustom call 0 replies

MT4 Programmer needed for simple custom indicator 3 replies

help needed modify existing custom indicator 8 replies

Need help Custom Indicator (MetaTrader4) 4 replies

Attachments: Help needed with custom indicator(how to call it from the ea)
Exit Attachments

Help needed with custom indicator(how to call it from the ea)

  • #1
  • First Post: Jan 30, 2009 2:59pm Jan 30, 2009 2:59pm
Hi guys....I already made so many trials&errors with this, and the truth
is that Im totaly lost.....I even tried to transfer code directly to the ea,
but that seems to be a pain in the ass!

This is probably the best divergence indicator out there,
and the signals are just great....
it is not a problem for me to call proper icustom function,
but the problem is I dont have a clue how to get a divergence signals
from it to my ea!

ps. this version doesnt repaint.

Please help.
Attached File(s)
File Type: mq4 FX5_Divergence_V2.1.mq4   11 KB | 561 downloads
forexflash
  • #2
  • Jan 30, 2009 3:13pm Jan 30, 2009 3:13pm
Here is the format. Remember you have to include every extern variable in the indicator, even the notes.

The easiest way to do this is to copy and paste all of the extern variables into your EA from the custom indicator

PHP Code
double DataFromIndex0 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", seperatore1, faseEMA, slowEMA, signal, seperator2, drawdivergenceLines, 
         displayAlert, 0, 0) // On the last varable 0 is the current bar 1 is the bar befroe it and so on.
double DataFromIndex1 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", seperatore1, faseEMA, slowEMA, signal, seperator2, drawdivergenceLines, 
         displayAlert, 1, 0) // On the last varable 0 is the current bar 1 is the bar befroe it and so on.
double DataFromIndex2 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", seperatore1, faseEMA, slowEMA, signal, seperator2, drawdivergenceLines, 
         displayAlert, 2, 0) // On the last varable 0 is the current bar 1 is the bar befroe it and so on.
double DataFromIndex3 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", seperatore1, faseEMA, slowEMA, signal, seperator2, drawdivergenceLines, 
         displayAlert, 3, 0) // On the last varable 0 is the current bar 1 is the bar befroe it and so on.                           
double DataFromIndex4 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", seperatore1, faseEMA, slowEMA, signal, seperator2, drawdivergenceLines, 
         displayAlert, 4, 0) // On the last varable 0 is the current bar 1 is the bar befroe it and so on.
  • #3
  • Jan 30, 2009 3:26pm Jan 30, 2009 3:26pm
Use the code posted by thatwasme. Then check these variables for divergence:

Inserted Code
if (DataFromIndex2 > 0) {
  //commands for bullish divergence
}
if (DataFromIndex3 > 0) {
  //commands for bearish divergence
}
  • #4
  • Jan 30, 2009 3:29pm Jan 30, 2009 3:29pm
Really appreciate it guys!!!
Well, back to the coding

Respect
forexflash
  • #5
  • Jan 30, 2009 3:57pm Jan 30, 2009 3:57pm
Well, here is a code...it is working, but it seems that the signal stays true, until the other signal!!!
So my ea sells all the time, until buy signal?

//=====================SIGNAL1=======================

bool BuySignal1=false, SellSignal1=false;

if(UseSignal1)
{
double DataFromIndex0 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", fastEMA,
slowEMA, signal, drawDivergenceLines, displayAlert, 0, 0);
double DataFromIndex1 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", fastEMA,
slowEMA, signal, drawDivergenceLines, displayAlert, 1, 0);
double DataFromIndex2 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", fastEMA,
slowEMA, signal, drawDivergenceLines, displayAlert, 2, 0);
double DataFromIndex3 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", fastEMA,
slowEMA, signal, drawDivergenceLines, displayAlert, 3, 0);
double DataFromIndex4 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", fastEMA,
slowEMA, signal, drawDivergenceLines, displayAlert, 4, 0);

if (DataFromIndex2 > 0) {BuySignal1=true;}
if (DataFromIndex3 > 0) {SellSignal1=true;}
}
else {SellSignal1=false;BuySignal1=false;}
forexflash
  • #6
  • Jan 30, 2009 4:01pm Jan 30, 2009 4:01pm
Quoting FOREXflash
Well, here is a code...it is working, but it seems that the signal stays true, until the other signal!!!
So my ea sells all the time, until buy signal?

//=====================SIGNAL1=======================
bool BuySignal1=false, SellSignal1=false;

if(UseSignal1)
{
double DataFromIndex0 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", fastEMA,
slowEMA, signal, drawDivergenceLines, displayAlert, 0, 0);
double DataFromIndex1 = iCustom(Symbol(), 0, "FX5_Divergence_V2.1", fastEMA,
slowEMA, signal, drawDivergenceLines, displayAlert, 1, 0);
double...
Hey Flash, if you are not using the other index buffers, you do not need them in your EA, only 2 and 3.

On your problem of always true, set up a toggle variable using a bool varable that activates on the first occurance of the buy signal and then is set to false until the sell divergence is activated and visa versa for the sell signal

Something like

if ( DataFromIndex2 > 0 && buytoggel )
{
your code for the buy;
buytoggel = false;
selltoggel = true;
}

if(dataFromIndex3 > 0 && selltoggel )
{
your code for sell;
seltoggle = false;
buytoggle = true;
}
  • #7
  • Jan 30, 2009 4:11pm Jan 30, 2009 4:11pm
LOL,thank bro....maybe you need to be called flash!

Realy appreciate your help.
forexflash
  • #8
  • Jan 30, 2009 5:00pm Jan 30, 2009 5:00pm
I JUST CANT WORK THIS OUT!

I think that there is a problem from taking correct signal from indicator.
EA need to buy or sell exactly on the buy or sell arrow from the indicator,
and then wait until other signal comes along.

This code here have all the elements, and it is simplest possible code for
an EA so you guys can easily spot what am I doing wrong, or how to code
a rule in EA to trade only on exact diveregence signal!

Thanks
Attached File(s)
File Type: mq4 SIMPLE FX5.mq4   2 KB | 369 downloads
forexflash
  • #9
  • Jan 30, 2009 6:53pm Jan 30, 2009 6:53pm
Your iCustom parameters do not match the indicator, unless you removed the 2 string parameters from you custom indicator. They must be exactly the same and in the exact same order.
  • #10
  • Jan 31, 2009 4:05am Jan 31, 2009 4:05am
Quoting thatwasme
Your iCustom parameters do not match the indicator, unless you removed the 2 string parameters from you custom indicator. They must be exactly the same and in the exact same order.
Yes I removed that 2 string\comment functions from the indi code, so the icustom
function is coded ok.
Any thoughts?
forexflash
  • #11
  • Jan 31, 2009 4:41am Jan 31, 2009 4:41am
The problem is that arrow appears on a candle only when the next candle is closed. So you will get the signal 2 candles later.

Please have a look at the file that I have modified. Now positions are opened correctly, but they are immediately closed, so there might be other problems with the EA.
Attached File(s)
File Type: mq4 SIMPLE FX5.mq4   2 KB | 485 downloads
  • #12
  • Jan 31, 2009 4:50am Jan 31, 2009 4:50am
Quoting quaestus
The problem is that arrow appears on a candle only when the next candle is closed. So you will get the signal 2 candles later.

Please have a look at the file that I have modified. Now positions are opened correctly, but they are immediately closed, so there might be other problems with the EA.
Thanks man, the problem with closing is that ea dont have a TP.....
it close a position if open1 is bigger than last open etc....

Big THANKS
Respect
forexflash
  • #13
  • Jan 31, 2009 5:03am Jan 31, 2009 5:03am
Its alive, its alive,aliveee......
Thanks

I will post full version in a few days, so check it out sometime!

THANKS!!!
forexflash
  • #14
  • Last Post: Nov 22, 2010 4:39am Nov 22, 2010 4:39am
Dear Flash
can i ask you give me your expert?
i looked it on web
but .....
I love fx5 divergence :X
thanks so much
0 traders viewing now