where is wrong with my first indicator

Dear friends:
Could you please tell me where is wrong. i compile my first indicator. but it show nothing in the windonw.
Regards


#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red

double CrossUp[];
double CrossDown[];
extern int FasterEMA = 10;
extern int SlowerEMA = 20;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0, DRAW_HISTOGRAM);
SetIndexBuffer(0, CrossUp);
SetIndexStyle(1, DRAW_HISTOGRAM);
SetIndexBuffer(1, CrossDown);
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start() {
int limit, i;
double fasterEMAnow, slowerEMAnow;
int counted_bars=IndicatorCounted();
//---- check for possible errors
if(counted_bars<0) return(-1);
//---- last counted bar will be recounted
if(counted_bars>0) counted_bars--;

limit=Bars-counted_bars;

for(i = 0; i <= limit; i++) {

fasterEMAnow = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i);

slowerEMAnow = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_CLOSE, i);

if (fasterEMAnow > slowerEMAnow) {
CrossUp[i] = 1;
}
else if (fasterEMAnow < slowerEMAnow) {
CrossDown[i] = -1;
}
}
return(0);
}

It is showing for me.

I agree. ztdep, this is what I see.

it show nothing in my chartsw

For troubleshooting purposes download the compiled file. Try attaching it to a chart and see if it works. I tried it on a couple of platforms. Build 220

Try it now. I set both arrays to 0 before loading them.

Dear thatwasme:
Thank you very much for your help, it works.
Could you please tell me what wrong with me.
Regards
Your Sincerely.
ztdep

I set both arrays to 0 first. The way you had it, both the > 0 array and the < 0 had data at the same time and the indicator was trying to display both in the same place. This can cause unpredictable results. see the part I highlighted in red.


#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red

double CrossUp[];
double CrossDown[];
extern int FasterEMA = 10;
extern int SlowerEMA = 20;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
SetIndexStyle(0, DRAW_HISTOGRAM);
SetIndexBuffer(0, CrossUp);
SetIndexStyle(1, DRAW_HISTOGRAM);
SetIndexBuffer(1, CrossDown);
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----

//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start() {
int limit, i;
double fasterEMAnow, slowerEMAnow;
int counted_bars=IndicatorCounted();
//---- check for possible errors
if(counted_bars<0) return(-1);
//---- last counted bar will be recounted
if(counted_bars>0) counted_bars--;

limit=Bars-counted_bars;

for(i = 0; i <= limit; i++) {

fasterEMAnow = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i);

slowerEMAnow = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_CLOSE, i);

CrossUp[i] = 0; CrossDown[i] = 0;

if (fasterEMAnow > slowerEMAnow) {
CrossUp[i] = 1;
}
else if (fasterEMAnow < slowerEMAnow) {
CrossDown[i] = -1;
}
}
return(0);
}

thank you very much for your kindly help, dear friends