Relative Strength Basket Trading System | Page 136 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

Trading system using relative strength 2,816 replies

BASKET TRADE Management: Using multiple trade management EA's on basket trades 11 replies

Basket Knights - A Basket Trading Round Table 1,313 replies

Trading System Using Relative Strength-Part 2 1,499 replies

My version of a relative strength basket 2 replies

Attachments: Relative Strength Basket Trading System
Exit Attachments

Relative Strength Basket Trading System

  • #2,701
  • Jan 9, 2009 5:04pm Jan 9, 2009 5:04pm
Quoting cybernet69
What are these strange unknown pairs v3 is trying to trade, i also see them in the parameter settings.
Sorry, but missed this on a first trawl through the missed posts - clearly not an accidental pair suffix.

I shall look at the source code.

  • #2,702
  • Jan 9, 2009 5:16pm Jan 9, 2009 5:16pm
Quoting cybernet69
What are these strange unknown pairs v3 is trying to trade, i also see them in the parameter settings.
It is the copy/paste bug, where Steve gets the pasting slightly wrong. This code snippet will explain it:

Inserted Code
symbol = StringConcatenate("EURAUD1", PairSuffix);
   TradeExists = CheckIfTradeAlreadyExists(symbol, OP_BUY, AudWeakMagicNumber);
   if (!TradeExists && TradeEURAUD1 && MarketInfo(symbol,MODE_SPREAD) <= MaximumSpread) 
   {
      ticket = OrderSend(symbol,OP_BUY, Lot, MarketInfo(symbol,MODE_ASK), 10, NULL, NULL, AudTradeComment, AudWeakMagicNumber, 0, CLR_NONE);
      if (ticket > -1) AudWeakTradesSent++;
   }

The basic problem is lousy program design stemming from the fact that I wrote the EA originally to handle xxxJPY baskets. When it became clear that all the currencies in the KG RS GROUP indi could become triggers, I should have re=designed the software so that a few functions could respond to all 8 triggers with appropriate parameters.

Instead, I took the lazy way out and copy/pasted the xxxJPY routines, changing the variables as I went, and have been suffering ever since. I got into the habit of copying variables from the extern sections of each trigger pair and removing the '1' from, say, GBPJPY1.

Except that sometimes, clearly, I forgot. Oops.

I will go through the code tomorrow and remove the offending digits.

Thanks for bringing this up. I would never have noticed - don't trade baskets containing the offending pairs.

  • #2,703
  • Jan 9, 2009 5:17pm Jan 9, 2009 5:17pm
Steve.

I choose 12, 20 purley because these are the norms. The key part is the PRICE_TYPICAL which means (high+low+close)/3.

Yes, it is strange about those EURAUD1, but they do appear in the inputs parameter settings tab, if that gives you any clues.
  • #2,704
  • Jan 9, 2009 5:44pm Jan 9, 2009 5:44pm
Quoting matrixebiz
Hey Steve, I’m not sure how Brokers detect if a trade was initiated by an EA or Manual, maybe from Comment being in the OrderSend function so was wondering if you can make the OrderSend comment an extern command so we could leave it blank if we wanted to. Thanks man
Look more closely at the inputs.

  • #2,705
  • Jan 9, 2009 8:22pm Jan 9, 2009 8:22pm
Steve.

I think you have done a VERY good job on coding this EA.

Cheers.
  • #2,706
  • Edited 10:39pm Jan 9, 2009 9:38pm | Edited 10:39pm
I have a question about the KG RS Group. I've been running the demo for a while now, and decided to go live. So I put the EA and template on my live platform.

However the KG RS Group numbers on the Live platform do not match the Demo platform, some by a little, some by a lot. I left it for a day, and there are still discrepancies.

Does anyone have any ideas to fix this?
  • #2,707
  • Jan 9, 2009 10:47pm Jan 9, 2009 10:47pm
Quoting sundog
I have a question about the KG RS Group. I've been running the demo for a while now, and decided to go live. So I put the EA and template on my live platform.

However the KG RS Group numbers on the Live platform do not match the Demo platform, some by a little, some by a lot. I left it for a day, and there are still discrepancies.

Does anyone have any ideas to fix this?
How big the different?
What broker? Do you use same broker for live & demo?
Do they have 28 pairs needed by the indicator for calculation?

Thanks,

KG
  • #2,708
  • Jan 10, 2009 12:21am Jan 10, 2009 12:21am
Quoting Kang_Gun
How big the different?
What broker? Do you use same broker for live & demo?
Do they have 28 pairs needed by the indicator for calculation?

Thanks,

KG

Hello KG,

Alpari, same broker for live and demo, no, they only have 23 pairs.

I would have thought that it would still be consistant.

Tks
  • #2,709
  • Jan 10, 2009 5:01am Jan 10, 2009 5:01am
Quoting sundog
Hello KG,

Alpari, same broker for live and demo, no, they only have 23 pairs.

I would have thought that it would still be consistant.

Tks
It depends if the they use the same data feed for both live and demo accounts. IBFX use different feeds, so demo and live figures are always different. You can always ask Alpari what they do.

  • #2,710
  • Jan 10, 2009 5:11am Jan 10, 2009 5:11am
Steve.

What did you think about implementing the iCCI calculation ?
  • #2,711
  • Jan 10, 2009 5:30am Jan 10, 2009 5:30am
Quoting cybernet69
Steve.

What did you think about implementing the iCCI calculation ?
I am going to implement it as an optional additional filter so we can experiment with it.

In my head, I was reaching the stage of contemplating filtering the individual trades. My first thought was to play with RSI but was going to post an 'any ideas about this' question first. As I said last night, you can read my mind - must be something to do with being a cybernet

So, unless anybody here can definitively shout, "I KNOW THIS WORKS 'COS I USE IT EVERY DAY WITH HUGE SUCCESS' about something different, in will go the CCI.

  • #2,712
  • Jan 10, 2009 5:36am Jan 10, 2009 5:36am
The think with indicators is that someone will always have a personal preference. However, the CCI was originally developed for commodities but now professional (bank) traders use it for currency trading due to the high percentage of +wins against -losses.

Maybe, we shouldnt focus too much on the type of filtering indicator too use but as long as we all agree that it is needed to help prevent DD.

So, without trying to make a coding nightmare, we could make it a custom option. i.e. you can use CCI, RSI or STOCH etc.
  • #2,713
  • Jan 10, 2009 5:52am Jan 10, 2009 5:52am
Steve,

You could do something along the lines of:

CurrencyStrength=0 being CCI
CurrencyStrength=1 being RSI
CurrencyStrength=2 being STOCH
CurrencyStrength=3 being BOLLINGER
CurrencyStrength=4 being MA

etc

What do you think ?
  • #2,714
  • Jan 10, 2009 6:22am Jan 10, 2009 6:22am
Quoting cybernet69
Steve,

You could do something along the lines of:

CurrencyStrength=0 being CCI
CurrencyStrength=1 being RSI
CurrencyStrength=2 being STOCH
CurrencyStrength=3 being BOLLINGER
CurrencyStrength=4 being MA

etc

What do you think ?
I have just checked, and iCustom accepts a string variable for the indi name, so it is nearly as easy to code for a number of options as it is for a single one.

Nice thinking. Thanks.

  • #2,715
  • Jan 10, 2009 7:19am Jan 10, 2009 7:19am
Steve.

Be careful with the red wine until you have finished coding the change.

  • #2,716
  • Jan 10, 2009 7:40am Jan 10, 2009 7:40am
Quoting SteveHopwood
It depends if the they use the same data feed for both live and demo accounts. IBFX use different feeds, so demo and live figures are always different. You can always ask Alpari what they do.

I think I will Steve, the difference is pretty pretty big.

Demo ~ Live (end of trading Friday)
USD 36.992 ~ 58.1712
JPY 10.8857 ~ 50.5533
EUR 77.1313 ~ 54.9292
GBP 16.3755 ~ 16.2908

Also, do the imputs in the KG RS Group have any bearing on it?
  • #2,717
  • Jan 10, 2009 9:59am Jan 10, 2009 9:59am
V4 is ready, with the extra filter for individual trades.

After thinking about it, I decided simply to code the CCI. This EA already has an off putting number of inputs and people are already showing themselves unable to cope with them.

We can see what effect the recent filters have on reducing draw down periods. At the mo, the CCI filter merely cancels an individual trade. If this proves successful, it might be worthwhile contemplating making it an opposite-direction trade rather than simply cancelling it. We shall see.

I shall make sure V4 comes here in time for market opening tomorrow; first I want to see if I can track down why the StrengthInProfitClose routine is not working properly - it would be nice to have that on track and I had forgotten about it.

  • #2,718
  • Jan 10, 2009 10:08am Jan 10, 2009 10:08am
Good work Steve.

Also, if you have time, could you sort out that EURAUD1, etc problemo.

Many thanks.
  • #2,719
  • Jan 10, 2009 10:12am Jan 10, 2009 10:12am
Quoting cybernet69
Good work Steve.

Also, if you have time, could you sort out that EURAUD1, etc problemo.

Many thanks.
It is already done - took a few seconds after I looked at the code. I posted an explanation here.

I can see why the strength in profit thingy doesn't work properly. The blasted < and > are the wrong way around - must be a red wine thingy.

V4 coming soon.

  • #2,720
  • Jan 10, 2009 1:16pm Jan 10, 2009 1:16pm
Hello All,

Which one has better result so far.. KGRangeTrading or Flexible trading ?

i only have tested KGRangeTrading v9b...
at first i setted up with 200 TP and 200 SL using 10K account with 0,1 lot.
the drawdown is so huge.. so i change the setting become
100 TP and 100 SL with Jumping Stop at 50.
the result is quite good but still not impressive.. with maximum drawdown below 10% balance.

my balance now 10.850 with floating loss 266,79.
so it's about 6% in a week...

does anybody have better result with KGRangetrading 9b ? what is the best setting ?

Steve, our coding master ,when the jumping stop hit 50.. so the basket will be closed at $0, right ? could u please add 'lockindollars' feature in KGRangetrading like u did in KGFlexible EA?
because i think it's very helpfull feature.


how bout KGFlexible trading result.. anybody wanna share the experience ?
which one have shown better result ? KGRangeTrading or KGFlexibletrading ?

Regards,
- Mike -
4 traders viewing now