EA not trading if a manual open position exist for pair

#1
First Post: Jan 5, 2009 2:03pm Jan 5, 2009 2:03pm

husky_1
| Joined Dec 2008 | Status: Let Sleeping Dogs Lie | 131 Posts

Hey guys,
I am having an issue where an EA I created will not execute an order if I have another order open, which was manually opened. I created my ea with the expert advisor builder found at http://sufx.core.t3-ism.net/ExpertAd...tml#CloseSell2.

I had an issue where it actually closed an order (one of my close signals is based on server time) that it did not open. I thought adding a Magic number would do the trick, but am not sure since I changed it on Friday, and had no open orders going into the Jan-5 session.

Any suggestions to make sure that the following two rules are met:
1. It will open an order even if there is a position open on the pair.
2. Will only close orders that it opened.

Here is my code, I left off some of my signals:

Inserted Code

/+------------------------------------------------------------------+
//| This MQL is generated by Expert Advisor Builder                  |
//|                http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/ |
//|                                                                  |
//|  In no event will author be liable for any damages whatsoever.   |
//|                      Use at your own risk.                       |
//|                                                                  |
//+------------------- DO NOT REMOVE THIS HEADER --------------------+

#define SIGNAL_NONE 0
#define SIGNAL_BUY   1
#define SIGNAL_SELL  2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

#property copyright "Expert Advisor Builder"
#property link      "http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/"

extern int MagicNumber = 22;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 0.2;
extern int Slippage = 10;
extern bool UseStopLoss = True;
extern int StopLoss = 100;
extern bool UseTakeProfit = True;
extern int TakeProfit = 35;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;

int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init() {
   BarCount = Bars;

   if (EachTickMode) Current = 0; else Current = 1;

   return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit() {
   return(0);
}
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start() {
   int Order = SIGNAL_NONE;
   int Total, Ticket;
   double StopLossLevel, TakeProfitLevel;



   if (EachTickMode && Bars != BarCount) TickCheck = False;
   Total = OrdersTotal();
   Order = SIGNAL_NONE;

   //+------------------------------------------------------------------+
   //| Variable Begin                                                   |
   //+------------------------------------------------------------------+

   string thisyear=Year();
   string thismonth=Month();
   string thisday=Day();
   string timeframe= StringConcatenate(thisyear,".",thismonth,".",thisday," 00:00");
   datetime todayinfo = StrToTime(timeframe);

//Removed buy/sell signals

   
   //+------------------------------------------------------------------+
   //| Variable End                                                     |
   //+------------------------------------------------------------------+

   //Check position
   bool IsTrade = False;

   for (int i = 0; i < Total; i ++) {
      OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
      if(OrderType() <= OP_SELL &&  OrderSymbol() == Symbol()) {
         IsTrade = True;
         if(OrderType() == OP_BUY) {
            //Close

            //+------------------------------------------------------------------+
            //| Signal Begin(Exit Buy)                                           |
            //+------------------------------------------------------------------+

                     //removed exit signals


            //+------------------------------------------------------------------+
            //| Signal End(Exit Buy)                                             |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if(Bid - OrderOpenPrice() > Point * TrailingStop) {
                  if(OrderStopLoss() < Bid - Point * TrailingStop) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         } else {
            //Close

            //+------------------------------------------------------------------+
            //| Signal Begin(Exit Sell)                                          |
            //+------------------------------------------------------------------+

                    //removed exit signals


            //+------------------------------------------------------------------+
            //| Signal End(Exit Sell)                                            |
            //+------------------------------------------------------------------+

            if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
               OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
               if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
               if (!EachTickMode) BarCount = Bars;
               IsTrade = False;
               continue;
            }
            //Trailing stop
            if(UseTrailingStop && TrailingStop > 0) {                 
               if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
                  if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
                     OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
                     if (!EachTickMode) BarCount = Bars;
                     continue;
                  }
               }
            }
         }
      }
   }

   //+------------------------------------------------------------------+
   //| Signal Begin(Entry)                                              |
   //+------------------------------------------------------------------+

   //removed buy/sell signals

   //+------------------------------------------------------------------+
   //| Signal End                                                       |
   //+------------------------------------------------------------------+

   //Buy
   if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                Print("BUY order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
            } else {
                Print("Error opening BUY order : ", GetLastError());
            }
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   //Sell
   if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
      if(!IsTrade) {
         //Check free margin
         if (AccountFreeMargin() < (1000 * Lots)) {
            Print("We have no money. Free Margin = ", AccountFreeMargin());
            return(0);
         }

         if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
         if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

         Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
         if(Ticket > 0) {
            if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
                Print("SELL order opened : ", OrderOpenPrice());
                if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
            } else {
                Print("Error opening SELL order : ", GetLastError());
            }
         }
         if (EachTickMode) TickCheck = True;
         if (!EachTickMode) BarCount = Bars;
         return(0);
      }
   }

   if (!EachTickMode) BarCount = Bars;

   return(0);
}
//+------------------------------------------------------------------+

Thanks

Makin my way, the only way I know how...

#2
Jan 5, 2009 11:05pm Jan 5, 2009 11:05pm

Zen_Leow
Joined Jun 2008 | Status: Programming for a better future. | 652 Posts

asking for help yet refusing to share... tsk tsk...

Programming for a better future.

#3
Jan 6, 2009 12:23am Jan 6, 2009 12:23am

akukaya
| Commercial User | Joined Jul 2008 | 567 Posts

I like Zen comment...

By the way, I think your problem is because your EA is base on total orders.

If you already have a manual trade, the total order already >0.
If your EA code asking for start EA when total <1, it will never execute.

My advise, let run the EA with specific account.

You can have more than one account in your PC.

#4
Jan 6, 2009 7:05pm Jan 6, 2009 7:05pm

husky_1
| Joined Dec 2008 | Status: Let Sleeping Dogs Lie | 131 Posts

Zen,
I see your point, and sorry to come off that way. At the end of the day the justification I made to myself when removing the buy and sell logic was that I needed coding help and not trading methodolgy. I am sure this thought process is not consistent with good karma and will try to win some karma points once I have optimized my EA and share with everyone else. I see no sense in sharing until I have code that I am willing to run on a live account.

Akukaya,
Thanks for your reply, I am having a hard time identifying the area that i need to change the <1 stuff, but that is ok since I was already heading down the path of multiple accounts.

Makin my way, the only way I know how...

#5
Jan 17, 2009 6:14am Jan 17, 2009 6:14am

Seavo
| Joined Aug 2006 | Status: Trader | 78 Posts

Hi husky_1,

The problem is where IsTrade is being set.

right now you have it looking for:

if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;

OrderSymbol() is selecting all trades with that pair, Symbol() is specifying the current symbol.

try using OrderMagicNumber() == MagicNumber instead. Otherwise, setting the magic number in the MagicNumber variable is only really helping you see what trades are opened by your EA.

btw: keep a copy of your currently working EA before modding it. I can't tell you how many times that's saved my butt ;-)

And as for "bad karma" not releasing your logic, I'd leave worrying about karma to the trolls. This post took me all of 10 minutes maybe. Your strategy took more than that to come up with (I hope if it's going live ;-)). That's just a bad trade.

Good luck with your EA bro!

Seavo

#6
Last Post: Edited 1:38pm Jan 17, 2009 1:22pm | Edited 1:38pm

husky_1
| Joined Dec 2008 | Status: Let Sleeping Dogs Lie | 131 Posts

Seavo
Thanks for your help and your support. I am glad that you understand that I am looking for coding help and not trading help. I have made the changes, and worked fine in testing, which means it closes the order properly.

Monday, I will take a look and see if it will place nice with other orders.

Makin my way, the only way I know how...

Platform Tech
/
EA not trading if a manual open position exist for pair
Reply to Thread

0 traders viewing now

Options

Similar Threads

EA not trading if a manual open position exist for pair