Scalp/Float,M5,Micro,PriceAction

Type : ExpertAdvisor (Robot Trading)
Positions : 1 to Multiple
Profit/SL : Scalp/Floating
TF : M5
Acc/Lot : Micro / 0.01
Trigger : PriceAction (OHLC)

Hello, I've tried to make open order conditions based on price action (OHLC)
using Low[] array, with this simple condition :

if current bar low is lower than previous bar low = sell_signal
if current bar low is higher than previous bar low = buy_signal

translate to the coding, where 0 is current bar and 1 is previous bar :

if (low[0] < low[1]) order=sell_signal;
if (low[0] > low[1]) order=buy_signal;

but, when tested on M5 timeframe, it only trigger sell_signal.
do i need to submit full coding here?

Make sure that your EA uses both long & short positions - it may only be set to long

Quoting LongToBeFree

Disliked

Make sure that your EA uses both long & short positions - it may only be set to long

Ignored

Thanx, i've make sure it uses both long and shorts..still wont work..

here it is, the coding...also attached mql and result report on zip..
//+------------------------------------------------------------------+
//| This EA tested for eurusd with default setting. |
//| Tested on M5 TF |
//| designed for use with micro lot (0.01) |
//| equity start $100 |
//| |
//| created with combined function from other user |
//| |
//+------------------------------------------------------------------+
#property copyright "bbmod"
#property link "bmodz"

extern int MagicNumber = 0;
extern bool EachTickMode = false;
extern double Lots = 0.01;
extern int Slippage = 3;

extern double MaximumRisk =0.015;
extern double DecreaseFactor =3;
extern int MaxOrders = 100;

//floatcontrol
extern double ProfitTarget = 0.5;
extern int SL = -500;
int loss = 0;
extern bool UseAlerts = true;
double PL=0.5;

//PriceACtionControl
extern string ohlc_now = "Low[0]";
extern string ohlc_pre = "Low[1]";
extern string ohlc_now1 = "Low[0]";
extern string ohlc_pre1 = "Low[1]";



#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init() {
BarCount = Bars;

if (EachTickMode) Current = 0; else Current = 1;

return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit() {
return(0);
}

//+------------------------------------------------------------------------+
//| Closes everything
//+------------------------------------------------------------------------+
void CloseAll()
{
for(int j=OrdersTotal()-1;j>=0;j--)
{
OrderSelect(j, SELECT_BY_POS);
bool result = false;
if ( OrderType() == OP_BUY) result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );
if ( OrderType() == OP_SELL) result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );
if ( OrderType()== OP_BUYSTOP) result = OrderDelete( OrderTicket() );
if ( OrderType()== OP_SELLSTOP) result = OrderDelete( OrderTicket() );
if (UseAlerts) PlaySound("alert.wav");
}
return;
}

//+------------------------------------------------------------------------+
//| Closes SELL
//+------------------------------------------------------------------------+
void CloseSELL()
{
for(int j=OrdersTotal()-1;j>=0;j--)
{
OrderSelect(j, SELECT_BY_POS);
bool result = false;
if ( OrderType() == OP_SELL) result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_ASK), 5, Red );
if ( OrderType()== OP_SELLSTOP) result = OrderDelete( OrderTicket() );
if (UseAlerts) PlaySound("alert.wav");
}
return;
}

//+------------------------------------------------------------------------+
//| Closes BUY
//+------------------------------------------------------------------------+
void CloseBUY()
{
for(int j=OrdersTotal()-1;j>=0;j--)
{
OrderSelect(j, SELECT_BY_POS);
bool result = false;
if ( OrderType() == OP_BUY) result = OrderClose( OrderTicket(), OrderLots(), MarketInfo(OrderSymbol(), MODE_BID), 5, Red );
if ( OrderType()== OP_BUYSTOP) result = OrderDelete( OrderTicket() );
if (UseAlerts) PlaySound("alert.wav");
}
return;
}

//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start() {

double BuyLots, SellLots, BuyProfit, SellProfit;


//+------------------------------------------------------------------+
// Determine last order price |
//-------------------------------------------------------------------+
for(int j=0;j<OrdersTotal();j++)
{
OrderSelect(j,SELECT_BY_POS,MODE_TRADES);

if(OrderType()==OP_BUY) BuyLots += OrderLots();
if(OrderType()==OP_SELL) SellLots += OrderLots();
if(OrderType() == OP_BUY) BuyProfit += OrderProfit() + OrderCommission() + OrderSwap();
if(OrderType() == OP_SELL) SellProfit += OrderProfit() + OrderCommission() + OrderSwap();

}

PL = BuyProfit+SellProfit;

if(BuyProfit+SellProfit > ProfitTarget) CloseAll();
if (BuyProfit <= SL) CloseBUY();
if (SellProfit <= SL) CloseSELL();


/////////////////////////
/////////////////////////


int openOrder = SIGNAL_NONE;
int openBUY = SIGNAL_NONE;
int openSELL = SIGNAL_NONE;
int closeOrder = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;

int digit = MarketInfo(Symbol(),MODE_DIGITS);

if (EachTickMode && Bars != BarCount) EachTickMode = False;
Total = OrdersTotal();


//+------------------------------------------------------------------+
//| Signal Begin
//+------------------------------------------------------------------+


// open close
if (ohlc_now > ohlc_pre ) openBUY = SIGNAL_BUY;
if (ohlc_now < ohlc_pre ) openSELL = SIGNAL_SELL;


//+------------------------------------------------------------------+
//| Signal End |
//+------------------------------------------------------------------+

//Buy
if (openBUY == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount))))
{
if(ScanTrades() < MaxOrders)
{
//Check free margin
if (AccountFreeMargin() < (1000 * Lots))
{
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
//
Ticket = OrderSend(Symbol(), OP_BUY, LotsOptimized(),
NormalizeDouble(Ask,digit),
Slippage,
NormalizeDouble(StopLossLevel,digit),
NormalizeDouble(TakeProfitLevel,digit),
"Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
//
if(Ticket > 0)
{
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) Print("BUY order opened : ", OrderOpenPrice()); else Print("Error opening BUY order : ", GetLastError());
}
//
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//Sell
if (openSELL == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount))))
{
if(ScanTrades() < MaxOrders)
{
//Check free margin
if (AccountFreeMargin() < (1000 * Lots))
{
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
//
Ticket = OrderSend(Symbol(), OP_SELL, LotsOptimized(),
NormalizeDouble(Bid,digit),
Slippage,
NormalizeDouble(StopLossLevel,digit),
NormalizeDouble(TakeProfitLevel,digit),
"Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0)
{
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) Print("SELL order opened : ", OrderOpenPrice(),"Ticket:",Ticket); else Print("Error opening SELL order : ", GetLastError());
}
//
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//+------------------------------------------------------------------+
//Check position
//+------------------------------------------------------------------+
for (int i = 0; i < OrdersTotal() ; i ++)
{
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderMagicNumber()==MagicNumber )
{

if (closeOrder == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount))))

{
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;

if (OrderProfit() < 0 ) loss++;
return(0);
}

if (closeOrder == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount))))

{
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;

if (OrderProfit() < 0 ) loss++;
return(0);
}

}
}



if (!EachTickMode) BarCount = Bars;

//subprint details
subPrintDetails();

return(0);
}


//+------------------------------------------------------------------+
//Count Open Order
//+------------------------------------------------------------------+
int ScanTrades()
{
int total = OrdersTotal();
int numords = 0;
int ot=OrderType();

for(int cnt=0; cnt<total; cnt++)
{
OrderSelect(cnt, SELECT_BY_POS);
if(OrderSymbol() == Symbol() && OrderType()<=OP_SELLSTOP && OrderMagicNumber() == MagicNumber)
numords++;
}
return(numords);
}

//+------------------------------------------------------------------+
//Count BUY Order
//+------------------------------------------------------------------+

int OrdersBUY()
{
int total = OrdersTotal();

int OrdersBUY = 0;
int OrdersSELL = 0;
//int numords = 0;
int ot=OrderType();

for(int cnt=0; cnt<total; cnt++)
{
OrderSelect(cnt, SELECT_BY_POS);
if(OrderSymbol() == Symbol() && OrderType()==OP_BUY && OrderMagicNumber() == MagicNumber)
{
OrdersBUY++;

}

}
return(OrdersBUY);
}

//+------------------------------------------------------------------+
//Count SELL Order
//+------------------------------------------------------------------+

int OrdersSELL()
{
int total = OrdersTotal();

int OrdersBUY = 0;
int OrdersSELL = 0;
//int numords = 0;
int ot=OrderType();

for(int cnt=0; cnt<total; cnt++)
{
OrderSelect(cnt, SELECT_BY_POS);
if(OrderSymbol() == Symbol() && OrderType()==OP_SELL && OrderMagicNumber() == MagicNumber)
{
OrdersSELL++;

}

}
return(OrdersSELL);
}

/*
//bool ExistPositions() {
// for (int i=0; i<OrdersTotal(); i++) {
// if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) {
// if (OrderSymbol()==Symbol() && OrderMagicNumber()==MagicNumber) {
// return(True);
// }
// }
// }
// return(false);
//}
*/

//+------------------------------------------------------------------+
//Lot Optimization
//+------------------------------------------------------------------+

double LotsOptimized()
{
double lot=Lots;
int orders=OrdersHistoryTotal(); // history orders total
// int losses=0; // number of losses orders without a break
//---- select lot size
if(MaximumRisk>0)lot=NormalizeDouble(Lots*AccountFreeMargin()*MaximumRisk/1000.0,1);
//---- calcuulate number of losses orders without a break
if(DecreaseFactor>0)
{
for(int i=orders-1;i>=0;i--)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) { Print("Error in history!"); break; }
if(OrderSymbol()!=Symbol() || OrderType()>OP_SELL) continue;
//----
if(OrderProfit()>0) break;
if(OrderProfit()<0) loss++;
}

}
//---- return lot size
if(lot<0.01) lot=0.01;
return(lot);
}


//+------------------------------------------------------------------+
//Shows Details on CHART
//+------------------------------------------------------------------+


void subPrintDetails()
{
string sComment = "";
string sp = "----------------------------------------\n";
string NL = "\n";
string sDirection = "";
sComment = sComment + sp;
//add print equity status
sComment = sComment + "Account equity = " + AccountEquity() + NL;
sComment = sComment + "Free Margin = " + AccountFreeMargin() + NL;
sComment = sComment + "Margin in use = " + AccountMargin() + NL;
sComment = sComment + "Order amount = " + ScanTrades() + NL;
sComment = sComment + "OrdersBUY = " + OrdersBUY() + NL;
sComment = sComment + "OrdersSELL = " + OrdersSELL() + NL;
sComment = sComment + "Profit/Loss = " + PL + NL;
sComment = sComment + "Loss count = " + loss + NL;
sComment = sComment + "OHLC [0]= " + Open[0] + High[0] + Low[0] + Close[0] + NL;
sComment = sComment + "OHLC [1]= " + Open[1] + High[1] + Low[1] + Close[1] + NL;
sComment = sComment + "OHLC [2]= " + Open[2] + High[2] + Low[2] + Close[2] + NL;
Comment(sComment);
}

It will be easier to help with full code

i've updated my previous post. there goes full code and file.

did you check the journal or expert tabs for any error messages? error code 130 is the usual suspect. if so, might wanna look into those stop loss and take profit levels of yours.

Yes, i've checked, since i dont use built in TP and SL, i use CloseAll Function as u can c on the full code, or instead download the mql and test the EA yourself.

Waiting for further suggestions...

Is it just me, or are you trying to use the bid price for everything?

would you please quote the code here? or on what line of the code?
Could you also put your altered/fixed code here? (after you've tested and download the mql?)
thx.

Better late than never suppose,
anyway after running a compile function in mt4 there were 11 errors, typos.... maybe that could help....