Function Definition Unexpected

Hi all!

I'm starting to learn how to do some coding and just out of interest though I program a really simple ea that just takes orders when it crosses certain RSI levels over different currency pairs and just wanting to limit it to open one order on each pair and won't open again till the order in that pair is either filled or stop out.

So I was looking through the forums and found a post on a different system but with the same idea of only opening orders on pairs that don't already have one open and I just copied that section of it by typing it out word for word (so I can get more accustomed to the syntax, structure and grammar)

it starts of with

bool DecideToOpenTrade(string SymboleToUse)
{
code
}


but when i compile it, it says there's a "'('- function definition unexpected error"

so i then just copied that other systems entire code and that problem dind't occur.

I really have no idea how to go about this and any input will be greatly appreciated

-Jeremy

a word of advise to all potential thread starters asking for help with their codes.

Please post your code files...

How else can we help you debug?

for your case, if I were to venture a pure guess (since I've not seen the codes), its likely to be a missing semicolon ';' above the function you were writing. so the compiler was reading the previous statement which you haven't terminate with a semicolon, and saw you function definition. That's why it said its not expecting a function now. again, this is just a guess. post your codes.

btw, just curious... was the DecideToOpenTrade function one of my doings?

regards,
Zen

hey zen!

sorry bout not posting hte entire code, didn't realise it would have made the discussion a lot easier, silly me, didn't want to post it up for brevity's sake haha


but the code is on my work machine and I've got the day off cause of uni exam today so I won't be able to get it posted till tomorrow

and yes I think that DecideToOpen thing was from something you posted up too

So this is the code that I'm working on
excuse it's simplicity, I've only just started


the function definition error occurs at the line

and I've checked through to see if I've missed out a semicolon anywhere, and I don't think I am... but then again I could be wrong hehe

any advise will be greatly appreciated! thanks

-Jeremy

return(0);
}
}
//----
//Trade Checking Logic

gah!
it was so simple
hahahaha

thanks ken

just one more question since my code is already here, i originally intended it to send an order only when the bar is closed and the rsi is above 80 or less than 20, but i've noticed that instead it takes the order as soon as it touches the rsi levels

i thought i account for this by adjusting the shift (i.e. putting 1 instead of 0) but that dind't seem to work

and now i think i'll need to use something to do with the iclose function
am i on the right track?

#include <stdlib.mqh>
//+------------------------------------------------------------------+
//| Common External variables |
//+------------------------------------------------------------------+
extern double Lots = 0.1;
extern double StopLoss = 100;
extern double TakeProfit = 10.00;
extern double TrailingStop = 5.00;
//+------------------------------------------------------------------+
//| External variables |
//+------------------------------------------------------------------+
extern double MaxTrades = 8;
extern double Pips = 20;
extern double SecureProfit = 10;
extern double AccountProtection = 1;
extern double OrderstoProtect = 3;
extern double ReverseCondition = 0;
extern double EURUSDPipValue = 10;
extern double GBPUSDPipValue = 10;
extern double USDCHFPipValue = 7.94;
extern double USDJPYPipValue = 9.03;
extern double mm = 0;
extern double risk = 12;
extern double AccountisNormal = 0;
extern double TimeZoneofData = 0;
//+------------------------------------------------------------------+
//| Global variables |
//+------------------------------------------------------------------+
double OpenOrders = 0;
int cnt = 0;
double slippage = 5;
double sl = 0;
double tp = 0;
double BuyPrice = 0;
double SellPrice = 0;
double lotsi = 0;
double mylotsi = 0;
double mode = 0;
double MyOrderType=0;
bool ContinueOpening = True;
double LastPrice = 0;
double PreviousOpenOrders = 0;
double Profit = 0;
double LastTicket = 0;
double LastType = 0;
double LastClosePrice = 0;
double LastLots = 0;
double Pivot = 0;
double PipValue = 0;
bool Reversed = False;
string text = "";
string text2 = "";
double myl = 0;
double myh = 0;
double myC = 0;
double myO = 0;
double mypivot = 0;
double Today = 0;
double RefDate = 0;
double LastBarOfDay = 0;
double FirstBarOfDay = 0;
double Loop = 0;
double myyh = 0;
double myyl = 0;
double myyc = 0;
double p = 0;
double flp = 0;
double feh = 0;
double fel = 0;
double ph = 0;
double pl = 0;
double gap = 0;

bool SetObjectText(string name, string text, string font, int size, color Acolor)
{
return(ObjectSetText(name, text, size, font, Acolor));
}
bool MoveObject(string name, int type, datetime Atime, double Aprice, datetime Atime2 = 0, double Aprice2 = 0, color Acolor = CLR_NONE, int Aweight = 0, int Astyle = 0)
{
if (ObjectFind(name) != -1) {
int OType = ObjectType(name);
if ((iRSI(NULL,0,70,PRICE_HIGH,0) > OP_BUY) && (iRSI(NULL,0,70,PRICE_HIGH,0) < iRSI(NULL,0,70,PRICE_HIGH,1)))
{
if (Open[0]<Open[1])
{OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,0); {
return(ObjectMove(name, 0, Atime, Aprice) && ObjectMove(name, 1, Atime2, Aprice2));
}
if ((iRSI(NULL,0,3,PRICE_LOW,0) < OP_SELL) && (iRSI(NULL,0,3,PRICE_LOW,0) > iRSI(NULL,0,3,PRICE_LOW,1)))
{
if (Open[0]>Open[1])
{OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,0); {
return(ObjectMove(name, 0, Atime, Aprice));
}
else {
return(ObjectCreate(name, type, 0, Atime, Aprice, Atime2, Aprice2, 0, 0) && ObjectSet(name, OBJPROP_COLOR, Acolor));
}
}
//+------------------------------------------------------------------+
//| Initialization |
//+------------------------------------------------------------------+
int init()
{
return(0);
}
int start()
{
//+------------------------------------------------------------------+
//| Local variables |
//+------------------------------------------------------------------+
if( AccountisNormal == 1 ) {
if( mm != 0 ) lotsi = MathCeil(AccountBalance() * risk / 10000) ; else lotsi = Lots;
}
else {
if( mm != 0 ) lotsi = MathCeil(AccountBalance() * risk / 10000) / 10 ; else lotsi = Lots;
}
if( lotsi > 100 ) lotsi = 100;
OpenOrders = 0;
for( cnt = 0; cnt < OrdersTotal(); cnt++ ) {
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if( OrderSymbol() == Symbol() ) OpenOrders++;
}
myh = High[0];
myl = Low[0];
myC = Close[0];
myO = Open[0];
myyh = High[1];
myyl = Low[1];
myyc = Close[1];
p = (myyh + myyl + myyc + myO) / 4;
ph = (myyh + myh + myyc + myO) / 4;
pl = (myyl + myl + myyc + myO) / 4;
flp = (myh + myl + myC) / 3;
gap = MathAbs(p - flp) / Point;
}

PipValue = 5;
if (Symbol()== "EURUSDm") PipValue = EURUSDPipValue;
if (Symbol()== "GBPUSDm") PipValue = GBPUSDPipValue;
if (Symbol()== "USDJPYm") PipValue = USDJPYPipValue;
if (Symbol()== "USDCHFm") PipValue = USDCHFPipValue;


if( PreviousOpenOrders > OpenOrders ) {
for( cnt = OrdersTotal()-1; cnt >= 0; cnt-- ) {
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
mode = OrderType();
if( OrderSymbol() == Symbol() ) {
if( mode == OP_BUY ) OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),slippage,Blue);
if( mode == OP_SELL ) OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),slippage,Red);
return(0);
}
}
}
PreviousOpenOrders = OpenOrders;
if( OpenOrders >= MaxTrades ) ContinueOpening = False ; else ContinueOpening = True;
if( LastPrice == 0 ) {
for( cnt = 0; cnt < OrdersTotal(); cnt++ ) {
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if( OrderSymbol() == Symbol() ) {
LastPrice = OrderOpenPrice();
if(OrderType()==OP_BUY) MyOrderType=2;
if(OrderType()==OP_SELL) MyOrderType=1;
}
}
}
if( OpenOrders < 1 ) MyOrderType=0;
if( OpenOrders < 1 && Bid < p && Bid < flp && gap >= 7 ) {
LastPrice = 0;
MyOrderType=1;
}
if( OpenOrders < 1 && Ask > p && Ask > flp && gap >= 7 ) {
LastPrice = 0;
MyOrderType=2;
}
for( cnt = OrdersTotal()-1; cnt >= 0; cnt-- ) {
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if( OrderSymbol() == Symbol() && Reversed == False ) {
if( OrderType() == OP_SELL ) {
if( TrailingStop > 0 ) {
if( OrderOpenPrice() - Ask >= TrailingStop * Point + Pips * Point ) {
if( OrderStopLoss() > Ask + Point * TrailingStop || OrderStopLoss() == 0 ) {
OrderModify(OrderTicket(),OrderOpenPrice(),Ask + Point * TrailingStop,OrderClosePrice() - TakeProfit * Point - TrailingStop * Point,0,Purple);
return(0);
}
}
}
}
if( OrderType() == OP_BUY ) {
if( TrailingStop > 0 ) {
if( Bid - OrderOpenPrice() >= TrailingStop * Point + Pips * Point ) {
if( OrderStopLoss() < Bid - Point * TrailingStop ) {
OrderModify(OrderTicket(),OrderOpenPrice(),Bid - Point * TrailingStop,OrderClosePrice() + TakeProfit * Point + TrailingStop * Point,0,Yellow);
return(0);
}
}
}
}
}
}
Profit = 0;
LastTicket = 0;
LastType = 0;
LastClosePrice = 0;
LastLots = 0;
for( cnt = 0; cnt < OrdersTotal(); cnt++ ) {
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if( OrderSymbol() == Symbol() ) {
LastTicket = OrderTicket();
if( OrderType() == OP_BUY ) LastType = 0;
if( OrderType() == OP_SELL ) LastType = 1;
LastClosePrice = OrderClosePrice();
LastLots = OrderLots();
if( LastType == 0 ) {
if( OrderClosePrice() < OrderOpenPrice() ) {
Profit = Profit - (OrderOpenPrice() - OrderClosePrice()) * OrderLots() / Point;
}
if( OrderClosePrice() > OrderOpenPrice() ) {
Profit = Profit + (OrderClosePrice() - OrderOpenPrice()) * OrderLots() / Point;
}
}
if( LastType == 1 ) {
if( OrderClosePrice() > OrderOpenPrice() ) {
Profit = Profit - (OrderClosePrice() - OrderOpenPrice()) * OrderLots() / Point;
}
if( OrderClosePrice() < OrderOpenPrice() ) {
Profit = Profit + (OrderOpenPrice() - OrderClosePrice()) * OrderLots() / Point;
}
}
}
}
Profit = Profit * PipValue;
text2 = "Profit: $" + DoubleToStr(Profit,2) + " +/- ";
if( OpenOrders >= MaxTrades - OrderstoProtect && AccountProtection == 1 ) {
if( MyOrderType == 2 && Bid == tp ) {
OrderClose(LastTicket,LastLots,LastClosePrice,slippage,Yellow);
ContinueOpening = False;
return(0);
}
if( MyOrderType == 1 && Ask == tp ) {
OrderClose(LastTicket,LastLots,LastClosePrice,slippage,Yellow);
ContinueOpening = False;
return(0);
}
}
if( MyOrderType == 1 && ContinueOpening ) {
if( Bid - LastPrice >= Pips * Point || OpenOrders < 1 ) {
SellPrice = Bid;
LastPrice = 0;
if( TakeProfit == 0 ) tp = 0 ; else tp = SellPrice - TakeProfit * Point;
if( StopLoss == 0 ) sl = 0 ; else sl = SellPrice + StopLoss * Point;
if( OpenOrders != 0 ) {
mylotsi = lotsi;
for(cnt =0;cnt <OpenOrders;cnt ++) {
if( MaxTrades > 12 ) mylotsi = NormalizeDouble(mylotsi * 1.5,1) ; else mylotsi = NormalizeDouble(mylotsi * 2,1);
}
}
else {
mylotsi = lotsi;
}
if( mylotsi > 100 ) mylotsi = 100;
OrderSend(Symbol(),OP_SELL,mylotsi,SellPrice,slippage,sl,tp,"",0,0,Red);
return(0);
}
}
if( MyOrderType == 2 && ContinueOpening ) {
if( LastPrice - Ask >= Pips * Point || OpenOrders < 1 ) {
BuyPrice = Ask;
LastPrice = 0;
if( TakeProfit == 0 ) tp = 0 ; else tp = BuyPrice + TakeProfit * Point;
if( StopLoss == 0 ) sl = 0 ; else sl = BuyPrice - StopLoss * Point;
if( OpenOrders != 0 ) {
mylotsi = lotsi;
for(cnt =0;cnt <OpenOrders;cnt ++) {
if( MaxTrades > 12 ) mylotsi = NormalizeDouble(mylotsi * 1.5,1) ; else mylotsi = NormalizeDouble(mylotsi * 2,1);
}
}
else {
mylotsi = lotsi;
}
if( mylotsi > 100 ) mylotsi = 100;
OrderSend(Symbol(),OP_BUY,mylotsi,BuyPrice,slippage,sl,tp,"",0,0,Blue);
return(0);
}
}
return(0);
}


mine olso have the same error msg..

mq4;124:9;'(' - function definition unexpected
mq4;128:10;'(' - function definition unexpected

im not programmer so i dont know how to write code,i just, copy..paste..delete.and change the indicator for that ea. ps. i get other ea that fullfil my need and than change the indicator.. ..pls someone help.. and pls tell me is there any error..beside that?..thanks